Re: kern/172535: [modules] kldload+kldunload if_carp makes kldstat not working
The following reply was made to PR kern/172535; it has been noted by GNATS. From: c0re To: bug-follo...@freebsd.org, - - Cc: Subject: Re: kern/172535: [modules] kldload+kldunload if_carp makes kldstat not working Date: Wed, 5 Mar 2014 16:03:57 +0400 --001a11c1f542bd063504f3dad0be Content-Type: text/plain; charset=ISO-8859-1 With new CARP in 10.0-RELESE problem disappeared. --001a11c1f542bd063504f3dad0be Content-Type: text/html; charset=ISO-8859-1 With new CARP in 10.0-RELESE problem disappeared. --001a11c1f542bd063504f3dad0be-- ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/187283: Failed for rsplib-3.0.1 in build
>Number: 187283 >Category: misc >Synopsis: Failed for rsplib-3.0.1 in build >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Wed Mar 05 14:50:01 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Thomas Dreibholz >Release:9.2-RELEASE-p12 >Organization: Simula Research Laboratory >Environment: FreeBSD pcbsd 9.2-RELEASE-p12 FreeBSD 9.2-RELEASE-p12 #0: Thu Jan 16 21:12:30 UTC 2014 r...@amd64-builder.pcbsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: rsplib-3.0.1 fails to build. The upstream version 3.0.2 fixes this problem. >How-To-Repeat: >Fix: Use the upstream bugfix version 3.0.2 from the port net/rsplib. >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/187103: clang 3.4 miscompiles nsAppRunner.cpp from firefox firefox-27.0.1, 1 in i386
Synopsis: clang 3.4 miscompiles nsAppRunner.cpp from firefox firefox-27.0.1,1 in i386 State-Changed-From-To: open->patched State-Changed-By: dim State-Changed-When: Wed Mar 5 22:44:05 UTC 2014 State-Changed-Why: Upstream fixed the bug here: http://llvm.org/viewvc/llvm-project?rev=203007&view=rev I imported the fix in head r262809, and will MFC it after a week. http://www.freebsd.org/cgi/query-pr.cgi?pr=187103 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/187103: commit references a PR
The following reply was made to PR bin/187103; it has been noted by GNATS. From: dfil...@freebsd.org (dfilter service) To: bug-follo...@freebsd.org Cc: Subject: Re: bin/187103: commit references a PR Date: Wed, 5 Mar 2014 22:43:43 + (UTC) Author: dim Date: Wed Mar 5 22:43:30 2014 New Revision: 262809 URL: http://svnweb.freebsd.org/changeset/base/262809 Log: Pull in r203007 from upstream clang trunk: Don't produce an alias between destructors with different calling conventions. Fixes pr19007. (Please note that is an LLVM PR identifier, not a FreeBSD one.) This should fix Firefox and/or libxul crashes (due to problems with regparm/stdcall calling conventions) on i386. Reported by: multiple users on freebsd-current PR: bin/187103 MFC after: 1 week Modified: head/contrib/llvm/tools/clang/lib/CodeGen/CGCXX.cpp Modified: head/contrib/llvm/tools/clang/lib/CodeGen/CGCXX.cpp == --- head/contrib/llvm/tools/clang/lib/CodeGen/CGCXX.cppWed Mar 5 22:04:30 2014(r262808) +++ head/contrib/llvm/tools/clang/lib/CodeGen/CGCXX.cppWed Mar 5 22:43:30 2014(r262809) @@ -92,7 +92,13 @@ bool CodeGenModule::TryEmitBaseDestructo if (!ClassLayout.getBaseClassOffset(UniqueBase).isZero()) return true; + // Give up if the calling conventions don't match. We could update the call, + // but it is probably not worth it. const CXXDestructorDecl *BaseD = UniqueBase->getDestructor(); + if (BaseD->getType()->getAs()->getCallConv() != + D->getType()->getAs()->getCallConv()) +return true; + return TryEmitDefinitionAsAlias(GlobalDecl(D, Dtor_Base), GlobalDecl(BaseD, Dtor_Base), false); ___ svn-src-...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org" ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/187307: Security vulnerability with FreeBSD Jail
>Number: 187307 >Category: misc >Synopsis: Security vulnerability with FreeBSD Jail >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 05 23:10:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Nicola Galante >Release:10.0 >Organization: Smithsonian Astrophysical Observatory >Environment: FreeBSD hostserver.localdomain 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014 r...@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: I found a potential vulnerability with FreeBSD jails. I installed a server (hostserver) for my institute. This hostserver has a certain IP address, let's say 10.0.0.100, and I installed and configured three service jails (elog, mail, www), each with a different IP address (10.0.0.101, 10.0.0.102, 10.0.0.103) root@hostserver:/jails/j # jls JID IP Address Hostname Path 1 10.0.0.101 elogjail /jails/j/elog 2 10.0.0.102 mailjail /jails/j/mail 3 10.0.0.103 wwwjail /jails/j/www I have an account on both the hostserver and the elogjail. Password authentication on hostserver and ssh key authentication in the jail. The service sshd is running on both the hostserver and elogjail. If I ssh into the elogjail [galante@caronte ~]$ ssh galante@elogjail Enter passphrase for key '/home/galante/.ssh/id_dsa': Last login: Wed Mar 5 21:37:23 2014 from caronte galante@elogjail:~ % as expected. But if I turn off the sshd service in elogjail (and keep the elogjail up and running) and I try to connect to elogjail, I first get a complaint that the fingerprint for the RSA key sent by the remote host has changed. If I remove the corresponding line in my local .ssh/known_hosts file and try to reconnect, this is what happens: [galante@caronte ~]$ ssh galante@elogjail Password for galante@hostserver: Last login: Wed Mar 5 21:12:20 2014 from caronte galante@hostserver:~ % I log into the host system! Of course this is possible because I have an account on both the host system and the jail. However, I believe that this can cause a serious potential security threat. I can envision several scenarios where somebody attempts to get into a jail and instead gets into the host system. I checked also the DNS responsiveness. The problem persists even if I use IP addresses instead of host names. >How-To-Repeat: Follow the steps described above. >Fix: I don't know how to fix the problem other than by disabling sshd in the hostserver. >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/176051: [kernel] [patch] uipc: Simplify and correct debug printing of flags.
On 3/4/14 8:29 AM, Christoph Mallon wrote:
> On 27.02.2014 11:02, bruef...@freebsd.org wrote:
>> The patch in the PR doesn't compile (latest HEAD).
>
>
> "doesn't compile" is not helpful feedback.
> Please state at least the error message.
>
[...]
cc -c -O2 -pipe -fno-strict-aliasing -std=c99 -gdwarf-2 -Wall
-Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
-Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs
-fdiagnostics-show-option -Wno-error-tautological-compare
-Wno-error-empty-body -Wno-error-parentheses-equality
-Wno-unused-function -nostdinc -I. -I/usr/src/sys
-I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/libfdt -D_KERNEL
-DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h
-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -mno-aes -mno-avx
-mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float
-fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -Werror
/usr/src/sys/kern/uipc_debug.c
/usr/src/sys/kern/uipc_debug.c:87:2: error: adding 'int' to a string
does not append to the string [-Werror,-Wstring-plus-int]
PRINT_FLAG(so_options, SO_DEBUG);
^~~~
/usr/src/sys/kern/uipc_debug.c:49:44: note: expanded from macro 'PRINT_FLAG'
((var) & (flag) ? db_printf(", " #flag + sep), (void)(sep = 0) :
(void)0)
~~~^
/usr/src/sys/kern/uipc_debug.c:87:2: note: use array indexing to silence
this warning
/usr/src/sys/kern/uipc_debug.c:49:44: note: expanded from macro 'PRINT_FLAG'
((var) & (flag) ? db_printf(", " #flag + sep), (void)(sep = 0) :
(void)0)
^
/usr/src/sys/kern/uipc_debug.c:87:2: error: format string is not a
string literal (potentially insecure) [-Werror,-Wformat-security]
PRINT_FLAG(so_options, SO_DEBUG);
^~~~
/usr/src/sys/kern/uipc_debug.c:49:33: note: expanded from macro 'PRINT_FLAG'
((var) & (flag) ? db_printf(", " #flag + sep), (void)(sep = 0) :
(void)0)
^~~~
/usr/src/sys/kern/uipc_debug.c:88:2: error: adding 'int' to a string
does not append to the string [-Werror,-Wstring-plus-int]
PRINT_FLAG(so_options, SO_ACCEPTCONN);
^
/usr/src/sys/kern/uipc_debug.c:49:44: note: expanded from macro 'PRINT_FLAG'
((var) & (flag) ? db_printf(", " #flag + sep), (void)(sep = 0) :
(void)0)
~~~^
/usr/src/sys/kern/uipc_debug.c:88:2: note: use array indexing to silence
this warning
/usr/src/sys/kern/uipc_debug.c:49:44: note: expanded from macro 'PRINT_FLAG'
((var) & (flag) ? db_printf(", " #flag + sep), (void)(sep = 0) :
(void)0)
^
/usr/src/sys/kern/uipc_debug.c:88:2: error: format string is not a
string literal (potentially insecure) [-Werror,-Wformat-security]
PRINT_FLAG(so_options, SO_ACCEPTCONN);
^
/usr/src/sys/kern/uipc_debug.c:49:33: note: expanded from macro 'PRINT_FLAG'
((var) & (flag) ? db_printf(", " #flag + sep), (void)(sep = 0) :
(void)0)
^~~~
/usr/src/sys/kern/uipc_debug.c:89:2: error: adding 'int' to a string
does not append to the string [-Werror,-Wstring-plus-int]
PRINT_FLAG(so_options, SO_REUSEADDR);
^~~~
/usr/src/sys/kern/uipc_debug.c:49:44: note: expanded from macro 'PRINT_FLAG'
((var) & (flag) ? db_printf(", " #flag + sep), (void)(sep = 0) :
(void)0)
~~~^
/usr/src/sys/kern/uipc_debug.c:89:2: note: use array indexing to silence
this warning
/usr/src/sys/kern/uipc_debug.c:49:44: note: expanded from macro 'PRINT_FLAG'
((var) & (flag) ? db_printf(", " #flag + sep), (void)(sep = 0) :
(void)0)
^
/usr/src/sys/kern/uipc_debug.c:89:2: error: format string is not a
string literal (potentially insecure) [-Werror,-Wformat-security]
PRINT_FLAG(so_options, SO_REUSEADDR);
^~~~
/usr/src/sys/kern/uipc_debug.c:49:33: note: expanded from macro 'PRINT_FLAG'
((var) & (flag) ? db_printf(", " #flag + sep), (void)(sep = 0) :
(void)0)
^~~~
/usr/src/sys/kern/uipc_debug.c:90:2: error: adding 'int' to a string
does not append to the string [-Werror,-Wstring-plus-int]
PRINT_FLAG(so_options, SO_KEEPALIVE);
^~~~
/usr/src/sys/kern/uipc_debug.c:49:44: note: expanded from macro 'PRINT_FLAG'
((var) & (flag) ? db_printf(", " #flag + sep), (void)(sep = 0) :
(void)0)
~~~^
/usr/src/sys/kern/uipc_debug.c:90:2: note: use array indexing to silence
this warning
/usr/src/sys/kern/uipc_debug.c:49:44: note: expanded from macro 'PRINT_F
Re: misc/187307: Security vulnerability with FreeBSD Jail
Synopsis: Security vulnerability with FreeBSD Jail State-Changed-From-To: open->closed State-Changed-By: delphij State-Changed-When: Wed Mar 5 23:39:19 UTC 2014 State-Changed-Why: Not a bug, please see my reply on freebsd-security@. Responsible-Changed-From-To: freebsd-bugs->delphij Responsible-Changed-By: delphij Responsible-Changed-When: Wed Mar 5 23:39:19 UTC 2014 Responsible-Changed-Why: Take just in case I was wrong. http://www.freebsd.org/cgi/query-pr.cgi?pr=187307 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: ports/187283: Failed for net/rsplib 3.0.1 in build
Old Synopsis: Failed for rsplib-3.0.1 in build New Synopsis: Failed for net/rsplib 3.0.1 in build Responsible-Changed-From-To: freebsd-bugs->freebsd-ports-bugs Responsible-Changed-By: linimon Responsible-Changed-When: Thu Mar 6 02:35:48 UTC 2014 Responsible-Changed-Why: ports PR. http://www.freebsd.org/cgi/query-pr.cgi?pr=187283 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/187309: databases/memcached: install error
>Number: 187309 >Category: misc >Synopsis: databases/memcached: install error >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Mar 06 04:30:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Ross >Release:10.0 >Organization: >Environment: FreeBSD ghost.arzinger.ua 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014 r...@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: today's update give the following error (during install phase): ---> Installing the new version via the port ===> Staging for memcached-1.4.17_1 ===> memcached-1.4.17_1 depends on shared library: libevent-2.0.so - found ===> Generating temporary packing list /usr/bin/make install-recursive Making install in doc /usr/bin/make install-am test -z "/usr/local/man/man1" || /bin/mkdir -p "/usr/ports/databases/memcached/work/stage/usr/local/man/man1" install -o root -g wheel -m 444 memcached.1 '/usr/ports/databases/memcached/work/stage/usr/local/man/man1' test -z "/usr/local/bin" || /bin/mkdir -p "/usr/ports/databases/memcached/work/stage/usr/local/bin" install -s -o root -g wheel -m 555 memcached '/usr/ports/databases/memcached/work/stage/usr/local/bin' test -z "/usr/local/include/memcached" || /bin/mkdir -p "/usr/ports/databases/memcached/work/stage/usr/local/include/memcached" install -o root -g wheel -m 444 protocol_binary.h '/usr/ports/databases/memcached/work/stage/usr/local/include/memcached' install -o root -g wheel -m 555 /usr/ports/databases/memcached/work/memcached-1.4.17/scripts/memcached-tool /usr/ports/databases/memcached/work/stage/usr/local/bin install -o root -g wheel -m 444 /usr/ports/databases/memcached/work/memcached-1.4.17/doc/ /usr/ports/databases/memcached/work/stage/usr/local/man/man1 install: /usr/ports/databases/memcached/work/memcached-1.4.17/doc/: Inappropriate file type or format *** Error code 71 Stop. make[2]: stopped in /usr/ports/databases/memcached *** Error code 1 Stop. make[1]: stopped in /usr/ports/databases/memcached *** Error code 1 Stop. make: stopped in /usr/ports/databases/memcached >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
bin/187310: [patch] pw command segfaults when the -V parameter is used on commands that alter groups
>Number: 187310
>Category: bin
>Synopsis: [patch] pw command segfaults when the -V parameter is used on
>commands that alter groups
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Mar 06 05:50:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Kim Shrier
>Release:10.0 Release amd64
>Organization:
>Environment:
FreeBSD snorri.lab.westryn.net 10.0-RELEASE FreeBSD 10.0-RELEASE #1 r261308M:
Sun Feb 23 18:45:19 MST 2014
ca...@snorri.lab.westryn.net:/usr/obj/usr/src/sys/SNORRI_02 amd64
>Description:
When specifying an alternate location of the etc directory using the -V command
line parameter to /usr/sbin/pw, the pw command segfaults when it does anything
that updates groups
>How-To-Repeat:
Create a master.passwd and group file in a directory other than /etc. For the
sake of this description, I'll use /tmp/pw_problem/etc.
mkdir -p /tmp/pw_problem/etc
cd /tmp/pw_problem/etc
Create a master.passwd file in this directory that contains a line like:
bob:*:1001:1001::0:0:Robert:/home/bob:/bin/sh
Create a group file in this directory that contains a line like:
bob:*:1001:
Run pwd_mkdb.
pwd_mkdb -p -d /tmp/pw_problem/etc master.passwd
Now, try to delete the user with pw
pw -V /tmp/pw_problem/etc userdel bob
Segmentation fault (core dumped)
>Fix:
The problem is that the gr_mem member of the group struct is dereferenced
without first checking to see if it is NULL. This occurs in both
/usr/src/usr.sbin/pw/pw_group.c and /usr/src/usr.sbin/pw/pw_user.c.
The reason this happens only when the -V parameter is used is because pw uses
different routines based on whether or not the -V parameter is present. When
it isn't specified, it uses getgrent, getgrgid, and getgrnam from libc. When
-V is specified, it uses vgetgrent, vgetgrgid, and vgetgrnam which uses code
from pw_vpw.c which is part of the source for pw. These three routines call
vnextgrent which eventually calls gr_scan from libutil. Looking at the source
in libutil, it is possible for the group structure returned by gr_scan to have
a NULL gr_mem. Other code in libutil deals with this possibility. The pw code
does not.
I am attaching a patch file that I made against head.
The rcsid for pw_group is:
static const char rcsid[] =
"$FreeBSD: head/usr.sbin/pw/pw_group.c 244738 2012-12-27 14:44:13Z bapt $";
The rcsid for pw_user is:
static const char rcsid[] =
"$FreeBSD: head/usr.sbin/pw/pw_user.c 252688 2013-07-04 07:59:11Z des $";
Patch attached with submission follows:
--- usr.sbin/pw/pw_group.c.orig 2014-03-05 21:12:10.0 -0700
+++ usr.sbin/pw/pw_group.c 2014-03-05 21:22:03.0 -0700
@@ -227,10 +227,12 @@
else if (arg->ch == 'm') {
int k = 0;
- while (grp->gr_mem[k] != NULL) {
- if (extendarray(&members, &grmembers, i + 2) !=
-1)
- members[i++] = grp->gr_mem[k];
- k++;
+ if (grp->gr_mem != NULL) {
+ while (grp->gr_mem[k] != NULL) {
+ if (extendarray(&members, &grmembers, i
+ 2) != -1)
+ members[i++] = grp->gr_mem[k];
+ k++;
+ }
}
}
@@ -311,6 +313,9 @@
int k;
struct passwd *pwd;
+ if (grp->gr_mem == NULL)
+ return;
+
k = 0;
while (grp->gr_mem[k] != NULL) {
matchFound = false;
@@ -415,8 +420,10 @@
printf("Group Name: %-15s #%lu\n"
" Members: ",
grp->gr_name, (long) grp->gr_gid);
- for (i = 0; grp->gr_mem[i]; i++)
- printf("%s%s", i ? "," : "", grp->gr_mem[i]);
+ if (grp->gr_mem != NULL) {
+ for (i = 0; grp->gr_mem[i]; i++)
+ printf("%s%s", i ? "," : "", grp->gr_mem[i]);
+ }
fputs("\n\n", stdout);
}
return EXIT_SUCCESS;
--- usr.sbin/pw/pw_user.c.orig 2014-03-05 21:12:10.0 -0700
+++ usr.sbin/pw/pw_user.c 2014-03-05 21:21:43.0 -0700
@@ -425,19 +425,21 @@
}
grp = GETGRNAM(a_name->val);
- if (grp != NULL && *grp->gr_mem == NULL)
+ if (grp != NULL && (grp->gr_mem == NULL || *grp->gr_mem
== NULL))
delgrent(GETGRNAM(a_name->val));
SETGRENT();
while ((grp = GETGRENT()) != NULL) {
Re: ports/187309: databases/memcached: install error
Synopsis: databases/memcached: install error Responsible-Changed-From-To: freebsd-bugs->freebsd-ports-bugs Responsible-Changed-By: linimon Responsible-Changed-When: Thu Mar 6 06:43:43 UTC 2014 Responsible-Changed-Why: ports PR. http://www.freebsd.org/cgi/query-pr.cgi?pr=187309 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
