misc/179507: devel/kBuild won't compile on current
>Number: 179507 >Category: misc >Synopsis: devel/kBuild won't compile on current >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jun 12 08:00:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: kalentzidis Petros >Release:10-CURRENT >Organization: >Environment: FreeBSD freeBSD 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r251615: Tue Jun 11 13:49:26 EEST 2013 phantom@freeBSD:/usr/obj/usr/src/sys/pk_generic amd64 >Description: When trying to install devel/kBuild, I am getting the following error : kmk: Entering directory `/usr/ports/devel/kBuild/work/kBuild-0.1.9998' kBuild: Pass - Build Programs kBuild: Pass - Libraries kBuild: Compiling kDep - /usr/ports/devel/kBuild/work/kBuild-0.1.9998/src/lib/kDep.c kBuild: Compiling kUtil - /usr/ports/devel/kBuild/work/kBuild-0.1.9998/src/lib/crc32.c cc1: error: to generate dependencies you must specify either -M or -MM kmk: *** [/usr/ports/devel/kBuild/work/kBuild-0.1.9998/out/freebsd.amd64/release/obj/kUtil/crc32.o] Error 1 The failing command: @gcc -c -O2 -g -O3 -m64 -I/usr/ports/devel/kBuild/work/kBuild-0.1.9998/src/lib -I/usr/ports/devel/kBuild/work/kBuild-0.1.9998/src/kmk/glob -I/usr/local/include -DKBUILD_VERSION_MAJOR=0 -DKBUILD_VERSION_MINOR=1 -DKBUILD_VERSION_PATCH=9998 -DKBUILD_OS_FREEBSD -DKBUILD_ARCH_AMD64 -DNDEBUG -Wp,-MD,/usr/ports/devel/kBuild/work/kBuild-0.1.9998/out/freebsd.amd64/release/obj/kUtil/crc32.o.dep -Wp,-MT,/usr/ports/devel/kBuild/work/kBuild-0.1.9998/out/freebsd.amd64/release/obj/kUtil/crc32.o -Wp,-MP -o /usr/ports/devel/kBuild/work/kBuild-0.1.9998/out/freebsd.amd64/release/obj/kUtil/crc32.o /usr/ports/devel/kBuild/work/kBuild-0.1.9998/src/lib/crc32.c kmk: *** Waiting for unfinished jobs cc1: error: to generate dependencies you must specify either -M or -MM kmk: *** [/usr/ports/devel/kBuild/work/kBuild-0.1.9998/out/freebsd.amd64/release/obj/kDep/kDep.o] Error 1 The failing command: @gcc -c -O2 -g -O3 -m64 -I/usr/ports/devel/kBuild/work/kBuild-0.1.9998/src/lib -I/usr/ports/devel/kBuild/work/kBuild-0.1.9998/src/kmk/glob -I/usr/local/include -DKBUILD_VERSION_MAJOR=0 -DKBUILD_VERSION_MINOR=1 -DKBUILD_VERSION_PATCH=9998 -DKBUILD_OS_FREEBSD -DKBUILD_ARCH_AMD64 -DNDEBUG -Wp,-MD,/usr/ports/devel/kBuild/work/kBuild-0.1.9998/out/freebsd.amd64/release/obj/kDep/kDep.o.dep -Wp,-MT,/usr/ports/devel/kBuild/work/kBuild-0.1.9998/out/freebsd.amd64/release/obj/kDep/kDep.o -Wp,-MP -o /usr/ports/devel/kBuild/work/kBuild-0.1.9998/out/freebsd.amd64/release/obj/kDep/kDep.o /usr/ports/devel/kBuild/work/kBuild-0.1.9998/src/lib/kDep.c kmk: Leaving directory `/usr/ports/devel/kBuild/work/kBuild-0.1.9998' kmk: Entering directory `/usr/ports/devel/kBuild/work/kBuild-0.1.9998' kmk: *** Exiting with status 2 gmake: *** [/usr/ports/devel/kBuild/work/kBuild-0.1.9998/out/freebsd.amd64/release/bootstrap/ts-stage2-build] Error 2 ./kBuild/env.sh: info: rc=2: gmake -f bootstrap.gmk *** Error code 2 >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/162211: commit references a PR
The following reply was made to PR bin/162211; it has been noted by GNATS.
From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:
Subject: Re: bin/162211: commit references a PR
Date: Wed, 12 Jun 2013 07:52:58 + (UTC)
Author: grog
Date: Wed Jun 12 07:52:49 2013
New Revision: 251647
URL: http://svnweb.freebsd.org/changeset/base/251647
Log:
Handle some expression regressions.
Explicitly use GNU cpp for preprocessing.
Remove explicit debugging code.
Change some variable names to be less confusing.
Improve some comments.
Improve indentation.
PR: 162211
168785
MFC after: 2 weeks
Modified:
head/usr.bin/calendar/calendar.h
head/usr.bin/calendar/dates.c
head/usr.bin/calendar/io.c
head/usr.bin/calendar/parsedata.c
head/usr.bin/calendar/pathnames.h
head/usr.bin/calendar/sunpos.c
Modified: head/usr.bin/calendar/calendar.h
==
--- head/usr.bin/calendar/calendar.h Wed Jun 12 07:07:06 2013
(r251646)
+++ head/usr.bin/calendar/calendar.h Wed Jun 12 07:52:49 2013
(r251647)
@@ -101,11 +101,11 @@ extern int EastLongitude;
* program wrong.
*/
-/*
+/*
* All the astronomical calculations are carried out for the meridian 120
* degrees east of Greenwich.
*/
-#define UTCOFFSET_CNY 8.0
+#define UTCOFFSET_CNY 8.0
extern intdebug; /* show parsing of the input */
extern intyear1, year2;
@@ -174,7 +174,7 @@ intj2g(int);
/* dates.c */
extern int cumdaytab[][14];
-extern int mondaytab[][14];
+extern int monthdaytab[][14];
extern int debug_remember;
void generatedates(struct tm *tp1, struct tm *tp2);
void dumpdates(void);
Modified: head/usr.bin/calendar/dates.c
==
--- head/usr.bin/calendar/dates.c Wed Jun 12 07:07:06 2013
(r251646)
+++ head/usr.bin/calendar/dates.c Wed Jun 12 07:52:49 2013
(r251647)
@@ -10,7 +10,7 @@
* 2. Redistributions in binary form must reproduce the above copyright
*notice, this list of conditions and the following disclaimer in the
*documentation and/or other materials provided with the distribution.
- *
+ *
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
@@ -22,7 +22,7 @@
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
- *
+ *
*/
#include
@@ -73,8 +73,8 @@ int cumdaytab[][14] = {
{0, -1, 30, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334, 365},
};
/* 1-based month, individual */
-static int *mondays;
-int mondaytab[][14] = {
+static int *monthdays;
+int monthdaytab[][14] = {
{0, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31, 30},
{0, 31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31, 30},
};
@@ -192,11 +192,11 @@ generatedates(struct tm *tp1, struct tm
* - Take all days from
* - Take the first days from m2
*/
- mondays = mondaytab[isleap(y1)];
- for (d = d1; d <= mondays[m1]; d++)
+ monthdays = monthdaytab[isleap(y1)];
+ for (d = d1; d <= monthdays[m1]; d++)
createdate(y1, m1, d);
for (m = m1 + 1; m < m2; m++)
- for (d = 1; d <= mondays[m]; d++)
+ for (d = 1; d <= monthdays[m]; d++)
createdate(y1, m, d);
for (d = 1; d <= d2; d++)
createdate(y1, m2, d);
@@ -210,21 +210,21 @@ generatedates(struct tm *tp1, struct tm
* - Take all days from y2-[1 .. m2>
* - Take the first days of y2-m2
*/
- mondays = mondaytab[isleap(y1)];
- for (d = d1; d <= mondays[m1]; d++)
+ monthdays = monthdaytab[isleap(y1)];
+ for (d = d1; d <= monthdays[m1]; d++)
createdate(y1, m1, d);
for (m = m1 + 1; m <= 12; m++)
- for (d = 1; d <= mondays[m]; d++)
+ for (d = 1; d <= monthdays[m]; d++)
createdate(y1, m, d);
for (y = y1 + 1; y < y2; y++) {
- mondays = mondaytab[isleap(y)];
+ monthdays = monthdaytab[isleap(y)];
for (m = 1; m <= 12; m++)
- for (d = 1; d <= mondays[m]; d++)
+ for (d = 1; d <= monthdays[m]; d++)
createdate(y, m, d);
}
- mondays = mondaytab[
Re: conf/174225: [network.subr] [patch] add support for ipv6_addrs_IF style aliases to rc.conf(5)
Synopsis: [network.subr] [patch] add support for ipv6_addrs_IF style aliases to rc.conf(5) Responsible-Changed-From-To: freebsd-bugs->hrs Responsible-Changed-By: hrs Responsible-Changed-When: Wed Jun 12 08:09:48 UTC 2013 Responsible-Changed-Why: Take. http://www.freebsd.org/cgi/query-pr.cgi?pr=174225 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
kern/179523: [patch] Memory leak/corruption in cpuctl pseudo-driver and more
>Number: 179523
>Category: kern
>Synopsis: [patch] Memory leak/corruption in cpuctl pseudo-driver and more
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jun 12 20:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: clar...@runbox.com
>Release:9.1-RELEASE-p3
>Organization:
>Environment:
FreeBSD beastie.local 9.1-RELEASE-p3 FreeBSD 9.1-RELEASE-p3 #0: Mon Apr 29
18:27:25 UTC 2013
r...@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
1) Processor microcode update functions update_intel and update_via in
sys/dev/cpuctl/cpuctl.c allocate a buffer with malloc but free it with
contigfree. update_amd appears to be correct because it does contigmalloc
followed by contigfree.
2) Also, the UCODE_SIZE_MAX limit of 10 KB is too small for some microcode
updates. I noticed this because I tried to apply the most recent update for an
Intel Core i5-3570, which is 16 KB, and it failed due to this limit.
Currently, the largest microcode update I can find is 28 KB, so I raised the
limit to 32 KB to accommodate this.
I have fixed and tested both issues and attached a patch. The patch applies
cleanly both to the head and to 9.1-RELEASE-p3.
>How-To-Repeat:
1) Found by inspection of sys/dev/cpuctl/cpuctl.c
2) Try to apply a microcode update to an Intel, AMD, or VIA processor that
exceeds 10 KB in size.
>Fix:
Simply apply the attached patch and rebuild.
Patch attached with submission follows:
--- sys/dev/cpuctl/cpuctl.c.orig2012-12-03 19:52:24.0 -0500
+++ sys/dev/cpuctl/cpuctl.c 2013-06-12 13:15:20.0 -0400
@@ -63,7 +63,7 @@
# define DPRINTF(...)
#endif
-#defineUCODE_SIZE_MAX (10 * 1024)
+#defineUCODE_SIZE_MAX (32 * 1024)
static int cpuctl_do_msr(int cpu, cpuctl_msr_args_t *data, u_long cmd,
struct thread *td);
@@ -295,7 +295,7 @@
static int
update_intel(int cpu, cpuctl_update_args_t *args, struct thread *td)
{
- void *ptr = NULL;
+ void *ptr, *ptr_to_free = NULL;
uint64_t rev0, rev1;
uint32_t tmp[4];
int is_bound = 0;
@@ -314,8 +314,8 @@
/*
* 16 byte alignment required.
*/
- ptr = malloc(args->size + 16, M_CPUCTL, M_WAITOK);
- ptr = (void *)(16 + ((intptr_t)ptr & ~0xf));
+ ptr_to_free = malloc(args->size + 16, M_CPUCTL, M_WAITOK);
+ ptr = (void *)(16 + ((intptr_t)ptr_to_free & ~0xf));
if (copyin(args->data, ptr, args->size) != 0) {
DPRINTF("[cpuctl,%d]: copyin %p->%p of %zd bytes failed",
__LINE__, args->data, ptr, args->size);
@@ -346,8 +346,8 @@
else
ret = EEXIST;
fail:
- if (ptr != NULL)
- contigfree(ptr, args->size, M_CPUCTL);
+ if (ptr_to_free != NULL)
+ free(ptr_to_free, M_CPUCTL);
return (ret);
}
@@ -409,7 +409,7 @@
static int
update_via(int cpu, cpuctl_update_args_t *args, struct thread *td)
{
- void *ptr = NULL;
+ void *ptr, *ptr_to_free = NULL;
uint64_t rev0, rev1, res;
uint32_t tmp[4];
int is_bound = 0;
@@ -428,8 +428,8 @@
/*
* 4 byte alignment required.
*/
- ptr = malloc(args->size + 16, M_CPUCTL, M_WAITOK);
- ptr = (void *)(16 + ((intptr_t)ptr & ~0xf));
+ ptr_to_free = malloc(args->size + 16, M_CPUCTL, M_WAITOK);
+ ptr = (void *)(16 + ((intptr_t)ptr_to_free & ~0xf));
if (copyin(args->data, ptr, args->size) != 0) {
DPRINTF("[cpuctl,%d]: copyin %p->%p of %zd bytes failed",
__LINE__, args->data, ptr, args->size);
@@ -476,8 +476,8 @@
else
ret = 0;
fail:
- if (ptr != NULL)
- contigfree(ptr, args->size, M_CPUCTL);
+ if (ptr_to_free != NULL)
+ free(ptr_to_free, M_CPUCTL);
return (ret);
}
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/179523: [patch] Memory leak/corruption in cpuctl pseudo-driver and more
The following reply was made to PR kern/179523; it has been noted by GNATS. From: John Clark To: bug-follo...@freebsd.org, clar...@runbox.com Cc: Subject: Re: kern/179523: [patch] Memory leak/corruption in cpuctl pseudo-driver and more Date: Wed, 12 Jun 2013 16:46:57 -0400 P.S. Oops, it looks like I reversed my name and email address in the web submission form. I should have set up sendmail and used send-pr... - John ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
