Re: bin/177871: [patch] etherswitchcfg(8): uninitialized variable while setting port vlangroup
Synopsis: [patch] etherswitchcfg(8): uninitialized variable while setting port vlangroup Responsible-Changed-From-To: freebsd-bugs->freebsd-embedded Responsible-Changed-By: adrian Responsible-Changed-When: Fri Apr 19 17:51:46 UTC 2013 Responsible-Changed-Why: Snarf. http://www.freebsd.org/cgi/query-pr.cgi?pr=177871 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/177872: [patch] etherswitchcfg(8) crashes if called with no argument for vlangroups members
Synopsis: [patch] etherswitchcfg(8) crashes if called with no argument for vlangroups members Responsible-Changed-From-To: freebsd-bugs->freebsd-embedded Responsible-Changed-By: adrian Responsible-Changed-When: Fri Apr 19 17:51:59 UTC 2013 Responsible-Changed-Why: snarf. http://www.freebsd.org/cgi/query-pr.cgi?pr=177872 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/177873: [patch] etherswitchcfg(): Change the per port vlangroup option to pvid
Synopsis: [patch] etherswitchcfg(): Change the per port vlangroup option to pvid Responsible-Changed-From-To: freebsd-bugs->freebsd-embedded Responsible-Changed-By: adrian Responsible-Changed-When: Fri Apr 19 17:52:10 UTC 2013 Responsible-Changed-Why: snarf. http://www.freebsd.org/cgi/query-pr.cgi?pr=177873 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/172963: commit references a PR
The following reply was made to PR kern/172963; it has been noted by GNATS.
From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:
Subject: Re: kern/172963: commit references a PR
Date: Fri, 19 Apr 2013 21:09:04 + (UTC)
Author: rwatson
Date: Fri Apr 19 21:08:56 2013
New Revision: 249660
URL: http://svnweb.freebsd.org/changeset/base/249660
Log:
Merge r249478 from stable/8 to releng/8.4:
FreeBSD 8.0 introduced inpcb reference counting, and FreeBSD 8.1 began
using
that reference count to protect inpcb stability in udp_pcblist() and other
monitoring functions, preventing the inpcb from being garbage collected
across potentially sleeping copyout() operations despite the inpcb zone
becoming shrinkable.
However, this introduced a race condition in which inp->inp_socket() might
become NULL as a result of the socket being freed, but before the inpcb we
removed from the global list of connections, allowing it to be exposed to a
third thread invoking udp_input() or udp6_input() which would try to
indirect through inp_socket without testing it for NULL. This might occur
with particular regularity on systems that frequently run netstat, or which
use SNMP for connection monitoring.
Later FreeBSD releases use a different reference/destruction model, but
stable/8 remained affected in FreeBSD 8.2 and 8.3; the problem could be
spotted on very high-load UDP services, such as top-level name servers.
An Errata Note for 8.x branches under continuing support might be
appropriate. Regardless, this fix should be merged to releng/8.4 prior to
8.4-RELEASE.
PR: 172963
Submitted by: Vincent Miller
Submitted by: Julien Charbon
Submitted by: Marc De La Gueronniere
Approved by:re (rodrigc)
Modified:
releng/8.4/sys/netinet/udp_usrreq.c
releng/8.4/sys/netinet6/udp6_usrreq.c
Directory Properties:
releng/8.4/sys/ (props changed)
releng/8.4/sys/netinet/ (props changed)
releng/8.4/sys/netinet6/ (props changed)
Modified: releng/8.4/sys/netinet/udp_usrreq.c
==
--- releng/8.4/sys/netinet/udp_usrreq.cFri Apr 19 21:08:21 2013
(r249659)
+++ releng/8.4/sys/netinet/udp_usrreq.cFri Apr 19 21:08:56 2013
(r249660)
@@ -495,6 +495,15 @@ udp_input(struct mbuf *m, int off)
INP_RLOCK(inp);
/*
+ * Detached PCBs can linger in the list if someone
+ * holds a reference. (e.g. udp_pcblist)
+ */
+ if (inp->inp_socket == NULL) {
+ INP_RUNLOCK(inp);
+ continue;
+ }
+
+ /*
* Handle socket delivery policy for any-source
* and source-specific multicast. [RFC3678]
*/
@@ -620,6 +629,15 @@ udp_input(struct mbuf *m, int off)
*/
INP_RLOCK(inp);
INP_INFO_RUNLOCK(&V_udbinfo);
+
+ /*
+ * Detached PCBs can linger in the hash table if someone holds a
+ * reference. (e.g. udp_pcblist)
+ */
+ if (inp->inp_socket == NULL) {
+ INP_RUNLOCK(inp);
+ goto badunlocked;
+ }
if (inp->inp_ip_minttl && inp->inp_ip_minttl > ip->ip_ttl) {
INP_RUNLOCK(inp);
goto badunlocked;
Modified: releng/8.4/sys/netinet6/udp6_usrreq.c
==
--- releng/8.4/sys/netinet6/udp6_usrreq.c Fri Apr 19 21:08:21 2013
(r249659)
+++ releng/8.4/sys/netinet6/udp6_usrreq.c Fri Apr 19 21:08:56 2013
(r249660)
@@ -273,6 +273,13 @@ udp6_input(struct mbuf **mp, int *offp,
}
/*
+ * Detached PCBs can linger in the list if someone
+ * holds a reference. (e.g. udp_pcblist)
+ */
+ if (inp->inp_socket == NULL)
+ continue;
+
+ /*
* Handle socket delivery policy for any-source
* and source-specific multicast. [RFC3678]
*/
@@ -396,6 +403,15 @@ udp6_input(struct mbuf **mp, int *offp,
}
INP_RLOCK(inp);
INP_INFO_RUNLOCK(&V_udbinfo);
+
+ /*
+ * Detached PCBs can linger in the hash table if someone holds a
+ * reference. (e.g. udp_pcblist)
+ */
+ if (inp->inp_socket == NULL) {
+ INP_RUNLOCK(inp);
+ goto badunlocked;
+ }
up = intoudpcb(inp);
if (up->u_tun_func == NULL) {
u
misc/177985: disk usage problem when copying from one zfs dataset to another on the same pool using mv command
>Number: 177985 >Category: misc >Synopsis: disk usage problem when copying from one zfs dataset to >another on the same pool using mv command >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Apr 20 04:40:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Jon Valliere >Release:8.3 < FreeNAS variant >Organization: >Environment: FreeBSD freenas.local 8.3-RELEASE-p6 FreeBSD 8.3-RELEASE-p6 #0 r248141M: Sun Mar 10 16:35:05 PDT 2013 r...@build.ixsystems.com:/home/jpaetzel/8.3.1-RELEASE/os-base/amd64/tank/home/jpaetzel/8.3.1-RELEASE/FreeBSD/src/sys/FREENAS.amd64 amd64 >Description: the mv command performs a copy then delete operation when moving a file from one filesystem to another. in freebsd zfs datasets are handled as independent file systems even tho they share the same logical disk pool much like dynamic partitioning, if you would. for this given example I have a pool called array_0; array_0 has a total capacity of 4tb. I have two datasets on array_0; stor and public. stor has a folder FooBar which contains 3tb worth of files. mv array_0/stor/FooBar array_0/public/FooBar because these are different file systems it will copy then delete. here is the problem. there is only 1tb of space available on the pool. there isn't enough space for a full copy. today mv copied 1tb of data until the pool ran out of space then went kind of crazy. obviously it was not deleting files after it had already copied as it went along. if it had been deleting files as it was copying then it never would have totally consumed all disk space. >How-To-Repeat: create a pool with two datasets create a some directory structure that represents 75% of total capacity. mv that folder from one dataset to another on the same pool. >Fix: delete individual files after they are copied during the mv >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: conf/177845: WITH_BMAKE does not work on CURRENT
Still running into problems with the latest version of HEAD. For some odd reason it's not calling the build with the right version of make; it was working with svn though (which is bizarre), so I suspect my git workspace is fubar somehow (doing a diff to try and find the discrepancy right now). --- buildworld --- make: illegal option -- J usage: make [-BPSXeiknpqrstv] [-C directory] [-D variable] [-d flags] [-E variable] [-f makefile] [-I directory] [-j max_jobs] [-m directory] [-V variable] [variable=value] [target ...] *** [buildworld] Error code 2 make: stopped in /usr/src 1 error make: stopped in /usr/src On Sun, Apr 14, 2013 at 1:49 PM, Simon J. Gerraty wrote: > FWIW the buildworld I just did (with freebsd make as /usr/bin/make) > finished ok (tree updated to r249461), and lots of previous builds used > bmake as /usr/bin/make. I'll rebuild this same tree that way... > > Yep, that complete ok too. > >> I'm rebuilding world right now so it might be due to a bug fixed = >>in the past, but I swear I've seen this on another CURRENT box I kept = >>reasonably (within the past couple months) up to date. ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
