Re: kern/175323: commit references a PR
The following reply was made to PR kern/175323; it has been noted by GNATS. From: dfil...@freebsd.org (dfilter service) To: bug-follo...@freebsd.org Cc: Subject: Re: kern/175323: commit references a PR Date: Sat, 26 Jan 2013 10:50:11 + (UTC) Author: avg Date: Sat Jan 26 10:50:04 2013 New Revision: 245946 URL: http://svnweb.freebsd.org/changeset/base/245946 Log: g_mirror: g_getattr() failure should not be fatal This allows to use gmirror e.g. on top of ZVOLs. PR: kern/175323 Submitted by:alexei.vol...@softlynx.ru, mav Reported by: alexei.vol...@softlynx.ru Tested by: alexei.vol...@softlynx.ru Reviewed by: ae, mav, pjd MFC after: 1 week Modified: head/sys/geom/mirror/g_mirror.c Modified: head/sys/geom/mirror/g_mirror.c == --- head/sys/geom/mirror/g_mirror.cSat Jan 26 10:34:17 2013 (r245945) +++ head/sys/geom/mirror/g_mirror.cSat Jan 26 10:50:04 2013 (r245946) @@ -457,9 +457,7 @@ g_mirror_init_disk(struct g_mirror_softc disk->d_priority = md->md_priority; disk->d_flags = md->md_dflags; error = g_getattr("GEOM::candelete", disk->d_consumer, &i); - if (error != 0) - goto fail; - if (i) + if (error == 0 && i != 0) disk->d_flags |= G_MIRROR_DISK_FLAG_CANDELETE; if (md->md_provider[0] != '\0') disk->d_flags |= G_MIRROR_DISK_FLAG_HARDCODED; ___ svn-src-...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org" ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/175323: Fail to use ZVOL as a gmirror component
Synopsis: Fail to use ZVOL as a gmirror component Responsible-Changed-From-To: freebsd-bugs->avg Responsible-Changed-By: avg Responsible-Changed-When: Sat Jan 26 12:18:50 UTC 2013 Responsible-Changed-Why: I am handling this one. http://www.freebsd.org/cgi/query-pr.cgi?pr=175323 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/173332: commit references a PR
The following reply was made to PR bin/173332; it has been noted by GNATS. From: dfil...@freebsd.org (dfilter service) To: bug-follo...@freebsd.org Cc: Subject: Re: bin/173332: commit references a PR Date: Sat, 26 Jan 2013 21:29:54 + (UTC) Author: ian Date: Sat Jan 26 21:29:45 2013 New Revision: 245949 URL: http://svnweb.freebsd.org/changeset/base/245949 Log: Reduce watchdogd's memory footprint when running daemonized. This uses the recently-added jemalloc(3) feature of setting the lg_chunk tuning option to zero to request that memory be allocated in the smallest chunks possible. Without this option, the default is to initally map 8MB, and then the mlockall() call wires that entire allocation even though the program only uses a few Kbytes of it at runtime. PR: bin/173332 Approved by: cognet (mentor) Modified: head/usr.sbin/watchdogd/watchdogd.c Modified: head/usr.sbin/watchdogd/watchdogd.c == --- head/usr.sbin/watchdogd/watchdogd.cSat Jan 26 20:16:58 2013 (r245948) +++ head/usr.sbin/watchdogd/watchdogd.cSat Jan 26 21:29:45 2013 (r245949) @@ -71,6 +71,14 @@ static int nap = 1; static char *test_cmd = NULL; /* + * Ask malloc() to map minimum-sized chunks of virtual address space at a time, + * so that mlockall() won't needlessly wire megabytes of unused memory into the + * process. This must be done using the malloc_conf string so that it gets set + * up before the first allocation, which happens before entry to main(). + */ +const char * malloc_conf = "lg_chunk:0"; + +/* * Periodically pat the watchdog, preventing it from firing. */ int @@ -188,7 +196,7 @@ watchdog_loop(void) if (watchdog_onoff(0) == 0) { end_program = 2; } else { - warnx("Could not stop the watchdog, not exiting"); + warnx("Could not stop the watchdog, not exitting"); end_program = 0; } } ___ svn-src-...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org" ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"