Re: ports/171141: www/xombrero wrapper script acts wrong #2
Old Synopsis: xombrero wrapper script acts wrong #2 New Synopsis: www/xombrero wrapper script acts wrong #2 Responsible-Changed-From-To: freebsd-bugs->zeising Responsible-Changed-By: zeising Responsible-Changed-When: Wed Aug 29 08:59:51 UTC 2012 Responsible-Changed-Why: Take, it's my port. http://www.freebsd.org/cgi/query-pr.cgi?pr=171141 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/170651: On 9.0-RELEASE#0 and master sh(1) gobbles high bit at first
The following reply was made to PR bin/170651; it has been noted by GNATS. From: Steffen "Daode" Nurpmeso To: Jilles Tjoelker Cc: bug-follo...@freebsd.org Subject: Re: bin/170651: On 9.0-RELEASE#0 and master sh(1) gobbles high bit at first Date: Wed, 29 Aug 2012 12:24:11 +0200 This is a multi-part message in MIME format. --=_503dedcb.nteIZRWEG6EbH/vp9TUbaaUn9m8DsADejmyTkwQSsrStVaAf Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Jilles Tjoelker wrote: |This PR bin/170651 does in fact look valid. It looks like libedit only |partially picks up an LC_CTYPE change. Whether it shows '\OOO' or real |characters with bit 7 set changes immediately; whether it accepts |characters with bit 7 set changes only after doing something that causes |libedit to be reinitialized (such as 'set +o'). | |This is probably a bug in libedit and/or sh's use of it, although there |are bigger bugs in libedit and sh's use of it. | |-- |Jilles Tjoelker As all locale changes effectively boil down in var.c:{update,init}charset(), either call histedit() in updatecharset(), which is what the first (-easy) diff does, or introduce a new function which only performs the necessary libedit call-in to update the mapping (second patch, -harder). Since histedit() always causes a reparse of editrc(5) (and AFAIU), i would vote for the harder patch :) Thanks and ciao, --steffen --=_503dedcb.nteIZRWEG6EbH/vp9TUbaaUn9m8DsADejmyTkwQSsrStVaAf Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="pr_bin_170651-easy.diff" diff --git a/bin/sh/var.c b/bin/sh/var.c index 6041459..ccbb5d7 100644 --- a/bin/sh/var.c +++ b/bin/sh/var.c @@ -515,6 +515,7 @@ bltinunsetlocale(void) /* * Update the localeisutf8 flag. + * And force reinitialization of libedit's key mappings (PR bin/170651). */ void updatecharset(void) @@ -523,6 +524,9 @@ updatecharset(void) charset = nl_langinfo(CODESET); localeisutf8 = !strcmp(charset, "UTF-8"); +#ifndef NO_HISTORY + histedit(); +#endif } void --=_503dedcb.nteIZRWEG6EbH/vp9TUbaaUn9m8DsADejmyTkwQSsrStVaAf Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="pr_bin_170651-harder.diff" diff --git a/bin/sh/histedit.c b/bin/sh/histedit.c index 6371599..069ac04 100644 --- a/bin/sh/histedit.c +++ b/bin/sh/histedit.c @@ -158,6 +158,16 @@ bad: } } +void +hist_on_lc_change(void) +{ + if (iflag && editing) { + if (el) + el_set(el, EL_EDITOR, Vflag ? "vi" : "emacs"); + else + histedit(); + } +} void sethistsize(const char *hs) diff --git a/bin/sh/myhistedit.h b/bin/sh/myhistedit.h index e31276d..3193a09 100644 --- a/bin/sh/myhistedit.h +++ b/bin/sh/myhistedit.h @@ -37,6 +37,7 @@ extern EditLine *el; extern int displayhist; void histedit(void); +void hist_on_lc_change(void); void sethistsize(const char *); void setterm(const char *); diff --git a/bin/sh/var.c b/bin/sh/var.c index 6041459..8f019bf 100644 --- a/bin/sh/var.c +++ b/bin/sh/var.c @@ -515,6 +515,7 @@ bltinunsetlocale(void) /* * Update the localeisutf8 flag. + * And force reinitialization of libedit's key mappings (PR bin/170651). */ void updatecharset(void) @@ -523,6 +524,9 @@ updatecharset(void) charset = nl_langinfo(CODESET); localeisutf8 = !strcmp(charset, "UTF-8"); +#ifndef NO_HISTORY + hist_on_lc_change(); +#endif } void --=_503dedcb.nteIZRWEG6EbH/vp9TUbaaUn9m8DsADejmyTkwQSsrStVaAf-- ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/166656: [patch] dhclient(8) doesn't exit os link down
Synopsis: [patch] dhclient(8) doesn't exit os link down State-Changed-From-To: open->patched State-Changed-By: jhb State-Changed-When: Wed Aug 29 12:45:32 UTC 2012 State-Changed-Why: I think the current patches to dhclient in HEAD satisfy this now. Responsible-Changed-From-To: freebsd-bugs->jhb Responsible-Changed-By: jhb Responsible-Changed-When: Wed Aug 29 12:45:32 UTC 2012 Responsible-Changed-Why: I think the current patches to dhclient in HEAD satisfy this now. http://www.freebsd.org/cgi/query-pr.cgi?pr=166656 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/171137: NDIS causing PANIC
The following reply was made to PR kern/171137; it has been noted by GNATS. From: Gary Palmer To: Mike Manilone Cc: bug-follo...@freebsd.org Subject: Re: kern/171137: NDIS causing PANIC Date: Wed, 29 Aug 2012 08:59:44 -0400 On Wed, Aug 29, 2012 at 01:40:09AM +, Mike Manilone wrote: > The following reply was made to PR kern/171137; it has been noted by GNATS. > > From: Mike Manilone > To: bug-follo...@freebsd.org > Cc: > Subject: Re: kern/171137: NDIS causing PANIC > Date: Wed, 29 Aug 2012 09:34:56 +0800 > > Thanks for your patch. I rebuilt my kernel with "make buildkernel; make > installkernel". > Then I tried to /etc/rc.d/netif restart, still panic. (Maybe GREATER_THAN ?) Did you reboot between the installkernel and trying the netif restart? Gary ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/171121: bge driver not working with BCM5719 (HP Proliant DL 360 G8)
Hi, Unfortunately our switches can not set MTU per port, so no luck. :-/ But I could hook up a laptop and test whether having a low MTU on the link partner. Is it helpful if I test and verify that? Has it been a long time since you contacted Broadcom? Is there any hope of getting this fixed? I'm kinda stuck and may need to consider Linux instead if this does not sort out. :-( Bye, Anders. ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
bin/171173: etherswitchcfg vlangroup IOETHERSWITCHGETPORT error
>Number: 171173 >Category: bin >Synopsis: etherswitchcfg vlangroup IOETHERSWITCHGETPORT error >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Aug 29 20:20:01 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Harm Weites >Release:10.0-CURRENT >Organization: >Environment: FreeBSD router1.weites.net 10.0-CURRENT FreeBSD 10.0-CURRENT #7 r239193M: Thu Jan 1 01:00:00 CET 1970 root@dummy:/home/harm/work/freebsd/head/obj/mipseb/mips.mips/usr/home/harm/work/freebsd/head/src/sys/TP-WN1043ND mips >Description: I'm observing the following issue when using etherswitchcfg on my TP-Link 1043ND embedded MIPS device. The default vlan configuration is done in the dev/etherswitchcfg init, creating vlan1 (wan port) and vlan2 (ports 1-4) with corresponding vlangroups. Those work as expected. When configuring the switch to have a vlan(group) per physical port, I receive the following error: etherswitchcfg: ioctl(IOETHERSWITCHGETPORT): Bad address >How-To-Repeat: # /sbin/etherswitchcfg port3 vlangroup 3 etherswitchcfg: ioctl(IOETHERSWITCHGETPORT): Bad address >Fix: While going through etherswitchcfg.c I noticed a subtle difference with set_port_vlangroup() and set_port_media(); the latter also uses ioctl(IOETHERSWITCHGETPORT) but does not fail and works just fine. It looks like there is a missing bzero() in set_port_vlangroup(), I've attached a patch to address that. While at it, I've also added a print to tell the user what'll happen, and a fix to prevent the function to segfault when a vlangroup is not supplied. Result of my fixed code: # ./etherswitchcfg port3 vlangroup 3 Set vlangroup of port 3 to 3 port3: vlangroup: 3 media: Ethernet autoselect (100baseTX ) status: active Patch attached with submission follows: Index: etherswitchcfg.c === --- etherswitchcfg.c(revision 239193) +++ etherswitchcfg.c(working copy) @@ -136,13 +136,20 @@ int v; etherswitch_port_t p; + if (!argv[1]) + errx(EX_USAGE, "missing vlangroup #\n"); + v = strtol(argv[1], NULL, 0); if (v < 0 || v >= cfg->info.es_nvlangroups) errx(EX_USAGE, "vlangroup must be between 0 and %d", cfg->info.es_nvlangroups-1); + + bzero(&p, sizeof(p)); p.es_port = cfg->unit; if (ioctl(cfg->fd, IOETHERSWITCHGETPORT, &p) != 0) err(EX_OSERR, "ioctl(IOETHERSWITCHGETPORT)"); p.es_vlangroup = v; + + printf("Set vlangroup of port %d to %d\n", p.es_port, p.es_vlangroup); if (ioctl(cfg->fd, IOETHERSWITCHSETPORT, &p) != 0) err(EX_OSERR, "ioctl(IOETHERSWITCHSETPORT)"); } >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/171137: NDIS causing PANIC
The following reply was made to PR kern/171137; it has been noted by GNATS. From: Mike Manilone To: Gary Palmer Cc: bug-follo...@freebsd.org Subject: Re: kern/171137: NDIS causing PANIC Date: Thu, 30 Aug 2012 03:58:15 +0800 On 2012/08/29 20:59, Gary Palmer wrote: > On Wed, Aug 29, 2012 at 01:40:09AM +, Mike Manilone wrote: >> The following reply was made to PR kern/171137; it has been noted by GNATS. >> >> From: Mike Manilone >> To: bug-follo...@freebsd.org >> Cc: >> Subject: Re: kern/171137: NDIS causing PANIC >> Date: Wed, 29 Aug 2012 09:34:56 +0800 >> >> Thanks for your patch. I rebuilt my kernel with "make buildkernel; make >> installkernel". >> Then I tried to /etc/rc.d/netif restart, still panic. (Maybe GREATER_THAN >> ?) > Did you reboot between the installkernel and trying the netif restart? > > Gary Sure. It still causes panic. ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
bin/171174: ps(1) shows bad error message with specific arguments
>Number: 171174 >Category: bin >Synopsis: ps(1) shows bad error message with specific arguments >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Aug 29 21:10:01 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Devin Teske >Release:FreeBSD 10.0-CURRENT amd64 >Organization: FIS Global, Inc. >Environment: FreeBSD ref10-amd64.freebsd.org 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r231914: Sun Feb 19 17:24:37 UTC 2012 b...@glide.freebsd.org:/usr/obj/scratch/src/sys/GLIDE amd64 >Description: Executing "ps -p ''" produces an appropriate error message (shown below): ps: Invalid (zero-length) process id However, when one executes instead "ps -o ucomm -p ''", the error message contains a corrupted string (shown below): ps: Invalid process id: PfÐ >How-To-Repeat: Use the "-o" flag with any value in conjunction with "-p" passed a NULL (zero-length) argument. >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/171174: commit references a PR
The following reply was made to PR bin/171174; it has been noted by GNATS. From: dfil...@freebsd.org (dfilter service) To: bug-follo...@freebsd.org Cc: Subject: Re: bin/171174: commit references a PR Date: Wed, 29 Aug 2012 21:38:44 + (UTC) Author: emaste Date: Wed Aug 29 21:38:34 2012 New Revision: 239883 URL: http://svn.freebsd.org/changeset/base/239883 Log: Avoid passing uninitialized stack to addelem() if called with an empty arg. PR: bin/171174 Modified: head/bin/ps/ps.c Modified: head/bin/ps/ps.c == --- head/bin/ps/ps.c Wed Aug 29 21:12:19 2012(r239882) +++ head/bin/ps/ps.c Wed Aug 29 21:38:34 2012(r239883) @@ -889,8 +889,8 @@ add_list(struct listinfo *inf, const cha int toolong; char elemcopy[PATH_MAX]; - if (*argp == 0) - inf->addelem(inf, elemcopy); + if (*argp == '\0') + inf->addelem(inf, argp); while (*argp != '\0') { while (*argp != '\0' && strchr(W_SEP, *argp) != NULL) argp++; ___ svn-src-...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org" ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/171174: ps(1) shows bad error message with specific arguments
Synopsis: ps(1) shows bad error message with specific arguments State-Changed-From-To: open->patched State-Changed-By: emaste State-Changed-When: Wed Aug 29 23:16:20 UTC 2012 State-Changed-Why: Fix committed as 239883 Responsible-Changed-From-To: freebsd-bugs->emaste Responsible-Changed-By: emaste Responsible-Changed-When: Wed Aug 29 23:16:20 UTC 2012 Responsible-Changed-Why: Grab http://www.freebsd.org/cgi/query-pr.cgi?pr=171174 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"