kern/164203: usr/src/sys/sys/smp.h:124: warning: comparison between signed and unsigned

2012-01-16 Thread Oliver

>Number: 164203
>Category:   kern
>Synopsis:   usr/src/sys/sys/smp.h:124: warning: comparison between signed 
>and unsigned
>Confidential:   no
>Severity:   non-critical
>Priority:   medium
>Responsible:freebsd-bugs
>State:  open
>Quarter:
>Keywords:   
>Date-Required:
>Class:  sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 16 15:50:09 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Oliver
>Release:9.0-RELEASE
>Organization:
n/a
>Environment:
FreeBSD test 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC 2012   
  r...@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Hello,

I'm trying to build VirtualBox on 9.0-Release and get the following warning:

===8<=SNIP==
In file included from 
/opt/vbox/VirtualBox-4.1.8_OSE/src/VBox/Runtime/r0drv/freebsd/the-freebsd-kernel.h:57,
 from 
/opt/vbox/VirtualBox-4.1.8_OSE/src/VBox/Runtime/r0drv/freebsd/memobj-r0drv-freebsd.c:35:
/usr/src/sys/sys/smp.h: In function 'cpu_next':
/usr/src/sys/sys/smp.h:124: warning: comparison between signed and unsigned
In file included from 
/opt/vbox/VirtualBox-4.1.8_OSE/src/VBox/Runtime/r0drv/freebsd/the-freebsd-kernel.h:57,
 from 
/opt/vbox/VirtualBox-4.1.8_OSE/src/VBox/Runtime/r0drv/freebsd/process-r0drv-freebsd.c:34:
/usr/src/sys/sys/smp.h: In function 'cpu_next':
/usr/src/sys/sys/smp.h:124: warning: comparison between signed and unsigned
/opt/vbox/VirtualBox-4.1.8_OSE/src/VBox/Runtime/r0drv/freebsd/memobj-r0drv-freebsd.c:
 In function 'rtR0MemObjFreeBSDPhysPageInit':
/opt/vbox/VirtualBox-4.1.8_OSE/src/VBox/Runtime/r0drv/freebsd/memobj-r0drv-freebsd.c:398:
 error: 'PG_UNMANAGED' undeclared (first use in this function)
/opt/vbox/VirtualBox-4.1.8_OSE/src/VBox/Runtime/r0drv/freebsd/memobj-r0drv-freebsd.c:398:
 error: (Each undeclared identifier is reported only once
/opt/vbox/VirtualBox-4.1.8_OSE/src/VBox/Runtime/r0drv/freebsd/memobj-r0drv-freebsd.c:398:
 error: for each function it appears in.)
In file included from 
/opt/vbox/VirtualBox-4.1.8_OSE/src/VBox/Runtime/r0drv/freebsd/the-freebsd-kernel.h:57,
 from 
/opt/vbox/VirtualBox-4.1.8_OSE/src/VBox/Runtime/r0drv/freebsd/semevent-r0drv-freebsd.c:35:
/usr/src/sys/sys/smp.h: In function 'cpu_next':
/usr/src/sys/sys/smp.h:124: warning: comparison between signed and unsigned
kmk: *** 
[/opt/vbox/VirtualBox-4.1.8_OSE/out/freebsd.amd64/release/obj/RuntimeR0Drv/r0drv/freebsd/memobj-r0drv-freebsd.o]
 Error 1

=>8=SNAP=

I checked /usr/src/sys/sys/smp.h and can see that mp_maxid is declared as 
extern u_int. But I'm not sure if this is a compiler problem or just a wrong 
declaration on line 124, for cpu_next(int i).

If it's changed to cpu_next(u_int i) it works, and virtualbox compiles and 
works too.

Thanks.

KR,

Grimeton

>How-To-Repeat:
- Install 9.0-RELEASE
- Install src.txz from your fav. server
- Get VirtualBox 4.1.8 sources from www.virtualbox.org
- configure and build virtualbox and see the error message from above

>Fix:
One can change the delaration of cpu_next() to cpu_next(u_int i).


>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


Re: misc/163525: 8.2-STABLE buildworld broken due to non-existing MK_INET_SUPPORT

2012-01-16 Thread Eugene Grosbein
16.01.2012 08:30, lini...@freebsd.org пишет:
> Synopsis: 8.2-STABLE buildworld broken due to non-existing MK_INET_SUPPORT
> 
> State-Changed-From-To: open->feedback
> State-Changed-By: linimon
> State-Changed-When: Mon Jan 16 01:30:37 UTC 2012
> State-Changed-Why: 
> Has this problem been resolved?
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=163525

Yes, it has been resolved, world builds just fine in this mode.
Thank you, the PR should be closed.

Eugene Grosbein
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


Re: kern/162741: commit references a PR

2012-01-16 Thread Adam McDougall

On 12/07/11 02:10, dfilter service wrote:

The following reply was made to PR kern/162741; it has been noted by GNATS.

From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:
Subject: Re: kern/162741: commit references a PR
Date: Wed,  7 Dec 2011 07:03:23 + (UTC)

  Author: alc
  Date: Wed Dec  7 07:03:14 2011
  New Revision: 228317
  URL: http://svn.freebsd.org/changeset/base/228317

  Log:
Eliminate the possibility of 32-bit arithmetic overflow in the calculation
of vm_kmem_size that may occur if the system administrator has specified a
vm.vm_kmem_size tunable value that exceeds the hard cap.

PR: 162741
Submitted by:   Adam McDougall
Reviewed by:bde@
MFC after:  3 weeks

  Modified:
head/sys/kern/kern_malloc.c

  Modified: head/sys/kern/kern_malloc.c
  ==
  --- head/sys/kern/kern_malloc.c   Wed Dec  7 00:22:34 2011
(r228316)
  +++ head/sys/kern/kern_malloc.c   Wed Dec  7 07:03:14 2011
(r228317)
  @@ -740,11 +740,11 @@ kmeminit(void *dummy)
/*
 * Limit kmem virtual size to twice the physical memory.
 * This allows for kmem map sparseness, but limits the size
  -  * to something sane. Be careful to not overflow the 32bit
  -  * ints while doing the check.
  +  * to something sane.  Be careful to not overflow the 32bit
  +  * ints while doing the check or the adjustment.
 */
  - if (((vm_kmem_size / 2) / PAGE_SIZE)>  cnt.v_page_count)
  - vm_kmem_size = 2 * cnt.v_page_count * PAGE_SIZE;
  + if (vm_kmem_size / 2 / PAGE_SIZE>  mem_size)
  + vm_kmem_size = 2 * mem_size * PAGE_SIZE;

   #ifdef DEBUG_MEMGUARD
tmp = memguard_fudge(vm_kmem_size, vm_kmem_size_max);


Since 9.0-RELEASE is out the door now, could this be merged to 8 and 9? 
 Thanks!

___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


misc/164206: [PATCH] buildworld WITHOUT_OPENSSL stops at lib/libarchive

2012-01-16 Thread Devin Teske

>Number: 164206
>Category:   misc
>Synopsis:   [PATCH] buildworld WITHOUT_OPENSSL stops at lib/libarchive
>Confidential:   no
>Severity:   non-critical
>Priority:   low
>Responsible:freebsd-bugs
>State:  open
>Quarter:
>Keywords:   
>Date-Required:
>Class:  sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 16 17:10:08 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Devin Teske
>Release:FreeBSD 9.0-RELEASE amd64
>Organization:
FIS Global, Inc.
>Environment:
FreeBSD scribe.vicor.com 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 
UTC 2010
r...@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
When performing buildworld while specifying WITHOUT_OPENSSL, the depend target 
fails during mkdep. Output below:

$ make buildworld -DWITHOUT_OPENSSL
[snip]
===> lib/libarchive (depend)
rm -f .depend
mkdep -f .depend -a -DHAVE_BZLIB_H=1 -DHAVE_LIBLZMA=1 -DHAVE_LZMA_H=1 
-DPLATFORM_CONFIG_H=\"/usr/src/lib/libarchive/config_freebsd.h\" 
-I/usr/obj/usr/src/lib/libarchive 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_check_magic.c
 /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_entry.c 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_entry_copy_stat.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_entry_stat.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_entry_strmode.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_entry_link_resolver.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_entry_xattr.c
 /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read.c 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_data_into_fd.c
 /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_disk
 .c 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_disk_entry_from_file.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_disk_set_standard_lookup.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_extract.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_open_fd.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_open_file.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_open_filename.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_open_memory.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_all.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_bzip2.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_compress.c
 /usr/src/lib/libarchive/../../contrib/libarchive/libarchive
 /archive_read_support_compression_gzip.c /usr/src/lib/libarc!
 
hive/../.../contrib/libarchive/libarchive/archive_read_support_compression_none.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_program.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_rpm.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_uu.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_compression_xz.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_all.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_ar.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_cpio.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_empty.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_iso9660.c
 /usr/src/lib/libarchive/../../con
 trib/libarchive/libarchive/archive_read_support_format_mtree.c 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_raw.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_tar.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_xar.c
 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_support_format_zip.c
 /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_string.c 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_string_sprintf.c
 /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_util.c 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_virtual.c 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write.c 
/usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_write_disk.c
 /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archi

misc/164208: [PATCH] buildworld WITHOUT_OPENSSL stops at lib/libbsnmp/libbsnmp

2012-01-16 Thread Devin Teske

>Number: 164208
>Category:   misc
>Synopsis:   [PATCH] buildworld WITHOUT_OPENSSL stops at 
>lib/libbsnmp/libbsnmp
>Confidential:   no
>Severity:   serious
>Priority:   medium
>Responsible:freebsd-bugs
>State:  open
>Quarter:
>Keywords:   
>Date-Required:
>Class:  sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 16 17:30:09 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Devin Teske
>Release:FreeBSD 9.0-RELEASE amd64
>Organization:
FIS Global, Inc.
>Environment:
FreeBSD scribe.vicor.com 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 
UTC 2010
r...@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
When performing buildworld while specifying WITHOUT_OPENSSL, the all target 
fails during cc of snmpcrypto.c in contrib/bsnmp/lib. Output below:

$ make -DWITHOUT_OPENSSL
[snip]
===> lib/libbsnmp/libbsnmp (all)
[snip]
cc -I/usr/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib -DHAVE_E
RR_H -DHAVE_GETADDRINFO -DHAVE_STRLCPY -DHAVE_STDINT_H -DHAVE_INTTYPES_H -DQUADF
MT='"llu"' -DQUADXFMT='"llx"' -std=gnu99 -fstack-protector -Wsystem-headers -Wal
l -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototy
pes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow
-Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wre
dundant-decls -Wold-style-definition -Wno-pointer-sign -c /usr/src/lib/libbsnmp/
libbsnmp/../../../contrib/bsnmp/lib/snmpcrypto.c
/usr/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmpcrypto.c:371: erro
r: conflicting types for 'snmp_passwd_to_keys'
/usr/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmp.h:273: error: pre
vious declaration of 'snmp_passwd_to_keys' was here
/usr/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmpcrypto.c:384: erro
r: conflicting types for 'snmp_get_local_keys'
/usr/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmp.h:274: error: pre
vious declaration of 'snmp_get_local_keys' was here
*** Error code 1

>How-To-Repeat:
1. csup RELENG_9
2. cd /usr/src
3. make buildworld -DWITHOUT_OPENSSL

NOTE: You'll first stop at lib/libarchive making depend. Apply the patch from 
PR 164206 to make it past lib/libarchive

4. See above description for error output
>Fix:
See attached patch.txt.

Patch attached with submission follows:

--- contrib/bsnmp/lib/snmpcrypto.c.orig 2011-09-22 17:51:37.0 -0700
+++ contrib/bsnmp/lib/snmpcrypto.c  2012-01-15 09:49:27.0 -0800
@@ -366,7 +366,7 @@ snmp_pdu_decrypt(const struct snmp_pdu *
return (SNMP_CODE_OK);
 }
 
-int
+enum snmp_code
 snmp_passwd_to_keys(struct snmp_user *user, char *passwd __unused)
 {
if (user->auth_proto == SNMP_AUTH_NOAUTH &&
@@ -378,7 +378,7 @@ snmp_passwd_to_keys(struct snmp_user *us
return (SNMP_CODE_FAILED);
 }
 
-int
+enum snmp_code
 snmp_get_local_keys(struct snmp_user *user, uint8_t *eid __unused,
 uint32_t elen __unused)
 {


>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


misc/164209: [PATCH] buildworld WITHOUT_OPENSSL stops at usr.sbin/wpa/hostapd

2012-01-16 Thread Devin Teske

>Number: 164209
>Category:   misc
>Synopsis:   [PATCH] buildworld WITHOUT_OPENSSL stops at 
>usr.sbin/wpa/hostapd
>Confidential:   no
>Severity:   serious
>Priority:   medium
>Responsible:freebsd-bugs
>State:  open
>Quarter:
>Keywords:   
>Date-Required:
>Class:  sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 16 17:50:07 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Devin Teske
>Release:FreeBSD 9.0-RELEASE amd64
>Organization:
FIS Global, Inc.
>Environment:
FreeBSD scribe.vicor.com 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 
UTC 2010
r...@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
When performing buildworld while specifying WITHOUT_OPENSSL, the depend target 
fails during mkdep. Output below:

===> usr.sbin/wpa/hostapd (depend)
rm -f .depend
mkdep -f .depend -a-DDRUID -I/usr/src/usr.sbin/wpa/hostapd 
-I/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src 
-I/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/common 
-I/usr/src/usr.sbin/wp
a/hostapd/../../../contrib/wpa//src/crypto 
-I/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/l2_packet 
-I/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/utils 
-DCONFIG_CTRL_IFACE -DCONFIG_CTRL
_IFACE_UNIX -I/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//hostapd 
-I/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/drivers 
-DCONFIG_DRIVER_BSD -DHOSTAPD -DCONFIG_DRIVER_RADIUS_ACL -DCONFIG_IP
V6 -DEAP_TLS_NONE -DINTERNAL_AES -DINTERNAL_SHA1 -DINTERNAL_MD5 
-I/usr/src/usr.sbin/wpa/hostapd 
-I/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src 
-I/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//
src/common -I/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/crypto 
-I/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/l2_packet 
-I/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/utils
-DCONFIG_CTRL_IFACE -DCONFIG_CTRL_IFACE_UNIX 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/ap/accounting.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/crypto/aes-wrap.c 
/usr/src/usr.sbin
/wpa/hostapd/../../../contrib/wpa//src/ap/ap_config.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/ap/ap_drv_ops.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/ap/ap_mlme.c 
/usr/src/usr.
sbin/wpa/hostapd/../../../contrib/wpa//src/ap/authsrv.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/eap_common/chap.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/utils/common.c /usr/sr
c/usr.sbin/wpa/hostapd/../../../contrib/wpa//hostapd/config_file.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//hostapd/ctrl_iface.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/crypto/crypt
o_openssl.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/ap/ctrl_iface_ap.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/drivers/drivers.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/
wpa//src/ap/drv_callbacks.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//hostapd/dump_state.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/eap_common/eap_common.c 
/usr/src/usr.sbin/wpa/hosta
pd/../../../contrib/wpa//src/eap_common/eap_peap_common.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//hostapd/eap_register.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/eap_server/eap_serv
er.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/eap_server/eap_server_gtc.c
 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/eap_server/eap_server_identity.c
 /usr/src/usr.sbin/wpa/hostapd/
./../../contrib/wpa//src/eap_server/eap_server_md5.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/eap_server/eap_server_methods.c
 /usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/eap_server
/eap_server_mschapv2.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/eap_server/eap_server_peap.c
 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/eap_server/eap_server_tls.c
 /usr/src/usr.sbi
n/wpa/hostapd/../../../contrib/wpa//src/eap_server/eap_server_tls_common.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/eap_server/eap_server_ttls.c
 /usr/src/usr.sbin/wpa/hostapd/../../../contrib/w
pa//src/eapol_auth/eapol_auth_dump.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/eapol_auth/eapol_auth_sm.c
 /usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/utils/eloop.c 
/usr/src/usr.sbin/
wpa/hostapd/../../../contrib/wpa//src/ap/hostapd.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/ap/ieee802_11_auth.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/common/ieee802_11_common
.c /usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/ap/ieee802_11_ht.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/ap/ieee802_1x.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/ut
ils/ip_addr.c 
/usr/src/usr.sbin/wpa/hostapd/../../../contrib/wpa//src/crypto/md5.c 
/usr/src/u

Re: misc/164208: [PATCH] buildworld WITHOUT_OPENSSL stops at lib/libbsnmp/libbsnmp

2012-01-16 Thread Devin Teske
The following reply was made to PR misc/164208; it has been noted by GNATS.

From: Devin Teske 
To: , 
Cc:  
Subject: Re: misc/164208: [PATCH] buildworld WITHOUT_OPENSSL stops at 
lib/libbsnmp/libbsnmp
Date: Mon, 16 Jan 2012 09:48:13 -0800

 Typo in the original description.
 
$ make -DWITHOUT_OPENSSL
 
 should be
 
$ make buildworld -DWITHOUT_OPENSSL
 
 -- 
 Devin
 
 _
 The information contained in this message is proprietary and/or confidential. 
If you are not the intended recipient, please: (i) delete the message and all 
copies; (ii) do not disclose, distribute or use the message in any manner; and 
(iii) notify the sender immediately. In addition, please be aware that any 
message addressed to our domain is subject to archiving and review by persons 
other than the intended recipient. Thank you.
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


misc/164210: [PATCH] buildworld WITHOUT_OPENSSL stops at usr.sbin/wpa/wpa_supplicant

2012-01-16 Thread Devin Teske

>Number: 164210
>Category:   misc
>Synopsis:   [PATCH] buildworld WITHOUT_OPENSSL stops at 
>usr.sbin/wpa/wpa_supplicant
>Confidential:   no
>Severity:   serious
>Priority:   medium
>Responsible:freebsd-bugs
>State:  open
>Quarter:
>Keywords:   
>Date-Required:
>Class:  sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 16 18:00:21 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Devin Teske
>Release:FreeBSD 9.0-RELEASE amd64
>Organization:
FIS Global, Inc.
>Environment:
FreeBSD scribe.vicor.com 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 
UTC 2010
r...@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
When performing buildworld while specifying WITHOUT_OPENSSL, the all target 
fails while linking wpa_supplicant in usr.sbin/wpa/wpa_supplicant. Output below:

$ make buildworld -DWITHOUT_OPENSSL
[snip]
===> usr.sbin/wpa/wpa_supplicant (all)
[snip]
cc -I/usr/src/usr.sbin/wpa/wpa_supplicant 
-I/usr/src/usr.sbin/wpa/wpa_supplicant/../../../contrib/wpa//src 
-I/usr/src/usr.sbin/wpa/wpa_supplicant/../../../contrib/wpa//src/common 
-I/usr/src/
usr.sbin/wpa/wpa_supplicant/../../../contrib/wpa//src/crypto 
-I/usr/src/usr.sbin/wpa/wpa_supplicant/../../../contrib/wpa//src/l2_packet 
-I/usr/src/usr.sbin/wpa/wpa_supplicant/../../../contrib/wpa//sr
c/utils -DCONFIG_CTRL_IFACE -DCONFIG_CTRL_IFACE_UNIX 
-I/usr/src/usr.sbin/wpa/wpa_supplicant/../../../contrib/wpa//wpa_supplicant 
-I/usr/src/usr.sbin/wpa/wpa_supplicant/../../../contrib/wpa//src/drive
rs -I/usr/src/usr.sbin/wpa/wpa_supplicant/../../../contrib/wpa//src/rsn_supp 
-DCONFIG_DRIVER_BSD -DCONFIG_DRIVER_NDIS -DCONFIG_DRIVER_WIRED 
-DCONFIG_TERMINATE_ONLASTIF -DCONFIG_DEBUG_SYSLOG -DCONFIG_
BACKEND_FILE  -DIEEE8021X_EAPOL -DEAP_TLS_NONE -DINTERNAL_AES -DINTERNAL_SHA1 
-DINTERNAL_MD5 -I/usr/src/usr.sbin/wpa/wpa_supplicant 
-I/usr/src/usr.sbin/wpa/wpa_supplicant/../../../contrib/wpa//src -I
/usr/src/usr.sbin/wpa/wpa_supplicant/../../../contrib/wpa//src/common 
-I/usr/src/usr.sbin/wpa/wpa_supplicant/../../../contrib/wpa//src/crypto 
-I/usr/src/usr.sbin/wpa/wpa_supplicant/../../../contrib/w
pa//src/l2_packet 
-I/usr/src/usr.sbin/wpa/wpa_supplicant/../../../contrib/wpa//src/utils 
-DCONFIG_CTRL_IFACE -DCONFIG_CTRL_IFACE_UNIX -std=gnu99 -fstack-protector   -o 
wpa_supplicant aes-cbc.o aes-ct
r.o aes-eax.o aes-encblock.o aes-internal.o aes-omac1.o aes-unwrap.o aes-wrap.o 
bss.o blacklist.o common.o config.o ctrl_iface.o ctrl_iface_unix.o drivers.o 
eloop.o events.o l2_packet_freebsd.o main.
o md5.o notify.o preauth.o pmksa_cache.o scan.o sha1-pbkdf2.o sha1-tlsprf.o 
sha1-tprf.o sha1.o wpa.o wpa_common.o wpa_debug.o wpa_ie.o wpa_supplicant.o 
wpabuf.o wpas_glue.o driver_ndis.o Packet32.o d
river_wired.o driver_freebsd.o os_unix.o config_file.o base64.o eapol_supp_sm.o 
eap.o eap_common.o eap_methods.o eap_register.o tls_none.o -lpcap
aes-cbc.o: In function `aes_128_cbc_encrypt':
aes-cbc.c:(.text+0x37): undefined reference to `aes_encrypt_init'
aes-cbc.c:(.text+0xba): undefined reference to `aes_encrypt'
aes-cbc.c:(.text+0xe6): undefined reference to `aes_encrypt_deinit'
aes-cbc.o: In function `aes_128_cbc_decrypt':
aes-cbc.c:(.text+0x147): undefined reference to `aes_decrypt_init'
aes-cbc.c:(.text+0x1a7): undefined reference to `aes_decrypt'
aes-cbc.c:(.text+0x20c): undefined reference to `aes_decrypt_deinit'
aes-ctr.o: In function `aes_128_ctr_encrypt':
aes-ctr.c:(.text+0x42): undefined reference to `aes_encrypt_init'
aes-ctr.c:(.text+0x84): undefined reference to `aes_encrypt'
aes-ctr.c:(.text+0x12d): undefined reference to `aes_encrypt_deinit'
aes-encblock.o: In function `aes_128_encrypt_block':
aes-encblock.c:(.text+0x1e): undefined reference to `aes_encrypt_init'
aes-encblock.c:(.text+0x43): undefined reference to `aes_encrypt'
aes-encblock.c:(.text+0x4c): undefined reference to `aes_encrypt_deinit'
aes-omac1.o: In function `omac1_aes_128_vector':
aes-omac1.c:(.text+0xdf): undefined reference to `aes_encrypt_init'  
aes-omac1.c:(.text+0x204): undefined reference to `aes_encrypt'
aes-omac1.c:(.text+0x238): undefined reference to `aes_encrypt'
aes-omac1.c:(.text+0x32d): undefined reference to `aes_encrypt'
aes-omac1.c:(.text+0x336): undefined reference to `aes_encrypt_deinit'
aes-unwrap.o: In function `aes_unwrap':
aes-unwrap.c:(.text+0x62): undefined reference to `aes_decrypt_init' 
aes-unwrap.c:(.text+0xfb): undefined reference to `aes_decrypt'
aes-unwrap.c:(.text+0x14d): undefined reference to `aes_decrypt_deinit'
aes-wrap.o: In function `aes_wrap':
aes-wrap.c:(.text+0x6b): undefined reference to `aes_encrypt_init'
aes-wrap.c:(.text+0xdf): undefined reference to `aes_encrypt'
aes-wrap.c:(.text+0x15b): undefined reference to `aes_encrypt_deinit'
md5.o: In function `hmac_md5_vector':
md5.c:(.text+0x80): undefined reference to `md5_vector'
md5.c:(.text+0x198): undefined reference to `md5_vector'
md5.c:(.text+0x24d): undefined reference to `md5_vector'
sha1

Re: conf/163668: commit references a PR

2012-01-16 Thread dfilter service
The following reply was made to PR conf/163668; it has been noted by GNATS.

From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:  
Subject: Re: conf/163668: commit references a PR
Date: Mon, 16 Jan 2012 19:34:35 + (UTC)

 Author: jh
 Date: Mon Jan 16 19:34:21 2012
 New Revision: 230226
 URL: http://svn.freebsd.org/changeset/base/230226
 
 Log:
   Change checkpath() to not exit on error. This is a prerequisite for
   fixing the mount(8) "failok" option.
   
   PR:  163668
   Reviewed by: Garrett Cooper, delphij (previous version)
 
 Modified:
   head/sbin/mount/getmntopts.c
   head/sbin/mount/mntopts.h
   head/sbin/mount/mount.c
   head/sbin/mount/mount_fs.c
   head/sbin/mount_cd9660/mount_cd9660.c
   head/sbin/mount_ext2fs/mount_ext2fs.c
   head/sbin/mount_msdosfs/mount_msdosfs.c
   head/sbin/mount_nfs/mount_nfs.c
   head/sbin/mount_ntfs/mount_ntfs.c
   head/sbin/mount_nullfs/mount_nullfs.c
   head/sbin/mount_reiserfs/mount_reiserfs.c
   head/sbin/mount_std/mount_std.c
   head/sbin/mount_udf/mount_udf.c
   head/sbin/mount_unionfs/mount_unionfs.c
   head/usr.sbin/mount_portalfs/mount_portalfs.c
 
 Modified: head/sbin/mount/getmntopts.c
 ==
 --- head/sbin/mount/getmntopts.c   Mon Jan 16 18:19:53 2012
(r230225)
 +++ head/sbin/mount/getmntopts.c   Mon Jan 16 19:34:21 2012
(r230226)
 @@ -124,16 +124,20 @@ rmslashes(char *rrpin, char *rrpout)
*rrpout = '\0';
  }
  
 -void
 +int
  checkpath(const char *path, char *resolved)
  {
struct stat sb;
  
if (realpath(path, resolved) != NULL && stat(resolved, &sb) == 0) {
 -  if (!S_ISDIR(sb.st_mode))
 -  errx(EX_USAGE, "%s: not a directory", resolved);
 +  if (!S_ISDIR(sb.st_mode)) {
 +  errno = ENOTDIR;
 +  return (1);
 +  }
} else
 -  errx(EX_USAGE, "%s: %s", resolved, strerror(errno));
 +  return (1);
 +
 +  return (0);
  }
  
  void
 
 Modified: head/sbin/mount/mntopts.h
 ==
 --- head/sbin/mount/mntopts.h  Mon Jan 16 18:19:53 2012(r230225)
 +++ head/sbin/mount/mntopts.h  Mon Jan 16 19:34:21 2012(r230226)
 @@ -93,7 +93,7 @@ struct mntopt {
  
  void getmntopts(const char *, const struct mntopt *, int *, int *);
  void rmslashes(char *, char *);
 -void checkpath(const char *, char resolved_path[]);
 +int checkpath(const char *, char resolved_path[]);
  extern int getmnt_silent;
  void build_iovec(struct iovec **iov, int *iovlen, const char *name, void 
*val, size_t len);
  void build_iovec_argf(struct iovec **iov, int *iovlen, const char *name, 
const char *fmt, ...);
 
 Modified: head/sbin/mount/mount.c
 ==
 --- head/sbin/mount/mount.cMon Jan 16 18:19:53 2012(r230225)
 +++ head/sbin/mount/mount.cMon Jan 16 19:34:21 2012(r230226)
 @@ -539,7 +539,10 @@ mountfs(const char *vfstype, const char 
static struct cpa mnt_argv;
  
/* resolve the mountpoint with realpath(3) */
 -  (void)checkpath(name, mntpath);
 +  if (checkpath(name, mntpath) != 0) {
 +  warn("%s", mntpath);
 +  return (1);
 +  }
name = mntpath;
  
if (mntopts == NULL)
 
 Modified: head/sbin/mount/mount_fs.c
 ==
 --- head/sbin/mount/mount_fs.c Mon Jan 16 18:19:53 2012(r230225)
 +++ head/sbin/mount/mount_fs.c Mon Jan 16 19:34:21 2012(r230226)
 @@ -118,7 +118,10 @@ mount_fs(const char *vfstype, int argc, 
dev = argv[0];
dir = argv[1];
  
 -  (void)checkpath(dir, mntpath);
 +  if (checkpath(dir, mntpath) != 0) {
 +  warn("%s", mntpath);
 +  return (1);
 +  }
(void)rmslashes(dev, dev);
  
build_iovec(&iov, &iovlen, "fstype", fstype, (size_t)-1);
 
 Modified: head/sbin/mount_cd9660/mount_cd9660.c
 ==
 --- head/sbin/mount_cd9660/mount_cd9660.c  Mon Jan 16 18:19:53 2012
(r230225)
 +++ head/sbin/mount_cd9660/mount_cd9660.c  Mon Jan 16 19:34:21 2012
(r230226)
 @@ -149,7 +149,8 @@ main(int argc, char **argv)
 * Resolve the mountpoint with realpath(3) and remove unnecessary
 * slashes from the devicename if there are any.
 */
 -  (void)checkpath(dir, mntpath);
 +  if (checkpath(dir, mntpath) != 0)
 +  err(1, "%s", mntpath);
(void)rmslashes(dev, dev);
  
if (ssector == -1) {
 
 Modified: head/sbin/mount_ext2fs/mount_ext2fs.c
 ==
 --- head/sbin/mount_ext2fs/mount_ext2fs.c  Mon Jan

misc/164217: [patch] correct synchronize flag in setfacl(1) manpage

2012-01-16 Thread Garrett Cooper

>Number: 164217
>Category:   misc
>Synopsis:   [patch] correct synchronize flag in setfacl(1) manpage
>Confidential:   no
>Severity:   non-critical
>Priority:   low
>Responsible:freebsd-bugs
>State:  open
>Quarter:
>Keywords:   
>Date-Required:
>Class:  sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 16 20:30:08 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Garrett Cooper
>Release:9.0-STABLE
>Organization:
n/a
>Environment:
FreeBSD streetfighter.ixsystems.com 9.0-STABLE FreeBSD 9.0-STABLE #1 r230088: 
Fri Jan 13 16:34:03 PST 2012 
gcoo...@streetfighter.ixsystems.com:/usr/obj/usr/src/sys/STREETFIGHTER  amd64
>Description:
According to the source code (see post # 1 and # 2 in docs/162380 ), the 'S' 
flag described in setfacl(1) is actually 's'.
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


Re: misc/164130: broken netisr initialization

2012-01-16 Thread Robert N. M. Watson

On 14 Jan 2012, at 22:00, Коньков Евгений wrote:

> also in r49 next things are broken:
> 
> 1. in net.isr.dispatch = deferred
> 
> intr{swiX: netisr X} always have state 'WAIT'

Thanks for your (multiple) e-mails. I will catch up on the remainder of the 
thread tomorrow, having returned from travel today, but wanted to point you at 
"netstat -Q", which will allow you to more directly test what dispatch policy 
is being implemented. It allows you to directly inspect counters for directly 
dispatched vs. deferred packets with each netisr thread. Relying on sampled CPU 
use can be quite misleading, as dispatch policies can have counter-intuitive 
effects on performance and CPU use; directly monitoring the cause, rather than 
the effect, would be more reliable for debugging purposes.

Robert


> 
>  PID USERNAME   PRI NICE   SIZERES STATE   C   TIME   WCPU COMMAND
>   11 root   155 ki31 0K32K RUN 1  25:02 87.16% idle{idle: 
> cpu1}
>   11 root   155 ki31 0K32K CPU00  25:08 86.72% idle{idle: 
> cpu0}
>   11 root   155 ki31 0K32K CPU22  24:23 83.50% idle{idle: 
> cpu2}
>   11 root   155 ki31 0K32K CPU33  24:47 81.93% idle{idle: 
> cpu3}
>   12 root   -92- 0K   248K WAIT3   0:59  6.54% intr{irq266: 
> re0}
> 3375 root400 15468K  6504K select  2   1:03  4.98% snmpd
>   12 root   -72- 0K   248K WAIT3   0:28  3.12% intr{swi1: 
> netisr 1}
>   12 root   -60- 0K   248K WAIT0   0:34  1.71% intr{swi4: 
> clock}
>   12 root   -72- 0K   248K WAIT3   0:27  1.71% intr{swi1: 
> netisr 3}
>   12 root   -72- 0K   248K WAIT1   0:20  1.37% intr{swi1: 
> netisr 0}
>0 root   -920 0K   152K -   2   0:30  0.98% 
> kernel{dummynet}
>   12 root   -72- 0K   248K WAIT3   0:13  0.88% intr{swi1: 
> netisr 2}
>   13 root   -92- 0K32K sleep   1   0:11  0.24% 
> ng_queue{ng_queue3}
>   13 root   -92- 0K32K sleep   1   0:11  0.10% 
> ng_queue{ng_queue0}
>   13 root   -92- 0K32K sleep   1   0:11  0.10% 
> ng_queue{ng_queue1}
> 
> 
> 2. There is no cpu load differences between dispatch methods. I have
> tested two: direct and deferred (see on picture)
> 
> http://piccy.info/view3/2482121/cc6464fbe959fd65ecb5a8b94a23ec38/orig/
> 
> 'deferred' method works same as 'direct' method!
> 
> 

___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


misc/164232: CORE BATTLE

2012-01-16 Thread Jose Vasquez

>Number: 164232
>Category:   misc
>Synopsis:   CORE BATTLE
>Confidential:   no
>Severity:   serious
>Priority:   medium
>Responsible:freebsd-bugs
>State:  open
>Quarter:
>Keywords:   
>Date-Required:
>Class:  sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 17 04:40:05 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Jose Vasquez
>Release:FreeBSD 2.2.6
>Organization:
>Environment:
>Description:
Who is the toughest in CORE?

suggestion: CORE battle, boxing match between robert and brooks

To occur on stage at next BSD conference or potentially outside venue

Rules for fight:
ABSOLUTELY no beard pulling
Swinging brooks around by his pony tail permitted
NO glasses roundhousing

Winner becomes head of core
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


Re: junk/164232: CORE BATTLE

2012-01-16 Thread linimon
Synopsis: CORE BATTLE

State-Changed-From-To: open->closed
State-Changed-By: linimon
State-Changed-When: Tue Jan 17 04:54:48 UTC 2012
State-Changed-Why: 
yet someone else wasting my time.


Responsible-Changed-From-To: freebsd-bugs->gnats-admin
Responsible-Changed-By: linimon
Responsible-Changed-When: Tue Jan 17 04:54:48 UTC 2012
Responsible-Changed-Why: 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164232
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


Re: docs/164217: [patch] correct synchronize flag in setfacl(1) manpage

2012-01-16 Thread linimon
Synopsis: [patch] correct synchronize flag in setfacl(1) manpage

Responsible-Changed-From-To: freebsd-bugs->freebsd-doc
Responsible-Changed-By: linimon
Responsible-Changed-When: Tue Jan 17 04:58:33 UTC 2012
Responsible-Changed-Why: 
reassign.

http://www.freebsd.org/cgi/query-pr.cgi?pr=164217
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


Re: misc/163525: 8.2-STABLE buildworld broken due to non-existing MK_INET_SUPPORT

2012-01-16 Thread linimon
Synopsis: 8.2-STABLE buildworld broken due to non-existing MK_INET_SUPPORT

State-Changed-From-To: feedback->closed
State-Changed-By: linimon
State-Changed-When: Tue Jan 17 05:13:26 UTC 2012
State-Changed-Why: 
problem has been resolved.

http://www.freebsd.org/cgi/query-pr.cgi?pr=163525
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"