Re: kern/163493: FreeBSD 9x amd64 unstable while work with RAM
The following reply was made to PR kern/163493; it has been noted by GNATS. From: Oleg Ginzburg To: bug-follo...@freebsd.org, olev...@olevole.ru Cc: Subject: Re: kern/163493: FreeBSD 9x amd64 unstable while work with RAM Date: Thu, 22 Dec 2011 11:37:07 +0400 Update: The described case for the physical machine is ZFS-related. It is reproduced at ZFS Volume-based swap: (for example - da0 is empty disk): kldload zfs echo 'zfs_load="YES"' >> /etc/rc.conf zpool create swp /dev/da0 zfs create -V 4G swp/swap zfs set org.freebsd:swap=on zwp/swap zfs set checksum=off swp/swap service zfs restart service zvol restart then repeat actions from How-to-repeat For VirtualBox a case - problems arise without ZFS. It seems, it is related with inheritance kmem\* or other parameters from the master host ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/163525: 8.2-STABLE buildworld broken due to non-existing MK_INET_SUPPORT
>Number: 163525
>Category: misc
>Synopsis: 8.2-STABLE buildworld broken due to non-existing
>MK_INET_SUPPORT
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Dec 22 09:50:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Eugene Grosbein
>Release:FreeBSD 8.2-STABLE i386
>Organization:
RDTC JSC
>Environment:
System: FreeBSD eg.sd.rdtc.ru 8.2-STABLE FreeBSD 8.2-STABLE #35: Thu Sep 29
14:35:55 NOVT 2011 r...@eg.sd.rdtc.ru:/usr/local/obj/usr/local/src/sys/EG i386
>Description:
For 8.2-STABLE, "make MODULES_WITH_WORLD=yes buildworld" fails:
===> sys/modules/netgraph/ipfw (cleandir)
"/usr/local/src/sys/modules/netgraph/ipfw/Makefile", line 10: Malformed
conditional (${MK_INET_SUPPORT} ! = "no")
"/usr/local/src/sys/modules/netgraph/ipfw/Makefile", line 18: if-less endif
make: fatal errors encountered -- cannot continue
This is because MK_INET_SUPPORT was not MFC'd to RELENG_8.
>How-To-Repeat:
See above.
>Fix:
Either perform MFC for MK_INET_SUPPORT to RELENG_8
or fix sys/modules/netgraph/ipfw/Makefile to not use it.
Eugene Grosbein
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/163536: 'ps axl > somefile'. Output is restricted by terminal width
>Number: 163536 >Category: misc >Synopsis: 'ps axl > somefile'. Output is restricted by terminal width >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Dec 22 14:20:11 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Eugen Konkov >Release:9.0-PRERELEASE >Organization: ISP FreeLine >Environment: FreeBSD meta-up 9.0-PRERELEASE FreeBSD 9.0-PRERELEASE #3: Wed Dec 21 14:29:05 EET 2011 @:/usr/obj/usr/src/sys/KES_KERN_v10 i386 >Description: when doing pa axl > 123 I want to look at full command parameters, but instead I get truncated output. that output in file is terminal screen width instead of full output information of process >How-To-Repeat: #ps axl > 123 >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
kern/163540: SCHED_4BSD seems unstable on RELENG_9
>Number: 163540 >Category: kern >Synopsis: SCHED_4BSD seems unstable on RELENG_9 >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Dec 22 15:30:11 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Volodymyr Kostyrko >Release:RELENG_9 >Organization: >Environment: FreeBSD green.tandem.local 9.0-PRERELEASE FreeBSD 9.0-PRERELEASE #0: Thu Dec 22 15:46:04 EET 2011 arcade@green.tandem.local:/usr/obj/usr/src/sys/MINIMAL_4BSD amd64 >Description: Recently tried to switch to SCHED_4BSD for testing purposes. After that system starts to dump core from time to time. >How-To-Repeat: Compile a kernel with SCHED_4BSD, then sysctl -a for me throws: Fatal trap 12: page fault while in kernel mode cpuid = 1; apic id = 01 fault virtual address = 0xf fault code = supervisor read data, page not present instruction pointer = 0x20:0x8038cd3f stack pointer = 0x28:0xff80d7e48700 frame pointer = 0x28:0xff80d7e48770 code segment= base 0x0, limit 0xf, type 0x1b = DPL 0, pres 1, long 1, def32 0, gran 1 processor eflags= interrupt enabled, resume, IOPL = 0 current process = 2030 (sysctl) trap number = 12 panic: page fault cpuid = 1 KDB: stack backtrace: #0 0x803b2198 at kdb_backtrace+0x58 #1 0x80381f40 at panic+0x190 #2 0x8058ee55 at trap_fatal+0x395 #3 0x8058f029 at trap_pfault+0x1c9 #4 0x8058e876 at trap+0x3a6 #5 0x80579943 at calltrap+0x8 #6 0x8038cd11 at sysctl_sysctl_next_ls+0x71 #7 0x8038cd11 at sysctl_sysctl_next_ls+0x71 #8 0x8038cd11 at sysctl_sysctl_next_ls+0x71 #9 0x8038cc43 at sysctl_sysctl_next+0x83 #10 0x8038bf41 at sysctl_root+0x211 #11 0x8038c508 at userland_sysctl+0x1d8 #12 0x8038c2f4 at sys___sysctl+0x74 #13 0x8058f505 at amd64_syscall+0x2a5 #14 0x80579c2b at Xfast_syscall+0xfb (kgdb) bt #0 sched_switch (td=Variable "td" is not available. ) at /usr/src/sys/kern/sched_4bsd.c:1021 #1 0x80389c94 in mi_switch (flags=dwarf2_read_address: Corrupted DWARF expression. ) at /usr/src/sys/kern/kern_synch.c:448 #2 0x803bc8ca in sleepq_timedwait (wchan=dwarf2_read_address: Corrupted DWARF expression. ) at /usr/src/sys/kern/subr_sleepqueue.c:652 #3 0x80389846 in _sleep (ident=Variable "ident" is not available. ) at /usr/src/sys/kern/kern_synch.c:230 #4 0x8055ed29 in scheduler (dummy=dwarf2_read_address: Corrupted DWARF expression. ) at /usr/src/sys/vm/vm_glue.c:793 #5 0x803394c3 in mi_startup () at /usr/src/sys/kern/init_main.c:258 #6 0x8025c93c in btext () #7 0x808e0aa0 in sleepq_chains () #8 0xfe0006b14440 in ?? () #9 0x in ?? () #10 0x in ?? () #11 0x81ef0bb0 in ?? () #12 0x81ef0b68 in ?? () #13 0x80929890 in bootverbose () #14 0x803a5345 in sched_switch (td=Variable "td" is not available. ) at /usr/src/sys/kern/sched_4bsd.c:1001 Current language: auto; currently minimal >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/163536: 'ps axl > somefile'. Output is restricted by terminal width
Synopsis: 'ps axl > somefile'. Output is restricted by terminal width State-Changed-From-To: open->closed State-Changed-By: jh State-Changed-When: Thu Dec 22 18:06:40 UTC 2011 State-Changed-Why: Please use "ps -axlww > 123" instead. http://www.freebsd.org/cgi/query-pr.cgi?pr=163536 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
kern/163545: Return of uninitialized value in Chelsio T3 driver
>Number: 163545
>Category: kern
>Synopsis: Return of uninitialized value in Chelsio T3 driver
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Dec 22 20:00:26 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Dan McGregor
>Release:9.0-PRERELEASE
>Organization:
>Environment:
FreeBSD shadrach.dyndns.org 9.0-PRERELEASE FreeBSD 9.0-PRERELEASE #8 r228275:
Mon Dec 5 14:05:35 CST 2011
d...@shadrach.dyndns.org:/usr/obj/usr/src9/sys/SHADRACH amd64
>Description:
In the Chelsio T3 driver there is an uninitialized value returned by
aq100x_power_down in sys/dev/cxgb/common/cxgb_aq100x.c. It appears that the
intended return value is err, not v.
>How-To-Repeat:
I don't know of any problems that develop because of this problem, though it
seems that it's possible for it to fail.
>Fix:
It looks like the value that should be returned is err, not (v).
Index: sys/dev/cxgb/common/cxgb_aq100x.c
===
--- sys/dev/cxgb/common/cxgb_aq100x.c (révision 228798)
+++ sys/dev/cxgb/common/cxgb_aq100x.c (copie de travail)
@@ -232,7 +232,7 @@
err = t3_mdio_change_bits(phy, MDIO_DEV_PMA_PMD, MII_BMCR, BMCR_PDOWN,
off ? BMCR_PDOWN : 0);
if (err || off)
- return (v);
+ return (err);
msleep(300);
do {
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: conf/160960: [patch] /etc/rc.d/named
The following reply was made to PR conf/160960; it has been noted by GNATS.
From: "Dmitry N Fomin"
To: freebsd-gnats-sub...@freebsd.org, freebsd-bugs@freebsd.org
Cc:
Subject: Re: conf/160960: [patch] /etc/rc.d/named
Date: Fri, 23 Dec 2011 00:13:21 +0300
Somebody can confirm this problem and try patch?
Thanks.
--- /usr/src/etc/rc.d/named2010-12-21 17:09:25.0 +
+++ /usr/src/etc/rc.d/named2011-09-24 08:55:27.0 +
@@ -100,9 +100,22 @@
make_symlinks
if checkyesno named_wait; then
- until ${command%/sbin/named}/bin/host $named_wait_host
>/dev/null 2>&1; do
- echo " Waiting for nameserver to resolve
$named_wait_host"
+ if [ -z "${named_wait_timeout}" ]; then
+ named_wait_timeout="10"
+ fi
+ local timeout="${named_wait_timeout}"
+ until ${command%/sbin/named}/bin/host -W 1 $named_wait_host
>/dev/null 2>&1; do
+ if [ $timeout -eq $named_wait_timeout ]; then
+ echo " Waiting for nameserver to resolve
$named_wait_host"
+ echo ""
+ fi
sleep 1
+ timeout=$(($timeout - 1))
+ echo -e "\033[A Remains to wait time - ${timeout} sec."
+ if [ $timeout -le 0 ]; then
+ echo " Wait time (${named_wait_timeout} sec.)
has effused."
+ break
+ fi
done
fi
}
--- /usr/src/etc/defaults/rc.conf 2010-12-21 17:09:25.0 +
+++ /usr/src/etc/defaults/rc.conf 2011-09-23 18:43:44.0 +
@@ -279,6 +279,7 @@
named_symlink_enable="YES"# Symlink the chrooted pid file
named_wait="NO" # Wait for working name service before exiting
named_wait_host="localhost" # Hostname to check if named_wait is enabled
+named_wait_timeout="10" # Timeout in seconds if named_wait is
enabled
named_auto_forward="NO" # Set up forwarders from /etc/resolv.conf
named_auto_forward_only="NO" # Do "forward only" instead of "forward first"
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: conf/160960: [patch] /etc/rc.d/named
Somebody can confirm this problem and try patch?
Thanks.
--- /usr/src/etc/rc.d/named 2010-12-21 17:09:25.0 +
+++ /usr/src/etc/rc.d/named 2011-09-24 08:55:27.0 +
@@ -100,9 +100,22 @@
make_symlinks
if checkyesno named_wait; then
- until ${command%/sbin/named}/bin/host $named_wait_host
>/dev/null 2>&1; do
- echo " Waiting for nameserver to resolve
$named_wait_host"
+ if [ -z "${named_wait_timeout}" ]; then
+ named_wait_timeout="10"
+ fi
+ local timeout="${named_wait_timeout}"
+ until ${command%/sbin/named}/bin/host -W 1 $named_wait_host
>/dev/null 2>&1; do
+ if [ $timeout -eq $named_wait_timeout ]; then
+ echo " Waiting for nameserver to resolve
$named_wait_host"
+ echo ""
+ fi
sleep 1
+ timeout=$(($timeout - 1))
+ echo -e "\033[A Remains to wait time - ${timeout} sec."
+ if [ $timeout -le 0 ]; then
+ echo " Wait time (${named_wait_timeout} sec.)
has effused."
+ break
+ fi
done
fi
}
--- /usr/src/etc/defaults/rc.conf 2010-12-21 17:09:25.0 +
+++ /usr/src/etc/defaults/rc.conf 2011-09-23 18:43:44.0 +
@@ -279,6 +279,7 @@
named_symlink_enable="YES" # Symlink the chrooted pid file
named_wait="NO"# Wait for working name service before exiting
named_wait_host="localhost"# Hostname to check if named_wait is enabled
+named_wait_timeout="10"# Timeout in seconds if named_wait is
enabled
named_auto_forward="NO"# Set up forwarders from /etc/resolv.conf
named_auto_forward_only="NO" # Do "forward only" instead of "forward first"
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: conf/160960: [patch] /etc/rc.d/named
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
On 12/22/11 13:13, Dmitry N Fomin wrote:
> Somebody can confirm this problem and try patch? Thanks.
I'm not quite satisfied with this version of patch -- host command
have its own timeout rules and it's less than optimal when a computer
stays stall for a few minutes while it says only 9 seconds.
By the way this loses one functionality -- the admin wants the system
to boot until a name service query is available, what shall he/she do?
My suggestion would be consider a negative number as "wait forever" here.
> --- /usr/src/etc/rc.d/named 2010-12-21 17:09:25.0 + +++
> /usr/src/etc/rc.d/named 2011-09-24 08:55:27.0 + @@
> -100,9 +100,22 @@ make_symlinks
>
> if checkyesno named_wait; then - until
> ${command%/sbin/named}/bin/host $named_wait_host >/dev/null 2>&1;
> do - echo " Waiting for nameserver to resolve
> $named_wait_host" +
> if [ -z "${named_wait_timeout}" ]; then +
> named_wait_timeout="10" + fi +local
> timeout="${named_wait_timeout}" + until
> ${command%/sbin/named}/bin/host -W 1 $named_wait_host >/dev/null
> 2>&1; do +if [ $timeout -eq $named_wait_timeout ]; then +
> echo "Waiting for nameserver to resolve $named_wait_host" +
> echo "" + fi sleep 1 +
> timeout=$(($timeout - 1)) + echo -e
> "\033[A Remains to wait time - ${timeout} sec." +
> if [ $timeout
> -le 0 ]; then + echo " Wait time
> (${named_wait_timeout} sec.)
> has effused." + break + fi done
> fi }
>
> --- /usr/src/etc/defaults/rc.conf 2010-12-21 17:09:25.0
> + +++ /usr/src/etc/defaults/rc.conf 2011-09-23
> 18:43:44.0 + @@ -279,6 +279,7 @@
> named_symlink_enable="YES"# Symlink the chrooted pid file
> named_wait="NO" # Wait for working name service before exiting
> named_wait_host="localhost" # Hostname to check if named_wait is
> enabled +named_wait_timeout="10" # Timeout in seconds if
> named_wait is enabled named_auto_forward="NO" # Set up forwarders
> from /etc/resolv.conf named_auto_forward_only="NO"# Do "forward
> only" instead of "forward first"
>
>
>
> ___
> freebsd-bugs@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To
> unsubscribe, send any mail to
> "freebsd-bugs-unsubscr...@freebsd.org"
- --
Xin LI https://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.18 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk7zodkACgkQOfuToMruuMBoLACfdWlpIvkFhmfjHbBlOSbMg3Sv
R/wAnispG8cqieBl842CK2kyvsbxfUXN
=7PnV
-END PGP SIGNATURE-
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: conf/160960: [patch] /etc/rc.d/named
The following reply was made to PR conf/160960; it has been noted by GNATS.
From: Xin Li
To: f...@okbire.ru
Cc: freebsd-gnats-sub...@freebsd.org, freebsd-bugs@freebsd.org,
d...@delphij.net
Subject: Re: conf/160960: [patch] /etc/rc.d/named
Date: Thu, 22 Dec 2011 13:32:10 -0800
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
On 12/22/11 13:13, Dmitry N Fomin wrote:
> Somebody can confirm this problem and try patch? Thanks.
I'm not quite satisfied with this version of patch -- host command
have its own timeout rules and it's less than optimal when a computer
stays stall for a few minutes while it says only 9 seconds.
By the way this loses one functionality -- the admin wants the system
to boot until a name service query is available, what shall he/she do?
My suggestion would be consider a negative number as "wait forever" here.
> --- /usr/src/etc/rc.d/named 2010-12-21 17:09:25.0 + +++
> /usr/src/etc/rc.d/named 2011-09-24 08:55:27.0 + @@
> -100,9 +100,22 @@ make_symlinks
>
> if checkyesno named_wait; then - until
> ${command%/sbin/named}/bin/host $named_wait_host >/dev/null 2>&1;
> do - echo " Waiting for nameserver to resolve
> $named_wait_host" +
> if [ -z "${named_wait_timeout}" ]; then +
> named_wait_timeout="10" +fi +local
> timeout="${named_wait_timeout}" +until
> ${command%/sbin/named}/bin/host -W 1 $named_wait_host >/dev/null
> 2>&1; do + if [ $timeout -eq $named_wait_timeout ]; then +
> echo " Waiting for nameserver to resolve $named_wait_host" +
> echo "" +fi sleep 1 +
> timeout=$(($timeout - 1)) + echo -e
> "\033[A Remains to wait time - ${timeout} sec." +
> if [ $timeout
> -le 0 ]; then + echo " Wait time
> (${named_wait_timeout} sec.)
> has effused." + break + fi done
> fi }
>
> --- /usr/src/etc/defaults/rc.conf2010-12-21 17:09:25.0
> + +++ /usr/src/etc/defaults/rc.conf 2011-09-23
> 18:43:44.0 + @@ -279,6 +279,7 @@
> named_symlink_enable="YES" # Symlink the chrooted pid file
> named_wait="NO" # Wait for working name service before exiting
> named_wait_host="localhost" # Hostname to check if named_wait is
> enabled +named_wait_timeout="10" # Timeout in seconds if
> named_wait is enabled named_auto_forward="NO"# Set up forwarders
> from /etc/resolv.conf named_auto_forward_only="NO" # Do "forward
> only" instead of "forward first"
>
>
>
> ___
> freebsd-bugs@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To
> unsubscribe, send any mail to
> "freebsd-bugs-unsubscr...@freebsd.org"
- --
Xin LIhttps://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.18 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk7zodkACgkQOfuToMruuMBoLACfdWlpIvkFhmfjHbBlOSbMg3Sv
R/wAnispG8cqieBl842CK2kyvsbxfUXN
=7PnV
-END PGP SIGNATURE-
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/163547: vmstat -i show AVG rate instead of rate
>Number: 163547 >Category: misc >Synopsis: vmstat -i show AVG rate instead of rate >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Dec 22 22:20:08 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Eugen Konkov >Release:9.0-PRERELEASE >Organization: ISP FreeLine >Environment: FreeBSD meta-up 9.0-PRERELEASE FreeBSD 9.0-PRERELEASE #3: Wed Dec 21 14:29:05 EET 2011 @:/usr/obj/usr/src/sys/KES_KERN_v10 i386 >Description: # vmstat -i interrupt total rate in column name there are noted that that is 'rate' but actually that column show average rate. Will be use full if you additionally display 'current rate' as TOP shows current CPU idle, for example. or, at lease, fix colum name from 'rate' to 'avg rate' >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/163545: [cxgb] [patch] Return of uninitialized value in Chelsio T3 driver
Old Synopsis: Return of uninitialized value in Chelsio T3 driver New Synopsis: [cxgb] [patch] Return of uninitialized value in Chelsio T3 driver Responsible-Changed-From-To: freebsd-bugs->freebsd-net Responsible-Changed-By: linimon Responsible-Changed-When: Thu Dec 22 23:55:33 UTC 2011 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=163545 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/83348: [patch] Improper handling of malloc failures within libc's yp/xdryp.c
Synopsis: [patch] Improper handling of malloc failures within libc's yp/xdryp.c State-Changed-From-To: open->closed State-Changed-By: ghelmer State-Changed-When: Thu Dec 22 19:57:03 CST 2011 State-Changed-Why: Applied, thanks. http://www.freebsd.org/cgi/query-pr.cgi?pr=83348 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/83348: commit references a PR
The following reply was made to PR bin/83348; it has been noted by GNATS.
From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:
Subject: Re: bin/83348: commit references a PR
Date: Fri, 23 Dec 2011 01:56:39 + (UTC)
Author: ghelmer
Date: Fri Dec 23 01:56:25 2011
New Revision: 228826
URL: http://svn.freebsd.org/changeset/base/228826
Log:
Handle failures to malloc memory to hold key or val copies.
PR: bin/83348
Modified:
head/lib/libc/yp/xdryp.c
Modified: head/lib/libc/yp/xdryp.c
==
--- head/lib/libc/yp/xdryp.c Fri Dec 23 01:39:10 2011(r228825)
+++ head/lib/libc/yp/xdryp.c Fri Dec 23 01:56:25 2011(r228826)
@@ -82,10 +82,21 @@ xdr_ypresp_all_seq(XDR *xdrs, u_long *ob
switch (status) {
case YP_TRUE:
key = (char
*)malloc(out.ypresp_all_u.val.key.keydat_len + 1);
+ if (key == NULL) {
+ xdr_free((xdrproc_t)xdr_ypresp_all, &out);
+ *objp = YP_YPERR;
+ return (FALSE);
+ }
bcopy(out.ypresp_all_u.val.key.keydat_val, key,
out.ypresp_all_u.val.key.keydat_len);
key[out.ypresp_all_u.val.key.keydat_len] = '\0';
val = (char
*)malloc(out.ypresp_all_u.val.val.valdat_len + 1);
+ if (val == NULL) {
+ free(key);
+ xdr_free((xdrproc_t)xdr_ypresp_all, &out);
+ *objp = YP_YPERR;
+ return (FALSE);
+ }
bcopy(out.ypresp_all_u.val.val.valdat_val, val,
out.ypresp_all_u.val.val.valdat_len);
val[out.ypresp_all_u.val.val.valdat_len] = '\0';
___
svn-src-...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/83349: [patch] improper handling o malloc's failures within libc/yp/yplib.c routines
Synopsis: [patch] improper handling o malloc's failures within libc/yp/yplib.c routines State-Changed-From-To: open->closed State-Changed-By: ghelmer State-Changed-When: Thu Dec 22 20:14:01 CST 2011 State-Changed-Why: Patch applied, thanks. http://www.freebsd.org/cgi/query-pr.cgi?pr=83349 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/83349: commit references a PR
The following reply was made to PR bin/83349; it has been noted by GNATS.
From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:
Subject: Re: bin/83349: commit references a PR
Date: Fri, 23 Dec 2011 02:13:54 + (UTC)
Author: ghelmer
Date: Fri Dec 23 02:13:42 2011
New Revision: 228828
URL: http://svn.freebsd.org/changeset/base/228828
Log:
Handle malloc failures in yplib.c.
PR: bin/83349
Modified:
head/lib/libc/yp/yplib.c
Modified: head/lib/libc/yp/yplib.c
==
--- head/lib/libc/yp/yplib.c Fri Dec 23 02:04:35 2011(r228827)
+++ head/lib/libc/yp/yplib.c Fri Dec 23 02:13:42 2011(r228828)
@@ -331,6 +331,8 @@ _yp_dobind(char *dom, struct dom_binding
if (ysd == NULL) {
ysd = (struct dom_binding *)malloc(sizeof *ysd);
+ if (ysd == NULL)
+ return (YPERR_RESRC);
bzero((char *)ysd, sizeof *ysd);
ysd->dom_socket = -1;
ysd->dom_vers = 0;
@@ -683,11 +685,18 @@ yp_match(char *indomain, char *inmap, co
*/
*outvallen = yprv.val.valdat_len;
*outval = (char *)malloc(*outvallen+1);
+ if (*outval == NULL) {
+ _yp_unbind(ysd);
+ *outvallen = 0;
+ YPUNLOCK();
+ return (YPERR_RESRC);
+ }
bcopy(yprv.val.valdat_val, *outval, *outvallen);
(*outval)[*outvallen] = '\0';
YPUNLOCK();
return (0);
}
+ _yp_unbind(ysd);
#endif
again:
@@ -713,6 +722,13 @@ again:
if (!(r = ypprot_err(yprv.stat))) {
*outvallen = yprv.val.valdat_len;
*outval = (char *)malloc(*outvallen+1);
+ if (*outval == NULL) {
+ _yp_unbind(ysd);
+ *outvallen = 0;
+ xdr_free((xdrproc_t)xdr_ypresp_val, &yprv);
+ YPUNLOCK();
+ return (YPERR_RESRC);
+ }
bcopy(yprv.val.valdat_val, *outval, *outvallen);
(*outval)[*outvallen] = '\0';
#ifdef YPMATCHCACHE
@@ -791,10 +807,25 @@ again:
if (!(r = ypprot_err(yprkv.stat))) {
*outkeylen = yprkv.key.keydat_len;
*outkey = (char *)malloc(*outkeylen+1);
+ if (*outkey == NULL) {
+ _yp_unbind(ysd);
+ *outkeylen = 0;
+ xdr_free((xdrproc_t)xdr_ypresp_key_val, &yprkv);
+ YPUNLOCK();
+ return (YPERR_RESRC);
+ }
bcopy(yprkv.key.keydat_val, *outkey, *outkeylen);
(*outkey)[*outkeylen] = '\0';
*outvallen = yprkv.val.valdat_len;
*outval = (char *)malloc(*outvallen+1);
+ if (*outval == NULL) {
+ free(*outkey);
+ _yp_unbind(ysd);
+ *outkeylen = *outvallen = 0;
+ xdr_free((xdrproc_t)xdr_ypresp_key_val, &yprkv);
+ YPUNLOCK();
+ return (YPERR_RESRC);
+ }
bcopy(yprkv.val.valdat_val, *outval, *outvallen);
(*outval)[*outvallen] = '\0';
}
@@ -851,10 +882,25 @@ again:
if (!(r = ypprot_err(yprkv.stat))) {
*outkeylen = yprkv.key.keydat_len;
*outkey = (char *)malloc(*outkeylen+1);
+ if (*outkey == NULL) {
+ _yp_unbind(ysd);
+ *outkeylen = 0;
+ xdr_free((xdrproc_t)xdr_ypresp_key_val, &yprkv);
+ YPUNLOCK();
+ return (YPERR_RESRC);
+ }
bcopy(yprkv.key.keydat_val, *outkey, *outkeylen);
(*outkey)[*outkeylen] = '\0';
*outvallen = yprkv.val.valdat_len;
*outval = (char *)malloc(*outvallen+1);
+ if (*outval == NULL) {
+ free(*outkey);
+ _yp_unbind(ysd);
+ *outkeylen = *outvallen = 0;
+ xdr_free((xdrproc_t)xdr_ypresp_key_val, &yprkv);
+ YPUNLOCK();
+ return (YPERR_RESRC);
+ }
bcopy(yprkv.val.valdat_val, *outval, *outvallen);
(*outval)[*outvallen] = '\0';
}
___
svn-src-...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebs
misc/163555: [PATCH] bitchx port is out of date and BitchX 1.2 does not compile (fix included)
>Number: 163555
>Category: misc
>Synopsis: [PATCH] bitchx port is out of date and BitchX 1.2 does not
>compile (fix included)
>Confidential: no
>Severity: critical
>Priority: high
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Fri Dec 23 04:00:20 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Dan Mashal
>Release:FreeBSD 9.0-RC3
>Organization:
net
>Environment:
FreeBSD w00p 9.0-RC3 FreeBSD 9.0-RC3 #0: Sun Dec 4 08:56:36 UTC 2011
r...@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
Old obsolete, insecure version.
The current version of BitchX, released in 2004, have security problems
allowing remote IRC servers to execute arbitrary code on the client's machine
(CVE-2007-3360, CVE-2007-4584).
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2007-3360
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2007-4584
BitchX 1.2 is release ready per developers (caf) and should be added to the
ports tree. It is stable. However, in order for it to compile on BitchX 9 the
configure file must be patched.
I would also like to become the maintainer of the BitchX port.
>How-To-Repeat:
run the following commands:
0) Be running FreeBSD9.0-RC3 system.
1) svn co https://bitchx.svn.sourceforge.net/svnroot/bitchx/trunk bitchx-trunk
2) cd bitchx-trunk
3) ./configure
Receive error about unterminated quoted strings.
>Fix:
Change the configure file in the BitchX1.2 source.
lines changed in configure file: 12668 and 13936
diff:
# diff configure.old configure.new
12668c12668
< system="MP-RAS-`$AWK '{print $3}' /etc/.relid'`"
---
> system="MP-RAS-$AWK {print $3} /etc/.relid"
13936c13936
< system="MP-RAS-`$AWK '{print $3}' /etc/.relid'`"
---
> system="MP-RAS-$AWK {print $3} /etc/.relid"
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: ports/163555: [PATCH] irc/bitchx is out of date and BitchX 1.2 does not compile (fix included)
Old Synopsis: [PATCH] bitchx port is out of date and BitchX 1.2 does not compile (fix included) New Synopsis: [PATCH] irc/bitchx is out of date and BitchX 1.2 does not compile (fix included) Responsible-Changed-From-To: freebsd-bugs->danfe Responsible-Changed-By: linimon Responsible-Changed-When: Fri Dec 23 07:03:11 UTC 2011 Responsible-Changed-Why: make this a ports PR, fix Synopsis, and assign. http://www.freebsd.org/cgi/query-pr.cgi?pr=163555 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
