kern/160562: [geom][patch] Allow to insert new component to geom_raid3 without specifying number.
>Number: 160562
>Category: kern
>Synopsis: [geom][patch] Allow to insert new component to geom_raid3
>without specifying number.
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Sep 08 15:10:07 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Lev Serebryakov
>Release:FreeBSD 9.0-BETA2 i386
>Organization:
>Environment:
System: FreeBSD vmware-9-32.home.serebryakov.spb.ru 9.0-BETA2 FreeBSD 9.0-BETA2
#1: Wed Sep 7 22:08:28 MSK 2011
l...@vmware-9-32.home.serebryakov.spb.ru:/usr/obj/usr/src/sys/VMWARE i386
>Description:
Now "geom_raid3" requires "-n " argument for "insert" command, which
insert new component instead of removed (or failed) one.
It is not convient in most cases (one lost component).
This patch allows not to specify component number. In such case new component
is added instead of first missed component.
>How-To-Repeat:
Try to add new component to geom_raid3 without "-n" argument.
>Fix:
Index: sbin/geom/class/raid3/graid3.8
===
--- sbin/geom/class/raid3/graid3.8 (revision 225448)
+++ sbin/geom/class/raid3/graid3.8 (working copy)
@@ -53,7 +53,7 @@
.Nm
.Cm insert
.Op Fl hv
-.Fl n Ar number
+.Op Fl n Ar number
.Ar name
.Ar prov
.Nm
@@ -171,6 +171,8 @@
removed previously with the
.Cm remove
command or if one component is missing and will not be connected again.
+If no number is given, new component will beaaded instead of first missed
+component.
.Pp
Additional options include:
.Bl -tag -width ".Fl h"
Index: sbin/geom/class/raid3/geom_raid3.c
===
--- sbin/geom/class/raid3/geom_raid3.c (revision 225448)
+++ sbin/geom/class/raid3/geom_raid3.c (working copy)
@@ -76,7 +76,7 @@
{ "insert", G_FLAG_VERBOSE, NULL,
{
{ 'h', "hardcode", NULL, G_TYPE_BOOL },
- { 'n', "number", NULL, G_TYPE_NUMBER },
+ { 'n', "number", G_VAL_OPTIONAL, G_TYPE_NUMBER },
G_OPT_SENTINEL
},
"[-hv] <-n number> name prov"
Index: sys/geom/raid3/g_raid3_ctl.c
===
--- sys/geom/raid3/g_raid3_ctl.c(revision 225448)
+++ sys/geom/raid3/g_raid3_ctl.c(working copy)
@@ -404,7 +404,7 @@
u_char *sector;
off_t compsize;
intmax_t *no;
- int *hardcode, *nargs, error;
+ int *hardcode, *nargs, error, autono;
nargs = gctl_get_paraml(req, "nargs", sizeof(*nargs));
if (nargs == NULL) {
@@ -425,11 +425,10 @@
gctl_error(req, "No 'arg%u' argument.", 1);
return;
}
- no = gctl_get_paraml(req, "number", sizeof(*no));
- if (no == NULL) {
- gctl_error(req, "No '%s' argument.", "no");
- return;
- }
+ if (gctl_get_param(req, "number", NULL) != NULL)
+ no = gctl_get_paraml(req, "number", sizeof(*no));
+ else
+ no = NULL;
if (strncmp(name, "/dev/", 5) == 0)
name += 5;
g_topology_lock();
@@ -465,17 +464,30 @@
gctl_error(req, "No such device: %s.", name);
goto end;
}
- if (*no >= sc->sc_ndisks) {
- sx_xunlock(&sc->sc_lock);
- gctl_error(req, "Invalid component number.");
- goto end;
+ if (no != NULL) {
+ if (*no >= sc->sc_ndisks) {
+ sx_xunlock(&sc->sc_lock);
+ gctl_error(req, "Invalid component number.");
+ goto end;
+ }
+ disk = &sc->sc_disks[*no];
+ if (disk->d_state != G_RAID3_DISK_STATE_NODISK) {
+ sx_xunlock(&sc->sc_lock);
+ gctl_error(req, "Component %jd is already connected.",
*no);
+ goto end;
+ }
+ } else {
+ disk = NULL;
+ for (autono = 0; autono < sc->sc_ndisks && disk == NULL;
autono++)
+ if (sc->sc_disks[autono].d_state ==
G_RAID3_DISK_STATE_NODISK)
+ disk = &sc->sc_disks[autono];
+ if (disk == NULL) {
+ sx_xunlock(&sc->sc_lock);
+ gctl_error(req, "No unconnected components.");
+ goto end;
+ }
+
}
- disk = &sc->sc_disks[*no];
- if (disk->d_state != G_RAID3_DISK_STATE_NODISK) {
- sx_xunlock(&sc->sc_lock);
- gctl_error(req, "Component %jd is already connected.", *no);
- goto end;
- }
if (
Re: kern/109968: [boot] [panic] Panic while booting with PCscsi II AM53C974AKC SCSI card by 6.1RC or 6.2 iso CD [regression]
Synopsis: [boot] [panic] Panic while booting with PCscsi II AM53C974AKC SCSI card by 6.1RC or 6.2 iso CD [regression] State-Changed-From-To: open->feedback State-Changed-By: jh State-Changed-When: Thu Sep 8 15:46:56 UTC 2011 State-Changed-Why: Is this still a problem for you? http://www.freebsd.org/cgi/query-pr.cgi?pr=109968 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/118459: [hang] Freeze under high-load with SMP until keypressed
Synopsis: [hang] Freeze under high-load with SMP until keypressed State-Changed-From-To: open->feedback State-Changed-By: jh State-Changed-When: Thu Sep 8 15:48:44 UTC 2011 State-Changed-Why: Is this still a problem for you? http://www.freebsd.org/cgi/query-pr.cgi?pr=118459 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/121770: [panic] ZFS on i386, large file or heavy I/O leads to kernel panic or reboot
Synopsis: [panic] ZFS on i386, large file or heavy I/O leads to kernel panic or reboot State-Changed-From-To: open->closed State-Changed-By: jh State-Changed-When: Thu Sep 8 15:51:00 UTC 2011 State-Changed-Why: Probably a hardware problem. http://www.freebsd.org/cgi/query-pr.cgi?pr=121770 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
kern/160572: freebsd-update
>Number: 160572 >Category: kern >Synopsis: freebsd-update >Confidential: no >Severity: serious >Priority: high >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Thu Sep 08 23:00:16 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Sergey >Release:7.0 >Organization: Milkiland >Environment: FreeBSD 7.0-RELEASE FreeBSD 7.0-RELEASE #3: Fri Jun 20 17:50:28 EEST 2008 >Description: # /usr/sbin/freebsd-update install id: not found [: !=: unexpected operator sha256: not found No updates are available to install. Run '/usr/sbin/freebsd-update fetch' first. #/usr/sbin/freebsd-update fetch grep: not found freebsd-update: Invalid key fingerprint: 800651ef4b4c71c27e60786d7b487188970f4b4169cc055784e21eb71d410cc5 >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/109968: [boot] [panic] Panic while booting with PCscsi II AM53C974AKC SCSI card by 6.1RC or 6.2 iso CD [regression]
The old box doesn't exist, and I using 8.2 for all systems. This problem don't matter any more. On Thu, Sep 8, 2011 at 11:46 PM, wrote: > Synopsis: [boot] [panic] Panic while booting with PCscsi II AM53C974AKC SCSI > card by 6.1RC or 6.2 iso CD [regression] > > State-Changed-From-To: open->feedback > State-Changed-By: jh > State-Changed-When: Thu Sep 8 15:46:56 UTC 2011 > State-Changed-Why: > Is this still a problem for you? > > http://www.freebsd.org/cgi/query-pr.cgi?pr=109968 > ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/30360: vmstat(8) returns impossible data
The following reply was made to PR bin/30360; it has been noted by GNATS. From: Ed Maste To: Cc: Subject: Re: bin/30360: vmstat(8) returns impossible data Date: Thu, 8 Sep 2011 21:27:13 -0400 See also the thread at http://lists.freebsd.org/pipermail/freebsd-current/2010-October/020564.html A suggestion from one of the followups: > I'd be very happy if all vmstat and iostat would get a command line > switch to suppress the "summary since last reboot" line. > This information may be useful for some cases but in other cases, like > creating performance data for monitoring systems like Icinga / Nagios > one has to remove the first line(s) manually. Adding this mode would solve the problem for non-interactive use of vmstat (in that overflow doesn't matter for the delta between two samples), but will leave the bogus data in the normal case. Maybe -q (quiet) could suppress the header and another -q could suppress also the first line? So vmstat -qq -w 1 -c 2 would provide just the one delta summary line after one second. (For reference, spare flags on vmstat and iostat seem to be b e g j l q r u v y) ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
