Re: kern/157534: commit references a PR
The following reply was made to PR kern/157534; it has been noted by GNATS. From: dfil...@freebsd.org (dfilter service) To: bug-follo...@freebsd.org Cc: Subject: Re: kern/157534: commit references a PR Date: Sat, 13 Aug 2011 12:37:38 + (UTC) Author: marius Date: Sat Aug 13 12:37:22 2011 New Revision: 224820 URL: http://svn.freebsd.org/changeset/base/224820 Log: MFC: r224494, r224761 - Send the RELSIM_ADJUST_OPENINGS in response to a MPI_EVENT_QUEUE_FULL using the right SIM in case the HBA is RAID-capable but the target in question is not a hot spare or member of a RAID volume. - Report the loss and addition of SAS and SATA targets detected via PHY link status changes and signalled by MPI_EVENT_SAS_DEVICE_STATUS_CHANGE to cam(4) as lost devices and trigger rescans as appropriate. Without this it can take quite some time until a lost device actually is no longer tried to be used, if it ever stops. [1] - Handle MPI_EVENT_IR2, MPI_EVENT_LOG_ENTRY_ADDED, MPI_EVENT_SAS_DISCOVERY and MPI_EVENT_SAS_PHY_LINK_STATUS silently as these serve no additional purpose beyond adding cryptic entries to logs. - Add a warning for MPI_EVENT_SAS_DISCOVERY_ERROR events, which can help identifying broken disks. [2] Thanks to Hans-Joerg Sirtl for providing one of the HBAs these changes were developed with and RIP to the mainboard that didn't survive testing them. PR: 157534 [1] Submitted by:Andrew Boyer [2] Modified: stable/8/sys/dev/mpt/mpilib/mpi_ioc.h stable/8/sys/dev/mpt/mpt_cam.c stable/8/sys/dev/mpt/mpt_raid.c stable/8/sys/dev/mpt/mpt_raid.h Directory Properties: stable/8/sys/ (props changed) stable/8/sys/amd64/include/xen/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) stable/8/sys/contrib/dev/acpica/ (props changed) stable/8/sys/contrib/pf/ (props changed) Modified: stable/8/sys/dev/mpt/mpilib/mpi_ioc.h == --- stable/8/sys/dev/mpt/mpilib/mpi_ioc.h Sat Aug 13 12:33:41 2011 (r224819) +++ stable/8/sys/dev/mpt/mpilib/mpi_ioc.h Sat Aug 13 12:37:22 2011 (r224820) @@ -33,7 +33,7 @@ * Title: MPI IOC, Port, Event, FW Download, and FW Upload messages * Creation Date: August 11, 2000 * - *mpi_ioc.h Version: 01.05.14 + *mpi_ioc.h Version: 01.05.16 * * Version History * --- @@ -140,6 +140,16 @@ * added _MULTI_PORT_DOMAIN. * 05-24-07 01.05.14 Added Common Boot Block type to FWDownload Request. * Added Common Boot Block type to FWUpload Request. + * 08-07-07 01.05.15 Added MPI_EVENT_SAS_INIT_RC_REMOVED define. + * Added MPI_EVENT_IR2_RC_DUAL_PORT_ADDED and + * MPI_EVENT_IR2_RC_DUAL_PORT_REMOVED for IR2 event data. + * Added SASAddress field to SAS Initiator Device Table + * Overflow event data structure. + * 03-28-08 01.05.16 Added two new ReasonCode values to SAS Device Status + * Change Event data to indicate completion of internally + * generated task management. + * Added MPI_EVENT_DSCVRY_ERR_DS_SATA_INIT_FAILURE define. + * Added MPI_EVENT_SAS_INIT_RC_INACCESSIBLE define. * -- */ @@ -639,6 +649,8 @@ typedef struct _EVENT_DATA_SAS_DEVICE_ST #define MPI_EVENT_SAS_DEV_STAT_RC_CLEAR_TASK_SET_INTERNAL (0x0B) #define MPI_EVENT_SAS_DEV_STAT_RC_QUERY_TASK_INTERNAL (0x0C) #define MPI_EVENT_SAS_DEV_STAT_RC_ASYNC_NOTIFICATION(0x0D) +#define MPI_EVENT_SAS_DEV_STAT_RC_CMPL_INTERNAL_DEV_RESET (0x0E) +#define MPI_EVENT_SAS_DEV_STAT_RC_CMPL_TASK_ABORT_INTERNAL (0x0F) /* SCSI Event data for Queue Full event */ @@ -735,6 +747,8 @@ typedef struct _MPI_EVENT_DATA_IR2 #define MPI_EVENT_IR2_RC_PD_REMOVED (0x05) #define MPI_EVENT_IR2_RC_FOREIGN_CFG_DETECTED (0x06) #define MPI_EVENT_IR2_RC_REBUILD_MEDIUM_ERROR (0x07) +#define MPI_EVENT_IR2_RC_DUAL_PORT_ADDED(0x08) +#define MPI_EVENT_IR2_RC_DUAL_PORT_REMOVED (0x09) /* defines for logical disk states */ #define MPI_LD_STATE_OPTIMAL(0x00) @@ -894,6 +908,7 @@ typedef struct _EVENT_DATA_DISCOVERY_ERR #define MPI_EVENT_DSCVRY_ERR_DS_UNSUPPORTED_DEVICE (0x0800) #define MPI_EVENT_DSCVRY_ERR_DS_MAX_SATA_TARGETS(0x1000) #define MPI_EVENT_DSCVRY_ERR_DS_MULTI_PORT_DOMAIN (0x2000) +#define MPI_EVENT_DSCVRY_ERR_DS_SATA_INIT_FAILURE (0x4000) /* SAS SMP Error Event data */ @@ -929,6 +944,8 @@ typedef struct _EVENT_DATA_SAS_INIT_DEV_ /* defines for the ReasonCode fie
Re: kern/157534: commit references a PR
The following reply was made to PR kern/157534; it has been noted by GNATS. From: dfil...@freebsd.org (dfilter service) To: bug-follo...@freebsd.org Cc: Subject: Re: kern/157534: commit references a PR Date: Sat, 13 Aug 2011 12:37:47 + (UTC) Author: marius Date: Sat Aug 13 12:37:23 2011 New Revision: 224821 URL: http://svn.freebsd.org/changeset/base/224821 Log: MFC: r224494, r224761 - Send the RELSIM_ADJUST_OPENINGS in response to a MPI_EVENT_QUEUE_FULL using the right SIM in case the HBA is RAID-capable but the target in question is not a hot spare or member of a RAID volume. - Report the loss and addition of SAS and SATA targets detected via PHY link status changes and signalled by MPI_EVENT_SAS_DEVICE_STATUS_CHANGE to cam(4) as lost devices and trigger rescans as appropriate. Without this it can take quite some time until a lost device actually is no longer tried to be used, if it ever stops. [1] - Handle MPI_EVENT_IR2, MPI_EVENT_LOG_ENTRY_ADDED, MPI_EVENT_SAS_DISCOVERY and MPI_EVENT_SAS_PHY_LINK_STATUS silently as these serve no additional purpose beyond adding cryptic entries to logs. - Add a warning for MPI_EVENT_SAS_DISCOVERY_ERROR events, which can help identifying broken disks. [2] Thanks to Hans-Joerg Sirtl for providing one of the HBAs these changes were developed with and RIP to the mainboard that didn't survive testing them. PR: 157534 [1] Submitted by:Andrew Boyer [2] Modified: stable/7/sys/dev/mpt/mpilib/mpi_ioc.h stable/7/sys/dev/mpt/mpt_cam.c stable/7/sys/dev/mpt/mpt_raid.c stable/7/sys/dev/mpt/mpt_raid.h Directory Properties: stable/7/sys/ (props changed) stable/7/sys/cddl/contrib/opensolaris/ (props changed) stable/7/sys/contrib/dev/acpica/ (props changed) stable/7/sys/contrib/pf/ (props changed) Modified: stable/7/sys/dev/mpt/mpilib/mpi_ioc.h == --- stable/7/sys/dev/mpt/mpilib/mpi_ioc.h Sat Aug 13 12:37:22 2011 (r224820) +++ stable/7/sys/dev/mpt/mpilib/mpi_ioc.h Sat Aug 13 12:37:23 2011 (r224821) @@ -33,7 +33,7 @@ * Title: MPI IOC, Port, Event, FW Download, and FW Upload messages * Creation Date: August 11, 2000 * - *mpi_ioc.h Version: 01.05.14 + *mpi_ioc.h Version: 01.05.16 * * Version History * --- @@ -140,6 +140,16 @@ * added _MULTI_PORT_DOMAIN. * 05-24-07 01.05.14 Added Common Boot Block type to FWDownload Request. * Added Common Boot Block type to FWUpload Request. + * 08-07-07 01.05.15 Added MPI_EVENT_SAS_INIT_RC_REMOVED define. + * Added MPI_EVENT_IR2_RC_DUAL_PORT_ADDED and + * MPI_EVENT_IR2_RC_DUAL_PORT_REMOVED for IR2 event data. + * Added SASAddress field to SAS Initiator Device Table + * Overflow event data structure. + * 03-28-08 01.05.16 Added two new ReasonCode values to SAS Device Status + * Change Event data to indicate completion of internally + * generated task management. + * Added MPI_EVENT_DSCVRY_ERR_DS_SATA_INIT_FAILURE define. + * Added MPI_EVENT_SAS_INIT_RC_INACCESSIBLE define. * -- */ @@ -639,6 +649,8 @@ typedef struct _EVENT_DATA_SAS_DEVICE_ST #define MPI_EVENT_SAS_DEV_STAT_RC_CLEAR_TASK_SET_INTERNAL (0x0B) #define MPI_EVENT_SAS_DEV_STAT_RC_QUERY_TASK_INTERNAL (0x0C) #define MPI_EVENT_SAS_DEV_STAT_RC_ASYNC_NOTIFICATION(0x0D) +#define MPI_EVENT_SAS_DEV_STAT_RC_CMPL_INTERNAL_DEV_RESET (0x0E) +#define MPI_EVENT_SAS_DEV_STAT_RC_CMPL_TASK_ABORT_INTERNAL (0x0F) /* SCSI Event data for Queue Full event */ @@ -735,6 +747,8 @@ typedef struct _MPI_EVENT_DATA_IR2 #define MPI_EVENT_IR2_RC_PD_REMOVED (0x05) #define MPI_EVENT_IR2_RC_FOREIGN_CFG_DETECTED (0x06) #define MPI_EVENT_IR2_RC_REBUILD_MEDIUM_ERROR (0x07) +#define MPI_EVENT_IR2_RC_DUAL_PORT_ADDED(0x08) +#define MPI_EVENT_IR2_RC_DUAL_PORT_REMOVED (0x09) /* defines for logical disk states */ #define MPI_LD_STATE_OPTIMAL(0x00) @@ -894,6 +908,7 @@ typedef struct _EVENT_DATA_DISCOVERY_ERR #define MPI_EVENT_DSCVRY_ERR_DS_UNSUPPORTED_DEVICE (0x0800) #define MPI_EVENT_DSCVRY_ERR_DS_MAX_SATA_TARGETS(0x1000) #define MPI_EVENT_DSCVRY_ERR_DS_MULTI_PORT_DOMAIN (0x2000) +#define MPI_EVENT_DSCVRY_ERR_DS_SATA_INIT_FAILURE (0x4000) /* SAS SMP Error Event data */ @@ -929,6 +944,8 @@ typedef struct _EVENT_DATA_SAS_INIT_DEV_ /* defines for the ReasonCode field of the SAS Initiator Device Status Change event *
misc/159745: [patch] Fix improperly specified dependency list for secure/lib/libssh
>Number: 159745
>Category: misc
>Synopsis: [patch] Fix improperly specified dependency list for
>secure/lib/libssh
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Aug 13 17:20:07 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Garrett Cooper
>Release:9-CURRENT
>Organization:
iXsystems
>Environment:
FreeBSD bayonetta.local 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r223824M: Sun Jul 31
20:34:01 PDT 2011 gcooper@bayonetta.local:/usr/obj/usr/src/sys/BAYONETTA
amd64
>Description:
Running buildworld will fail if one invokes it like: make buildworld
-DWITHOUT_GSSAPI -DWITH_KERBEROS
The problem is that the dependency list in Makefile.inc1 requires both GSSAPI
and KERBEROS to be hardwired to no -- otherwise the build will fail looking for
a non-existent dependency.
The attached patch describes what I mean, but might not be the correct
solution. The correct solution might be to set WITHOUT_KERBEROS if
WITHOUT_GSSAPI is set, because gssapi is a dependency of kerberos, and not the
other way around.
>How-To-Repeat:
make buildworld -DWITHOUT_GSSAPI -DWITH_KERBEROS
>Fix:
Patch attached with submission follows:
Index: Makefile.inc1
===
--- Makefile.inc1 (revision 224801)
+++ Makefile.inc1 (working copy)
@@ -1257,8 +1257,9 @@
lib/libradius__L secure/lib/libssl__L: secure/lib/libcrypto__L
.if ${MK_OPENSSH} != "no"
_secure_lib_libssh= secure/lib/libssh
+.if ${MK_GSSAPI} == "no" || ${MK_KERBEROS_SUPPORT} == "no"
secure/lib/libssh__L: lib/libz__L secure/lib/libcrypto__L lib/libcrypt__L
-.if ${MK_KERBEROS_SUPPORT} != "no"
+.else
secure/lib/libssh__L: lib/libgssapi__L kerberos5/lib/libkrb5__L \
kerberos5/lib/libhx509__L kerberos5/lib/libasn1__L lib/libcom_err__L \
lib/libmd__L kerberos5/lib/libroken__L
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
bin/159746: [patch] cat - incorrect output on fstat() failure
>Number: 159746 >Category: bin >Synopsis: [patch] cat - incorrect output on fstat() failure >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Aug 13 17:30:10 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Alex K. >Release:FreeBSD 8.2-RELEASE >Organization: >Environment: FreeBSD system.foxbsd.org 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011 r...@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: Incorrect output on fstat() failure. >How-To-Repeat: >Fix: 260c260 < err(1, "%s", filename); --- > err(1, "stdout"); >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
bin/159750: [PATCH] /usr/bin/tail can call fclose(NULL) causing core dump
>Number: 159750
>Category: bin
>Synopsis: [PATCH] /usr/bin/tail can call fclose(NULL) causing core dump
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Aug 13 22:50:07 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Steve Wills
>Release:
>Organization:
>Environment:
>Description:
I've been getting core dumps from tail when the FS it's on disappears. It can
call fclose with a NULL argument, which causes the crash.
>How-To-Repeat:
run tail -F /path/to/file/on/md, then destroy the md(4)
>Fix:
See attached.
Patch attached with submission follows:
--- usr.bin/tail/forward.c.orig 2011-08-13 18:04:19.054770069 -0400
+++ usr.bin/tail/forward.c 2011-08-13 18:04:23.822771648 -0400
@@ -361,7 +361,9 @@
if (errno != ENOENT)
ierr(file->file_name);
show(file);
- fclose(file->fp);
+ if (file->fp != NULL) {
+ fclose(file->fp);
+ }
file->fp = NULL;
ev_change++;
continue;
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
bin/159752: [patch] chio - incorrect spelling in license
>Number: 159752 >Category: bin >Synopsis: [patch] chio - incorrect spelling in license >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Aug 13 23:30:13 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Alex K. >Release:8.2 >Organization: >Environment: FreeBSD system.foxbsd.org 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011 r...@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: The spelling of acknowledgements could be changed to acknowledgments. Trivial and submitted to gain experienced making diffs. >How-To-Repeat: >Fix: --- chio.c 2010-06-02 05:34:41.0 -0400 +++ chio.temp 2011-08-13 23:12:22.0 -0400 @@ -12,7 +12,7 @@ *notice, this list of conditions and the following disclaimer in the *documentation and/or other materials provided with the distribution. * 3. All advertising materials mentioning features or use of this software - *must display the following acknowledgements: + *must display the following acknowledgments: * This product includes software developed by Jason R. Thorpe * for And Communications, http://www.and.com/ * 4. The name of the author may not be used to endorse or promote products >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/159753: Perl Port marked as IGNORE if PERL_VERSION=5.14
>Number: 159753 >Category: misc >Synopsis: Perl Port marked as IGNORE if PERL_VERSION=5.14 >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Aug 13 23:30:13 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Dmitry >Release:8.2-RELEASE >Organization: >Environment: FreeBSD oemcomp.openair 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #2: Sun Jul 31 13:40:17 EEST 2011 root@oemcomp.openair:/usr/obj/usr/src/sys/TELIASONERA i386 >Description: # portupgrade -arR ** Port marked as IGNORE: devel/p5-AnyEvent: requires Perl 5.8.1 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-B-Hooks-EndOfScope: requires Perl 5.8.0 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-Class-C3: requires Perl 5.8.0 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-Class-C3-XS: requires Perl 5.8.0 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-ExtUtils-ParseXS: requires Perl 5.8.1 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: x11-toolkits/p5-Gtk2: requires Perl 5.8.0 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-IO-Tty: requires Perl 5.8.0 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-MRO-Compat: requires Perl 5.8.0 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-Moose: requires Perl 5.8.4 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-MooseX-Getopt: requires Perl 5.8.0 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-Mouse: requires Perl 5.8.5 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: x11-toolkits/p5-Pango: requires Perl 5.8.0 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-Sub-Exporter: requires Perl 5.6.2 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-Sub-Name: requires Perl 5.6.0 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-Task-Weaken: requires Perl 5.8.5 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: net/p5-URI: requires Perl 5.8.1 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: converters/p5-Unicode-String: requires Perl 5.7.2 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-Variable-Magic: requires Perl 5.8.0 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: textproc/p5-XML-LibXML: requires Perl 5.6.1 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again ** Port marked as IGNORE: devel/p5-namespace-clean: requires Perl 5.8.0 or later, install lang/perl5.8 or lang/perl5.10 or lang/perl5.12 and try again >How-To-Repeat: install perl5.14, then any p5- port with PERL_CONFIGURE=5.8.1+ in his Makefile (for example devel/p5-AnyEvent) This after bsd.perl.mk Revision 1.21 >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/159752: [patch] chio - incorrect spelling in license
On Sat, 13 Aug 2011, Alex K. wrote: Description: The spelling of acknowledgements could be changed to acknowledgments. Trivial and submitted to gain experienced making diffs. How-To-Repeat: Fix: --- chio.c 2010-06-02 05:34:41.0 -0400 +++ chio.temp 2011-08-13 23:12:22.0 -0400 @@ -12,7 +12,7 @@ *notice, this list of conditions and the following disclaimer in the *documentation and/or other materials provided with the distribution. * 3. All advertising materials mentioning features or use of this software - *must display the following acknowledgements: + *must display the following acknowledgments: * This product includes software developed by Jason R. Thorpe * for And Communications, http://www.and.com/ * 4. The name of the author may not be used to endorse or promote products This is the standard Berkeley copyright with the standard Berkeley mispelling. It (or an upper case variant) is used in 6580 regular files out of 17612 in /usr/src 4.4BSD-Lite2. Do you really wish to fix them all? (y or n) :-). The correct spelling is used in 42 files in Lite2 (one is the dictionary :-). I think errors in copyrights can only be fixed by the copyright holder, but this problem will go away when clause 3 is removed (as permitted by Berkeley for most files not including non-Berkeley ones like chio.c). Bruce ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/159752: [patch] chio - incorrect spelling in license
The following reply was made to PR bin/159752; it has been noted by GNATS. From: Bruce Evans To: "Alex K." Cc: freebsd-gnats-sub...@freebsd.org, freebsd-bugs@FreeBSD.org Subject: Re: bin/159752: [patch] chio - incorrect spelling in license Date: Sun, 14 Aug 2011 12:37:25 +1000 (EST) On Sat, 13 Aug 2011, Alex K. wrote: >> Description: > The spelling of acknowledgements could be changed to acknowledgments. > Trivial and submitted to gain experienced making diffs. >> How-To-Repeat: > >> Fix: > --- chio.c 2010-06-02 05:34:41.0 -0400 > +++ chio.temp 2011-08-13 23:12:22.0 -0400 > @@ -12,7 +12,7 @@ > *notice, this list of conditions and the following disclaimer in the > *documentation and/or other materials provided with the distribution. > * 3. All advertising materials mentioning features or use of this software > - *must display the following acknowledgements: > + *must display the following acknowledgments: > * This product includes software developed by Jason R. Thorpe > * for And Communications, http://www.and.com/ > * 4. The name of the author may not be used to endorse or promote products This is the standard Berkeley copyright with the standard Berkeley mispelling. It (or an upper case variant) is used in 6580 regular files out of 17612 in /usr/src 4.4BSD-Lite2. Do you really wish to fix them all? (y or n) :-). The correct spelling is used in 42 files in Lite2 (one is the dictionary :-). I think errors in copyrights can only be fixed by the copyright holder, but this problem will go away when clause 3 is removed (as permitted by Berkeley for most files not including non-Berkeley ones like chio.c). Bruce ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
