Re: kern/150315: [ata] sizeof(union ccb) changed between 7.x and 8.x
The following reply was made to PR kern/150315; it has been noted by GNATS. From: Alexander Motin To: bug-follo...@freebsd.org, woll...@freebsd.org Cc: Subject: Re: kern/150315: [ata] sizeof(union ccb) changed between 7.x and 8.x Date: Mon, 18 Jul 2011 13:43:08 +0300 The main problem is not just in union ccb size change. Problem is that elements newly added to several structures were added not to the ends, and in some places there are arrays of structures used. As result providing compatibility layer would required to repack all requests and responses, reordering their fields. I am not sure that supporting it now (1.5 years after 8.0 release) worth polluting code. Speaking about smartctl -- the best way is to rebuild it, as new version also supports CAM ATA. -- Alexander Motin ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
kern/159010: zfsv28 serves bad device nodes via nfs on FreeBSD 8.2
>Number: 159010 >Category: kern >Synopsis: zfsv28 serves bad device nodes via nfs on FreeBSD 8.2 >Confidential: no >Severity: serious >Priority: medium >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 18 15:20:10 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Gerrit Kühn >Release:8.2-stable as of 15th of July 2011 >Organization: AEI/MPG >Environment: FreeBSD mclane.rt.aei.uni-hannover.de 8.2-STABLE FreeBSD 8.2-STABLE #0: Thu Jul 14 14:09:47 CEST 2011 r...@mclane.rt.aei.uni-hannover.de:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Copied from my email on freebsd-stable: I guess I found the root of all evil now: device nodes on zfs! This is how a linux /dev/console looked on the 8.0-FreeBSD server on zfsv15: crw--- 1 root wheel5, 1 Oct 28 2010 /tank/diskless/gco-fe2/dev/console Now, after updating to FreeBSD-8.2 and zfsv28 it looks like this on the server: crw-r--r-- 1 root wheel 255, 0x00ff Jul 18 16:33 /tank/diskless/pt-fe2/dev/console Strange enough, the Linux client still displays the correct values when using "ls -la", but it refuses to work properly. I tried creating new device nodes from the client side with mknod and I tried getting correct ones from a backup, but they always end up being broken. Even moving the directories over to a ufs volume leaves them unusable: crw-r--r-- 1 root wheel0, 0 Jul 18 16:33 /tmp/console Luckily, I am back into business now with my machines, because moving the stuff from zfs to ufs and dropping in a correct version of /dev on the ufs side works just fine. However, it would be great if this could be fixed, because I do not have many ufs partitions left these days... >How-To-Repeat: Upgrade filesystems containing device nodes (Linux diskless client in this case) to zfsv28 on FreeBSD 8.2-stable. >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
bin/159011: Memory leak in bin/ed/buf.c
>Number: 159011
>Category: bin
>Synopsis: Memory leak in bin/ed/buf.c
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Jul 18 16:10:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Henning Petersen
>Release:FreeBSD-current
>Organization:
>Environment:
>Description:
Memory leak in bin/ed/buf.c .
>How-To-Repeat:
>Fix:
diff -u -r1.22 buf.c
--- bin/ed/buf.c30 Jun 2002 05:13:53 - 1.22
+++ bin/ed/buf.c18 Jul 2011 13:19:28 -
@@ -94,6 +94,7 @@
;
if (s - cs >= LINECHARS) {
errmsg = "line too long";
+ free(lp);
return NULL;
}
len = s - cs;
@@ -102,6 +103,7 @@
if (fseeko(sfp, (off_t)0, SEEK_END) < 0) {
fprintf(stderr, "%s\n", strerror(errno));
errmsg = "cannot seek temp file";
+ free(lp);
return NULL;
}
sfseek = ftello(sfp);
@@ -112,6 +114,7 @@
sfseek = -1;
fprintf(stderr, "%s\n", strerror(errno));
errmsg = "cannot write temp file";
+ free(lp);
return NULL;
}
lp->len = len;
Patch attached with submission follows:
diff -u -r1.22 buf.c
--- bin/ed/buf.c30 Jun 2002 05:13:53 - 1.22
+++ bin/ed/buf.c18 Jul 2011 13:19:28 -
@@ -94,6 +94,7 @@
;
if (s - cs >= LINECHARS) {
errmsg = "line too long";
+ free(lp);
return NULL;
}
len = s - cs;
@@ -102,6 +103,7 @@
if (fseeko(sfp, (off_t)0, SEEK_END) < 0) {
fprintf(stderr, "%s\n", strerror(errno));
errmsg = "cannot seek temp file";
+ free(lp);
return NULL;
}
sfseek = ftello(sfp);
@@ -112,6 +114,7 @@
sfseek = -1;
fprintf(stderr, "%s\n", strerror(errno));
errmsg = "cannot write temp file";
+ free(lp);
return NULL;
}
lp->len = len;
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
kern/159013: kldunload dtraceall crashing if userland dtrace provider is in use
>Number: 159013 >Category: kern >Synopsis: kldunload dtraceall crashing if userland dtrace provider is in >use >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 18 17:20:14 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Alex Samorukov >Release:FreeBSD-STABLE >Organization: netart >Environment: FreeBSD bsd.home 8.2-STABLE FreeBSD 8.2-STABLE #3: Fri Jul 15 21:22:54 UTC 2011 r...@bsd.home:/usr/obj/usr/src/sys/DTRACE amd64 >Description: I found that kldunload dtracell causing kernel crash if userland providers are in use. >How-To-Repeat: 1) Compile kernel with DTRACE support on -STABLE. 2) Run program acting as userland provider. I am using mod_php + apache for this, see ports/158983 for the source. 3) Load module (kldload dtraceall) 4) start the web server to initialize the provider. 5) Do kldunload dtraceall. System will panic. bsd# head -n 31 core.txt.0 bsd.home dumped core - see /var/crash/vmcore.0 Mon Jul 18 22:10:40 UTC 2011 FreeBSD bsd.home 8.2-STABLE FreeBSD 8.2-STABLE #3: Fri Jul 15 21:22:54 UTC 2011 r...@bsd.home:/usr/obj/usr/src/sys/DTRACE amd64 panic: double fault GNU gdb 6.1.1 [FreeBSD] Copyright 2004 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type "show copying" to see the conditions. There is absolutely no warranty for GDB. Type "show warranty" for details. This GDB was configured as "amd64-marcel-freebsd"... Unread portion of the kernel message buffer: Fatal double fault rip = 0x808f2cf8 rsp = 0xff8126aa8f60 rbp = 0xff8126aa90e0 cpuid = 0; apic id = 00 panic: double fault cpuid = 0 KDB: stack backtrace: #0 0x8062d78e at kdb_backtrace+0x5e #1 0x805f8d17 at panic+0x187 #2 0x808f2494 at dblfault_handler+0xa4 #3 0x808daced at Xdblfault+0xad Uptime: 2m18s 6) if i`m unloading httpd before kldunload everything is fine. I think this bug is not critical, but needs to be fixed. >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/127440: [dtrace] Dtrace arg0/arg1 variables don't contain return value of syscall:::return
The following reply was made to PR kern/127440; it has been noted by GNATS. From: Alex Samorukov To: bug-follo...@freebsd.org, h...@restart.be Cc: Subject: Re: kern/127440: [dtrace] Dtrace arg0/arg1 variables don't contain return value of syscall:::return Date: Mon, 18 Jul 2011 20:57:09 +0200 This bug is fixed. In 8-STABLE your test showing: 2 42158 read:entry read(9, 0x7fff9fe0, 16384) 2 42159 read:return = 77 So i think that this PR should be closed. ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/154073: commit references a PR
The following reply was made to PR kern/154073; it has been noted by GNATS.
From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:
Subject: Re: kern/154073: commit references a PR
Date: Mon, 18 Jul 2011 19:24:00 + (UTC)
Author: delphij
Date: Mon Jul 18 19:23:50 2011
New Revision: 224196
URL: http://svn.freebsd.org/changeset/base/224196
Log:
Disable gvmat64.S, the assembler version of longest_match for now.
PR: kern/154073
MFC after: 3 days
Approved by: re (kib)
Modified:
head/lib/libz/Makefile
Modified: head/lib/libz/Makefile
==
--- head/lib/libz/Makefile Mon Jul 18 18:56:50 2011(r224195)
+++ head/lib/libz/Makefile Mon Jul 18 19:23:50 2011(r224196)
@@ -42,16 +42,16 @@ CFLAGS+= -DASMV -DNO_UNDERLINE
ACFLAGS+= -Wa,--noexecstack
.endif
-.if ${MACHINE_ARCH} == "amd64"
-.PATH:${.CURDIR}/contrib/gcc_gvmat64
-SRCS+=gvmat64.S
-CFLAGS+= -DASMV -DNO_UNDERLINE
-ACFLAGS+= -Wa,--noexecstack
-.if ${CC:T:Mclang} == "clang"
-# XXX: clang integrated-as doesn't grok .intel_syntax directives yet
-ACFLAGS+= ${.IMPSRC:T:Mgvmat64.S:C/^.+$/-no-integrated-as/}
-.endif
-.endif
+#.if ${MACHINE_ARCH} == "amd64"
+#.PATH: ${.CURDIR}/contrib/gcc_gvmat64
+#SRCS+= gvmat64.S
+#CFLAGS+= -DASMV -DNO_UNDERLINE
+#ACFLAGS+=-Wa,--noexecstack
+#.if ${CC:T:Mclang} == "clang"
+## XXX: clang integrated-as doesn't grok .intel_syntax directives yet
+#ACFLAGS+=${.IMPSRC:T:Mgvmat64.S:C/^.+$/-no-integrated-as/}
+#.endif
+#.endif
VERSION_DEF= ${.CURDIR}/Versions.def
SYMBOL_MAPS= ${.CURDIR}/Symbol.map
___
svn-src-...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/154073: [libz] libz causes perl to exit on signal 11
Synopsis: [libz] libz causes perl to exit on signal 11 Responsible-Changed-From-To: freebsd-bugs->delphij Responsible-Changed-By: delphij Responsible-Changed-When: Mon Jul 18 19:35:51 UTC 2011 Responsible-Changed-Why: Assume responsibility. http://www.freebsd.org/cgi/query-pr.cgi?pr=154073 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/159010: [zfs] zfsv28 serves bad device nodes via nfs on FreeBSD 8.2
Old Synopsis: zfsv28 serves bad device nodes via nfs on FreeBSD 8.2 New Synopsis: [zfs] zfsv28 serves bad device nodes via nfs on FreeBSD 8.2 Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: linimon Responsible-Changed-When: Mon Jul 18 21:37:15 UTC 2011 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=159010 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/159019: freebsd ipv6 address are advertised but do not respond
>Number: 159019 >Category: misc >Synopsis: freebsd ipv6 address are advertised but do not respond >Confidential: no >Severity: serious >Priority: medium >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jul 19 01:10:08 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Russell Cattelan >Release: >Organization: >Environment: >Description: macpro00[6:16pm]-=>dig lists.freebsd.org ; <<>> DiG 9.6.0-APPLE-P2 <<>> lists.freebsd.org ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 63270 ;; flags: qr rd ra; QUERY: 1, ANSWER: 2, AUTHORITY: 0, ADDITIONAL: 0 ;; QUESTION SECTION: ;lists.freebsd.org. IN ;; ANSWER SECTION: lists.freebsd.org. 2383IN CNAME bwwwdyn.freebsd.org. bwwwdyn.freebsd.org.3598IN 2001:4f8:fff6::27 ;; Query time: 70 msec ;; SERVER: 10.0.0.9#53(10.0.0.9) ;; WHEN: Mon Jul 18 19:59:29 2011 ;; MSG SIZE rcvd: 85 but macpro00[8:00pm]-=>telnet 2001:4f8:fff6::27 80 Trying 2001:4f8:fff6::27... So anybody with ipv6 enabled will end up with with a connection timeout. >How-To-Repeat: >Fix: maybe it would be best not to publish the records for the standard systems but do like a ivp6.freebsd.org >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/156258: commit references a PR
The following reply was made to PR bin/156258; it has been noted by GNATS.
From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:
Subject: Re: bin/156258: commit references a PR
Date: Tue, 19 Jul 2011 03:30:52 + (UTC)
Author: avatar
Date: Tue Jul 19 03:30:42 2011
New Revision: 224208
URL: http://svn.freebsd.org/changeset/base/224208
Log:
MFC r223035: Using statfs.f_fstypename rather than statfs.f_type whilst
performing fstype comparsion as nullfs will copy f_type from underlayer FS.
PR: bin/156258
Submitted by:Marcin Wisnicki
Modified:
stable/7/usr.bin/find/function.c
Directory Properties:
stable/7/usr.bin/find/ (props changed)
Modified: stable/7/usr.bin/find/function.c
==
--- stable/7/usr.bin/find/function.c Tue Jul 19 00:37:24 2011
(r224207)
+++ stable/7/usr.bin/find/function.c Tue Jul 19 03:30:42 2011
(r224208)
@@ -841,7 +841,8 @@ f_fstype(PLAN *plan, FTSENT *entry)
static dev_t curdev;/* need a guaranteed illegal dev value */
static int first = 1;
struct statfs sb;
- static int val_type, val_flags;
+ static int val_flags;
+ static char fstype[sizeof(sb.f_fstypename)];
char *p, save[2] = {0,0};
if ((plan->flags & F_MTMASK) == F_MTUNKNOWN)
@@ -883,13 +884,13 @@ f_fstype(PLAN *plan, FTSENT *entry)
* always copy both of them.
*/
val_flags = sb.f_flags;
- val_type = sb.f_type;
+ strlcpy(fstype, sb.f_fstypename, sizeof(fstype));
}
switch (plan->flags & F_MTMASK) {
case F_MTFLAG:
return val_flags & plan->mt_data;
case F_MTTYPE:
- return val_type == plan->mt_data;
+ return (strncmp(fstype, plan->c_data, sizeof(fstype)) == 0);
default:
abort();
}
@@ -900,22 +901,11 @@ c_fstype(OPTION *option, char ***argvp)
{
char *fsname;
PLAN *new;
- struct xvfsconf vfc;
fsname = nextarg(option, argvp);
ftsoptions &= ~FTS_NOSTAT;
new = palloc(option);
-
- /*
- * Check first for a filesystem name.
- */
- if (getvfsbyname(fsname, &vfc) == 0) {
- new->flags |= F_MTTYPE;
- new->mt_data = vfc.vfc_typenum;
- return new;
- }
-
switch (*fsname) {
case 'l':
if (!strcmp(fsname, "local")) {
@@ -933,12 +923,8 @@ c_fstype(OPTION *option, char ***argvp)
break;
}
- /*
- * We need to make filesystem checks for filesystems
- * that exists but aren't in the kernel work.
- */
- fprintf(stderr, "Warning: Unknown filesystem type %s\n", fsname);
- new->flags |= F_MTUNKNOWN;
+ new->flags |= F_MTTYPE;
+ new->c_data = fsname;
return new;
}
___
svn-src-...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/159019: [ip6] freebsd ipv6 address are advertised but do not respond
Old Synopsis: freebsd ipv6 address are advertised but do not respond New Synopsis: [ip6] freebsd ipv6 address are advertised but do not respond Responsible-Changed-From-To: freebsd-bugs->freebsd-net Responsible-Changed-By: linimon Responsible-Changed-When: Tue Jul 19 05:16:38 UTC 2011 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=159019 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
