kern/158339: replay_alloc() could dereference a null pointer...

2011-06-27 Thread Greg Becker

>Number: 158339
>Category:   kern
>Synopsis:   replay_alloc() could dereference a null pointer...
>Confidential:   no
>Severity:   non-critical
>Priority:   low
>Responsible:freebsd-bugs
>State:  open
>Quarter:
>Keywords:   
>Date-Required:
>Class:  sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 27 12:30:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Greg Becker
>Release:8.2
>Organization:
CodeConcepts
>Environment:
FreeBSD dev4.i.cacheiq.com 8.2-STABLE FreeBSD 8.2-STABLE #5: Wed Jun 22 
11:11:13 CDT 2011 gbec...@dev4.i.cacheiq.com:/usr/obj/usr/src/sys/DEV4  
amd64


>Description:
relay_alloc() (in src/sys/rpc/replay.c) calls malloc() with the M_NOWAIT flag, 
then proceeds to assume the pointer returned by malloc() is not NULL.  This 
could cause a panic in a situation in which malloc() cannot satisfy the request.

>How-To-Repeat:

>Fix:
Check the return code from malloc().  See attached patch.

Patch attached with submission follows:

--- /usr/src/sys/rpc/replay.c   2011-06-27 06:47:01.0 -0500
+++ /home/gbecker/replay.c  2011-06-27 06:46:21.0 -0500
@@ -115,14 +115,12 @@
 
rc->rc_count++;
rce = malloc(sizeof(*rce), M_RPC, M_NOWAIT|M_ZERO);
-   if (rce) {
-   rce->rce_hash = h;
-   rce->rce_msg = *msg;
-   bcopy(addr, &rce->rce_addr, addr->sa_len);
+   rce->rce_hash = h;
+   rce->rce_msg = *msg;
+   bcopy(addr, &rce->rce_addr, addr->sa_len);
 
-   TAILQ_INSERT_HEAD(&rc->rc_cache[h], rce, rce_link);
-   TAILQ_INSERT_HEAD(&rc->rc_all, rce, rce_alllink);
-   }
+   TAILQ_INSERT_HEAD(&rc->rc_cache[h], rce, rce_link);
+   TAILQ_INSERT_HEAD(&rc->rc_all, rce, rce_alllink);
 
return (rce);
 }


>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


VIP Exclusive - How To Excel Yourself Series - Part 2 - SA’s Read Green Initiative

2011-06-27 Thread Life Enriching InfoMagazines
Your VIP Access... Improve Your Lifestyle & Business Series!  South 
Africa's New Read Green Online Publishing Technology

Save Paper Save Trees... Help South Africa Reduce Climate Change (Facts About 
Paper) "http://www.colorpages.co.za/smartread/default1210"; - Support This Read 
Green Initiative!

Excel Yourself - Life Enriching Exclusive Series Part 2 - Now Online in Modern 
Living InfoMags
Click on any Magazine to Open - Experience and Enjoy Interactive Online 
Magazines with Digital Pageflip Technology!

Self Improvement Made EasyCamping HolidaysAnti-Ageing and Skincare Made 
EasyHow To Decorate Like a Pro
Gardening Made EasyHome Security Made Easy   Tips About Buying Your Next 
CarBecome an Effective Time 
Manager 

You May Need Flash Player  Free Download 
"http://www.adobe.com/shockwave/download/alternates"; If this message is not 
displaying properly  Click here to launch your browser 
"http://www.colorpages.co.za/index.php"; 

 "http://www.colorpages.co.za/competition/default0611"; 

 InfoMags:  Instant Viewing - No Huge Downloads   FREE!  Click on any 
Magazine to Open  FREE!  Enter Our Competition!

 "http://www.colorpages.co.za/flashbooks/citypages1/default1210";>http://www.colorpages.co.za/flashbooks/koopkrag/default";>http://www.colorpages.co.za/flashbooks/poolpeople/StdScreenVers01";>http://www.colorpages.co.za/competition/default0611"; - You Could Be Our Next 
Lucky Winner!

Hot of The Screen:  The Video Pages 
"http://www.colorpages.co.za/videopages/default1010.html"; - See The Fantastic 
Machines - Believe It Or Not...

Innovative Messaging:  Digi Smart Flyer 
"http://www.infomag.co.za/smartflyer/default1210.html"; - Empower Your Sales 
Force!

Limited Special Offer:  InfoMags Online 
"http://www.colorpages.co.za/smartmag/default1210"; - Promote Your Business!

Property Auctions:  Auction Diary 
"http://www.colorpages.co.za/flashbooks/omniland/default240611.html"; - Upcoming 
Property Auctions

Digital Delivery:  Free Subscription 
"http://www.colorpages.co.za/contactus/html/subscribe2.html"; - Subscribe For 
VIP Benefits!

Function Venue:  Primi Centurion 
"http://www.colorpages.co.za/flashbooks/primi/default0610"; - We Cater For All 
Functions

Please Update:  My e-Mail "mailto:"; - Alternative e-Mail Address

Everyday Visit:  InfoPlanet "http://www.infoplanet.co.za"; - Great Everyday Info 
at Your Fingertips!

Save Paper Save Trees... Help South Africa Reduce Climate Change (Facts About 
Paper) "http://www.colorpages.co.za/smartread/default1210"; - Support Our 
Advertisers!

Biz Enquiries: Tel 012 329 2823/4 - Ask for ext 202 - Online Marketing & 
Publishing, eCatalogues, eFlyers, FaceBook Pages etc.

InfoMag Technologies | PO Box 30232 | Sunnyside | 0132 | South Africa

To Unsubscribe use this link:  Remove me from list "mailto:"; - Why Miss Out On 
Exclusive InfoMags, Competitions and Special Offers? 

Powered by MyListManager
http://www.mylistmanager.co.za/cgi-bin/uls/uls.cgi?matheKialo=Yes&adminid=1711&&listid=9103&eid=2224413&archid=1987
--

Please use Second Link above -  Remove me from list -  to unsubscribe from 
mailing list
http://www.mylistmanager.co.za/cgi-bin/uls/uls.cgi?ulsRemove=9103-2224413=1987

___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


kern/158340: Possible dereference of null pointer by code that calls replay_find()...

2011-06-27 Thread Greg Becker

>Number: 158340
>Category:   kern
>Synopsis:   Possible dereference of null pointer by code that calls 
>replay_find()...
>Confidential:   no
>Severity:   non-critical
>Priority:   low
>Responsible:freebsd-bugs
>State:  open
>Quarter:
>Keywords:   
>Date-Required:
>Class:  sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 27 12:50:07 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Greg Becker
>Release:8.2
>Organization:
CodeConcepts
>Environment:
>Description:
In replay_find() (src/sys/rpc/replay.c), if a message is found in the DRC but 
does not have a body then mp is left untouched.  The only caller of 
replay_find() is svc_getreq(), which assumes that replay_find() returns a valid 
pointer in this argument.

Now, I don't know if rce_repbody can legitimately be NULL, but for completeness 
svc_getreq() should probably set repbody to NULL and then check it after the 
call to replay_find(), and avoid making the call to SVC_REPLY() if repbody is 
NULL.

replay_find() also should set *mp = NULL if rce_repbody is NULL.


>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


misc/158351: missing #includes in

2011-06-27 Thread Robert Millan

>Number: 158351
>Category:   misc
>Synopsis:   missing #includes in 
>Confidential:   no
>Severity:   non-critical
>Priority:   low
>Responsible:freebsd-bugs
>State:  open
>Quarter:
>Keywords:   
>Date-Required:
>Class:  sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 27 16:30:12 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Robert Millan
>Release:Debian GNU/kFreeBSD "sid"
>Organization:
>Environment:
>Description:
dimoni# cat > test.c
#include 
^D
dimoni# gcc -c test.c -o /dev/null 
In file included from test.c:1:
/usr/include/cam/cam.h:40: error: expected '=', ',', ';', 'asm' or 
'__attribute__' before 'path_id_t'
/usr/include/cam/cam.h:41: error: expected '=', ',', ';', 'asm' or 
'__attribute__' before 'target_id_t'
/usr/include/cam/cam.h:42: error: expected '=', ',', ';', 'asm' or 
'__attribute__' before 'lun_id_t'
/usr/include/cam/cam.h:78: error: expected specifier-qualifier-list before 
'u_int32_t'
/usr/include/cam/cam.h:230: error: expected '=', ',', ';', 'asm' or 
'__attribute__' before 'cam_quirkmatch'
/usr/include/cam/cam.h:233: error: expected ')' before '*' token
/usr/include/cam/cam.h:235: error: expected ';', ',' or ')' before '*' token
/usr/include/cam/cam.h:252: error: expected declaration specifiers or '...' 
before 'FILE'

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- /usr/include/cam/cam.h  2011-02-19 23:06:57.0 +0100
+++ cam.h   2011-06-27 18:22:16.885773750 +0200
@@ -33,8 +33,11 @@
 
 #ifdef _KERNEL
 #include 
+#else
+#include  /* FILE */
 #endif
 
+#include 
 #include 
 
 typedef u_int path_id_t;


>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


Re: gnu/157019: [patch] gcc(1): Add some warnings from OpenBSD gcc and fix a typo.

2011-06-27 Thread uqs
Synopsis: [patch] gcc(1): Add some warnings from OpenBSD gcc and fix a typo.

State-Changed-From-To: open->feedback
State-Changed-By: uqs
State-Changed-When: Mon Jun 27 20:45:10 UTC 2011
State-Changed-Why: 
Hello Pedro,

the patch you attached is incomplete/malformed. Could you please
regenerate and re-send?

http://www.freebsd.org/cgi/query-pr.cgi?pr=157019
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


Re: conf/157903: commit references a PR

2011-06-27 Thread dfilter service
The following reply was made to PR conf/157903; it has been noted by GNATS.

From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:  
Subject: Re: conf/157903: commit references a PR
Date: Mon, 27 Jun 2011 21:00:28 + (UTC)

 Author: hselasky
 Date: Mon Jun 27 20:59:43 2011
 New Revision: 223605
 URL: http://svn.freebsd.org/changeset/base/223605
 
 Log:
   MFC r223486, r223489, r223490, r223511, r223512, r223513,
 r223515, r223518, r223519, r223521, r223534, r223535,
 r223536, r223537, r223538, r223543, r223288, r223604 and r223566:
   
   - Export all USB device ID's in so-called sections.
   - Fix duplicate occurence of a USB ID in if_urtw and if_zyd.
   - Add new tool to autogenerate nomatch entries for devd.
   - Add new usb.conf file to auto-load USB drivers.
   - Fix some issues related to the nomatch notifications.
   
   PR:  misc/157903
 
 Added:
   stable/8/etc/devd/usb.conf
  - copied, changed from r223543, head/etc/devd/usb.conf
   stable/8/tools/tools/bus_autoconf/
  - copied from r223486, head/tools/tools/bus_autoconf/
   stable/8/tools/tools/bus_autoconf/bus_autoconf_format_example.txt
  - copied unchanged from r223534, 
head/tools/tools/bus_autoconf/bus_autoconf_format_example.txt
   stable/8/tools/tools/bus_autoconf/bus_load_file.c
  - copied, changed from r223534, 
head/tools/tools/bus_autoconf/bus_load_file.c
   stable/8/tools/tools/bus_autoconf/bus_load_file.h
  - copied unchanged from r223534, 
head/tools/tools/bus_autoconf/bus_load_file.h
   stable/8/tools/tools/bus_autoconf/bus_sections.c
  - copied unchanged from r223534, 
head/tools/tools/bus_autoconf/bus_sections.c
   stable/8/tools/tools/bus_autoconf/bus_sections.h
  - copied unchanged from r223534, 
head/tools/tools/bus_autoconf/bus_sections.h
   stable/8/tools/tools/bus_autoconf/bus_usb.c
  - copied, changed from r223534, head/tools/tools/bus_autoconf/bus_usb.c
   stable/8/tools/tools/bus_autoconf/bus_usb.h
  - copied unchanged from r223534, head/tools/tools/bus_autoconf/bus_usb.h
 Modified:
   stable/8/etc/devd/Makefile
   stable/8/sys/dev/sound/usb/uaudio.c
   stable/8/sys/dev/usb/input/atp.c
   stable/8/sys/dev/usb/input/uep.c
   stable/8/sys/dev/usb/input/uhid.c
   stable/8/sys/dev/usb/input/ukbd.c
   stable/8/sys/dev/usb/input/ums.c
   stable/8/sys/dev/usb/misc/udbp.c
   stable/8/sys/dev/usb/misc/ufm.c
   stable/8/sys/dev/usb/net/if_aue.c
   stable/8/sys/dev/usb/net/if_axe.c
   stable/8/sys/dev/usb/net/if_cdce.c
   stable/8/sys/dev/usb/net/if_cue.c
   stable/8/sys/dev/usb/net/if_ipheth.c
   stable/8/sys/dev/usb/net/if_kue.c
   stable/8/sys/dev/usb/net/if_rue.c
   stable/8/sys/dev/usb/net/if_udav.c
   stable/8/sys/dev/usb/net/uhso.c
   stable/8/sys/dev/usb/serial/u3g.c
   stable/8/sys/dev/usb/serial/uark.c
   stable/8/sys/dev/usb/serial/ubsa.c
   stable/8/sys/dev/usb/serial/uchcom.c
   stable/8/sys/dev/usb/serial/ucycom.c
   stable/8/sys/dev/usb/serial/ufoma.c
   stable/8/sys/dev/usb/serial/uftdi.c
   stable/8/sys/dev/usb/serial/ugensa.c
   stable/8/sys/dev/usb/serial/uipaq.c
   stable/8/sys/dev/usb/serial/ulpt.c
   stable/8/sys/dev/usb/serial/umcs.c
   stable/8/sys/dev/usb/serial/umct.c
   stable/8/sys/dev/usb/serial/umodem.c
   stable/8/sys/dev/usb/serial/umoscom.c
   stable/8/sys/dev/usb/serial/uplcom.c
   stable/8/sys/dev/usb/serial/uslcom.c
   stable/8/sys/dev/usb/serial/uvisor.c
   stable/8/sys/dev/usb/serial/uvscom.c
   stable/8/sys/dev/usb/storage/umass.c
   stable/8/sys/dev/usb/storage/urio.c
   stable/8/sys/dev/usb/usb_device.c
   stable/8/sys/dev/usb/usb_hub.c
   stable/8/sys/dev/usb/usb_lookup.c
   stable/8/sys/dev/usb/usb_msctest.c
   stable/8/sys/dev/usb/usbdi.h
   stable/8/sys/dev/usb/wlan/if_rum.c
   stable/8/sys/dev/usb/wlan/if_run.c
   stable/8/sys/dev/usb/wlan/if_uath.c
   stable/8/sys/dev/usb/wlan/if_upgt.c
   stable/8/sys/dev/usb/wlan/if_ural.c
   stable/8/sys/dev/usb/wlan/if_urtw.c
   stable/8/sys/dev/usb/wlan/if_zyd.c
   stable/8/sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c
   stable/8/sys/netgraph/bluetooth/drivers/ubtbcmfw/ubtbcmfw.c
   stable/8/tools/tools/bus_autoconf/Makefile
   stable/8/tools/tools/bus_autoconf/bus_autoconf.c
   stable/8/tools/tools/bus_autoconf/bus_autoconf.h
   stable/8/tools/tools/bus_autoconf/bus_autoconf.sh
 Directory Properties:
   stable/8/etc/   (props changed)
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/tools/tools/   (props changed)
   stable/8/tools/tools/aac/   (props changed)
   stable/8/tools/tools/ath/   (props changed)
   stable/8/tools/tools/ath/common/dumpregs.h   (props changed)
   stable/8/tools/tools/ath/common/dumpregs_5210.c   (props changed)
   stable/8/tools/tools/ath/common/dumpregs_5211.c   (props changed)
   stable/8/tools/tools/ath/common/dumpregs_5212.c   (props changed)

Re: gnu/157019: [patch] gcc(1): Add some warnings from OpenBSD gcc and fix a typo.

2011-06-27 Thread Pedro F. Giffuni
--- On Mon, 6/27/11, u...@freebsd.org  wrote:

> Hello Pedro,
> 
> the patch you attached is incomplete/malformed. Could you
> please regenerate and re-send?
> 
Oops, sorry, it was a small newline mismatch.

New patch attached.

regards,

Pedro.

patch-gcc
Description: Binary data
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"

Re: kern/157188: [libpcap] [patch] incorporate patch from upstream

2011-06-27 Thread delphij
Synopsis: [libpcap] [patch] incorporate patch from upstream

State-Changed-From-To: open->patched
State-Changed-By: delphij
State-Changed-When: Tue Jun 28 00:58:18 UTC 2011
State-Changed-Why: 
Patch applied against -HEAD.


Responsible-Changed-From-To: freebsd-bugs->delphij
Responsible-Changed-By: delphij
Responsible-Changed-When: Tue Jun 28 00:58:18 UTC 2011
Responsible-Changed-Why: 
Take.

http://www.freebsd.org/cgi/query-pr.cgi?pr=157188
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


kern/158358: [patch] allow /boot/loader to work from an MBR extended partition

2011-06-27 Thread Gyrd Thane Lange

>Number: 158358
>Category:   kern
>Synopsis:   [patch] allow /boot/loader to work from an MBR extended 
>partition
>Confidential:   no
>Severity:   non-critical
>Priority:   low
>Responsible:freebsd-bugs
>State:  open
>Quarter:
>Keywords:   
>Date-Required:
>Class:  sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 28 01:00:20 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Gyrd Thane Lange
>Release:FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
FreeBSD parvati.thanelange.no 9.0-CURRENT FreeBSD 9.0-CURRENT #7 r221413M: Thu 
May 5 00:22:25 CEST 2011 
r...@parvati.thanelange.no:/usr/obj/usr/src/sys/PARVATI amd64
>Description:
http://parvati.thanelange.no/freebsd/boot_loader/

The FreeBSD loader has since a very long time ago attempted to work
with MBR extended partitions but a simple logical error has prevented
it from succeeding:

How it is supposed to work.

-
| 1 |
-
| 2 | --
-   |
|
|
|
- <-
| 5 |
-
|   | --
-   |
|
|
|
- <-
| 6 |
-
|   |
-


How /boot/loader (incorrectly) works.

-
| 1 |
-
| 2 | --
-   |
|
|
|
- <-
| 5 |
-
| 6 | --
-   |
|
|
|
- <-
| 7 |
-
| 8 |
-
>How-To-Repeat:
Install FreeBSD in an MBR extended partition. (It is easily doable using 
command line tools.)

Attempt to boot.

Observe that the /boot/loader does not find the desired partition.
>Fix:
Using the attached patch:
patch -d /usr/src/sys/boot/i386/libi386/ < boot_loader.diff

Patch is also found here:
http://parvati.thanelange.no/freebsd/boot_loader/boot_loader.diff


Patch attached with submission follows:

--- biosdisk.c.orig 2007-11-13 00:53:43.0 +0100
+++ biosdisk.c  2007-12-29 10:35:30.0 +0100
@@ -162,7 +162,8 @@
 static voidbd_closedisk(struct open_disk *od);
 static int bd_open_mbr(struct open_disk *od, struct i386_devdesc *dev);
 static int bd_bestslice(struct open_disk *od);
-static voidbd_checkextended(struct open_disk *od, int slicenum);
+static voidbd_checkextended(struct open_disk *od, struct dos_partition 
*dp, 
+struct dos_partition *primary_dp);
 static int bd_open_gpt(struct open_disk *od, struct i386_devdesc *dev);
 static struct gpt_part *bd_best_gptpart(struct open_disk *od);
 
@@ -381,6 +382,13 @@
 
switch (dp->dp_typ) {
case DOSPTYP_386BSD:
+   if (verbose)
+   sprintf(line, "%s: BSD %.6dMB (%d - %d)\n",
+   prefix, dp->dp_size / 2048,
+   dp->dp_start, dp->dp_start + dp->dp_size);
+   else
+   sprintf(line, "%s: BSD\n", prefix);
+   pager_output(line);
bd_printbsdslice(od, (daddr_t)dp->dp_start, prefix, verbose);
return;
case DOSPTYP_LINSWP:
@@ -626,7 +634,7 @@
   sizeof(struct dos_partition) * NDOSPART);
 od->od_nslices = 4;/* extended slices start here */
 for (i = 0; i < NDOSPART; i++)
-bd_checkextended(od, i);
+bd_checkextended(od, &od->od_slicetab[i], &od->od_slicetab[i]);
 od->od_flags |= BD_PARTTABOK;
 dptr = &od->od_slicetab[0];
 
@@ -728,16 +736,12 @@
 }
 
 static void
-bd_checkextended(struct open_disk *od, int slicenum)
+bd_checkextended(struct open_disk *od, struct dos_partition *dp, struct 
dos_partition *primary_dp)
 {
charbuf[BIOSDISK_SECSIZE];
-   struct dos_partition *dp;
-   u_int base;
-   int i, start, end;
-
-   dp = &od->od_slicetab[slicenum];
-   start = od->od_nslices;
-
+   int i;
+   struct dos_partition *base_dp;
+   
if (dp->dp_size == 0)
goto done;
if (dp->dp_typ != DOSPTYP_EXT)
@@ -748,24 +752,22 @@
DEBUG("no magic in extended table");
goto done;
}
-   base = dp->dp_start;
+   base_dp = dp;
dp = (struct dos_partition *)(&buf[DOSPARTOFF]);
for (i = 0; i < NDOSPART; i++, dp++) {
if (dp->dp_size == 0)
continue;
if (od->od_nslices == NEXTDOSPART)
goto done;
-   dp->dp_start += base;
-   bcopy(dp, &od->od_slicetab[od->od_nslices], sizeof(*dp));
-   od->od_nslices++;
+   if (dp->dp_typ == DOSPTYP_EXT) {
+   dp->dp_start += primary_dp->dp_start;
+   bd_checkextended(od, dp, primary_dp);
+   } else {
+   dp->dp_start += base_dp->dp_start;
+   bcopy(dp, &od->od_slicetab[od->od_nslices], 
sizeof(*dp));
+   od->od_nslices++;
+   }
}
-   end = od->od_nslices;
-
-   /*
-* now, recursively check the slices we just added
-*/
-

bin/158363: partial restore problem in /sbin/restore

2011-06-27 Thread SATO Jun

>Number: 158363
>Category:   bin
>Synopsis:   partial restore problem in /sbin/restore
>Confidential:   no
>Severity:   non-critical
>Priority:   low
>Responsible:freebsd-bugs
>State:  open
>Quarter:
>Keywords:   
>Date-Required:
>Class:  sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 28 02:10:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: SATO Jun
>Release:7.1
>Organization:
>Environment:
FreeBSD 7.1-STABLE #0: Mon Jan 26 17:43:26 J\st 2009 
/usr/src/sys/amd64/compile/GENERIC amd64
>Description:
Partial restoring using -i or -x option from multi volume backups is failed 
with 'tape is not dump tape'.

>How-To-Repeat:
Dump multi volume and restore with -i or -x option.

>Fix:
--- tape.c~ 2011-06-27 16:30:02.0 +0900
+++ tape.c  2011-06-28 10:08:36.0 +0900
@@ -425,7 +425,7 @@
 gethdr:
volno = newvol;
setdumpnum();
-   FLUSHTAPEBUF();
+   FLUSHTAPEBUF(); numtrec = 0;
if (gethead(&tmpbuf) == FAIL) {
dprintf(stdout, "header read failed at %ld blocks\n", blksread);
fprintf(stderr, "tape is not dump tape\n");


>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"


Re: kern/158369: ioctl SIOCGIFCONF in chroot(2) bug?

2011-06-27 Thread linimon
Old Synopsis: ioctl SIOCGIFCONF in chroot bug?
New Synopsis: ioctl SIOCGIFCONF in chroot(2) bug?

Responsible-Changed-From-To: freebsd-amd64->freebsd-bugs
Responsible-Changed-By: linimon
Responsible-Changed-When: Tue Jun 28 04:13:50 UTC 2011
Responsible-Changed-Why: 
reclassify.

http://www.freebsd.org/cgi/query-pr.cgi?pr=158369
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"