misc/157001: [PATCH] net/bird: add multiple fibs support
>Number: 157001
>Category: misc
>Synopsis: [PATCH] net/bird: add multiple fibs support
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri May 13 10:40:03 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Alexander V. Chernikov
>Release:FreeBSD 8.2-STABLE
>Organization:
JSC "Meganet"
>Environment:
FreeBSD silicium.meganet.ru 8.2-STABLE FreeBSD 8.2-STABLE #1: Mon Apr 18
18:22:06 MSD 2011 r...@silicium.meganet.ru:/usr/obj/usr/src/sys/ROUTER
amd64
>Description:
Changelog:
* Add FIBS option enabling multiple fibs support
* Add LEARN_FIX option enabling simultaneous operation of different routing
software
* Update to 1.3.1
fibs.diff:
this patch shouldn't be taken into upstream, our routing protocol (rtsock)
should be changed to support multiple fibs via single socket. However, for
"here and now" situation this patch can be placed into a port.
learn-krt-sock.c:
by default, bird considers IFF_FLAG1 routes (e.g. all dynamic installed, for
example, by quagga) as own incorrectly installed routes and deletes them. This
is default behavior for all *BSD systems since rtsock doesn't support some kind
of installer identification (caller process pid). This patch makes bird
consider all such routes as any other (non-directly connected) kernel routes.
Problems can arise if used with "persist" kernel option (bird will not delete
such routes after restart and IGP link-up)
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
diff -urN net/bird/Makefile net/bird.new/Makefile
--- net/bird/Makefile 2011-04-12 21:52:18.0 +0400
+++ net/bird.new/Makefile 2011-05-13 12:59:07.639973965 +0400
@@ -6,7 +6,7 @@
#
PORTNAME= bird
-PORTVERSION= 1.3.0
+PORTVERSION= 1.3.1
CATEGORIES=net
MASTER_SITES= ftp://bird.network.cz/pub/bird/
@@ -17,13 +17,26 @@
USE_GMAKE= yes
GNU_CONFIGURE= yes
+OPTIONS= FIBS"Enable multiple fib support" Off \
+ LEARN_FIX "Support multiple routing daemons" Off
+
MAKE_JOBS_UNSAFE= yes
USE_RC_SUBR= bird
+.include
+
+.if defined(WITH_FIBS)
+EXTRA_PATCHES+=${FILESDIR}/fibs.diff
+.endif
+
+.if defined(WITH_LEARN_FIX)
+EXTRA_PATCHES+=${FILESDIR}/learn-krt-sock.c
+.endif
+
post-install:
@if [ ! -f ${PREFIX}/etc/bird.conf ]; then \
${CP} -p ${PREFIX}/etc/bird.conf.example
${PREFIX}/etc/bird.conf ; \
fi
-.include
+.include
diff -urN net/bird/distinfo net/bird.new/distinfo
--- net/bird/distinfo 2011-04-12 21:52:18.0 +0400
+++ net/bird.new/distinfo 2011-05-10 13:32:38.378103543 +0400
@@ -1,2 +1,2 @@
-SHA256 (bird-1.3.0.tar.gz) =
ff90e3ee115a83e2b03a57095132923f66e1fca874dcca7a908075b6c2dc84b3
-SIZE (bird-1.3.0.tar.gz) = 735100
+SHA256 (bird-1.3.1.tar.gz) =
848be209aba6a1a85ae0ed6192710f8bcc2f1257068191fe2959398cdec01afb
+SIZE (bird-1.3.1.tar.gz) = 826422
diff -urN net/bird/files/fibs.diff net/bird.new/files/fibs.diff
--- net/bird/files/fibs.diff1970-01-01 03:00:00.0 +0300
+++ net/bird.new/files/fibs.diff2011-05-10 13:32:09.407955382 +0400
@@ -0,0 +1,126 @@
+diff -urN sysdep/bsd/Modules sysdep/bsd/Modules
+--- sysdep/bsd/Modules 2011-03-31 12:29:42.0 +0400
sysdep/bsd/Modules 2011-05-10 12:04:30.643950460 +0400
+@@ -4,3 +4,4 @@
+ krt-set.h
+ krt-sock.c
+ krt-sock.h
++fib.Y
+diff -urN sysdep/bsd/fib.Y sysdep/bsd/fib.Y
+--- sysdep/bsd/fib.Y 1970-01-01 03:00:00.0 +0300
sysdep/bsd/fib.Y 2011-05-10 12:04:05.724272679 +0400
+@@ -0,0 +1,29 @@
++/*
++ *BIRD -- FreeBSD rtsock configuration
++ *
++ *(c) 2011 Alexander V. Chernikov
++ *
++ *Can be freely distributed and used under the terms of the GNU GPL.
++ */
++
++CF_HDR
++
++CF_DECLS
++
++CF_KEYWORDS(ASYNC, KERNEL, TABLE, KRT_PREFSRC, KRT_REALM)
++
++CF_GRAMMAR
++
++CF_ADDTO(kern_proto, kern_proto rtsock_item ';')
++
++rtsock_item:
++ KERNEL TABLE expr {
++ if ($3 <= 0 || $3 >= max_fib_num())
++cf_error("Kernel routing table number out of range");
++ THIS_KRT->scan.table_id = $3;
++ }
++ ;
++
++CF_CODE
++
++CF_END
+diff -urN sysdep/bsd/krt-scan.h sysdep/bsd/krt-scan.h
+--- sysdep/bsd/krt-scan.h 2011-03-31 12:29:42.0 +0400
sysdep/bsd/krt-scan.h 2011-05-10 11:58:54.812942887 +0400
+@@ -10,6 +10,7 @@
+ #define _BIRD_KRT_SCAN_H_
+
+ struct krt_scan_params {
++ int table_id; /* Kernel table ID we sync with
*/
+ };
+
+ struct krt_scan_status {
+diff -urN sysdep/bsd/krt-sock.c sysdep/bsd/krt-sock.c
+--- sysdep/bsd/krt-sock.c 2011-05-02 12:13:18.0 +0400
sysdep/bsd/krt-sock.c 2011-05-10 12:25:22.075267568 +0400
+@@ -53,6 +53,21 @@
+ );
+ }
+
++int
++max_fib_num()
++{
++ int fibs = 1;
++ size_t fibs_le
Re: kern/143033: commit references a PR
The following reply was made to PR kern/143033; it has been noted by GNATS. From: dfil...@freebsd.org (dfilter service) To: bug-follo...@freebsd.org Cc: Subject: Re: kern/143033: commit references a PR Date: Fri, 13 May 2011 15:49:38 + (UTC) Author: mdf Date: Fri May 13 15:49:23 2011 New Revision: 221843 URL: http://svn.freebsd.org/changeset/base/221843 Log: Note that the _SWAP operation is supported for all list/queue types. Also place STAILQ_REMOVE_HEAD in alphabetical order. Lastly, document the _SWAP macros. PR: kern/143033 MFC after: 1 week Modified: head/share/man/man3/Makefile head/share/man/man3/queue.3 head/sys/sys/queue.h Modified: head/share/man/man3/Makefile == --- head/share/man/man3/Makefile Fri May 13 15:21:31 2011 (r221842) +++ head/share/man/man3/Makefile Fri May 13 15:49:23 2011 (r221843) @@ -53,6 +53,7 @@ MLINKS+= queue.3 LIST_EMPTY.3 \ queue.3 LIST_INSERT_HEAD.3 \ queue.3 LIST_NEXT.3 \ queue.3 LIST_REMOVE.3 \ + queue.3 LIST_SWAP.3 \ queue.3 SLIST_EMPTY.3 \ queue.3 SLIST_ENTRY.3 \ queue.3 SLIST_FIRST.3 \ @@ -67,6 +68,7 @@ MLINKS+= queue.3 LIST_EMPTY.3 \ queue.3 SLIST_REMOVE.3 \ queue.3 SLIST_REMOVE_AFTER.3 \ queue.3 SLIST_REMOVE_HEAD.3 \ + queue.3 SLIST_SWAP.3 \ queue.3 STAILQ_CONCAT.3 \ queue.3 STAILQ_EMPTY.3 \ queue.3 STAILQ_ENTRY.3 \ @@ -84,6 +86,7 @@ MLINKS+= queue.3 LIST_EMPTY.3 \ queue.3 STAILQ_REMOVE.3 \ queue.3 STAILQ_REMOVE_AFTER.3 \ queue.3 STAILQ_REMOVE_HEAD.3 \ + queue.3 STAILQ_SWAP.3 \ queue.3 TAILQ_CONCAT.3 \ queue.3 TAILQ_EMPTY.3 \ queue.3 TAILQ_ENTRY.3 \ @@ -102,7 +105,8 @@ MLINKS+= queue.3 LIST_EMPTY.3 \ queue.3 TAILQ_LAST.3 \ queue.3 TAILQ_NEXT.3 \ queue.3 TAILQ_PREV.3 \ - queue.3 TAILQ_REMOVE.3 + queue.3 TAILQ_REMOVE.3 \ + queue.3 TAILQ_SWAP.3 MLINKS+= stdarg.3 va_arg.3 \ stdarg.3 va_copy.3 \ stdarg.3 va_end.3 \ Modified: head/share/man/man3/queue.3 == --- head/share/man/man3/queue.3Fri May 13 15:21:31 2011 (r221842) +++ head/share/man/man3/queue.3Fri May 13 15:49:23 2011 (r221843) @@ -32,7 +32,7 @@ .\" @(#)queue.3 8.2 (Berkeley) 1/24/94 .\" $FreeBSD$ .\" -.Dd March 24, 2006 +.Dd May 13, 2011 .Dt QUEUE 3 .Os .Sh NAME @@ -50,6 +50,7 @@ .Nm SLIST_REMOVE_AFTER , .Nm SLIST_REMOVE_HEAD , .Nm SLIST_REMOVE , +.Nm SLIST_SWAP , .Nm STAILQ_CONCAT , .Nm STAILQ_EMPTY , .Nm STAILQ_ENTRY , @@ -67,6 +68,7 @@ .Nm STAILQ_REMOVE_AFTER , .Nm STAILQ_REMOVE_HEAD , .Nm STAILQ_REMOVE , +.Nm STAILQ_SWAP , .Nm LIST_EMPTY , .Nm LIST_ENTRY , .Nm LIST_FIRST , @@ -80,6 +82,7 @@ .Nm LIST_INSERT_HEAD , .Nm LIST_NEXT , .Nm LIST_REMOVE , +.Nm LIST_SWAP , .Nm TAILQ_CONCAT , .Nm TAILQ_EMPTY , .Nm TAILQ_ENTRY , @@ -98,7 +101,8 @@ .Nm TAILQ_LAST , .Nm TAILQ_NEXT , .Nm TAILQ_PREV , -.Nm TAILQ_REMOVE +.Nm TAILQ_REMOVE , +.Nm TAILQ_SWAP .Nd implementations of singly-linked lists, singly-linked tail queues, lists and tail queues .Sh SYNOPSIS @@ -118,6 +122,7 @@ lists and tail queues .Fn SLIST_REMOVE_AFTER "TYPE *elm" "SLIST_ENTRY NAME" .Fn SLIST_REMOVE_HEAD "SLIST_HEAD *head" "SLIST_ENTRY NAME" .Fn SLIST_REMOVE "SLIST_HEAD *head" "TYPE *elm" "TYPE" "SLIST_ENTRY NAME" +.Fn SLIST_SWAP "SLIST_HEAD *head1" "SLIST_HEAD *head2" "SLIST_ENTRY NAME" .\" .Fn STAILQ_CONCAT "STAILQ_HEAD *head1" "STAILQ_HEAD *head2" .Fn STAILQ_EMPTY "STAILQ_HEAD *head" @@ -136,6 +141,7 @@ lists and tail queues .Fn STAILQ_REMOVE_AFTER "STAILQ_HEAD *head" "TYPE *elm" "STAILQ_ENTRY NAME" .Fn STAILQ_REMOVE_HEAD "STAILQ_HEAD *head" "STAILQ_ENTRY NAME" .Fn STAILQ_REMOVE "STAILQ_HEAD *head" "TYPE *elm" "TYPE" "STAILQ_ENTRY NAME" +.Fn STAILQ_SWAP "STAILQ_HEAD *head1" "STAILQ_HEAD *head2" "STAILQ_ENTRY NAME" .\" .Fn LIST_EMPTY "LIST_HEAD *head" .Fn LIST_ENTRY "TYPE" @@ -150,6 +156,7 @@ lists and tail queues .Fn LIST_INSERT_HEAD "LIST_HEAD *head" "TYPE *elm" "LIST_ENTRY NAME" .Fn LIST_NEXT "TYPE *elm" "LIST_ENTRY NAME" .Fn LIST_REMOVE "TYPE *elm" "LIST_ENTRY NAME" +.Fn LIST_SWAP "LIST_HEAD *head1" "LIST_HEAD *head2" "TYPE" "LIST_ENTRY NAME" .\" .Fn TAILQ_CONCAT "TAILQ_HEAD *head1" "TAILQ_HEAD *head2" "TAILQ_ENTRY NAME" .Fn TAILQ_EMPTY "TAILQ_HEAD *head" @@ -170,6 +177,7 @@ lists and tail queues .Fn TAILQ_NEXT "TYPE *elm" "TAILQ_ENTRY NAME" .Fn TAILQ_PREV "TYPE *elm" "HEADNAME" "TA
Re: kern/143033: [headers] [patch] _SWAP not listed in comment in sys/queue.h
Synopsis: [headers] [patch] _SWAP not listed in comment in sys/queue.h State-Changed-From-To: open->patched State-Changed-By: mdf State-Changed-When: Fri May 13 15:53:19 UTC 2011 State-Changed-Why: Code patched with r221843. http://www.freebsd.org/cgi/query-pr.cgi?pr=143033 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: ports/157001: [PATCH] net/bird: add multiple fibs support
Synopsis: [PATCH] net/bird: add multiple fibs support Responsible-Changed-From-To: freebsd-bugs->freebsd-ports-bugs Responsible-Changed-By: linimon Responsible-Changed-When: Fri May 13 16:14:45 UTC 2011 Responsible-Changed-Why: ports PR. http://www.freebsd.org/cgi/query-pr.cgi?pr=157001 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/143033: [headers] [patch] _SWAP not listed in comment in sys/queue.h
The following reply was made to PR kern/143033; it has been noted by GNATS. From: Matthew Fleming To: "bug-follo...@freebsd.org" , "jerem...@apple.com" Cc: Subject: Re: kern/143033: [headers] [patch] _SWAP not listed in comment in sys/queue.h Date: Fri, 13 May 2011 12:03:37 -0400 I didn't see a reference to TAILQ_REMOVE_AFTER in CURRENT in either the man p= age or queue.h. So I believe this PR is finished after the MFC. ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/138341: [nanobsd] [patch] 8.0-BETA3: nanobsd build broken due to sysipc kernel module
Synopsis: [nanobsd] [patch] 8.0-BETA3: nanobsd build broken due to sysipc kernel module State-Changed-From-To: open->closed State-Changed-By: imp State-Changed-When: Fri May 13 12:18:36 MDT 2011 State-Changed-Why: This has been fixed in head, and merged back to 8, as far as I Can tell. If anything else is broken, please let me know. http://www.freebsd.org/cgi/query-pr.cgi?pr=138341 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/144553: [nanobsd] NanoBSD's updatep* scripts fail with boot0cfg: vnode_pager_getpages: I/O read error
Synopsis: [nanobsd] NanoBSD's updatep* scripts fail with boot0cfg: vnode_pager_getpages: I/O read error State-Changed-From-To: open->patched State-Changed-By: imp State-Changed-When: Fri May 13 12:23:10 MDT 2011 State-Changed-Why: This has already been fixed in -current. Haven't MFC'd this to 8 yet, I don't think. Will verify and merge and/or close. Responsible-Changed-From-To: freebsd-bugs->imp Responsible-Changed-By: imp Responsible-Changed-When: Fri May 13 12:23:10 MDT 2011 Responsible-Changed-Why: foo http://www.freebsd.org/cgi/query-pr.cgi?pr=144553 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/138341: commit references a PR
The following reply was made to PR kern/138341; it has been noted by GNATS.
From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:
Subject: Re: kern/138341: commit references a PR
Date: Fri, 13 May 2011 18:20:34 + (UTC)
Author: imp
Date: Fri May 13 18:20:24 2011
New Revision: 221849
URL: http://svn.freebsd.org/changeset/base/221849
Log:
MFC: 197075, 209442, 213781: Various fixes for MODULES_WITH_WORLD
r197075 | n_hibma | 2009-09-10 13:12:08 -0600 (Thu, 10 Sep 2009) | 4
lines
Missing opt_*.h file reference for make depend in sys/modules
r209442 | thompsa | 2010-06-22 14:52:35 -0600 (Tue, 22 Jun 2010) | 4
lines
Add missing opt_compat.h dependency.
r213781 | rpaulo | 2010-10-13 08:44:38 -0600 (Wed, 13 Oct 2010) | 2 lines
Add opt_compat.h to SRCS.
PR: 138341
Modified:
stable/8/sys/modules/cryptodev/Makefile
stable/8/sys/modules/dtrace/lockstat/Makefile
stable/8/sys/modules/mqueue/Makefile
stable/8/sys/modules/sysvipc/sysvmsg/Makefile
stable/8/sys/modules/sysvipc/sysvsem/Makefile
Directory Properties:
stable/8/sys/ (props changed)
stable/8/sys/amd64/include/xen/ (props changed)
stable/8/sys/cddl/contrib/opensolaris/ (props changed)
stable/8/sys/contrib/dev/acpica/ (props changed)
stable/8/sys/contrib/pf/ (props changed)
Modified: stable/8/sys/modules/cryptodev/Makefile
==
--- stable/8/sys/modules/cryptodev/MakefileFri May 13 17:50:30 2011
(r221848)
+++ stable/8/sys/modules/cryptodev/MakefileFri May 13 18:20:24 2011
(r221849)
@@ -3,6 +3,6 @@
.PATH:${.CURDIR}/../../opencrypto
KMOD = cryptodev
SRCS = cryptodev.c
-SRCS += bus_if.h device_if.h
+SRCS += bus_if.h device_if.h opt_compat.h
.include
Modified: stable/8/sys/modules/dtrace/lockstat/Makefile
==
--- stable/8/sys/modules/dtrace/lockstat/Makefile Fri May 13 17:50:30
2011(r221848)
+++ stable/8/sys/modules/dtrace/lockstat/Makefile Fri May 13 18:20:24
2011(r221849)
@@ -5,7 +5,7 @@
KMOD= lockstat
SRCS= lockstat.c
-SRCS+=vnode_if.h
+SRCS+=vnode_if.h opt_kdtrace.h
CFLAGS+= -I${.CURDIR}/../../../cddl/compat/opensolaris \
-I${.CURDIR}/../../../cddl/contrib/opensolaris/uts/common \
Modified: stable/8/sys/modules/mqueue/Makefile
==
--- stable/8/sys/modules/mqueue/Makefile Fri May 13 17:50:30 2011
(r221848)
+++ stable/8/sys/modules/mqueue/Makefile Fri May 13 18:20:24 2011
(r221849)
@@ -5,6 +5,6 @@
KMOD= mqueuefs
SRCS= uipc_mqueue.c \
vnode_if.h \
- opt_posix.h
+ opt_posix.h opt_compat.h
.include
Modified: stable/8/sys/modules/sysvipc/sysvmsg/Makefile
==
--- stable/8/sys/modules/sysvipc/sysvmsg/Makefile Fri May 13 17:50:30
2011(r221848)
+++ stable/8/sys/modules/sysvipc/sysvmsg/Makefile Fri May 13 18:20:24
2011(r221849)
@@ -3,6 +3,6 @@
.PATH: ${.CURDIR}/../../../kern
KMOD= sysvmsg
-SRCS= sysv_msg.c opt_sysvipc.h
+SRCS= sysv_msg.c opt_sysvipc.h opt_compat.h
.include
Modified: stable/8/sys/modules/sysvipc/sysvsem/Makefile
==
--- stable/8/sys/modules/sysvipc/sysvsem/Makefile Fri May 13 17:50:30
2011(r221848)
+++ stable/8/sys/modules/sysvipc/sysvsem/Makefile Fri May 13 18:20:24
2011(r221849)
@@ -3,6 +3,6 @@
.PATH: ${.CURDIR}/../../../kern
KMOD= sysvsem
-SRCS= sysv_sem.c opt_sysvipc.h
+SRCS= sysv_sem.c opt_sysvipc.h opt_compat.h
.include
___
svn-src-...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: conf/96746: [nanobsd] [patch] Configuration changes and README for nanobsd
Synopsis: [nanobsd] [patch] Configuration changes and README for nanobsd State-Changed-From-To: open->closed State-Changed-By: imp State-Changed-When: Fri May 13 12:40:34 MDT 2011 State-Changed-Why: This has been OBE. Just closing. The fixes to nanobsd.sh are in the tree already in different forms. The sokris config uses the old NO_FOO settings and would need to be significantly reworked to be good in the current tree. If there's patches that are relevant to 8 or -current, please resubmit and I'll commit. http://www.freebsd.org/cgi/query-pr.cgi?pr=96746 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/123240: [nanobsd] [patch] rerunning nanobsd.inc.sh fails because of existing directory
Synopsis: [nanobsd] [patch] rerunning nanobsd.inc.sh fails because of existing directory State-Changed-From-To: open->closed State-Changed-By: imp State-Changed-When: Fri May 13 12:43:00 MDT 2011 State-Changed-Why: This bug has been fixed a long time ago now. http://www.freebsd.org/cgi/query-pr.cgi?pr=123240 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/157013: Bizarre file descriptor race condition
>Number: 157013
>Category: misc
>Synopsis: Bizarre file descriptor race condition
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri May 13 19:20:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Aragon Gouveia
>Release:8.2-STABLE
>Organization:
>Environment:
FreeBSD igor.geek.sh 8.2-STABLE FreeBSD 8.2-STABLE #2: Thu May 5 14:52:46 SAST
2011 t...@igor.geek.sh:/usr/obj/usr/src-RELENG_8/sys/IGOR amd64
>Description:
Please see the script pasted in the repeat field.
When it is run, the while loop exits after the first iteration. However, if
the ssh command is commented, the loop executes two iterations.
Stranger still, on some of my FreeBSD systems the script works correctly
_sometimes_, but mostly not.
>How-To-Repeat:
#!/bin/sh
DFRTMP=$(mktemp -d /tmp/dfr.XX)
[ $? -eq 0 ] || exit 1
cat >${DFRTMP}/hosts <<"_EOF"
1 saturn.geek.sh
2 null
_EOF
while read hostid hostname; do
echo ${hostid}:${hostname}
ssh ${hostname} 'df -k'
done <${DFRTMP}/hosts
rm -rf ${DFRTMP}
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/140173: [nanobsd] [patch] Small nanobsd pkg install change
Synopsis: [nanobsd] [patch] Small nanobsd pkg install change State-Changed-From-To: open->closed State-Changed-By: imp State-Changed-When: Fri May 13 13:30:09 MDT 2011 State-Changed-Why: Thanks for the patch. Somebody committed it already, so this just needs to be closed. http://www.freebsd.org/cgi/query-pr.cgi?pr=140173 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/140436: [nanobsd] pkg-add process fails when there is no /usr/src/tools/tools/nanobsd/Pkg directory
Synopsis: [nanobsd] pkg-add process fails when there is no /usr/src/tools/tools/nanobsd/Pkg directory State-Changed-From-To: open->patched State-Changed-By: imp State-Changed-When: Fri May 13 13:40:12 MDT 2011 State-Changed-Why: Fixed... http://www.freebsd.org/cgi/query-pr.cgi?pr=140436 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/145395: [nanobsd] [patch] Extremely slow nanobsd disk image creation and 100% disk load on zfs
Synopsis: [nanobsd] [patch] Extremely slow nanobsd disk image creation and 100% disk load on zfs State-Changed-From-To: open->closed State-Changed-By: imp State-Changed-When: Fri May 13 13:44:33 MDT 2011 State-Changed-Why: We've been doing async for a while now. Bug OBE. http://www.freebsd.org/cgi/query-pr.cgi?pr=145395 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/145961: [patch] [nanobsd] improved flash update script
Synopsis: [patch] [nanobsd] improved flash update script State-Changed-From-To: open->closed State-Changed-By: imp State-Changed-When: Fri May 13 13:46:32 MDT 2011 State-Changed-Why: Similar functionality has been adapoted. Should be OK to close. Please let me know if I've overlooked something. http://www.freebsd.org/cgi/query-pr.cgi?pr=145961 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/140436: commit references a PR
The following reply was made to PR misc/140436; it has been noted by GNATS.
From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:
Subject: Re: misc/140436: commit references a PR
Date: Fri, 13 May 2011 19:40:16 + (UTC)
Author: imp
Date: Fri May 13 19:40:02 2011
New Revision: 221856
URL: http://svn.freebsd.org/changeset/base/221856
Log:
If there's no package directory, don't try to install packages from
it. Instead, report that 0 packages are reported.
PR: misc/140436
Modified:
head/tools/tools/nanobsd/nanobsd.sh
Modified: head/tools/tools/nanobsd/nanobsd.sh
==
--- head/tools/tools/nanobsd/nanobsd.shFri May 13 19:35:01 2011
(r221855)
+++ head/tools/tools/nanobsd/nanobsd.shFri May 13 19:40:02 2011
(r221856)
@@ -684,6 +684,12 @@ cust_install_files () (
cust_pkg () (
+ # If the package directory doesn't exist, we're done.
+ if [ ! -d ${NANO_PACKAGE_DIR} ]; then
+ echo "DONE 0 packages"
+ return 0
+ fi
+
# Copy packages into chroot
mkdir -p ${NANO_WORLDDIR}/Pkg
(
___
svn-src-...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/145962: [nanobsd] [patch] improved cfg save script
Synopsis: [nanobsd] [patch] improved cfg save script Responsible-Changed-From-To: freebsd-bugs->imp Responsible-Changed-By: imp Responsible-Changed-When: Fri May 13 13:55:00 MDT 2011 Responsible-Changed-Why: This looks good. I'll integrate. http://www.freebsd.org/cgi/query-pr.cgi?pr=145962 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/157015: bsnmpd does not create 64bit counters for interfaces without link
>Number: 157015 >Category: misc >Synopsis: bsnmpd does not create 64bit counters for interfaces without >link >Confidential: no >Severity: non-critical >Priority: medium >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri May 13 20:00:19 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Kurt Lidl >Release:8.2p1 >Organization: Cello Software LLC >Environment: FreeBSD extgw.fairview-park.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011 r...@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: On a machine with 4 ethernet interfaces (two on-board, two on a single dual-port PCI card), I noticed the following. Interfaces fxp0, fxp1 are on the PCI card. Interfaces fxp2, fxp3 are on the motherboard. Interfaces fxp0, fxp2, fxp3 are plugged into ethernet switches. Interface fxp1 is not plugged into anything, but configured "UP". Using snmpwalk, I see the following: # snmpwalk -v2c -c XXX gatewayname 1.3.6.1.2.1.31.1.1.1 IF-MIB::ifName.1 = STRING: fxp0 IF-MIB::ifName.2 = STRING: fxp1 IF-MIB::ifName.3 = STRING: fxp2 IF-MIB::ifName.4 = STRING: fxp3 IF-MIB::ifName.5 = STRING: lo0 IF-MIB::ifInMulticastPkts.1 = Counter32: 2294 IF-MIB::ifInMulticastPkts.2 = Counter32: 0 IF-MIB::ifInMulticastPkts.3 = Counter32: 1486 IF-MIB::ifInMulticastPkts.4 = Counter32: 43 IF-MIB::ifInMulticastPkts.5 = Counter32: 0 IF-MIB::ifInBroadcastPkts.1 = Counter32: 0 IF-MIB::ifInBroadcastPkts.2 = Counter32: 0 IF-MIB::ifInBroadcastPkts.3 = Counter32: 0 IF-MIB::ifInBroadcastPkts.4 = Counter32: 0 IF-MIB::ifInBroadcastPkts.5 = Counter32: 0 IF-MIB::ifOutMulticastPkts.1 = Counter32: 0 IF-MIB::ifOutMulticastPkts.2 = Counter32: 0 IF-MIB::ifOutMulticastPkts.3 = Counter32: 9 IF-MIB::ifOutMulticastPkts.4 = Counter32: 0 IF-MIB::ifOutMulticastPkts.5 = Counter32: 0 IF-MIB::ifOutBroadcastPkts.1 = Counter32: 0 IF-MIB::ifOutBroadcastPkts.2 = Counter32: 0 IF-MIB::ifOutBroadcastPkts.3 = Counter32: 0 IF-MIB::ifOutBroadcastPkts.4 = Counter32: 0 IF-MIB::ifOutBroadcastPkts.5 = Counter32: 0 IF-MIB::ifHCInOctets.1 = Counter64: 766678 IF-MIB::ifHCInOctets.3 = Counter64: 22034061 IF-MIB::ifHCInOctets.4 = Counter64: 57896044 IF-MIB::ifHCInUcastPkts.1 = Counter64: 18446744073709551613 IF-MIB::ifHCInUcastPkts.3 = Counter64: 62323 IF-MIB::ifHCInUcastPkts.4 = Counter64: 65222 IF-MIB::ifHCInMulticastPkts.1 = Counter64: 2294 IF-MIB::ifHCInMulticastPkts.3 = Counter64: 1486 IF-MIB::ifHCInMulticastPkts.4 = Counter64: 43 IF-MIB::ifHCInBroadcastPkts.1 = Counter64: 0 IF-MIB::ifHCInBroadcastPkts.3 = Counter64: 0 IF-MIB::ifHCInBroadcastPkts.4 = Counter64: 0 IF-MIB::ifHCOutOctets.1 = Counter64: 0 IF-MIB::ifHCOutOctets.3 = Counter64: 58266640 IF-MIB::ifHCOutOctets.4 = Counter64: 20901937 IF-MIB::ifHCOutUcastPkts.1 = Counter64: 0 IF-MIB::ifHCOutUcastPkts.3 = Counter64: 71308 IF-MIB::ifHCOutUcastPkts.4 = Counter64: 53540 IF-MIB::ifHCOutMulticastPkts.1 = Counter64: 0 IF-MIB::ifHCOutMulticastPkts.3 = Counter64: 9 IF-MIB::ifHCOutMulticastPkts.4 = Counter64: 0 IF-MIB::ifHCOutBroadcastPkts.1 = Counter64: 0 IF-MIB::ifHCOutBroadcastPkts.3 = Counter64: 0 IF-MIB::ifHCOutBroadcastPkts.4 = Counter64: 0 IF-MIB::ifLinkUpDownTrapEnable.1 = INTEGER: enabled(1) IF-MIB::ifLinkUpDownTrapEnable.2 = INTEGER: enabled(1) IF-MIB::ifLinkUpDownTrapEnable.3 = INTEGER: enabled(1) IF-MIB::ifLinkUpDownTrapEnable.4 = INTEGER: enabled(1) IF-MIB::ifLinkUpDownTrapEnable.5 = INTEGER: disabled(2) IF-MIB::ifHighSpeed.1 = Gauge32: 100 IF-MIB::ifHighSpeed.2 = Gauge32: 0 IF-MIB::ifHighSpeed.3 = Gauge32: 100 IF-MIB::ifHighSpeed.4 = Gauge32: 100 IF-MIB::ifHighSpeed.5 = Gauge32: 0 IF-MIB::ifPromiscuousMode.1 = INTEGER: false(2) IF-MIB::ifPromiscuousMode.2 = INTEGER: false(2) IF-MIB::ifPromiscuousMode.3 = INTEGER: false(2) IF-MIB::ifPromiscuousMode.4 = INTEGER: false(2) IF-MIB::ifPromiscuousMode.5 = INTEGER: false(2) IF-MIB::ifConnectorPresent.1 = INTEGER: true(1) IF-MIB::ifConnectorPresent.2 = INTEGER: true(1) IF-MIB::ifConnectorPresent.3 = INTEGER: true(1) IF-MIB::ifConnectorPresent.4 = INTEGER: true(1) IF-MIB::ifConnectorPresent.5 = INTEGER: false(2) IF-MIB::ifAlias.1 = STRING: IF-MIB::ifAlias.2 = STRING: IF-MIB::ifAlias.3 = STRING: IF-MIB::ifAlias.4 = STRING: IF-MIB::ifAlias.5 = STRING: IF-MIB::ifCounterDiscontinuityTime.1 = Timeticks: (0) 0:00:00.00 IF-MIB::ifCounterDiscontinuityTime.2 = Timeticks: (0) 0:00:00.00 IF-MIB::ifCounterDiscontinuityTime.3 = Timeticks: (0) 0:00:00.00 IF-MIB::ifCounterDiscontinuityTime.4 = Timeticks: (0) 0:00:00.00 IF-MIB::ifCounterDiscontinuityTime.5 = Timeticks: (0) 0:00:00.00 As you can see, the .2 interface (== fxp1) doesn't have 64bit counters available. (And it looks like the .1 interface (== fxp0) doesn't have a valid ifHCInUcastPkts field either. The value 18446744073709551613 is suspiciously close to 16*1024^5, in fact, just 3 short of it. Given that the machine wa
bin/157017: "vidcontrol -r" no longer works
>Number: 157017 >Category: bin >Synopsis: "vidcontrol -r" no longer works >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri May 13 20:50:06 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Jens Schweikhardt >Release:9.0-CURRENT >Organization: >Environment: FreeBSD hal9000.schweikhardt.net 9.0-CURRENT FreeBSD 9.0-CURRENT #17 r221230: Sat Apr 30 00:13:35 CEST 2011 t...@hal9000.schweikhardt.net:/usr/obj/home/root/FreeBSD/head/src/sys/HAL9000 i386 >Description: Apparently, "vidcontrol -r foreground background" no longer works. I don't know when exactly it stopped. I use it via /etc/rc.conf with allscreens_flags="-r cyan blue" The symptom is that running "man man" still uses black on white for reverse video instead of cyan and blue. My TERM is cons31l. >How-To-Repeat: To reproduce: $ vidcontrol -r cyan blue $ man man >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
gnu/157019: gcc: Add some warnings from OpenBSD gcc and fix a typo.
>Number: 157019
>Category: gnu
>Synopsis: gcc: Add some warnings from OpenBSD gcc and fix a typo.
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri May 13 22:30:08 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Pedro Giffuni
>Release:8.2-Release
>Organization:
>Environment:
FreeBSD mogwai.giffuni.net 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Mar 18
15:35:09 UTC 2011
r...@mogwai.giffuni.net:/usr/src/sys/amd64/compile/GENERIC amd64
>Description:
While looking for some unrelated fixes, I found these simple
patches for gcc-4.2.1 from OpenBSD's tree.
- Implement -Wvariable-decl.
- port -Wtrampolines support from gcc3. (I took out -ftrampolines since it
seems excessive for FreeBSD).
- Fix typo in check_for_nested_with_variably_modified present
for 4 years that hampered the inliner without anyone noticing.
>How-To-Repeat:
>Fix:
Patch attached.
Patch attached with submission follows:
--- gcc/c-decl.c2009/10/15 18:11:28 1.1
+++ gcc/c-decl.c2010/04/29 19:37:37 1.2
@@ -4256,6 +4256,8 @@ grokdeclarator (const struct c_declarator *declarator,
pedwarn ("ISO C90 forbids variable-size array %qs",
name);
}
+ if (warn_variable_decl)
+ warning (0, "variable-sized array %qs", name);
}
if (integer_zerop (size))
--- gcc/c.opt 2010/05/09 14:09:18 1.2
+++ gcc/c.opt 2010/05/12 14:35:56 1.3
@@ -407,6 +407,10 @@ Wtraditional
C ObjC Var(warn_traditional)
Warn about features not present in traditional C
+Wtrampolines
+Common Var(warn_trampolines)
+Warn when trampolines are emitted
+
Wtrigraphs
C ObjC C++ ObjC++
Warn if trigraphs are encountered that might affect the meaning of the program
--- gcc/common.opt 2010/04/28 07:27:02 1.4
+++ gcc/common.opt 2010/04/29 19:37:37 1.5
@@ -193,6 +193,10 @@ Wunused-variable
Common Var(warn_unused_variable)
Warn when a variable is unused
+Wvariable-decl
+Common Var(warn_variable_decl)
+Warn about variable-sized declarations.
+
Wvolatile-register-var
Common Var(warn_register_var)
Warn when a register variable is declared volatile
--- gcc/tree-nested.c 2009/10/15 18:11:28 1.1.1.1
+++ gcc/tree-nested.c 2010/05/12 14:35:56 1.3
@@ -750,7 +750,7 @@ check_for_nested_with_variably_modified (tree fndecl,
for (cgn = cgn->nested; cgn ; cgn = cgn->next_nested)
{
for (arg = DECL_ARGUMENTS (cgn->decl); arg; arg = TREE_CHAIN (arg))
- if (variably_modified_type_p (TREE_TYPE (arg), 0), orig_fndecl)
+ if (variably_modified_type_p (TREE_TYPE (arg), orig_fndecl))
return true;
if (check_for_nested_with_variably_modified (cgn->decl, orig_fndecl))
@@ -1622,6 +1622,15 @@ convert_tramp_reference (tree *tp, int *walk_subtrees,
if (DECL_NO_STATIC_CHAIN (decl))
break;
+ if (warn_trampolines)
+{
+ warning(0, "local function address taken needing trampoline
generation");
+}
/* Lookup the immediate parent of the callee, as that's where
we need to insert the trampoline. */
for (i = info; i->context != target_context; i = i->outer)
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: conf/155738: [patch] reaper of the dead: time to BURN_BRIDGES and remove bsd.compat.mk
Synopsis: [patch] reaper of the dead: time to BURN_BRIDGES and remove bsd.compat.mk Responsible-Changed-From-To: freebsd-bugs->portmgr Responsible-Changed-By: eadler Responsible-Changed-When: Fri May 13 22:47:58 UTC 2011 Responsible-Changed-Why: exp-run request http://www.freebsd.org/cgi/query-pr.cgi?pr=155738 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: conf/155737: [patch] reaper of the dead: remove OBJFORMAT variable in share/mk/sys.mk
Synopsis: [patch] reaper of the dead: remove OBJFORMAT variable in share/mk/sys.mk Responsible-Changed-From-To: freebsd-bugs->portmgr Responsible-Changed-By: eadler Responsible-Changed-When: Fri May 13 22:50:48 UTC 2011 Responsible-Changed-Why: exp-run request http://www.freebsd.org/cgi/query-pr.cgi?pr=155737 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/157020: [nanobsd] Restore nanobsd.sh $NANO_BOOT2CFG functionality
>Number: 157020
>Category: misc
>Synopsis: [nanobsd] Restore nanobsd.sh $NANO_BOOT2CFG functionality
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri May 13 23:00:15 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Henrik Brix Andersen
>Release:FreeBSD 9.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD drpepper.brixandersen.dk 9.0-CURRENT FreeBSD 9.0-CURRENT #2
r221582M: Thu May 12 23:24:30 CEST 2011
r...@drpepper.brixandersen.dk:/usr/obj/usr/home/brix/projects/freebsd/src/head/sys/GENERIC
i386
>Description:
The ability to set custom options for boot2 in nanobsd.sh added in r209210 was
(accidentially?) removed in r212938.
>How-To-Repeat:
>Fix:
This patch restores the above functionality.
--- nanobsd.sh.diff begins here ---
Index: tools/tools/nanobsd/nanobsd.sh
===
--- tools/tools/nanobsd/nanobsd.sh (revision 221859)
+++ tools/tools/nanobsd/nanobsd.sh (working copy)
@@ -660,7 +660,7 @@
sed -i "" -e '/^ttyv[0-8]/s/on/ off/' ${NANO_WORLDDIR}/etc/ttys
# Tell loader to use serial console early.
- echo " -h" > ${NANO_WORLDDIR}/boot.config
+ echo "${NANO_BOOT2CFG}" > ${NANO_WORLDDIR}/boot.config
)
###
--- nanobsd.sh.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/157013: Bizarre file descriptor race condition
Synopsis: Bizarre file descriptor race condition
State-Changed-From-To: open->closed
State-Changed-By: jilles
State-Changed-When: Fri May 13 23:18:18 UTC 2011
State-Changed-Why:
This is not a bug but a fairly common caveat with ssh(1).
The problem is that ssh(1) does not know if the other side wants
input and therefore it reads data and sends it to the other side.
Once data has been read from a pipe there is no way to put it back.
It would be possible with a regular file but determining the amount
to put back would be very complicated and unreliable.
If the other side is very fast, it might finish executing the
command before ssh(1) attempts its first read and the script
might work as intended.
You can solve the problem by redirecting ssh's input (either with
shell redirection or with the -n option) or by using a different
file descriptor for the list, like:
while read hostid hostname <&3; do
echo ${hostid}:${hostname}
ssh ${hostname} 'df -k'
done 3<${DFRTMP}/hosts
Responsible-Changed-From-To: freebsd-bugs->jilles
Responsible-Changed-By: jilles
Responsible-Changed-When: Fri May 13 23:18:18 UTC 2011
Responsible-Changed-Why:
Track.
http://www.freebsd.org/cgi/query-pr.cgi?pr=157013
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/157020: [nanobsd] Restore nanobsd.sh $NANO_BOOT2CFG functionality
Synopsis: [nanobsd] Restore nanobsd.sh $NANO_BOOT2CFG functionality Responsible-Changed-From-To: freebsd-bugs->imp Responsible-Changed-By: linimon Responsible-Changed-When: Sat May 14 01:47:42 UTC 2011 Responsible-Changed-Why: Over to a likely suspect. http://www.freebsd.org/cgi/query-pr.cgi?pr=157020 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
gnu/157025: gcc Bug 28796 - __builtin_nan() and __builtin_unordered() inconsistent
>Number: 157025
>Category: gnu
>Synopsis: gcc Bug 28796 - __builtin_nan() and __builtin_unordered()
>inconsistent
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat May 14 02:30:06 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Pedro Giffuni
>Release:8.2-Release
>Organization:
>Environment:
FreeBSD mogwai.giffuni.net 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Mar 18
15:35:09 UTC 2011
r...@mogwai.giffuni.net:/usr/src/sys/amd64/compile/GENERIC amd64
>Description:
As can be read in the top of Apple's gcc Changelog:
http://opensource.apple.com/source/gcc/gcc-5664/gcc/ChangeLog
The following commit was made:
2006-10-24 Richard Guenther
Radar 5675014
PR middle-end/28796
* builtins.c (fold_builtin_classify): Use HONOR_INFINITIES
and HONOR_NANS instead of MODE_HAS_INFINITIES and MODE_HAS_NANS
for deciding optimizations in consistency with fold-const.c
(fold_builtin_unordered_cmp): Likewise.
___
Applying this will make our base compiler behave consistently
with -ffinite-math-only and is in accordance to what clang
and newer GCCs do.
>How-To-Repeat:
There is a testcase in gcc bug 28796
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28796
FWIW, This was reported in gnu/153298 too but it was obviated
because the other patches were more important.
>Fix:
Patch attached.
Patch attached with submission follows:
--- gcc/builtins.c.orig 2007-05-19 02:12:19.0 +
+++ gcc/builtins.c 2011-05-13 20:58:56.0 +
@@ -8720,7 +8720,7 @@
switch (builtin_index)
{
case BUILT_IN_ISINF:
- if (!MODE_HAS_INFINITIES (TYPE_MODE (TREE_TYPE (arg
+ if (!HONOR_INFINITIES (TYPE_MODE (TREE_TYPE (arg
return omit_one_operand (type, integer_zero_node, arg);
if (TREE_CODE (arg) == REAL_CST)
@@ -8736,8 +8736,8 @@
return NULL_TREE;
case BUILT_IN_FINITE:
- if (!MODE_HAS_NANS (TYPE_MODE (TREE_TYPE (arg)))
- && !MODE_HAS_INFINITIES (TYPE_MODE (TREE_TYPE (arg
+ if (!HONOR_NANS (TYPE_MODE (TREE_TYPE (arg)))
+ && !HONOR_INFINITIES (TYPE_MODE (TREE_TYPE (arg
return omit_one_operand (type, integer_zero_node, arg);
if (TREE_CODE (arg) == REAL_CST)
@@ -8750,7 +8750,7 @@
return NULL_TREE;
case BUILT_IN_ISNAN:
- if (!MODE_HAS_NANS (TYPE_MODE (TREE_TYPE (arg
+ if (!HONOR_NANS (TYPE_MODE (TREE_TYPE (arg
return omit_one_operand (type, integer_zero_node, arg);
if (TREE_CODE (arg) == REAL_CST)
@@ -8833,13 +8833,13 @@
if (unordered_code == UNORDERED_EXPR)
{
- if (!MODE_HAS_NANS (TYPE_MODE (TREE_TYPE (arg0
+ if (!HONOR_NANS (TYPE_MODE (TREE_TYPE (arg0
return omit_two_operands (type, integer_zero_node, arg0, arg1);
return fold_build2 (UNORDERED_EXPR, type, arg0, arg1);
}
- code = MODE_HAS_NANS (TYPE_MODE (TREE_TYPE (arg0))) ? unordered_code
- : ordered_code;
+ code = HONOR_NANS (TYPE_MODE (TREE_TYPE (arg0))) ? unordered_code
+ : ordered_code;
return fold_build1 (TRUTH_NOT_EXPR, type,
fold_build2 (code, type, arg0, arg1));
}
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
