Re: kern/124164: [patch] Add SHA-256/512 hash algorithm to crypt(3)
Synopsis: [patch] Add SHA-256/512 hash algorithm to crypt(3) Responsible-Changed-From-To: freebsd-bugs->markm Responsible-Changed-By: markm Responsible-Changed-When: Sun Jan 30 09:50:32 UTC 2011 Responsible-Changed-Why: I've done crypt(3) in the past; may as well pick this one up. http://www.freebsd.org/cgi/query-pr.cgi?pr=124164 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
misc/154395: [patch] remove obsolete
>Number: 154395 >Category: misc >Synopsis: [patch] remove obsolete >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jan 30 15:20:10 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Eitan Adler >Release: >Organization: >Environment: >Description: grep -ER "{(SYSTEM|SYSLIB|LOCALLIB)DIR" /usr/ports turns up only one port which depends on the 4 obsolete variables defined in bsd.gnustep.mk I do not use gnustep so I am unable to test the following patch but the touched port along with a few other gnustep ports seem ok. >How-To-Repeat: >Fix: Index: Mk/bsd.gnustep.mk === RCS file: /home/ncvs/ports/Mk/bsd.gnustep.mk,v retrieving revision 1.63 diff -u -r1.63 bsd.gnustep.mk --- Mk/bsd.gnustep.mk 11 Jun 2010 09:12:37 - 1.63 +++ Mk/bsd.gnustep.mk 30 Jan 2011 14:48:27 - @@ -189,12 +189,6 @@ GNUSTEP_LOCAL_TOOLS= ${GNUSTEP_LOCAL_ROOT}/Tools GNUSTEP_LOCAL_SERVICES=${GNUSTEP_LOCAL_ROOT}/Library/Services -# Obsolete, for compatibility only -SYSTEMDIR= ${GNUSTEP_SYSTEM_ROOT} -SYSMAKEDIR=${GNUSTEP_MAKEFILES} -SYSLIBDIR= ${GNUSTEP_SYSTEM_LIBRARIES} -LOCALLIBDIR= ${GNUSTEP_LOCAL_LIBRARIES} - .if defined(WITH_GNUSTEP_DEVEL) PKGNAMESUFFIX?=-devel${PKGNAMESUFFIX2} PLIST_SUB+=GNUSTEP_DEVEL="" Index: Makefile === RCS file: /home/ncvs/ports/x11-themes/etoile-camaelon/Makefile,v retrieving revision 1.14 diff -u -r1.14 Makefile --- Makefile5 Jun 2010 06:14:27 - 1.14 +++ Makefile30 Jan 2011 14:54:14 - @@ -36,9 +36,9 @@ @${CAT} ${PKGMESSAGE} install-user: - @(. ${SYSMAKEDIR}/GNUstep.sh && defaults write Camaelon Theme Nesedah) + @(. ${GNUSTEP_MAKEFILES}/GNUstep.sh && defaults write Camaelon Theme Nesedah) deinstall-user: - @(. ${SYSMAKEDIR}/GNUstep.sh && defaults delete Camaelon Theme) + @(. ${GNUSTEP_MAKEFILES}/GNUstep.sh && defaults delete Camaelon Theme) .include >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: ports/154395: [bsd.gnustep.mk] [patch] remove obsolete variables
Old Synopsis: [patch] remove obsolete New Synopsis: [bsd.gnustep.mk] [patch] remove obsolete variables Responsible-Changed-From-To: freebsd-bugs->dinoex Responsible-Changed-By: linimon Responsible-Changed-When: Sun Jan 30 20:35:26 UTC 2011 Responsible-Changed-Why: Fix synopsis and assign. http://www.freebsd.org/cgi/query-pr.cgi?pr=154395 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: gnu/154385: Minor fixes to contrib/libstdc++
The following reply was made to PR gnu/154385; it has been noted by GNATS. From: "Pedro F. Giffuni" To: freebsd-gnats-sub...@freebsd.org Cc: Subject: Re: gnu/154385: Minor fixes to contrib/libstdc++ Date: Sun, 30 Jan 2011 14:25:19 -0800 (PST) --0-869839225-1296426319=:26178 Content-Type: text/plain; charset=us-ascii Apparently this patch has all that's needed. --0-869839225-1296426319=:26178 Content-Type: text/plain; name="patch-libstdc++.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch-libstdc++.txt" LS0tIGxpYnN0ZGMrKy9pbmNsdWRlL3N0ZC9zdGRfdmFsYXJyYXkuaAkyMDA3 LzAxLzE1IDE2OjQ1OjQ0CTEyMDc5OQorKysgbGlic3RkYysrL2luY2x1ZGUv c3RkL3N0ZF92YWxhcnJheS5oCTIwMDcvMDgvMTcgMDk6Mjg6MDkJMTI3NTgw CkBAIC0xMDEwLDcgKzEwMTAsNyBAQAogICAgIHsJCQkJCQkJCQlcCiAgICAg ICB0eXBlZGVmIF9CaW5DbG9zPF9OYW1lLCBfQ29uc3RhbnQsIF9WYWxBcnJh eSwgX1RwLCBfVHA+IF9DbG9zdXJlOyBcCiAgICAgICB0eXBlZGVmIHR5cGVu YW1lIF9fZnVuPF9OYW1lLCBfVHA+OjpyZXN1bHRfdHlwZSBfUnQ7ICAgICAg ICAgICAgICBcCi0gICAgICByZXR1cm4gX0V4cHI8X0Nsb3N1cmUsIF9UcD4o X0Nsb3N1cmUoX190LCBfX3YpKTsgICAgICAgIAkgICAgICAgIFwKKyAgICAg IHJldHVybiBfRXhwcjxfQ2xvc3VyZSwgX1J0PihfQ2xvc3VyZShfX3QsIF9f dikpOyAgICAgICAgCSAgICAgICAgXAogICAgIH0KIAogX0RFRklORV9CSU5B UllfT1BFUkFUT1IoKywgX19wbHVzKQotLS0gbGlic3RkYysrL2luY2x1ZGUv dHIxL3JhbmRvbQkyMDA3LzA0LzA3IDA4OjM4OjM5CTEyMzYzNworKysgbGli c3RkYysrL2luY2x1ZGUvdHIxL3JhbmRvbQkyMDA3LzEwLzIwIDEwOjAyOjM0 CTEyOTUwNwpAQCAtMTYxOCw3ICsxNjE4LDE2IEBACiAgICAgICAgIHJlc3Vs dF90eXBlCiAgICAgICAgIF9NX2NhbGwoX1VuaWZvcm1SYW5kb21OdW1iZXJH ZW5lcmF0b3ImIF9fdXJuZywKIAkJcmVzdWx0X3R5cGUgX19taW4sIHJlc3Vs dF90eXBlIF9fbWF4LCB0cnVlX3R5cGUpCi0gICAgICAgIHsgcmV0dXJuIHJl c3VsdF90eXBlKF9fdXJuZygpICUgKF9fbWF4IC0gX19taW4gKyAxKSkgKyBf X21pbjsgfQorICAgICAgICB7CisJICAvLyBYWFggTXVzdCBiZSBmaXhlZCB0 byBhbHNvIHdvcmsgd2hlbiBfX3VybmcubWF4KCkgLSBfX3VybmcubWluKCkK KwkgIC8vIGlzIHNtYWxsZXIgdGhhbiBfX21heCAtIF9fbWluLgorCSAgdHlw ZWRlZiB0eXBlbmFtZSBfX2dudV9jeHg6Ol9fYWRkX3Vuc2lnbmVkPHR5cGVu YW1lCisJICAgIF9Vbmlmb3JtUmFuZG9tTnVtYmVyR2VuZXJhdG9yOjpyZXN1 bHRfdHlwZT46Ol9fdHlwZSBfX3V0eXBlOworCSAgcmV0dXJuIHJlc3VsdF90 eXBlKChfX21heCAtIF9fbWluICsgMS4wTCkKKwkJCSAgICAgKiAoX191dHlw ZShfX3VybmcoKSkgLSBfX3V0eXBlKF9fdXJuZy5taW4oKSkpCisJCQkgICAg IC8gKF9fdXR5cGUoX191cm5nLm1heCgpKQorCQkJCS0gX191dHlwZShfX3Vy bmcubWluKCkpICsgMS4wTCkpICsgX19taW47CisJfQogCiAgICAgICB0ZW1w bGF0ZTx0eXBlbmFtZSBfVW5pZm9ybVJhbmRvbU51bWJlckdlbmVyYXRvcj4K ICAgICAgICAgcmVzdWx0X3R5cGUKLS0tIGxpYnN0ZGMrKy9saWJzdXBjKysv dHlwZWluZm8JMjAwNy8wNi8yNiAxNTozNTo0MgkxMjYwMzAKKysrIGxpYnN0 ZGMrKy9saWJzdXBjKysvdHlwZWluZm8JMjAwNy8xMC8wNiAyMzo0ODozMQkx MjkwNjEKQEAgLTk5LDcgKzk5LDEzIEBACiAjZW5kaWYKICAgICBib29sIG9w ZXJhdG9yIT0oY29uc3QgdHlwZV9pbmZvJiBfX2FyZykgY29uc3QKICAgICB7 IHJldHVybiAhb3BlcmF0b3I9PShfX2FyZyk7IH0KLSAgICAKKworICAgIC8v IFJldHVybiB0cnVlIGlmIHRoaXMgaXMgYSBwb2ludGVyIHR5cGUgb2Ygc29t ZSBraW5kCisgICAgdmlydHVhbCBib29sIF9faXNfcG9pbnRlcl9wKCkgY29u c3Q7CisKKyAgICAvLyBSZXR1cm4gdHJ1ZSBpZiB0aGlzIGlzIGEgZnVuY3Rp b24gdHlwZQorICAgIHZpcnR1YWwgYm9vbCBfX2lzX2Z1bmN0aW9uX3AoKSBj b25zdDsKKwogICAgIC8vIFRyeSBhbmQgY2F0Y2ggYSB0aHJvd24gdHlwZS4g U3RvcmUgYW4gYWRqdXN0ZWQgcG9pbnRlciB0byB0aGUKICAgICAvLyBjYXVn aHQgdHlwZSBpbiBUSFJfT0JKLiBJZiBUSFJfVFlQRSBpcyBub3QgYSBwb2lu dGVyIHR5cGUsIHRoZW4KICAgICAvLyBUSFJfT0JKIHBvaW50cyB0byB0aGUg dGhyb3duIG9iamVjdC4gSWYgVEhSX1RZUEUgaXMgYSBwb2ludGVyCkBAIC0x MTMsMTIgKzExOSw2IEBACiAgICAgdmlydHVhbCBib29sIF9fZG9fdXBjYXN0 KGNvbnN0IF9fY3h4YWJpdjE6Ol9fY2xhc3NfdHlwZV9pbmZvICpfX3Rhcmdl dCwKIAkJCSAgICAgdm9pZCAqKl9fb2JqX3B0cikgY29uc3Q7CiAKLSAgIC8v IFJldHVybiB0cnVlIGlmIHRoaXMgaXMgYSBwb2ludGVyIHR5cGUgb2Ygc29t ZSBraW5kCi0gICAgdmlydHVhbCBib29sIF9faXNfcG9pbnRlcl9wKCkgY29u c3Q7Ci0KLSAgICAvLyBSZXR1cm4gdHJ1ZSBpZiB0aGlzIGlzIGEgZnVuY3Rp b24gdHlwZQotICAgIHZpcnR1YWwgYm9vbCBfX2lzX2Z1bmN0aW9uX3AoKSBj b25zdDsKLQogICBwcm90ZWN0ZWQ6CiAgICAgY29uc3QgY2hhciAqX19uYW1l OwogICAgIAotLS0gbGlic3RkYysrL2luY2x1ZGUvZXh0L2NvZGVjdnRfc3Bl Y2lhbGl6YXRpb25zLmgJMjAwNi8xMC8yMSAwMjo0MTozOAkxMTc5MjMKKysr IGxpYnN0ZGMrKy9pbmNsdWRlL2V4dC9jb2RlY3Z0X3NwZWNpYWxpemF0aW9u cy5oCTIwMDcvMTAvMTEgMTU6MjM6MTEJMTI5MjM1CkBAIC0xMjgsNyArMTI4 LDcgQEAKICAgICBib29sCiAgICAgZ29vZCgpIGNvbnN0IHRocm93KCkKICAg ICB7IAotICAgICAgY29uc3QgZGVzY3JpcHRvcl90eXBlIF9fZXJyID0gcmVp bnRlcnByZXRfY2FzdDxpY29udl90PigtMSk7CisgICAgICBjb25zdCBkZXNj cmlwdG9yX3R5cGUgX19lcnIgPSAoaWNvbnZfdCkoLTEpOwogICAgICAgYm9v bCBfX3Rlc3QgPSBfTV9pbl9kZXNjICYmIF9NX2luX2Rlc2MgIT0gX19lcnI7 IAogICAgICAgX190ZXN0ICY9ICBfTV9vdXRfZGVzYyAmJiBfTV9vdXRfZGVz YyAhPSBfX2VycjsKICAgICAgIHJldHVybiBfX3Rlc3Q7CkBAIC0xNjYsNyAr MTY2LDcgQEAKICAgICB2b2lkCiAgICAgaW5pdCgpCiAgICAgewotICAgICAg Y29uc3QgZGVzY3JpcHRvcl90eXBlIF9fZXJyID0gcmVpbnRlcnByZXRfY2Fz dDxpY29udl90PigtMSk7CisgICAgICBjb25zdCBkZXNjcmlwdG9yX3R5cGUg X19lcnIgPSAoaWNvbnZfdCkoLTEpOwogICAgICAgY29uc3QgYm9vbCBfX2hh dmVfZW5jb2RpbmdzID0gX01faW50X2VuYy5zaXplKCkgJiYgX01fZXh0X2Vu Yy5zaXplKCk7CiAgICAgICBpZiAoIV9NX2luX2Rlc2MgJiYgX19oYXZlX2Vu Y29kaW5ncykKIAl7CkBAIC0xOTksNyArMTk5LDcgQEAKICAgICB2b2lkCiAg ICAgZGVzdHJveSgpIHRocm
Re: bin/151866: [libfetch] [patch] closing the cached FTP connection
The following reply was made to PR bin/151866; it has been noted by GNATS. From: Mark Johnston To: bug-follo...@freebsd.org Cc: Subject: Re: bin/151866: [libfetch] [patch] closing the cached FTP connection Date: Sun, 30 Jan 2011 20:28:54 -0500 I'm not quite sure what you mean... this won't affect fork()ed processes, and a child that execve()s won't be able to access the connection through the libfetch API anyway, it would just have the socket descriptor itself, and it would have to know the actual value of the descriptor to use it. Thanks, -Mark ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
bin/154407: usr.bin/tar/ ignores error codes from read() just silently pads nulls
>Number: 154407 >Category: bin >Synopsis: usr.bin/tar/ ignores error codes from read() just silently >pads nulls >Confidential: no >Severity: serious >Priority: high >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Jan 31 04:00:21 UTC 2011 >Closed-Date: >Last-Modified: >Originator: "Julian H. Stacey" >Release:FreeBSD 8.1-RELEASE amd64 >Organization: http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen. >Environment: System: FreeBSD blak.js.berklix.net 8.1-RELEASE FreeBSD 8.1-RELEASE #2: Fri Aug 20 15:11:19 CEST 2010 j...@blak.js.berklix.net:/usr/src/sys/amd64/compile/BLAK.small amd64 >Description: usr.bin/tar/ ignores error codes from read() silently pads with nulls, corrupting copied data without warning ! Log of how I discovered problem + diffs + copy of send-pr: http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/tar/ (various files have .ignore extension to avoid my customise script). Comparison with gtar: gtar also delivers false nulls unfortunately, gtar warns users it is getting device errors. Comparison with cp: cp warns of errors, cp delivers no false nulls, truncates at read fail. >How-To-Repeat: - Get a normal data CD or DVD you have created ) (not commercial recorded hollywood deliberately sector crippled media), - Damage the media so it will have some read errors, mount /dev/acd0 /cdrom cd /tmp mkdir -p cp tar/cdrom cp -R /cdrom cp (cd /cdrom ; tar cf - . ) | ( cd tar/cdrom ; tar xf - ) cd tar/cdrom # http://berklix.com/~jhs/src/bsd/jhs/bin/public/cmpd/ find . -type f -exex cmpd -d {} ../../cp/cdrom \; # http://berklix.com/~jhs/src/bsd/jhs/bin/public/8f/ foreach i ( `find . -type f | xargs 8f -n 2048 -b 0 -l` ) echo $i xargs od -c $i | yail end >Fix: My patches fix code to avoid unwarned damaged data. As it's Tim K.'s recently written code, I presume he will want to fix it himself, so my patch lines as well as fixing, are also appended with edit mark // JHS for easy searching. write.c & util.c were bad in 8.1-RELEASE (& the critical bit in ./-current/src/usr/bin/write.c ^write_file_data() the final bytes_read = read(fd, bsdtar->buff, FILEDATABUFLEN); is also bad) Various return values silently ignored. All invocations of [f]read() & [f]write() & all invocations of *_read_* & *_write_* etc should be checked whether return value is properly used. Later fixes if any will be in http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/tar/ A copy appended. *** 8.1-RELEASE-generic/src/usr.bin/tar/write.c Mon Jun 14 04:09:06 2010 --- 8.1-RELEASE+jhs-error-detect/src/usr.bin/tar/write.cSat Jan 29 18:34:55 2011 *** *** 217,222 --- 217,224 if (ARCHIVE_OK != archive_write_open_file(a, bsdtar->filename)) bsdtar_errc(bsdtar, 1, 0, archive_error_string(a)); write_archive(a, bsdtar); + // JHS write_archive is declared void, + // JHS is there a static extern ret val to check ? } /* *** *** 301,312 archive_write_set_format(a, format); } lseek(bsdtar->fd, end_offset, SEEK_SET); /* XXX check return val XXX */ if (ARCHIVE_OK != archive_write_set_options(a, bsdtar->option_options)) bsdtar_errc(bsdtar, 1, 0, archive_error_string(a)); if (ARCHIVE_OK != archive_write_open_fd(a, bsdtar->fd)) bsdtar_errc(bsdtar, 1, 0, archive_error_string(a)); ! write_archive(a, bsdtar); /* XXX check return val XXX */ close(bsdtar->fd); bsdtar->fd = -1; --- 303,316 archive_write_set_format(a, format); } lseek(bsdtar->fd, end_offset, SEEK_SET); /* XXX check return val XXX */ + // JHS if (ARCHIVE_OK != archive_write_set_options(a, bsdtar->option_options)) bsdtar_errc(bsdtar, 1, 0, archive_error_string(a)); if (ARCHIVE_OK != archive_write_open_fd(a, bsdtar->fd)) bsdtar_errc(bsdtar, 1, 0, archive_error_string(a)); ! write_archive(a, bsdtar); /* XXX check return val XXX */ ! // JHS what return val ? write_archive is declared void close(bsdtar->fd); bsdtar->fd = -1; *** *** 390,395 --- 394,401 bsdtar_errc(bsdtar, 1, 0, archive_error_string(a)); write_archive(a, bsdtar); + // JHS write_archive is declared void, + // JHS is there a static extern ret val to check ? close(bsdtar->fd); bsdtar-
misc/154409: Indent bug report
>Number: 154409 >Category: misc >Synopsis: Indent bug report >Confidential: no >Severity: non-critical >Priority: medium >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jan 31 06:50:06 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Li >Release:8.0 release >Organization: >Environment: FreeBSD PC-686.Workstation 8.0-RELEASE-p5 FreeBSD 8.0-RELEASE-p5 #4: Fri Oct 15 17:57:04 CST 2010 root@PC-686.Workstation:/usr/obj/usr/src/sys/MYKERNEL amd64 >Description: I found two bugs of indnet(1). >How-To-Repeat: Here is a pieces of C codes: /**/ /* * example.c */ /**/ void example(void) { /* The first empty statement ";" indicates the first bug. */ /* Without this empty statement, indent(1) can handle the switch statement properly. */ /* The "case 1" will be wrong. */ ; switch (p_stage_3_parameter->s_3_mutation_method) { case 1: example_01(); break; case 2: example_02(); break; default: printf("Error.\n"); break; } if () { } else /* This comment indicates the second bug. */ { /* A comment following an "else" statement always cause an error. */ } } /**/ Here is my .indent.pro: -TFILE -Tfd_mask -Tfd_set -Tlinker_sym_tT -Tu_char -Tu_int -Tu_long -Tu_short -TTAILQ_HEAD -TTAILQ_ENTRY -TLIST_HEAD -TLIST_ENTRY -TSTAILQ_HEAD -TSTAILQ_ENTRY -TSLIST_HEAD -TSLIST_ENTRY -bad -bap -bbb -bc -bl -c81 -cd81 -cdb -nce -ci8 -cli0 -d0 -di8 -ndj -ei -nfc1 -nfcb -i8 -ip8 -l140 -lc140 -ldi0 -lp -npcs -psl -sc -nsob -nv -nfbs And I use gvim (I think this doesn't matter) to write C codes. >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"