misc/152360: Crash related to dummynet.
>Number: 152360 >Category: misc >Synopsis: Crash related to dummynet. >Confidential: no >Severity: critical >Priority: medium >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Nov 18 09:30:08 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Pawel Tyll >Release:8.1-STABLE >Organization: >Environment: FreeBSD hostname 8.1-STABLE FreeBSD 8.1-STABLE #0: Mon Nov 8 12:16:53 CET 2010 u...@hostname:/usr/obj/usr/src/sys/HOSTNAME amd64 >Description: Note that problem also happened on 8.1-RELEASE. This machine relies heavily on dummynet and traffic shaping is its primary purpose. Full core dump available. hostname.domain.tld dumped core - see /var/crash/vmcore.0 Sun Nov 7 00:16:09 CET 2010 FreeBSD hostname.domain.tld 8.1-RELEASE FreeBSD 8.1-RELEASE #1: Tue Jul 27 04:18:54 CEST 2010 u...@hostname.domain.tld:/usr/obj/usr/src/sys/hostname amd64 panic: page fault GNU gdb 6.1.1 [FreeBSD] Copyright 2004 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type "show copying" to see the conditions. There is absolutely no warranty for GDB. Type "show warranty" for details. This GDB was configured as "amd64-marcel-freebsd"... Unread portion of the kernel message buffer: = DPL 0, pres 1, long 1, def32 0, gran 1 processor eflags= processor eflags= interrupt enabled, interrupt enabled, resume, resume, IOPL = 0IOPL = 0 current process = current process = 12 (irq257: em1)0 (dummynet) trap number = 12 trap number = 12 panic: page fault cpuid = 6 Uptime: 16d23h57m45s Physical memory: 4044 MB Dumping 1704 MB: 1689 1673 1657 1641 1625 1609 1593 1577 1561 1545 1529 1513 1497 1481 1465 1449 1433 1417 1401 1385 1369 1353 1337 1321 1305 1289 1273 1257 1241 1225 1209 1193 1177 1161 1145 1129 1113 1097 1081 1065 1049 1033 1017 1001 985 969 953 937 921 905 889 873 857 841 825 809 793 777 761 745 729 713 697 681 665 649 633 617 601 585 569 553 537 521 505 489 473 457 441 425 409 393 377 361 345 329 313 297 281 265 249 233 217 201 185 169 153 137 121 105 89 73 57 41 25 9 Reading symbols from /boot/kernel/zfs.ko...Reading symbols from /boot/kernel/zfs.ko.symbols...done. done. Loaded symbols for /boot/kernel/zfs.ko Reading symbols from /boot/kernel/opensolaris.ko...Reading symbols from /boot/kernel/opensolaris.ko.symbols...done. done. Loaded symbols for /boot/kernel/opensolaris.ko Reading symbols from /boot/kernel/geom_mirror.ko...Reading symbols from /boot/kernel/geom_mirror.ko.symbols...done. done. Loaded symbols for /boot/kernel/geom_mirror.ko Reading symbols from /boot/kernel/if_em.ko...Reading symbols from /boot/kernel/if_em.ko.symbols...done. done. Loaded symbols for /boot/kernel/if_em.ko Reading symbols from /boot/kernel/ahci.ko...Reading symbols from /boot/kernel/ahci.ko.symbols...done. done. Loaded symbols for /boot/kernel/ahci.ko Reading symbols from /boot/kernel/ipmi.ko...Reading symbols from /boot/kernel/ipmi.ko.symbols...done. done. Loaded symbols for /boot/kernel/ipmi.ko Reading symbols from /boot/kernel/smbus.ko...Reading symbols from /boot/kernel/smbus.ko.symbols...done. done. Loaded symbols for /boot/kernel/smbus.ko #0 doadump () at pcpu.h:223 223 pcpu.h: No such file or directory. in pcpu.h (kgdb) #0 doadump () at pcpu.h:223 #1 0x8059af59 in boot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:416 #2 0x8059b38c in panic (fmt=0x8096d354 "%s") at /usr/src/sys/kern/kern_shutdown.c:590 #3 0x80894128 in trap_fatal (frame=0xff00031a27c0, eva=Variable "eva" is not available. ) at /usr/src/sys/amd64/amd64/trap.c:777 #4 0x808944f4 in trap_pfault (frame=0xff81b1c88560, usermode=0) at /usr/src/sys/amd64/amd64/trap.c:693 #5 0x80894d3a in trap (frame=0xff81b1c88560) at /usr/src/sys/amd64/amd64/trap.c:451 #6 0x8087a703 in calltrap () at /usr/src/sys/amd64/amd64/exception.S:223 #7 0x80698abf in in_localaddr (in=Variable "in" is not available. ) at /usr/src/sys/netinet/in.c:115 #8 0x806b0deb in ipfw_chk (args=0xff81b1c887d0) at /usr/src/sys/netinet/ipfw/ip_fw2.c:1688 #9 0x806b3e4a in ipfw_check_hook (arg=Variable "arg" is not available. ) at /usr/src/sys/netinet/ipfw/ip_fw_pfil.c:139 #10 0x8065438c in pfil_run_hooks (ph=Variable "ph" is not available. ) at /usr/src/sys/net/pfil.c:82 #11 0x806b94b3 in ip_input (m=dwarf2_read_address: Corrupted DWARF expression. ) at /usr/src/sys/netinet/ip_input.c:535 #12 0x8065379e in netisr_dispatch_src (proto=1, source=Variable "source" is not available. ) at /usr/src/sys/net/netisr.c:917 #13 0xff
misc/152361: [PATCH] multimedia/playd update
>Number: 152361
>Category: misc
>Synopsis: [PATCH] multimedia/playd update
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Thu Nov 18 10:30:10 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Aldis Berjoza
>Release:
>Organization:
>Environment:
>Description:
playd update to v1.9.7
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
diff -u playd.old/Makefile playd/Makefile
--- playd.old/Makefile 2010-11-18 10:59:21.996108231 +0200
+++ playd/Makefile 2010-11-18 11:44:47.652570534 +0200
@@ -6,9 +6,9 @@
#
PORTNAME= playd
-PORTVERSION= 1.9.5
+PORTVERSION= 1.9.7
CATEGORIES=multimedia
-MASTER_SITES= http://files.bsdroot.lv/FreeBSD/distfiles/
+MASTER_SITES= http://files.bsdroot.lv/my/FreeBSD/distfiles/
DISTNAME= playd.sh-${PORTVERSION}
MAINTAINER=al...@bsdroot.lv
@@ -23,6 +23,8 @@
MAN1= playd.1
NO_BUILD= yes
+WRKSRC=${WRKDIR}/playd-sh-${REV}
+REV= 59bc2a33074e
do-install:
${INSTALL_SCRIPT} ${WRKSRC}/bin/playd.sh ${PREFIX}/bin/playd
diff -u playd.old/distinfo playd/distinfo
--- playd.old/distinfo 2010-11-18 10:59:21.996108231 +0200
+++ playd/distinfo 2010-11-18 11:01:34.732062541 +0200
@@ -1,2 +1,2 @@
-SHA256 (playd.sh-1.9.5.tar.gz) =
de955bbc918a4304fea810a823e0ed57f4e8be4fa53345c80c239afbebae6d2e
-SIZE (playd.sh-1.9.5.tar.gz) = 9132
+SHA256 (playd.sh-1.9.7.tar.gz) =
b881e8c5480ed5e68d1e081f31c59ffd12b7fe4084d27eedd1226ce82db5fc2f
+SIZE (playd.sh-1.9.7.tar.gz) = 9497
diff -u playd.old/pkg-descr playd/pkg-descr
--- playd.old/pkg-descr 2010-11-18 10:59:22.010109576 +0200
+++ playd/pkg-descr 2010-11-18 11:01:21.501733005 +0200
@@ -4,7 +4,7 @@
player because playd supports playlists. It is easy to integrate
playd into a window manager menu (e.g. FVWM).
-WWW: http://aldis.git.bsdroot.lv/playd.sh
+WWW: http://wiki.bsdroot.lv/playd
-- Aldis Berjoza
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
kern/152363: Apache can not serve images from TMPFS
>Number: 152363 >Category: kern >Synopsis: Apache can not serve images from TMPFS >Confidential: no >Severity: non-critical >Priority: high >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Nov 18 13:50:06 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Karlo Luiten >Release:FreeBSD 8.1-STABLE amd64 >Organization: AnyWi Technologies >Environment: System: FreeBSD arenal.anywi.com 8.1-STABLE FreeBSD 8.1-STABLE #0: Mon Sep 13 15:48:43 CEST 2010 r...@arenal.anywi.com:/usr/obj/usr/src/sys/ARENAL amd64 >Description: When /tmp is mounted via TMPFS, and an apache virtualhost is set up to serve images from a directory within /tmp (documentroot), images are not displayed proberly in browsers (Opera,Chrome). Tested with .jpg. 1st line of hexdump of original file: 000 d8ff e0ff 1000 464a 4649 0100 0001 0100 1st lines of hexdump of apache-served file: 000 * 140 8600 0065 0008 2200 0053 0008 >How-To-Repeat: Mount tmpfs: (/etc/fstab): tmpfs /tmptmpfs rw,size=536870912,mode=01777 0 0 Setup a virtualhost within Apache with document root /tmp/any_dir Place a jpg file in this directory, try to access it >Fix: None (use mdconfig disk instead of tmpfs). >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/152363: Apache can not serve images from TMPFS
The following reply was made to PR kern/152363; it has been noted by GNATS. From: Mateusz Guzik To: bug-follo...@freebsd.org, ka...@anywi.com Cc: Subject: Re: kern/152363: Apache can not serve images from TMPFS Date: Thu, 18 Nov 2010 14:59:42 +0100 Your issue is probably already fixed in STABLE - see http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/127213 Can you update your system and try to reproduce this problem? -- Mateusz Guzik ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: ports/152361: [PATCH] multimedia/playd update
Synopsis: [PATCH] multimedia/playd update Responsible-Changed-From-To: freebsd-bugs->freebsd-ports-bugs Responsible-Changed-By: linimon Responsible-Changed-When: Thu Nov 18 15:45:38 UTC 2010 Responsible-Changed-Why: ports PR. http://www.freebsd.org/cgi/query-pr.cgi?pr=152361 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/152296: wrong message when trying to checkout using old repository path
Synopsis: wrong message when trying to checkout using old repository path
State-Changed-From-To: open->suspended
State-Changed-By: arundel
State-Changed-When: Thu Nov 18 16:58:58 UTC 2010
State-Changed-Why:
I'm very sorry for handling this PR inappropriatly. Somehow I was under the
impression that we had a version of svn in the base tree. However that is not
the case!
I think marking this as suspended is the best option for now, since there
was no patch attached to correct svn's handling of the wrong URL.
Since the svn port seems to get updated very regularly we can assume that the
development version of svn is still containing this issue. If somebody wants to
provide a patch we could try convincing the svn developers to push it upstream
in order to have it in one of the next svn releases and thus ports.
A different approach would be to add a local ports patch to
devel/subversion{-freebsd}/files.
Responsible-Changed-From-To: freebsd-bugs->freebsd-ports
Responsible-Changed-By: arundel
Responsible-Changed-When: Thu Nov 18 16:58:58 UTC 2010
Responsible-Changed-Why:
This is a ports related PR.
http://www.freebsd.org/cgi/query-pr.cgi?pr=152296
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/152360: [dummynet] [panic] Crash related to dummynet.
Old Synopsis: Crash related to dummynet. New Synopsis: [dummynet] [panic] Crash related to dummynet. Responsible-Changed-From-To: freebsd-bugs->freebsd-net Responsible-Changed-By: linimon Responsible-Changed-When: Thu Nov 18 17:34:27 UTC 2010 Responsible-Changed-Why: reclassify. http://www.freebsd.org/cgi/query-pr.cgi?pr=152360 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/69066: [panic] nmdm(4) page fault when slattach on a null modem device
Synopsis: [panic] nmdm(4) page fault when slattach on a null modem device State-Changed-From-To: feedback->closed State-Changed-By: jh State-Changed-When: Thu Nov 18 17:41:42 UTC 2010 State-Changed-Why: There is no evidence that the problem still exists. SLIP has been removed from head and stable/8. http://www.freebsd.org/cgi/query-pr.cgi?pr=69066 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: misc/152296: wrong message when trying to checkout using old repository path
On 18 November 2010 20:15, wrote:
> Synopsis: wrong message when trying to checkout using old repository path
>
> State-Changed-From-To: open->suspended
> State-Changed-By: arundel
> State-Changed-When: Thu Nov 18 16:58:58 UTC 2010
> State-Changed-Why:
> I'm very sorry for handling this PR inappropriatly. Somehow I was under the
> impression that we had a version of svn in the base tree. However that is not
> the case!
> I think marking this as suspended is the best option for now, since there
> was no patch attached to correct svn's handling of the wrong URL.
> Since the svn port seems to get updated very regularly we can assume that the
> development version of svn is still containing this issue. If somebody wants
> to
> provide a patch we could try convincing the svn developers to push it upstream
> in order to have it in one of the next svn releases and thus ports.
> A different approach would be to add a local ports patch to
> devel/subversion{-freebsd}/files.
>
>
> Responsible-Changed-From-To: freebsd-bugs->freebsd-ports
> Responsible-Changed-By: arundel
> Responsible-Changed-When: Thu Nov 18 16:58:58 UTC 2010
> Responsible-Changed-Why:
> This is a ports related PR.
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=152296
> ___
> freebsd-po...@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
>
I see only two possible ways to fix this problem:
If you have checkouted source tree before, you can use following
command to relocate it:
find /usr/src -name .svn|xargs -n 1 -J XXX sed -i '.bak'
's,http://svn.freebsd.org/viewvc/base/head/usr.bin/,http://svn.freebsd.org/base/head/usr.bin/,'
XXX/entries
If you can't checkout source tree with wrong url - fix your script,
which check out source tree, but never svn.
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/145999: [request] optional offset for `mdconfig -t vnode'
The following reply was made to PR kern/145999; it has been noted by GNATS. From: Mateusz Guzik To: bug-follo...@freebsd.org, m...@aldan.algebra.com Cc: Subject: Re: kern/145999: [request] optional offset for `mdconfig -t vnode' Date: Thu, 18 Nov 2010 19:29:05 +0100 This can be achieved with gnop(8). $ mdocnfig -t vnode md0 $ gnop create -o md0 $ ls /dev/md0* /dev/md0 /dev/md0.nop /dev/md0.nops1 /dev/md0.nops1a /dev/md0.nops1b /dev/md0.nops1d Have fun. :) -- Mateusz Guzik ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/79295: umount oddity with NFS (fwe) over VIA Fire II card
Synopsis: umount oddity with NFS (fwe) over VIA Fire II card State-Changed-From-To: open->feedback State-Changed-By: jh State-Changed-When: Thu Nov 18 20:32:32 UTC 2010 State-Changed-Why: Can you still reproduce this on recent FreeBSD versions? http://www.freebsd.org/cgi/query-pr.cgi?pr=79295 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/85450: [ata] [panic] subdisk6 detached (appears to be a sata problem, SiI 3112)
Synopsis: [ata] [panic] subdisk6 detached (appears to be a sata problem, SiI 3112) State-Changed-From-To: open->feedback State-Changed-By: jh State-Changed-When: Thu Nov 18 20:35:39 UTC 2010 State-Changed-Why: Can you still reproduce this on recent FreeBSD versions? http://www.freebsd.org/cgi/query-pr.cgi?pr=85450 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
kern/152378: [sound][patch] Update snd_envy24ht to be MPSAFE and use 32-bit DMA addresses
>Number: 152378
>Category: kern
>Synopsis: [sound][patch] Update snd_envy24ht to be MPSAFE and use 32-bit
>DMA addresses
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible:freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Nov 18 21:00:18 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Jason Harmening
>Release:8.1-STABLE
>Organization:
>Environment:
FreeBSD riviera.austin.rr.com 8.1-STABLE FreeBSD 8.1-STABLE #0: Sun Nov 14
12:01:19 CST 2010 ja...@riviera.austin.rr.com:/usr/obj/usr/src/sys/CUSTOM
amd64
>Description:
--Allow DMA addresses anywhere in the lower 4GB--Envy24HT has a 32-bit DMA
engine, not 28-bit like Envy24
--Mark interrupt handler as MPSAFE, seems to be correctly synchronized
Testing done:
daily usage of envy24ht-based sound card for ~1yr on machine w/ 6GB RAM
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
--- envy24ht.h.orig 2007-05-27 14:58:39.0 -0500
+++ envy24ht.h 2009-05-06 10:49:56.0 -0500
@@ -176,8 +176,7 @@
#define ENVY24HT_VOL_MIN 96 /* -144db(negate) */
#define ENVY24HT_VOL_MUTE 127 /* mute */
-#define BUS_SPACE_MAXADDR_ENVY24 0x0fff /* Address space beyond 256MB is
not
- supported */
+#define BUS_SPACE_MAXADDR_ENVY24 0x
#define BUS_SPACE_MAXSIZE_ENVY24 0x3fffc /* 64k x 4byte(1dword) */
#define ENVY24HT_CCS_GPIO_HDATA 0x1E
--- envy24ht.c 2009-05-07 09:09:31.0 -0500
+++ envy24ht.c 2009-05-07 09:22:38.0 -0500
@@ -2421,7 +2421,7 @@
sc->irq = bus_alloc_resource(sc->dev, SYS_RES_IRQ, &sc->irqid,
0, ~0, 1, RF_ACTIVE | RF_SHAREABLE);
if (!sc->irq ||
- snd_setup_intr(sc->dev, sc->irq, 0, envy24ht_intr, sc, &sc->ih)) {
+ snd_setup_intr(sc->dev, sc->irq, INTR_MPSAFE, envy24ht_intr, sc,
&sc->ih)) {
device_printf(sc->dev, "unable to map interrupt\n");
return ENXIO;
}
@@ -2431,7 +2431,7 @@
/*alignment*/4,
/*boundary*/0,
/*lowaddr*/BUS_SPACE_MAXADDR_ENVY24,
- /*highaddr*/BUS_SPACE_MAXADDR_ENVY24,
+ /*highaddr*/BUS_SPACE_MAXADDR,
/*filter*/NULL, /*filterarg*/NULL,
/*maxsize*/BUS_SPACE_MAXSIZE_ENVY24,
/*nsegments*/1, /*maxsegsz*/0x3,
>Release-Note:
>Audit-Trail:
>Unformatted:
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/152378: [sound][patch] Update snd_envy24ht to be MPSAFE and use 32-bit DMA addresses
Synopsis: [sound][patch] Update snd_envy24ht to be MPSAFE and use 32-bit DMA addresses Responsible-Changed-From-To: freebsd-bugs->freebsd-multimedia Responsible-Changed-By: arundel Responsible-Changed-When: Thu Nov 18 21:20:59 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=152378 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
bin/152385: ee(1) has different keybindings in the livefs environment
>Number: 152385 >Category: bin >Synopsis: ee(1) has different keybindings in the livefs environment >Confidential: no >Severity: non-critical >Priority: low >Responsible:freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Nov 18 21:50:08 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Bruce Cran >Release:9.0-CURRENT >Organization: >Environment: N/A >Description: In the 9-CURRENT snapshot livefs environment the keybindings for ee(1) are different to those when it's used in an installed system. This makes it rather frustrating to use. >How-To-Repeat: Run ee from a livefs environment. >Fix: >Release-Note: >Audit-Trail: >Unformatted: ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/38727: [patch] mptable(1) should complain about garbage arguments
Synopsis: [patch] mptable(1) should complain about garbage arguments State-Changed-From-To: open->analyzed State-Changed-By: arundel State-Changed-When: Thu Nov 18 23:31:29 UTC 2010 State-Changed-Why: Can somebody please commit this patch? I'll send in an updated version which applies cleanly to HEAD right away. http://www.freebsd.org/cgi/query-pr.cgi?pr=38727 ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: bin/38727: [patch] mptable(1) should complain about garbage arguments
The following reply was made to PR bin/38727; it has been noted by GNATS. From: Alexander Best To: bug-follo...@freebsd.org Cc: Subject: Re: bin/38727: [patch] mptable(1) should complain about garbage arguments Date: Thu, 18 Nov 2010 23:53:39 + --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline here's an updated patch which applies cleanly to HEAD. cheers. alex -- a13x --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="mptable.c.diff" diff --git a/usr.sbin/mptable/mptable.c b/usr.sbin/mptable/mptable.c index a16a1b9..b461e61 100644 --- a/usr.sbin/mptable/mptable.c +++ b/usr.sbin/mptable/mptable.c @@ -322,20 +322,21 @@ main( int argc, char *argv[] ) if ( strcmp( optarg, "mesg") == 0 ) dmesg = 1; else - dmesg = 0; - break; - case 'h': - if ( strcmp( optarg, "elp") == 0 ) - usage(); + usage(); break; case 'g': if ( strcmp( optarg, "rope") == 0 ) grope = 1; + else + usage(); break; case 'v': if ( strcmp( optarg, "erbose") == 0 ) verbose = 1; + else + usage(); break; + case 'h': default: usage(); } --+QahgC5+KEYLbs62-- ___ freebsd-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/145385: [cpu] Logical processor cannot be disabled for some SMT-enabled Intel procs
The following reply was made to PR kern/145385; it has been noted by GNATS.
From: Garrett Cooper
To: Andriy Gapon
Cc: bug-follo...@freebsd.org
Subject: Re: kern/145385: [cpu] Logical processor cannot be disabled for some
SMT-enabled Intel procs
Date: Thu, 18 Nov 2010 16:09:46 -0800
On Wed, Nov 17, 2010 at 4:34 PM, Garrett Cooper wrote=
:
> On Thu, Oct 7, 2010 at 10:03 AM, Andriy Gapon wrote:
>>
>> Here's a patch to remove halted logical processors from root cpu set (cp=
uset
>> number zero) and consequently all child sets:
>> http://people.freebsd.org/~avg/cpu-halt.diff
>>
>> Please note that unhalting CPUs will add them to cpuset zero, but will n=
ot
>> (re-)add them cpusets of the running processes. =A0So additional action =
will be
>> required from system administrator if e would like existing processes to=
make use
>> of unhalted CPUs.
>>
>> Also, interrupts that are bound to halted CPUs are not rebound on halt, =
and so
>> will be delivered to halted CPUs. =A0This should not be a problem for ty=
pical
>> environments, but would be nice to fix anyway.
>
> =A0 =A0Sorry for taking so long to get back on this item. The patch looks
> ok as far as setting the CPUSET is concerned (setting
> machdep.hlt_logical_cpus=3D1 works on an r710 with 8 logical procs as
> SCHED_ULE schedules all of the tasks on the non-logical SMT cores, not
> the logical ones, and the patch properly detects that there aren't any
> logical processors on a Core2 Quad I have at home), but it's missing a
> key case where I go from...
>
> machdep.hlt_logical_cpus: 1 -> 0
>
> =A0 =A0... it should reset CPUSETZERO.
> =A0 =A0The overall CPU topology should probably be cached and restored
> when reset, or at least CPUSETZERO should be reset (probably the
> simpler and cleaner route to go).
> =A0 =A0After that all that's required is work for i386 and I'd vote for a
> commit of the patch.
> Thanks for the hard work Andriy :)!
Just to illustrate, here's how I reproduced the successful behavior
(and the problem):
1. Execute the following script:
#!/bin/sh
i=3D0
ncpus=3D`sysctl -n kern.smp.cpus`
while [ $i -lt $ncpus ] ; do
while : ; do : ; done &
: $(( i +=3D 1 ))
done
2. Execute sysctl machdep.hlt_logical_cpus=3D1 .
3. Look at cpuset info; example:
Before:
# for i in `ps aux | grep gcooper | grep -v grep | awk '{ print $2 }'`
; do cpuset -g -p $i ; done
pid 2179 mask: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
pid 2180 mask: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
After:
# for i in `ps aux | grep gcooper | grep -v grep | awk '{ print $2 }'`
; do cpuset -g -p $i ; done
pid 2179 mask: 0, 2, 4, 6, 8, 10, 12, 14
pid 2180 mask: 0, 2, 4, 6, 8, 10, 12, 14
# sysctl machdep.hlt_logical_cpus=3D0
machdep.hlt_logical_cpus: 1 -> 0
# for i in `ps aux | grep gcooper | grep -v grep | awk '{ print $2 }'`
; do cpuset -g -p $i ; done
pid 2179 mask: 0, 2, 4, 6, 8, 10, 12, 14
pid 2180 mask: 0, 2, 4, 6, 8, 10, 12, 14
I'm taking the patch and running with it now to try and get it working 100%=
.
___
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
Re: kern/145385: [cpu] Logical processor cannot be disabled for some SMT-enabled Intel procs
The following reply was made to PR kern/145385; it has been noted by GNATS.
From: Garrett Cooper
To: Andriy Gapon
Cc: bug-follo...@freebsd.org
Subject: Re: kern/145385: [cpu] Logical processor cannot be disabled for some
SMT-enabled Intel procs
Date: Thu, 18 Nov 2010 19:01:08 -0800
--0016e6567d28366ef604955f1e9a
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On Thu, Nov 18, 2010 at 4:09 PM, Garrett Cooper wrote=
:
> On Wed, Nov 17, 2010 at 4:34 PM, Garrett Cooper wro=
te:
>> On Thu, Oct 7, 2010 at 10:03 AM, Andriy Gapon wrote:
>>>
>>> Here's a patch to remove halted logical processors from root cpu set (c=
puset
>>> number zero) and consequently all child sets:
>>> http://people.freebsd.org/~avg/cpu-halt.diff
>>>
>>> Please note that unhalting CPUs will add them to cpuset zero, but will =
not
>>> (re-)add them cpusets of the running processes. =A0So additional action=
will be
>>> required from system administrator if e would like existing processes t=
o make use
>>> of unhalted CPUs.
>>>
>>> Also, interrupts that are bound to halted CPUs are not rebound on halt,=
and so
>>> will be delivered to halted CPUs. =A0This should not be a problem for t=
ypical
>>> environments, but would be nice to fix anyway.
>>
>> =A0 =A0Sorry for taking so long to get back on this item. The patch look=
s
>> ok as far as setting the CPUSET is concerned (setting
>> machdep.hlt_logical_cpus=3D1 works on an r710 with 8 logical procs as
>> SCHED_ULE schedules all of the tasks on the non-logical SMT cores, not
>> the logical ones, and the patch properly detects that there aren't any
>> logical processors on a Core2 Quad I have at home), but it's missing a
>> key case where I go from...
>>
>> machdep.hlt_logical_cpus: 1 -> 0
>>
>> =A0 =A0... it should reset CPUSETZERO.
>> =A0 =A0The overall CPU topology should probably be cached and restored
>> when reset, or at least CPUSETZERO should be reset (probably the
>> simpler and cleaner route to go).
>> =A0 =A0After that all that's required is work for i386 and I'd vote for =
a
>> commit of the patch.
>> Thanks for the hard work Andriy :)!
>
> Just to illustrate, here's how I reproduced the successful behavior
> (and the problem):
>
> 1. Execute the following script:
>
> #!/bin/sh
> i=3D0
> ncpus=3D`sysctl -n kern.smp.cpus`
> while [ $i -lt $ncpus ] ; do
> =A0 =A0while : ; do : ; done &
> =A0 =A0: $(( i +=3D 1 ))
> done
>
> 2. Execute sysctl machdep.hlt_logical_cpus=3D1 .
> 3. Look at cpuset info; example:
>
> Before:
>
> # for i in `ps aux | grep gcooper | grep -v grep | awk '{ print $2 }'`
> ; do cpuset -g -p $i ; done
> pid 2179 mask: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
> pid 2180 mask: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
>
> After:
>
> # for i in `ps aux | grep gcooper | grep -v grep | awk '{ print $2 }'`
> ; do cpuset -g -p $i ; done
> pid 2179 mask: 0, 2, 4, 6, 8, 10, 12, 14
> pid 2180 mask: 0, 2, 4, 6, 8, 10, 12, 14
> # sysctl machdep.hlt_logical_cpus=3D0
> machdep.hlt_logical_cpus: 1 -> 0
> # for i in `ps aux | grep gcooper | grep -v grep | awk '{ print $2 }'`
> ; do cpuset -g -p $i ; done
> pid 2179 mask: 0, 2, 4, 6, 8, 10, 12, 14
> pid 2180 mask: 0, 2, 4, 6, 8, 10, 12, 14
>
> I'm taking the patch and running with it now to try and get it working 10=
0%.
This output was from a patch in progress based on Andriy's work,
that seems to get the bits in place properly:
test-26# sysctl machdep.hlt_logical_cpus=3D1
sysctl_hlt_logical_cpus: mask: 43690
cpuset_zero_modify (before): cpuset_zero: 65535, mask: 21845
cpuset_update (after): set: 21845, mask: 21845
cpuset_update (after): set: 21845, mask: 21845
cpuset_zero_modify (after): cpuset_zero: 21845, mask: 21845
machdep.hlt_logical_cpus: 0 -> 1
test-26# sysctl machdep.hlt_logical_cpus=3D0
sysctl_hlt_logical_cpus: mask: 0
cpuset_zero_modify (before): cpuset_zero: 21845, mask: 65535
cpuset_update (after): set: 21845, mask: 65535
cpuset_update (after): set: 21845, mask: 21845
cpuset_zero_modify (after): cpuset_zero: 65535, mask: 65535
machdep.hlt_logical_cpus: 1 -> 0
test-26#
Weird thing is that the CPU affinity isn't adjusted even though
cpuset_zero appears to be modified. I think this is the problem:
static int
cpuset_testupdate(struct cpuset *set, cpuset_t *mask)
{
struct cpuset *nset;
cpuset_t newmask;
int error;
mtx_assert(&cpuset_lock, MA_OWNED);
if (set->cs_flags & CPU_SET_RDONLY)
return (EPERM);
if (!CPU_OVERLAP(&set->cs_mask, mask))
return (EDEADLK);
CPU_COPY(&set->cs_mask, &newmask);
CPU_AND(&newmask, mask);
error =3D 0;
LIST_FOREACH(nset, &set->cs_children, cs_siblings)
if ((error =3D cpuset_testupdate(nset, &newmask)) !=3D 0)
break;
return (error);
