Re: [fpc-pascal] ExpandFileName failure on long filenames on Linux

2013-09-01 Thread Bart
On 8/31/13, Tomas Hajny  wrote:
> That probably depends on the level of urgency this issue has for you.

ATM it does not happen in real world scenarios for me.

> As I wrote -
> the other file and directory related functions and procedures have
> always had only shortstring interfaces, whereas with GetDir there has
> also been the ansistring version).

I would prefer waiting for _all_ IO functions to handle LongStrings
(or any not_shortstring).
If I understand correctly this will happen in the 2.8 series then
(which has the cpstring feature)?

(I suppose the curent limitation is documented somewhere?)

Bart
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] ExpandFileName failure on long filenames on Linux

2013-09-01 Thread Marco van de Voort
In our previous episode, Bart said:
> > As I wrote -
> > the other file and directory related functions and procedures have
> > always had only shortstring interfaces, whereas with GetDir there has
> > also been the ansistring version).
> 
> I would prefer waiting for _all_ IO functions to handle LongStrings
> (or any not_shortstring).

That was the original idea, removing the shortstring versions for not
embedded targets, so that nobody accidentally could call shortstring
versions.  (and only find out runtime)

But that was deemed to confusing, so now both sets are back again.

___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] ExpandFileName failure on long filenames on Linux

2013-09-01 Thread Tomas Hajny
On 1 Sep 13, at 14:32, Marco van de Voort wrote:
> In our previous episode, Bart said:
> > > As I wrote -
> > > the other file and directory related functions and procedures have
> > > always had only shortstring interfaces, whereas with GetDir there has
> > > also been the ansistring version).
> > 
> > I would prefer waiting for _all_ IO functions to handle LongStrings
> > (or any not_shortstring).
> 
> That was the original idea, removing the shortstring versions for not
> embedded targets, so that nobody accidentally could call shortstring
> versions.  (and only find out runtime)
> 
> But that was deemed to confusing, so now both sets are back again.

Well, this whole discussion is not about accidental calling of wrong 
version of anything but rather about getting support of the LFNs 
where needed. As pointed out by Jonas, the provided test program 
should work properly in cpstrrtl branch (even though the shortstring 
variants are still included there _in_addition_ to those providing 
full LFN support).

Tomas

___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] ExpandFileName failure on long filenames on Linux

2013-09-01 Thread Bart
On 9/1/13, Marco van de Voort  wrote:

> That was the original idea, removing the shortstring versions for not
> embedded targets, so that nobody accidentally could call shortstring
> versions.  (and only find out runtime)
>
> But that was deemed to confusing, so now both sets are back again.

If I understand you correctly:
This would mean that (in the cpstr branch) calling any IO function
with LongStrings (or the like) will NOT suffer from the problems the
shortstring counterparts have?

Bart
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] ExpandFileName failure on long filenames on Linux

2013-09-01 Thread Jonas Maebe

On 01 Sep 2013, at 16:34, Bart wrote:

> This would mean that (in the cpstr branch) calling any IO function
> with LongStrings (or the like) will NOT suffer from the problems the
> shortstring counterparts have?

Correct.


Jonas___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] ExpandFileName failure on long filenames on Linux

2013-09-01 Thread Bart
On 9/1/13, Jonas Maebe  wrote:

> Correct.

Thanks for the explanations.

Bart
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal


Re: [fpc-pascal] ExpandFileName failure on long filenames on Linux

2013-09-01 Thread Marco van de Voort
In our previous episode, Bart said:
> > That was the original idea, removing the shortstring versions for not
> > embedded targets, so that nobody accidentally could call shortstring
> > versions.  (and only find out runtime)
> >
> > But that was deemed to confusing, so now both sets are back again.
> 
> If I understand you correctly:
> This would mean that (in the cpstr branch) calling any IO function
> with LongStrings (or the like) will NOT suffer from the problems the
> shortstring counterparts have?

Yes, several problems were fixed. Mostly in the past they were considered
not worthwhile to fix (because it would only up from 255 to 260 chars).

Since in the unicode branch, the unicode functions are called that allow
longer strings (from memory: 8192 straight, and more with \\.\ prepended?),
it was decided to clean up all cases where there were shortstring only code
paths (like getdir).


___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-pascal