Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od
Thanks. Wondering why and where DCE is needed in FFmpeg build? On Mon, Dec 12, 2022 at 12:26 PM Timo Rothenpieler wrote: > On 12.12.2022 19:30, lilo...@gmail.com wrote: > > Currently -O1 is set to _cflags_noopt, but -O1 is actually for size > > optimization instead of no-opt which causes size optimized binaries > > been built with --disable-optimizations. > > It's like this very intentionally, since ffmpeg relies on > dead-code-elimination in a lot of places, which MSVC does not perform > when optimizations are turned off. > So optimizations cannot be fully turned off on MSVC. > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od
I built the latest FFmpeg with WSL2+MSVC on Windows. Tried configure with
--disable-optimizations, but still got an optimized build which makes it
hard to set breakpoint on hot functions (likely inlined).
On Mon, Dec 12, 2022 at 12:49 PM Carl Eugen Hoyos
wrote:
> Am Mo., 12. Dez. 2022 um 19:30 Uhr schrieb :
> >
> > Currently -O1 is set to _cflags_noopt, but -O1 is actually for size
> > optimization instead of no-opt which causes size optimized binaries
> > been built with --disable-optimizations.
> >
> > Signed-off-by: Thomson Tan
> > ---
> > configure | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index f4eedfc207..388d518345 100755
> > --- a/configure
> > +++ b/configure
> > @@ -4825,7 +4825,7 @@ probe_cc(){
> > _DEPFLAGS='$(CPPFLAGS) $(CFLAGS) -showIncludes -Zs'
> > _cflags_speed="-O2"
> > _cflags_size="-O1"
> > -_cflags_noopt="-O1"
> > +_cflags_noopt="-Od"
>
> I am curious:
> How did you test this patch?
>
> Thank you, Carl Eugen
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od
With this configuration (WSL2+MSVC) for this diff, I ran `make fate-rsync SAMPLES=fate-suite && make fate SAMPLES=fate-suite/` which passed locally. I also checked the binaries (ffmpeg.exe) and made sure the previous inlined functions are not inlined here. On Mon, Dec 12, 2022 at 1:13 PM Carl Eugen Hoyos wrote: > Am Mo., 12. Dez. 2022 um 22:02 Uhr schrieb Thomson Tan >: > > > > I built the latest FFmpeg with WSL2+MSVC on Windows. Tried configure > > with --disable-optimizations, but still got an optimized build which > makes > > it hard to set breakpoint on hot functions (likely inlined). > > Of course, this explains why you wrote the patch. > But I still wonder how you tested it. > > Please find out what top-posting means and avoid it here, Carl Eugen > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
