[FFmpeg-devel] Frame duplication support in FFMPEG for progressive frames' pulldown in HEVC
Hi all, Is there a support to handle pulldown feature of progressive HEVC streams in FFMPEG? FFMPEG already handles it for H.264 streams. Command line used to verify this in x264: x264.exe CIF_5frames_1fps.y4m --bframes 0 --fps 1 -o single.264 x264.exe CIF_5frames_1fps.y4m --bframes 0 --pulldown double -o double.264 "ffmpeg -i single.264" shows: Stream #0:0: Video: h264 (High), yuv420p(progressive), 352x288, 1 fps, 1 tbr, 1200k tbn, 2 tbc "ffmpeg -i double.264 shows: Stream #0:0: Video: h264 (High), yuv420p(progressive), 352x288, 1.67 fps, 2 tbr, 1200k tbn, 4 tbc Decoding using ffmpeg: ffmpeg -i single.264 -c:v rawvideo single.264.yuv (Gives 5 frames) ffmpeg -i double.264 -c:v rawvideo double.264.yuv (Gives 8 frames) The same doesn't work with x265 when I make param->pictureStructure=7 for HEVC frame doubling. Kindly let us know if there is a plan to implement handling of HEVC pulldown feature in FFMPEG? Thanks & Regards, Praveen Karadugattu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH]Support for Frame Doubling/ Tripling in FFMPEG's HEVC Decoder by parsing the picture_struct SEI value (Support for http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html)
Hi, This patch has the implementation for frame duplication (doubling/ tripling) in FFmpeg's HEVC decoder based on the picture_structre SEI value (7 for doubling and 8 for tripling) set while encoding. This addresses the requirement mentioned in the thread http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html Thanks & Regards, Praveen Support-for-Frame-Doubling-Tripling-in-FFMPEG-HEVC-Decoder.patch Description: Support-for-Frame-Doubling-Tripling-in-FFMPEG-HEVC-Decoder.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH]Support for Frame Doubling/ Tripling inFFMPEG's HEVC Decoder by parsing the picture_struct SEI value(Support forhttp://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html
Hi Michael, The given patch is expected to break compliance because there is no support for frame-doubling (pic_struct=7) and frame-tripling (pic_struct=8) in the HM decoder. I have verified this on the HM Decoder v16.8 incl RExt. In HM's TDecTop::xActivateParameterSets(), only the pic_struct values 1,2,9,10,11 and 12 are dealt with (ref: Line#355&366 of TDecTop.cpp). There is no provision to deal with pic_struct values 7 and 8 which deal with Doubling and Tripling respectively. Hence HM is not able to handle frame doubling/ tripling. I verified it by decoding and counting yuv frames as well. Thanks & Regards, Praveen From: ffmpeg-devel on behalf of Michael Niedermayer Sent: Friday, August 2, 2019 2:40 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH]Support for Frame Doubling/ Tripling inFFMPEG's HEVC Decoder by parsing the picture_struct SEI value(Support forhttp://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html) On Thu, Aug 01, 2019 at 12:46:21PM +0000, Praveen Kumar wrote: > Hi, > > This patch has the implementation for frame duplication (doubling/ tripling) > in FFmpeg's HEVC decoder based on the picture_structre SEI value (7 for > doubling and 8 for tripling) set while encoding. > This addresses the requirement mentioned in the thread > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html > > Thanks & Regards, > Praveen > hevc_parser.c | 29 + > hevc_sei.c|6 ++ > hevc_sei.h| 15 +++ > hevcdec.c |8 > 4 files changed, 58 insertions(+) > 1acaad49a85cde86f32440d05b764ca2304887cd > Support-for-Frame-Doubling-Tripling-in-FFMPEG-HEVC-Decoder.patch > From 6b602399c68ce7062d8c2aefee9b3814be3f3b0e Mon Sep 17 00:00:00 2001 > From: Praveen Karadugattu > Date: Thu, 1 Aug 2019 17:47:36 +0530 > Subject: [PATCH] Support for Frame Doubling/ Tripling in FFMPEG's HEVC Decoder > by parsing the picture_struct SEI value (Support for > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html) Breaks hevc fate tests TESThevc-conformance-WP_MAIN10_B_Toshiba_3 --- ./tests/ref/fate/hevc-conformance-WP_MAIN10_B_Toshiba_3 2019-07-31 21:32:01.464064534 +0200 +++ tests/data/fate/hevc-conformance-WP_MAIN10_B_Toshiba_3 2019-08-02 10:55:39.707488117 +0200 @@ -4,258 +4,131 @@ #dimensions 0: 416x240 #sar 0: 0/1 0, 0, 0,1, 299520, 0x6ecba46b -0, 1, 1,1, 299520, 0x54e6ef0a -0, 2, 2,1, 299520, 0x7a4d46c5 -0, 3, 3,1, 299520, 0xccd57f4e -0, 4, 4,1, 299520, 0xbe0cb48d -0, 5, 5,1, 299520, 0x10e7b49f -0, 6, 6,1, 299520, 0x81aa72e2 -0, 7, 7,1, 299520, 0x5bf7b51f -0, 8, 8,1, 299520, 0xfcedee4a -0, 9, 9,1, 299520, 0x586c99b6 -0, 10, 10,1, 299520, 0x414ca13c -0, 11, 11,1, 299520, 0x3f0162f2 -0, 12, 12,1, 299520, 0x4d450c05 -0, 13, 13,1, 299520, 0x0a58bd84 -0, 14, 14,1, 299520, 0x26e8394d -0, 15, 15,1, 299520, 0xfd78121b -0, 16, 16,1, 299520, 0x6afeaf44 -0, 17, 17,1, 299520, 0x3e9a9270 -0, 18, 18,1, 299520, 0x58b889ca -0, 19, 19,1, 299520, 0x0245ba62 -0, 20, 20,1, 299520, 0xddecc5ab -0, 21, 21,1, 299520, 0x32cf3cd9 -0, 22, 22,1, 299520, 0x5c0a0440 -0, 23, 23,1, 299520, 0x9d3e2fee -0, 24, 24,1, 299520, 0x2894c708 -0, 25, 25,1, 299520, 0x25be67d5 -0, 26, 26,1, 299520, 0xe3ece9d6 -0, 27, 27,1, 299520, 0xcc98e38b -0, 28, 28,1, 299520, 0xc448c794 -0, 29, 29,1, 299520, 0xb4f75575 -0, 30, 30,1, 299520, 0xac74a437 -0, 31, 31,1, 299520, 0x09c7f2e2 -0, 32, 32,1, 299520, 0xbfaed8ab -0, 33, 33,1, 299520, 0xb077d700 -0, 34, 34,1, 299520, 0x6efa0545 -0, 35, 35,1, 299520, 0xb8c1802d -0, 36, 36,1, 299520, 0x794774f8 -0, 37, 37,1, 299520, 0x1098f4ff -0, 38, 38,1, 299520, 0x80ab8bfc -0, 39, 39,1, 299520, 0xc324c3bc -0, 40, 40,1, 299520, 0x1eee77cd -0, 41, 41,
[FFmpeg-devel] [PATCH]Support for Frame Duplication (Doubling/ Tripling) by FFMPEG's HEVC Decoder by parsing the picture_struct SEI value (Requirement: http://ffmpeg.org/pipermail/ffmpeg-devel/2019-Ju
Hi, This patch has the implementation for supporting frame duplication (doubling/ tripling) by FFmpeg's HEVC decoder based on the picture_structre SEI value present in the encoded video. picture_structure value of 7 implies doubling and 8 implies tripling. The value of picture_structure is set while encoding. This addresses the requirement mentioned in the thread http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html Thanks & Regards, Praveen HEVC_Frame_Doubling_Tripling.patch Description: HEVC_Frame_Doubling_Tripling.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] Support for Frame Duplication (Doubling/Tripling) by FFMPEG's HEVC Decoder by parsing the picture_struct SEI value(Requirement:http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June
Hi, Re-sending the patch after incorporating the review comments over the previous patch sent yesterday. This patch has the implementation for supporting frame duplication (doubling/ tripling) by FFmpeg's HEVC decoder based on the picture_structre SEI value present in the encoded video. picture_structure value of 7 implies doubling and 8 implies tripling. The value of picture_structure is set while encoding. This addresses the requirement mentioned in the thread http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html Thanks & Regards, Praveen HEVC_Frame_Doubling_Tripling.patch Description: HEVC_Frame_Doubling_Tripling.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFMPEG's HEVC Decoder by parsing the picture_structSEIvalue(Requirement:http://ffmpeg.org/pipermail/ffmpeg-devel/2019-Jun
Thanks Kieran. Rectified the patch to just use repeat_pict for frame duplication and avoided modifying ticks_per_frame. Please find the updated patch attached here with and accept the same. Thanks & Regards, Praveen From: ffmpeg-devel on behalf of Kieran Kunhya Sent: Thursday, January 9, 2020 6:46 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFMPEG's HEVC Decoder by parsing the picture_structSEIvalue(Requirement:http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html) On Thu, 9 Jan 2020 at 10:09, Praveen Kumar wrote: > Hi, > > Re-sending the patch after incorporating the review comments over the > previous patch sent yesterday. > Hi, Leave ticks_per_frame alone. I don't see why you are changing it. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". HEVC_Frame_Doubling_Tripling.patch Description: HEVC_Frame_Doubling_Tripling.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFMPEG's HEVC Decoder by parsing the picture_structSEIvalue(Requirement:http://ffmpeg.org/pipermail/ffmpeg-devel/2019-Jun
Hi all, Could you please review and take this patch forward. Thanks & Regards, Praveen From: Praveen Kumar Sent: Thursday, January 23, 2020 7:12 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFMPEG's HEVC Decoder by parsing the picture_structSEIvalue(Requirement:http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html) Thanks Kieran. Rectified the patch to just use repeat_pict for frame duplication and avoided modifying ticks_per_frame. Please find the updated patch attached here with and accept the same. Thanks & Regards, Praveen From: ffmpeg-devel on behalf of Kieran Kunhya Sent: Thursday, January 9, 2020 6:46 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFMPEG's HEVC Decoder by parsing the picture_structSEIvalue(Requirement:http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html) On Thu, 9 Jan 2020 at 10:09, Praveen Kumar wrote: > Hi, > > Re-sending the patch after incorporating the review comments over the > previous patch sent yesterday. > Hi, Leave ticks_per_frame alone. I don't see why you are changing it. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFmpeg's HEVC Decoder by parsing the picture_struct SEI
Hi, Re-submitting the patch. This patch has the implementation for supporting frame-duplication (doubling/ tripling) by FFmpeg's HEVC decoder based on the picture_structure SEI value present in the encoded video. picture_structure value of 7 implies doubling and 8 implies tripling. The value of picture_structure is set while encoding. More details here: http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html Thanks & Regards, Praveen HEVC_Frame_Doubling_Tripling.patch Description: HEVC_Frame_Doubling_Tripling.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFmpeg's HEVC Decoder by parsing the picture_struct SEI
Yes Kieran, kindly push it to default. Many thanks for reviewing it and sharing your inputs. Regards, Praveen From: Kieran Kunhya Sent: Tuesday, February 4, 2020 10:58 PM To: Praveen Kumar Cc: ffmpeg-devel@ffmpeg.org ; Thilo Borgmann ; Kieran Kunhya ; Michael Niedermayer ; Praveen Kumar Karadugattu Subject: Re: [FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFmpeg's HEVC Decoder by parsing the picture_struct SEI On Wed, 29 Jan 2020 at 13:25, Praveen Kumar mailto:praveenku...@outlook.com>> wrote: Hi, Re-submitting the patch. This patch has the implementation for supporting frame-duplication (doubling/ tripling) by FFmpeg's HEVC decoder based on the picture_structure SEI value present in the encoded video. picture_structure value of 7 implies doubling and 8 implies tripling. The value of picture_structure is set while encoding. More details here: http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html Thanks & Regards, Praveen Patch is fine, would you like me to push it? Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFmpeg's HEVC Decoder by parsing the picture_struct SEI
Hi Kieren, Request you to kindly accept the patch and merge it. Thanks & Regards, Praveen From: Praveen Kumar Sent: Wednesday, February 5, 2020 11:40 AM To: Kieran Kunhya Cc: ffmpeg-devel@ffmpeg.org ; Thilo Borgmann ; Michael Niedermayer ; Praveen Kumar Karadugattu Subject: Re: [FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFmpeg's HEVC Decoder by parsing the picture_struct SEI Yes Kieran, kindly push it to default. Many thanks for reviewing it and sharing your inputs. Regards, Praveen From: Kieran Kunhya Sent: Tuesday, February 4, 2020 10:58 PM To: Praveen Kumar Cc: ffmpeg-devel@ffmpeg.org ; Thilo Borgmann ; Kieran Kunhya ; Michael Niedermayer ; Praveen Kumar Karadugattu Subject: Re: [FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFmpeg's HEVC Decoder by parsing the picture_struct SEI On Wed, 29 Jan 2020 at 13:25, Praveen Kumar mailto:praveenku...@outlook.com>> wrote: Hi, Re-submitting the patch. This patch has the implementation for supporting frame-duplication (doubling/ tripling) by FFmpeg's HEVC decoder based on the picture_structure SEI value present in the encoded video. picture_structure value of 7 implies doubling and 8 implies tripling. The value of picture_structure is set while encoding. More details here: http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.html Thanks & Regards, Praveen Patch is fine, would you like me to push it? Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
