[FFmpeg-devel] Submitting patches.
Is there a FAQ or other documentation on how to submit patches? There's a compiler warning that's driving me nuts and I'd like to clean it up if I can. Thank you, Mike ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] PPC64: Add versions of functions in libswscale/input.c optimized for POWER8 VSX SIMD.
A later patch to configure to make sure it was defined, so the breakage stopped. The patch for the configure option and the code should have been atomic, IMNSHO. On Thu, Jul 7, 2016 at 8:42 PM, Michael Niedermayer wrote: > On Thu, Jun 30, 2016 at 03:36:31PM +0200, Michael Niedermayer wrote: > > On Wed, Jun 29, 2016 at 04:15:12PM +, Dan Parrot wrote: > > > This patch addresses Trac ticket #5570. The optimized functions are in > file > > > libswscale/ppc/input_vsx.c. Each optimized function name is a > concatenation of the > > > corresponding name in libswscale/input.c with suffix _vsx. > > > --- > > > libswscale/ppc/Makefile | 1 + > > > libswscale/ppc/input_vsx.c| 437 > ++ > > > libswscale/swscale.c | 3 + > > > libswscale/swscale_internal.h | 1 + > > > 4 files changed, 442 insertions(+) > > > create mode 100644 libswscale/ppc/input_vsx.c > > > > patch applied > > > > Please keep an eye on fate.ffmpeg.org, if it breaks on one of the ppc > > machines i will revert the patch > > According to https://trac.ffmpeg.org/ticket/5570#comment:3 > this broke build on some machines > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > It is dangerous to be right in matters on which the established authorities > are wrong. -- Voltaire > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] use proper macro to avoid issue with prior avutil/timestamp.c
>From b2ddfdd9ed695a1f47ed6251369abca08864e3ab Mon Sep 17 00:00:00 2001
From: Mike Lieman
Date: Fri, 16 Aug 2024 23:05:51 -0400
Subject: [PATCH] use proper macro to avoid issue with prior
avutil/timestamp.c
patch causing long startup times with some files under mplayer
(https://trac.mplayerhq.hu/ticket/2425)
---
libavutil/timestamp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/timestamp.c b/libavutil/timestamp.c
index 6c231a517d..eab2531538 100644
--- a/libavutil/timestamp.c
+++ b/libavutil/timestamp.c
@@ -24,7 +24,7 @@ char *av_ts_make_time_string2(char *buf, int64_t ts,
AVRational tb)
snprintf(buf, AV_TS_MAX_STRING_SIZE, "NOPTS");
} else {
double val = av_q2d(tb) * ts;
-double log = (fpclassify(val) == FP_ZERO ? -INFINITY :
floor(log10(fabs(val;
+double log = (fpclassify(val) == FP_ZERO ? FP_INFINITE :
floor(log10(fabs(val;
int precision = (isfinite(log) && log < 0) ? -log + 5 : 6;
int last = snprintf(buf, AV_TS_MAX_STRING_SIZE, "%.*f", precision,
val);
last = FFMIN(last, AV_TS_MAX_STRING_SIZE - 1) - 1;
--
2.46.0
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] use proper macro to avoid issue with prior avutil/timestamp.c
> > FP_INFINITE is a return value from fpclassify(), not a double. > > Does maybe using av_int2double(UINT64_C(0xFFF) << 52) help your slow > startup? > Sadly, no. double log = (fpclassify(val) == FP_ZERO ? av_int2double(UINT64_C(0xFFF) << 52) : floor(log10(fabs(val; gives the same long-startup time. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] use proper macro to avoid issue with prior avutil/timestamp.c
I now understand that and am trying to work through the logic to see why
we are getting this strange behaviour.When I have some free time, I
think I'm going to have to step through this with gdb since without the
context of what's actually in buf, ts, and tb I can't understand what's
going on in the for loops, but it seems something's going on in the for
loops, since it's not happening when I'm using the incorrect constant.
On Sat, Aug 17, 2024 at 10:07 AM Rémi Denis-Courmont
wrote:
>
>
> Le 17 août 2024 06:09:16 GMT+03:00, Mike Lieman a
> écrit :
> >From b2ddfdd9ed695a1f47ed6251369abca08864e3ab Mon Sep 17 00:00:00 2001
> >From: Mike Lieman
> >Date: Fri, 16 Aug 2024 23:05:51 -0400
> >Subject: [PATCH] use proper macro to avoid issue with prior
> >avutil/timestamp.c
> > patch causing long startup times with some files under mplayer
> > (https://trac.mplayerhq.hu/ticket/2425)
> >
> >---
> > libavutil/timestamp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/libavutil/timestamp.c b/libavutil/timestamp.c
> >index 6c231a517d..eab2531538 100644
> >--- a/libavutil/timestamp.c
> >+++ b/libavutil/timestamp.c
> >@@ -24,7 +24,7 @@ char *av_ts_make_time_string2(char *buf, int64_t ts,
> >AVRational tb)
> > snprintf(buf, AV_TS_MAX_STRING_SIZE, "NOPTS");
> > } else {
> > double val = av_q2d(tb) * ts;
> >-double log = (fpclassify(val) == FP_ZERO ? -INFINITY :
> >floor(log10(fabs(val;
> >+double log = (fpclassify(val) == FP_ZERO ? FP_INFINITE :
>
> You're papering over whatever the real issue is here. As noted by James
> and the Trac issue already, FP_INFINITE is *not* a floating point value and
> using it this way makes no sense.
>
> >floor(log10(fabs(val;
> > int precision = (isfinite(log) && log < 0) ? -log + 5 : 6;
> > int last = snprintf(buf, AV_TS_MAX_STRING_SIZE, "%.*f",
> precision,
> >val);
> > last = FFMIN(last, AV_TS_MAX_STRING_SIZE - 1) - 1;
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] use proper macro to avoid issue with prior avutil/timestamp.c
> > On Sat, Aug 17, 2024 at 11:29 AM Hendrik Leppkes > wrote: > Or you could check if your build uses ffast-math, not sure we support that > Hot Dog! We have a weiner! Removing -ffast-math from my mplayer build appears to have resolved the issue. Thank you for your time and guidance. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
