Re: [FFmpeg-devel] [PATCH] configure: Include quotes around pkg_version

2024-12-26 Thread J Shiff
On Wed, Dec 25, 2024 at 5:03 PM Alexander Strasser via ffmpeg-devel
 wrote:
>
> On 2024-12-21 19:29 -0500, J Shiff wrote:
> > On Sat, Dec 21, 2024 at 5:44 PM Alexander Strasser via ffmpeg-devel
> >  wrote:
> > >
> > > On 2024-12-16 16:19 -0500, Joe Schiffler wrote:
> > > > Since $pkg_version includes spaces, builds can fail in some MSYS 
> > > > environments.
> > >
> > > Could you show what the pkg_version with spaces was in your case?
> >
> > The value of pkg_version would be: `aom >= 2.0.0`
>
> Ok, thanks for coming back to this!
>
> What is still strange about it: What changed and where?
>
> These values for pkg_version should come up on every platform
> and AFAICT it works just fine for me and many others.
>
> Didn't spot any relevant changes in ffmpeg configure on a quick
> look.
>
> Would be better to understand why it fails only in some
> environments and not others.

Thank you for showing interest in this topic.

Yeah, I also find it strange.
If you have any recommendations for narrowing it down further, I'm
open to suggestions.

My only guess would be there is some difference between how
pkg-config and pkgconf expect the user to handle spaces and quotes.

What are the potential negative consequences of including the quotes?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH] configure: Include quotes around pkg_version

2024-12-21 Thread J Shiff
On Sat, Dec 21, 2024 at 5:44 PM Alexander Strasser via ffmpeg-devel
 wrote:
>
> On 2024-12-16 16:19 -0500, Joe Schiffler wrote:
> > Since $pkg_version includes spaces, builds can fail in some MSYS 
> > environments.
>
> Could you show what the pkg_version with spaces was in your case?

The value of pkg_version would be: `aom >= 2.0.0`

However, this was because aom was the first package included in the build.
If I disabled aom, then the next package (dav1d) would give a similar
error, and so on.

I get this error message found in ffbuild/config.log:
`Can't find >=.pc in any of` ...

The message should be:
`Can't find aom.pc in any of` ...

The ellipsis represents the value of the PKG_CONFIG_PATH environment variable.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".