[FFmpeg-devel] [PATCH] build: fix msvc build

2016-01-23 Thread charlie . arnold 
From: Charlie Arnold 

Fix configure to set DST_PATH to the Windows style path when building with MSVC
---
 configure | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 8f4642b..f7d1000 100755
--- a/configure
+++ b/configure
@@ -6233,6 +6233,12 @@ enabled stripping || strip="echo skipping strip"
 
 config_files="$TMPH config.mak doc/config.texi"
 
+if enabled msvc; then
+dst_path=$(pwd -W)
+else
+dst_path=$(pwd)
+fi
+
 cat > config.mak <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] build: fix msvc build

2016-01-23 Thread Charlie Arnold 
I did, works for both in and out of tree builds

On Sat, Jan 23, 2016 at 1:15 PM, Andreas Cadhalpun <
andreas.cadhal...@googlemail.com> wrote:

> On 23.01.2016 22:11, charlie.arn...@gmail.com wrote:
> > From: Charlie Arnold 
> >
> > Fix configure to set DST_PATH to the Windows style path when building
> with MSVC
> > ---
> >  configure | 8 +++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 8f4642b..f7d1000 100755
> > --- a/configure
> > +++ b/configure
> > @@ -6233,6 +6233,12 @@ enabled stripping || strip="echo skipping strip"
> >
> >  config_files="$TMPH config.mak doc/config.texi"
> >
> > +if enabled msvc; then
> > +dst_path=$(pwd -W)
> > +else
> > +dst_path=$(pwd)
> > +fi
> > +
>
> That would be great, if it works. Did you test it?
>
> Best regards,
> Andreas
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] build: fix msvc build

2016-01-23 Thread Charlie Arnold 
I can fix it to check $host_os = cygwin, and use cygpath in that case.  I
don't have cygwin installed to test tho.

On Sat, Jan 23, 2016 at 1:28 PM, Andreas Cadhalpun <
andreas.cadhal...@googlemail.com> wrote:

> On 23.01.2016 22:25, James Darnley wrote:
> > On 2016-01-23 22:11, charlie.arn...@gmail.com wrote:
> >> +if enabled msvc; then
> >> +dst_path=$(pwd -W)
> >> +else
> >> +dst_path=$(pwd)
> >> +fi
> >> +
> >
> > If using MSVC through Cygwin is supported this would fail.  Its pwd
> > command does not have the -W option.
>
> I'm not sure if that's supported, but cygwin has cygpath, so
> that could be used there.
>
> > Most people probably don't use both.
>
> So you think it's sufficient as it is?
>
> Best regards,
> Andreas
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] build: fix MSVC under cygwin

2016-01-23 Thread charlie . arnold 
From: Charles Arnold 

Use cygpath -w when running under cygwin, and pwd -W under mingw
---
 configure | 12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index f7d1000..94a694a 100755
--- a/configure
+++ b/configure
@@ -6234,7 +6234,17 @@ enabled stripping || strip="echo skipping strip"
 config_files="$TMPH config.mak doc/config.texi"
 
 if enabled msvc; then
-dst_path=$(pwd -W)
+case $host_os in
+mingw32*|mingw64*)
+dst_path=$(pwd -W)
+;;
+cygwin*)
+dst_path=$(cygpath -w $(pwd))
+;;
+*)
+dst_path=$(pwd)
+;;
+esac
 else
 dst_path=$(pwd)
 fi
-- 
1.9.5.msysgit.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] build: fix MSVC under cygwin

2016-01-23 Thread Charlie Arnold 
On Sat, Jan 23, 2016 at 3:06 PM, James Darnley 
wrote:

> Is mingw the right host_os value for you?
>
>
Yes, mingw works for me.  Here's my uname:

$ uname -s
MINGW32_NT-6.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel