Re: [FFmpeg-devel] [PATCH 04/12] libavcodec: Implementation of AAC_fixed_decoder (LC-module) [4/4]

[Cary Tetrick]

Are there any patches supporting Intel QSV encoding that will work with
recent versions of ffmpeg on Windows?
Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Intel QSV encoder

[Cary Tetrick]

Sorry, sent with wrong subject.

Are there any patches supporting Intel QSV encoding that will work with
recent versions of ffmpeg on Windows?
Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] rtmp patch

[Cary Tetrick]

Hello,
I have a patch I'd like to submit. One part is in the
*git://git.ffmpeg.org/rtmpdump
 repository, and the other in the regular
ffmpeg repository (librtmp.c).*
*what is the correct way to coordinate this?*

*Thanks,*
*Cary*
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] Socket options for librtmp

[Cary Tetrick]

This reimplements a change authored by Brian Brice 
2015-01-19
"librtmp: Allow changing the socket send buffer size"
(Brian is aware of this change).
also negates change by Michael Niedermayer   2015-01-23
10:45:35
"avformat/librtmp: Fix build with --disable-network --enable-librtmp"
because it is no longer necessary.

The reason for this is that the socket settings changes need to be made in
librtmp
internally because:
  1. librtmp may attemp a new socket connection internally.
 in that case, it would not get the buffer settings.
  2. if using the tee muxer to send to more than one destination, the
arguments
 can't be passed through the flv muxer. passing them as key-value
paires in
  the manner already supported in librtmp works for that use case.

A patch has been sent to the librtmp mailing list rtmpd...@mplayerhq.hu
with the title "subject: librtmp arguments added for socket buffer size".

*This* patch is dependent on the one above, and should be applied after it
appears in the git://git.ffmpeg.org/rtmpdump repository.

Options to the ffmpeg commandline in support of now arguments in librtmp.
rtmp_buffer_size - sets rtmp socket send buffer size in bytes.
this is the same as the patch it replaces.
rtmp_nodelay - on or off. defaults to on.
allows users to control whether nagel is active.
 rtmp_buffchunks - on or off. default is off.
allows users to try using internal buffering instead of writing 128
byte
  chunks to sockets.

See this thread on Zeranoe forum:
http://ffmpeg.zeranoe.com/forum/viewtopic.php?f=7&t=657&p=7823#p7823

I believe this addresses case 1604 on the ffmpeg tracker.
"Summary of the bug: Rtmp output to justin.tv fps continually drops, ..."
- note the memory problem mentioned had been fixed. This fix only applies if
librtmp is enabled.
https://trac.ffmpeg.org/ticket/1604

Defualt behavior leaves things unchanged. Users must employ options
intentionally.


0001-Topic-Socket-options-for-librtmp.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Socket options for librtmp

[Cary Tetrick]

>
> please ping this thread when this happens
>
> about the patch itself
>
> IIUC a user using old rtmpdump with new ffmpeg would loose the
> rtmp_buffer_size option.
> Would it make sense to support the old setsockopt() code for this
> case ?
>
> [...]
>
>
>
That's a really good point. So the only real question then is whether to
keep it the way it is, or to submit another patch to support the other two
options (which are not as important IMO) in the same manner as Brian's
patch.
Either way, it would eliminate the dependency on rtmpdump.
What do you think?

Thanks,
Cary
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [Patch] no_delay option for librtmp

[Cary Tetrick]

This adds another option to a change authored by Brian Brice <
bbr...@gmail.com> 2015-01-19
 "librtmp: Allow changing the socket send buffer size"
 (Brian is aware of this change).

 Unlike a previous patch, this has no dependency on rtmpdump.

 Options to the ffmpeg commandline in support of now arguments in librtmp.
 rtmp_buffer_size - sets rtmp socket send buffer size in bytes.
 this is the same as the patch it replaces.
 rtmp_nodelay - on or off. defaults to on.
 allows users to control whether nagel is active.

 See this thread on Zeranoe forum:
 http://ffmpeg.zeranoe.com/forum/viewtopic.php?f=7&t=657&p=7823#p7823

 I believe this addresses case 1604 on the ffmpeg tracker.
 "Summary of the bug: Rtmp output to justin.tv fps continually drops, ..."
 - note the memory problem mentioned had been fixed. This fix only applies
if
 librtmp is enabled.
 https://trac.ffmpeg.org/ticket/1604
 Defualt behavior leaves things unchanged. Users must employ options
intentionally.

My previous patch should be ignored.


0001-This-adds-another-option-to-a-change-authored-by-Bri.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [Patch] no_delay option for librtmp

[Cary Tetrick]

Use this instead. (sorry, corrected grammatical errors.)


On Thu, Feb 26, 2015 at 1:22 PM, Cary Tetrick  wrote:

> This adds another option to a change authored by Brian Brice <
> bbr...@gmail.com> 2015-01-19
>  "librtmp: Allow changing the socket send buffer size"
>  (Brian is aware of this change).
>
>  Unlike a previous patch, this has no dependency on rtmpdump.
>
>  Options to the ffmpeg commandline in support of now arguments in librtmp.
>  rtmp_buffer_size - sets rtmp socket send buffer size in bytes.
>  this is the same as the patch it replaces.
>  rtmp_nodelay - on or off. defaults to on.
>  allows users to control whether nagel is active.
>
>  See this thread on Zeranoe forum:
>  http://ffmpeg.zeranoe.com/forum/viewtopic.php?f=7&t=657&p=7823#p7823
>
>  I believe this addresses case 1604 on the ffmpeg tracker.
>  "Summary of the bug: Rtmp output to justin.tv fps continually drops, ..."
>  - note the memory problem mentioned had been fixed. This fix only applies
> if
>  librtmp is enabled.
>  https://trac.ffmpeg.org/ticket/1604
>  Defualt behavior leaves things unchanged. Users must employ options
> intentionally.
>
> My previous patch should be ignored.
>


0001-Topic-Option-to-control-no_delay-flag-in-librtmp.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [Patch] no_delay option for librtmp

[Cary Tetrick]

No, i just extended what Brian already had. Just an option to to control
the no delay. I put the changes inside you #if for networking config.
On Feb 26, 2015 7:42 PM, "Michael Niedermayer"  wrote:

> On Thu, Feb 26, 2015 at 03:23:40PM -0600, Cary Tetrick wrote:
> > Use this instead. (sorry, corrected grammatical errors.)
> >
> >
> > On Thu, Feb 26, 2015 at 1:22 PM, Cary Tetrick 
> wrote:
> >
> > > This adds another option to a change authored by Brian Brice <
> > > bbr...@gmail.com> 2015-01-19
> > >  "librtmp: Allow changing the socket send buffer size"
> > >  (Brian is aware of this change).
> > >
> > >  Unlike a previous patch, this has no dependency on rtmpdump.
> > >
> > >  Options to the ffmpeg commandline in support of now arguments in
> librtmp.
> > >  rtmp_buffer_size - sets rtmp socket send buffer size in bytes.
> > >  this is the same as the patch it replaces.
> > >  rtmp_nodelay - on or off. defaults to on.
> > >  allows users to control whether nagel is active.
> > >
> > >  See this thread on Zeranoe forum:
> > >  http://ffmpeg.zeranoe.com/forum/viewtopic.php?f=7&t=657&p=7823#p7823
> > >
> > >  I believe this addresses case 1604 on the ffmpeg tracker.
> > >  "Summary of the bug: Rtmp output to justin.tv fps continually drops,
> ..."
> > >  - note the memory problem mentioned had been fixed. This fix only
> applies
> > > if
> > >  librtmp is enabled.
> > >  https://trac.ffmpeg.org/ticket/1604
> > >  Defualt behavior leaves things unchanged. Users must employ options
> > > intentionally.
> > >
> > > My previous patch should be ignored.
> > >
>
> >  librtmp.c |   11 ++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> > 0957935410df54a8122e3cd62d771d87a39c4347
> 0001-Topic-Option-to-control-no_delay-flag-in-librtmp.patch
> > From fe8be0cdb6ed76a67283bb1000585af79b492d4d Mon Sep 17 00:00:00 2001
> > From: Cary Tetrick 
> > Date: Thu, 26 Feb 2015 15:18:47 -0600
> > Subject: [PATCH]  Topic: Option to control no_delay flag in librtmp
> >
> >  This adds another option to a change authored by Brian Brice <
> bbr...@gmail.com> 2015-01-19
> >  "librtmp: Allow changing the socket send buffer size"
> >  (Brian is aware of this change).
> >
> >  Unlike a previous patch, this has no dependency on rtmpdump.
> >
> >  Options to the ffmpeg commandline in support of now arguments in
> librtmp.
> >  rtmp_buffer_size - sets rtmp socket send buffer size in bytes.
> >  this is the same as the patch it replaces.
> >  rtmp_nodelay - on or off. defaults to on.
> >  allows users to control whether nagel is active.
> >
> >  See this thread on Zeranoe forum:
> >  http://ffmpeg.zeranoe.com/forum/viewtopic.php?f=7&t=657&p=7823#p7823
> >
> >  I believe this addresses case 1604 on the ffmpeg tracker.
> >  "Summary of the bug: Rtmp output to justin.tv fps continually drops,
> ..."
> >  - note the memory problem mentioned had been fixed. This fix only
> applies if
> >  librtmp is enabled.
> >  https://trac.ffmpeg.org/ticket/1604
> >
> >  Defualt behavior leaves things unchanged. Users must employ options
> intentionally.
> > ---
> >  libavformat/librtmp.c | 11 ++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/librtmp.c b/libavformat/librtmp.c
> > index bfa9a71..64ae59d 100644
> > --- a/libavformat/librtmp.c
> > +++ b/libavformat/librtmp.c
> > @@ -52,6 +52,7 @@ typedef struct LibRTMPContext {
> >  int live;
> >  char *temp_filename;
> >  int buffer_size;
> > +int tcp_nodelay;
> >  } LibRTMPContext;
> >
> >  static void rtmp_log(int level, const char *fmt, va_list args)
> > @@ -239,6 +240,11 @@ static int rtmp_open(URLContext *s, const char
> *uri, int flags)
> >  int tmp = ctx->buffer_size;
> >  setsockopt(r->m_sb.sb_socket, SOL_SOCKET, SO_SNDBUF, &tmp,
> sizeof(tmp));
> >  }
> > +
> > +if (flags & AVIO_FLAG_WRITE) {
> > +int tmp = ctx->tcp_nodelay;
> > +setsockopt(r->m_sb.sb_socket, IPPROTO_TCP, TCP_NODELAY, &tmp,
> sizeof(tmp));
>
> does this need any #includes, any checks in configure?
>
> [...]
>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Freedom in capitalist society always remains about the same as it was in
> ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [Patch] no_delay option for librtmp

[Cary Tetrick]

It looks like #include  might work BUT
According to this page http://linux.die.net/man/7/tcp
it looks like this socket setting is not truly portable. :(
My intent was to offer some flexibility in what looks like a long standing
problem with rtmp streaming.
For my purposes, I can get by with changes I made to rtmpdump.
My sincere apologies for wasting your time.

On Thu, Feb 26, 2015 at 9:29 PM, Michael Niedermayer 
wrote:

> On Thu, Feb 26, 2015 at 08:00:49PM -0600, Cary Tetrick wrote:
> > No, i just extended what Brian already had. Just an option to to control
> > the no delay. I put the changes inside you #if for networking config.
>
> you misunderstood my question
>
> my question is what #includes it needs and if this is portable and
> available on all platforms which support CONFIG_NETWORK?
>
> there certainly is something missing as it does not build.
>
> libavformat/librtmp.c: In function ‘rtmp_open’:
> libavformat/librtmp.c:246:52: error: ‘TCP_NODELAY’ undeclared (first use
> in this function)
> libavformat/librtmp.c:246:52: note: each undeclared identifier is reported
> only once for each function it appears in
> make: *** [libavformat/librtmp.o] Error 1
>
>
> [...]
> > > > +
> > > > +if (flags & AVIO_FLAG_WRITE) {
> > > > +int tmp = ctx->tcp_nodelay;
> > > > +setsockopt(r->m_sb.sb_socket, IPPROTO_TCP, TCP_NODELAY,
> &tmp,
> > > sizeof(tmp));
> > >
> > > does this need any #includes, any checks in configure?
> > >
> > > [...]
> > >
> > > --
> > > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> > >
> > > Freedom in capitalist society always remains about the same as it was
> in
> > > ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
> > >
> > > ___
> > > ffmpeg-devel mailing list
> > > ffmpeg-devel@ffmpeg.org
> > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > >
> > >
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Everything should be made as simple as possible, but not simpler.
> -- Albert Einstein
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel