Re: [FFmpeg-devel] [PATCH] Implement hdcd filtering

[Benjamin St]

I tried to test with the files sample.cdda.flac and
> sample.hdcd.flac attached in the ticket.
> The output is different and one possible reason
> is the usage of floating point arithmetic in the
> filter.
>

Did you compare flac files or raw audiodata (e.g. wav)? For me flac it is
not identical but wav is.(probably due to different flac encoders?)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Implement hdcd filtering

[Benjamin St]

>
> fails make fate

It's due to the copyright header. I still don't know how to handle this
correct as this filter is based on https://github.com/kode54/foo_hdcd/,
which contains:

> 1. Redistributions of source code must retain the above copyright
> notice, this list of conditions and the following disclaimer.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Implement hdcd filtering

[Benjamin St]

> if the license is compatible with the LGPL then you could be added to
> the exceptions
>
Is it compatible? I would say yes... (but I'm not sure)
Any further comments?

Thanks, Benjamin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] Use int32_t instead of int for gaintable in hdcd filter

[Benjamin St]

From 11bbac3343cb06ce0862ffbbf6365ba834b4284b Mon Sep 17 00:00:00 2001
From: Benjamin Steffes 
Date: Sun, 29 May 2016 17:45:33 +0200
Subject: [PATCH] Use int32_t instead of int for gaintable in hdcd filter.

Signed-off-by: Benjamin Steffes 
---
 libavfilter/af_hdcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c
index 7907edf..16bdcb0 100644
--- a/libavfilter/af_hdcd.c
+++ b/libavfilter/af_hdcd.c
@@ -683,7 +683,7 @@ static const uint8_t readaheadtab[] = {
 };
 
 //values between 0 and 1 multiplied by 2^23 to avoid floating point numbers.
-static const int gaintab[] = {
+static const int32_t gaintab[] = {
 0x80, 0x7ff144, 0x7fe28a, 0x7fd3d2, 0x7fc51b, 0x7fb666, 0x7fa7b3, 0x7f9901, 0x7f8a52, 0x7f7ba3, 0x7f6cf7, 0x7f5e4c, 0x7f4fa3, 0x7f40fc, 0x7f3256,
 0x7f23b2, 0x7f1510, 0x7f066f, 0x7ef7d0, 0x7ee933, 0x7eda97, 0x7ecbfd, 0x7ebd65, 0x7eaece, 0x7ea039, 0x7e91a6, 0x7e8315, 0x7e7485, 0x7e65f6, 0x7e576a,
 0x7e48df, 0x7e3a56, 0x7e2bce, 0x7e1d49, 0x7e0ec5, 0x7e0042, 0x7df1c1, 0x7de342, 0x7dd4c5, 0x7dc649, 0x7db7cf, 0x7da956, 0x7d9adf, 0x7d8c6a, 0x7d7df7,
-- 
2.5.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel