Re: [FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-22 Thread Abdulrahman Saber
On Tue, Jan 14, 2025 at 2:02 PM Abdulrahman Saber  wrote:
>
> Signed-off-by: abdo 
> ---
>   libavfilter/vf_signalstats.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c
> index b1451cc465..9b6af8becd 100644
> --- a/libavfilter/vf_signalstats.c
> +++ b/libavfilter/vf_signalstats.c
> @@ -20,6 +20,7 @@
>* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> 02110-1301 USA
>*/
>   +#include "libavutil/internal.h"
>   #include "libavutil/intreadwrite.h"
>   #include "libavutil/mem.h"
>   #include "libavutil/opt.h"
> @@ -829,7 +830,7 @@ static const AVFilterPad signalstats_outputs[] = {
>const FFFilter ff_vf_signalstats = {
>   .p.name= "signalstats",
> -.p.description = "Generate statistics from video analysis.",
> +.p.description = NULL_IF_CONFIG_SMALL("Generate statistics from
> video analysis."),
>   .p.priv_class  = &signalstats_class,
>   .p.flags   = AVFILTER_FLAG_SLICE_THREADS,
>   .init  = init,
> --
> 2.25.1
>

Ping
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-23 Thread Abdulrahman Saber
On Thu, Jan 23, 2025 at 11:01 PM Alexander Strasser via ffmpeg-devel
 wrote:
> Seems like your mail client/editor does it (automatically?) to avoid
> overly long lines, which might be fine for email texts but isn't in
> patches.
>
> Hope you can find the setting for easier contribution in the future.
> Another approach for single patches or small series is to attach them.
> Usually mailers don't mess with attachments.

Hi Alexander!

I will try to avoid these mistakes in future patches. Thanks a lot for
fixing this patch.

--Abdulrahman
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


[FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-13 Thread Abdulrahman Saber
Signed-off-by: abdo 
---
 libavfilter/vf_signalstats.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c
index b1451cc465..9b6af8becd 100644
--- a/libavfilter/vf_signalstats.c
+++ b/libavfilter/vf_signalstats.c
@@ -20,6 +20,7 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301 USA
  */

+#include "libavutil/internal.h"
 #include "libavutil/intreadwrite.h"
 #include "libavutil/mem.h"
 #include "libavutil/opt.h"
@@ -829,7 +830,7 @@ static const AVFilterPad signalstats_outputs[] = {

 const FFFilter ff_vf_signalstats = {
 .p.name= "signalstats",
-.p.description = "Generate statistics from video analysis.",
+.p.description = NULL_IF_CONFIG_SMALL("Generate statistics from video
analysis."),
 .p.priv_class  = &signalstats_class,
 .p.flags   = AVFILTER_FLAG_SLICE_THREADS,
 .init  = init,
-- 
2.25.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


[FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-13 Thread Abdulrahman Saber

Signed-off-by: abdo 
---
 libavfilter/vf_signalstats.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c
index b1451cc465..9b6af8becd 100644
--- a/libavfilter/vf_signalstats.c
+++ b/libavfilter/vf_signalstats.c
@@ -20,6 +20,7 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
02110-1301 USA

  */
 +#include "libavutil/internal.h"
 #include "libavutil/intreadwrite.h"
 #include "libavutil/mem.h"
 #include "libavutil/opt.h"
@@ -829,7 +830,7 @@ static const AVFilterPad signalstats_outputs[] = {
  const FFFilter ff_vf_signalstats = {
 .p.name= "signalstats",
-.p.description = "Generate statistics from video analysis.",
+.p.description = NULL_IF_CONFIG_SMALL("Generate statistics from 
video analysis."),

 .p.priv_class  = &signalstats_class,
 .p.flags   = AVFILTER_FLAG_SLICE_THREADS,
 .init  = init,
--
2.25.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


[FFmpeg-devel] [PATCH] avfilter/signalstats: add NULL_IF_CONFIG_SMALL

2025-01-14 Thread Abdulrahman Saber

Signed-off-by: abdo 
---
 libavfilter/vf_signalstats.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c
index b1451cc465..9b6af8becd 100644
--- a/libavfilter/vf_signalstats.c
+++ b/libavfilter/vf_signalstats.c
@@ -20,6 +20,7 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
02110-1301 USA

  */
 +#include "libavutil/internal.h"
 #include "libavutil/intreadwrite.h"
 #include "libavutil/mem.h"
 #include "libavutil/opt.h"
@@ -829,7 +830,7 @@ static const AVFilterPad signalstats_outputs[] = {
  const FFFilter ff_vf_signalstats = {
 .p.name= "signalstats",
-.p.description = "Generate statistics from video analysis.",
+.p.description = NULL_IF_CONFIG_SMALL("Generate statistics from 
video analysis."),

 .p.priv_class  = &signalstats_class,
 .p.flags   = AVFILTER_FLAG_SLICE_THREADS,
 .init  = init,
--
2.25.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".