Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: fix gamma22 and gamma28 recognization
On Sat, Jan 21, 2023 at 12:15 AM Jan Ekström wrote: > > On Wed, Jan 18, 2023 at 4:24 PM Leo Izen wrote: > > > > Gamma 2.2 and Gamma 2.8 are tagged in the file as 0.45455 and 0.35714, > > respectively (i.e. 1/2.2 and 1/2.8). Trying to identify them as 2.2 and > > 2.8 instead of these values will cause the transfer function to not > > properly be recognized. This patch fixes this. > > Agreed upon reading the spec, which notes that the value is saved as > an unsigned 24bit integer consisting of the numerator part of a > rational number, with a 10^7 denumerator and a valid range of (0, 1]. > > Only nit: recognization -> recognition > > > --- > > libavcodec/libjxldec.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/libjxldec.c b/libavcodec/libjxldec.c > > index 55c7366f61..0009af9615 100644 > > --- a/libavcodec/libjxldec.c > > +++ b/libavcodec/libjxldec.c > > @@ -167,9 +167,9 @@ static enum AVColorTransferCharacteristic > > libjxl_get_trc(void *avctx, const JxlC > > case JXL_TRANSFER_FUNCTION_DCI: return AVCOL_TRC_SMPTE428; > > case JXL_TRANSFER_FUNCTION_HLG: return AVCOL_TRC_ARIB_STD_B67; > > case JXL_TRANSFER_FUNCTION_GAMMA: > > -if (jxl_color->gamma > 2.199 && jxl_color->gamma < 2.201) > > +if (jxl_color->gamma > 0.45355 && jxl_color->gamma < 0.4) > > return AVCOL_TRC_GAMMA22; > > -else if (jxl_color->gamma > 2.799 && jxl_color->gamma < 2.801) > > +else if (jxl_color->gamma > 0.35614 && jxl_color->gamma < 0.35814) > > These values leave ~0.001 of leeway which seems like it was before. > > LGTM Applied to master as 9d5e66942c5bae578926e29efebec348199798df with the typo fix, as well as back-ported to release/5.1. Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 0/2] libavformat/matroskadec: set fixed duration for subtitles
Hey guys, Any feedback on this patch? Regards ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump
On Sat, Jan 21, 2023 at 11:00:52PM +0100, Marton Balint wrote: > > > On Sat, 21 Jan 2023, Michael Niedermayer wrote: > > > On Sat, Jan 21, 2023 at 05:51:34PM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2023-01-20 03:05:09) > > > > PS: iam not sure i fully understood the reason behind why versions > > > > should be > > > > set to "wrong" values during some period, so as always i might be > > > > missing > > > > something > > > > > > The reason is that after the major bump, the API and ABI are declared to > > > be unstable for some period, so people can freely > > > - break ABI, e.g. by reordering struct members > > > - modify API added during the instability period in an arbitrary way > > > without a new major bump for every such change, that would be normally > > > required. > > > > > > My concern is that the instability period is quite long and there is > > > very little indication for our users that they cannot depend on the > > > ABI/API being stable. So I'm proposing to introduce some mechanism to > > > make this more visible for our callers. > > > > > > Alternatively, we could just not have an instability period at all. > > > > Does anyone plan to use the next bumps instability period for anything ? > > If so, i assume theres a good reason why it cannot be done without such > > period easily? > > AVCodecContext->frame_number should be changed to int64_t. I guess you could Is there a patchset that does that already ? Iam asking as i think starting work on this after the bump would be the wrong approuch Also how long of a instability period do you expect this would need ? Or maybe the question is who would work on this and have it toward the top of their todo list. thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Homeopathy is like voting while filling the ballot out with transparent ink. Sometimes the outcome one wanted occurs. Rarely its worse than filling out a ballot properly. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
