[FFmpeg-devel] [PATCH] configure: select rotation filters for ffmpeg
From fda793f6fa7678e36b00eeea12343f90da75bfcb Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 2 Mar 2019 20:49:12 +0530 Subject: [PATCH] configure: select rotation filters for ffmpeg autorotate is enabled by default in ffmpeg so the rotation filters are required and will be attempted for insertion without the user's knowledge if an input stream has rotation side-data. --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index bbeaf2fadc..3042ab9176 100755 --- a/configure +++ b/configure @@ -3595,8 +3595,8 @@ avutil_extralibs="d3d11va_extralibs nanosleep_extralibs pthreads_extralibs vaapi # programs ffmpeg_deps="avcodec avfilter avformat" ffmpeg_select="aformat_filter anull_filter atrim_filter format_filter - null_filter - trim_filter" + hflip_filter null_filter + transpose_filter trim_filter vflip_filter" ffmpeg_suggest="ole32 psapi shell32" ffplay_deps="avcodec avformat swscale swresample sdl2" ffplay_select="rdft crop_filter transpose_filter hflip_filter vflip_filter rotate_filter" -- 2.19.2___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] The log level of "co located POCs unavailable" should not be ERROR
On Sat, Mar 02, 2019 at 01:23:17PM +0800, Yukun Guo wrote: > On Fri, 1 Mar 2019 at 05:30, Michael Niedermayer wrote: > > When data is missing (in live streaming or otherwise) it under > > almost all cases cannot be losslessly recovered. So this use matches > > the definition > > Yes, this is reasonable. But then "Frame num gap" should be of ERROR > level too. H.264 standard states if there is a frame num gap, the > decoder should infer an unintentional loss of pictures, assuming > gaps_in_frame_num_value_allowed_flag = 0. But it is possible that > FFmpeg encounters a frame loss but does not print any error messages, > because the error concealment procedure > (https://github.com/FFmpeg/FFmpeg/blob/n4.1.1/libavcodec/h264_slice.c#L1577) > will clone the previous frame in place of the missing one. Yes, if this ends up not printing anything then that would be unexpected > > Also, regarding to the error concealment, why isn't > `short_ref[0].field_poc` copied for cloned frames? The unset field_poc > causes "co located POCs unavailable" error, despite > `ref_list[1][0].poc` is valid when doing spatial direct predition. If the frame is copied, its copy would be at a different point in time so it may need a different poc and simply copying it might cause issues thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you will be congratulated by your peers in Parliament. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] lavc/libx265: signal CPB properties through side data
On Sat, Feb 23, 2019 at 2:35 AM Jan Ekström wrote: > > This way values such as maxrate/bufsize can be utilized > further down the chain. > --- Ping. This is similar to what the libx264 and libvpx wrappers do, and enables modules such as hlsenc, movenc and mpegenc in libavformat utilize the rate control values (such as max rate/bit rate) for signaling purposes. Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: select rotation filters for ffmpeg
On Sat, Mar 02, 2019 at 09:03:18PM +0530, Gyan wrote: > > configure |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > 4b5163db4a15d9d6caaebb35d11fac16a5c64f37 > 0001-configure-select-rotation-filters-for-ffmpeg.patch > From fda793f6fa7678e36b00eeea12343f90da75bfcb Mon Sep 17 00:00:00 2001 > From: Gyan Doshi > Date: Sat, 2 Mar 2019 20:49:12 +0530 > Subject: [PATCH] configure: select rotation filters for ffmpeg > > autorotate is enabled by default in ffmpeg so the rotation filters > are required and will be attempted for insertion without the user's > knowledge if an input stream has rotation side-data. > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index bbeaf2fadc..3042ab9176 100755 > --- a/configure > +++ b/configure > @@ -3595,8 +3595,8 @@ avutil_extralibs="d3d11va_extralibs nanosleep_extralibs > pthreads_extralibs vaapi > # programs > ffmpeg_deps="avcodec avfilter avformat" > ffmpeg_select="aformat_filter anull_filter atrim_filter format_filter > - null_filter > - trim_filter" > + hflip_filter null_filter > + transpose_filter trim_filter vflip_filter" > ffmpeg_suggest="ole32 psapi shell32" > ffplay_deps="avcodec avformat swscale swresample sdl2" > ffplay_select="rdft crop_filter transpose_filter hflip_filter vflip_filter > rotate_filter" LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship: All citizens are under surveillance, all their steps and actions recorded, for the politicians to enforce control. Democracy: All politicians are under surveillance, all their steps and actions recorded, for the citizens to enforce control. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] avcodec/dxv: Correct integer overflow in get_opcodes()
Fixes:
13099/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXV_fuzzer-5665598896340992
Fixes: signed integer overflow: 2147483647 + 7 cannot be represented in type
'int'
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/dxv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c
index bf53d7d706..aef5ec19dd 100644
--- a/libavcodec/dxv.c
+++ b/libavcodec/dxv.c
@@ -426,7 +426,8 @@ static int fill_optable(unsigned *table0, OpcodeTable
*table1, int nb_elements)
static int get_opcodes(GetByteContext *gb, uint32_t *table, uint8_t *dst, int
op_size, int nb_elements)
{
OpcodeTable optable[1024];
-int sum, x, val, lshift, rshift, ret, size_in_bits, i, idx;
+int sum, x, val, lshift, rshift, ret, i, idx;
+int64_t size_in_bits;
unsigned endoffset, newoffset, offset;
unsigned next;
uint8_t *src = (uint8_t *)gb->buffer;
--
2.21.0
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] The log level of "co located POCs unavailable" should not be ERROR
On Sun, 3 Mar 2019 at 00:41, Michael Niedermayer wrote: > If the frame is copied, its copy would be at a different point in > time so it may need a different poc and simply copying it might > cause issues Sorry I didn't state it clearly. What I meant is POC = previous POC + 2, not copied [1]. This is correct, since the frame is missing you don't have better choices. I just wonder why not set field_poc? If I add these two lines: h->short_ref[0]->field_poc[0] = prev->field_poc[0] + 2; h->short_ref[0]->field_poc[1] = prev->field_poc[1] + 2; I find the error message is gone (only test videos that use frame coding throughout). [1]: https://github.com/FFmpeg/FFmpeg/blob/n4.1.1/libavcodec/h264_slice.c#L1599) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] configure: select rotation filters for ffmpeg
On 03-03-2019 03:51 AM, Michael Niedermayer wrote: On Sat, Mar 02, 2019 at 09:03:18PM +0530, Gyan wrote: configure |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) 4b5163db4a15d9d6caaebb35d11fac16a5c64f37 0001-configure-select-rotation-filters-for-ffmpeg.patch From fda793f6fa7678e36b00eeea12343f90da75bfcb Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 2 Mar 2019 20:49:12 +0530 Subject: [PATCH] configure: select rotation filters for ffmpeg autorotate is enabled by default in ffmpeg so the rotation filters are required and will be attempted for insertion without the user's knowledge if an input stream has rotation side-data. --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index bbeaf2fadc..3042ab9176 100755 --- a/configure +++ b/configure @@ -3595,8 +3595,8 @@ avutil_extralibs="d3d11va_extralibs nanosleep_extralibs pthreads_extralibs vaapi # programs ffmpeg_deps="avcodec avfilter avformat" ffmpeg_select="aformat_filter anull_filter atrim_filter format_filter - null_filter - trim_filter" + hflip_filter null_filter + transpose_filter trim_filter vflip_filter" ffmpeg_suggest="ole32 psapi shell32" ffplay_deps="avcodec avformat swscale swresample sdl2" ffplay_select="rdft crop_filter transpose_filter hflip_filter vflip_filter rotate_filter" LGTM Pushed as fda793f6fa7678e36b00eeea12343f90da75bfcb Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
