[FFmpeg-devel] [PATCH] fate: increase fuzz for refcmp filter tests
Should fix failing tests on GNU/kFreeBSD x86_32. Signed-off-by: Tobias Rapp --- Michael: Have put you on CC as you seem to be the owner of the affected machines. tests/fate/filter-video.mak | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak index 78cd471..c19f301 100644 --- a/tests/fate/filter-video.mak +++ b/tests/fate/filter-video.mak @@ -750,16 +750,16 @@ fate-filter-meta-4560-rotate0: CMD = framecrc -flags +bitexact -c:a aac_fixed -i REFCMP_DEPS = FFMPEG LAVFI_INDEV TESTSRC2_FILTER AVGBLUR_FILTER METADATA_FILTER FATE_FILTER_SAMPLES-$(call ALLYES, $(REFCMP_DEPS) PSNR_FILTER) += fate-filter-refcmp-psnr-rgb -fate-filter-refcmp-psnr-rgb: CMD = refcmp_metadata psnr rgb24 +fate-filter-refcmp-psnr-rgb: CMD = refcmp_metadata psnr rgb24 0.001 FATE_FILTER_SAMPLES-$(call ALLYES, $(REFCMP_DEPS) PSNR_FILTER) += fate-filter-refcmp-psnr-yuv -fate-filter-refcmp-psnr-yuv: CMD = refcmp_metadata psnr yuv422p +fate-filter-refcmp-psnr-yuv: CMD = refcmp_metadata psnr yuv422p 0.0015 FATE_FILTER_SAMPLES-$(call ALLYES, $(REFCMP_DEPS) SSIM_FILTER) += fate-filter-refcmp-ssim-rgb -fate-filter-refcmp-ssim-rgb: CMD = refcmp_metadata ssim rgb24 +fate-filter-refcmp-ssim-rgb: CMD = refcmp_metadata ssim rgb24 0.015 FATE_FILTER_SAMPLES-$(call ALLYES, $(REFCMP_DEPS) SSIM_FILTER) += fate-filter-refcmp-ssim-yuv -fate-filter-refcmp-ssim-yuv: CMD = refcmp_metadata ssim yuv422p +fate-filter-refcmp-ssim-yuv: CMD = refcmp_metadata ssim yuv422p 0.015 FATE_SAMPLES_FFPROBE += $(FATE_METADATA_FILTER-yes) FATE_SAMPLES_FFMPEG += $(FATE_FILTER_SAMPLES-yes) -- 2.7.4 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_decode: fix profile search when disable exact profile match.
On 2017/9/28 5:40, Mark Thompson wrote: > On 21/09/17 08:22, Jun Zhao wrote: >> From d7dc5c00692302e810412dea44ae3d2f122fb9a4 Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Thu, 21 Sep 2017 02:44:42 -0400 >> Subject: [PATCH 2/2] lavc/vaapi_decode: fix profile search when disable exact >> profile match. >> >> When disable exact profile match, alway use the profile found by >> codecid. >> >> Signed-off-by: Jun Zhao >> --- >> libavcodec/vaapi_decode.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c >> index cf58aae4c6..98b00e3637 100644 >> --- a/libavcodec/vaapi_decode.c >> +++ b/libavcodec/vaapi_decode.c >> @@ -329,6 +329,10 @@ static int vaapi_decode_make_config(AVCodecContext >> *avctx) >> if (exact_match) >> break; >> alt_profile = vaapi_profile_map[i].codec_profile; >> + >> +if (avctx->hwaccel_flags & >> +AV_HWACCEL_FLAG_ALLOW_PROFILE_MISMATCH) >> +break; >> } >> } >> av_freep(&profile_list); >> -- >> 2.11.0 >> > An exact match might exist later in the list. Consider an H.264 high input - > this change can choose H.264 constrained baseline instead even if H.264 high > is present. > > - Mark I will double-check the logic in this case BTW, the original issue is I found a HEVC clip use a wrong profile with 0 (avctx->profile == 0), then FFmpeg VAAPI hwaccel will use VaProfileHEVCMain10 in Skylake lead to vaCreateConfig fail, because Skylake don't support HEVC 10 bits decoding. > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] libavcodec/hapdec : add support for HapAphaOnly decoding
On Wed, 27 Sep 2017 at 16:52 Carl Eugen Hoyos wrote: > 2017-09-27 15:20 GMT+02:00 Martin Vignali : > > 2017-09-27 13:25 GMT+02:00 Tom Butterworth : > > > >> > >> > >> > On 27 Sep 2017, at 11:59, Martin Vignali > >> wrote: > >> > > >> >> > >> >>> +ctx->tex_fun = ctx->dxtc.rgtc1u_block; > >> >>> +avctx->pix_fmt = AV_PIX_FMT_RGB0; > >> >> > >> >> The rgtc1u_block function places the single channel value in every > >> channel > >> >> except the alpha channel > >> >> The pixel format you have chosen is one which disregards the alpha > >> channel > >> >> > >> >> The output of this alpha-only decoder should be in the alpha channel > of > >> a > >> >> pixel format which carries alpha. Probably other channels should have > >> zero > >> >> values. > >> >> > >> >> > >> > Hi Tom, > >> > > >> > After Carl answer, and thinking about that, > >> > The goal of HapAlphaOnly, is to store alpha, but can also store gray > only > >> > (much better than HAP) > >> > In fact, it can be call HAP Gray ! > >> > >> But it isn’t > >> > >> > For example from my part, i would like to use this codec, for matte, > but > >> > also for gray only layer (use with color blending) > >> > >> This is fine, but let’s concentrate on supporting Hap Alpha Only, not > your > >> non-standard use of it. If you would like this flexibility in Hap, that > >> should be argued for on the Hap project, not within FFmpeg. > >> > >> Hap Alpha Only is defined as an *alpha* channel stored in RGTC1U, and > the > >> implementation in FFmpeg must follow the definition (see > >> > https://github.com/Vidvox/hap/blob/master/documentation/HapVideoDRAFT.md < > >> > https://github.com/Vidvox/hap/blob/master/documentation/HapVideoDRAFT.md> > >> ). > >> > >> The Alpha Only encoder and decoder must ingest and emit a pixel format > >> which carries alpha. It may be that adding a new alpha-only pixel > format is > >> not seen as desirable, in which case an existing format with alpha > should > >> be selected. This allows users to, eg, transcode from an RGBA format to > Hap > >> Alpha Only and have the channel they expect be preserved from the input > >> video. Any other behaviour (eg having RGB converted to grey and then > stored > >> as alpha) is not acceptable. > >> > >> > If a user want to compress a gray picture, it can be done using > >> > RGB to Gray conversion > > Of course. > But if the input is single-plane, 8bit, it does not make sense to > output rgb (or rgba). > >> > And if user want to compress only alpha or a specific channel, i think > >> > ffmpeg have a filter for that (extractplanes (untested)), > >> > >> Your non-standard usage can still be achieved by channel switching in a > >> filter, the default behaviour must be according to the standard, which > is > >> to encode and decode the alpha channel. > > Which is not possible because FFmpeg does not support a single > alpha plane. > > Ok, in that case, the HAP Alpha Encoding current patch is fine (it take > > alpha from RGBA input) > > I am less convinced: > As long as FFmpeg does not have a native alpha-only > pix_fmt (I am not sure this would have any user-visible > advantage), single-layer 8bit formats should be decoded > as gray8. > This would result in a transcode to another alpha-carrying codec incorrectly placing the alpha channel in the colour channels, and setting the alpha channel to solid. Likewise, API users would not be able to know the channel intentions of the decoded frame. I'd argue that either a new pixel format be added, or an existing format which carries alpha should be used, even if that has the cost of redundant colour channels. Cheers - Tom ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: deprecate non-AVOption init.
Le sextidi 26 fructidor, an CCXXV, Nicolas George a écrit : > Signed-off-by: Nicolas George > --- > doc/APIchanges | 3 +++ > libavfilter/buffersink.c | 10 ++ > libavfilter/buffersink.h | 12 > 3 files changed, 21 insertions(+), 4 deletions(-) Will push soon if there is no objection. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: deprecate non-AVOption init.
On 9/28/2017 11:04 AM, Nicolas George wrote: > Le sextidi 26 fructidor, an CCXXV, Nicolas George a écrit : >> Signed-off-by: Nicolas George >> --- >> doc/APIchanges | 3 +++ >> libavfilter/buffersink.c | 10 ++ >> libavfilter/buffersink.h | 12 >> 3 files changed, 21 insertions(+), 4 deletions(-) > > Will push soon if there is no objection. > > Regards, There was a very strong objection to this patch in another reply. You should ask him to elaborate if necessary. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: deprecate non-AVOption init.
Le septidi 7 vendémiaire, an CCXXVI, James Almer a écrit : > There was a very strong objection to this patch in another reply. You > should ask him to elaborate if necessary. I do not remember. Checking. Oh, you mean wm4. I no longer read their mails, and it seems I was right: this is no objection. Will push soon unless there is an objection. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: deprecate non-AVOption init.
On 9/28/2017 11:14 AM, Nicolas George wrote: > Le septidi 7 vendémiaire, an CCXXVI, James Almer a écrit : >> There was a very strong objection to this patch in another reply. You >> should ask him to elaborate if necessary. > > I do not remember. Checking. Oh, you mean wm4. I no longer read their > mails, and it seems I was right: this is no objection. > > Will push soon unless there is an objection. > > Regards, That's not how things are done and you know it. You do not simply ignore another developer's email just because you don't like them. And *especially* not when it's a veto to an API change. This is a project handled by several people and it doesn't care about your personal grudges. So please, ask him to elaborate why he's against this patch, and don't push it until both parts are satisfied or other people intervene to argue in favor or one side of the discussion or the other. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: deprecate non-AVOption init.
On Thu, 28 Sep 2017 16:14:40 +0200 Nicolas George wrote: > Le septidi 7 vendémiaire, an CCXXVI, James Almer a écrit : > > There was a very strong objection to this patch in another reply. You > > should ask him to elaborate if necessary. > > I do not remember. Checking. Oh, you mean wm4. I no longer read their > mails, and it seems I was right: this is no objection. > > Will push soon unless there is an objection. So you openly admit on shitting on the project rules? That is nice of you. (It's not the first time you ignore my patch review comments.) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] ffmpeg have program decoding ACC ltam audo stream
2017-09-28 6:09 GMT+02:00 : > TS file http://www99.zippyshare.com/v/UwxzRccM/file.html Thank you for the sample. Damaged transport streams show all kind of messages, but the sample can be decoded. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: deprecate non-AVOption init.
On Tue, 12 Sep 2017 11:40:55 +0200 Nicolas George wrote: > Signed-off-by: Nicolas George > --- > doc/APIchanges | 3 +++ > libavfilter/buffersink.c | 10 ++ > libavfilter/buffersink.h | 12 > 3 files changed, 21 insertions(+), 4 deletions(-) jamrial asked to clarify this, so here's some reasoning why I'm against it: The alternative would be using AVOptions, but AVOptions are clunky. Especially when setting things like lists of allowed formats or channel layouts. I don't like AVOption APis in general, but with those lists it gets seriously error-prone on the API user side. On the source filter side, AVBufferSrcParameters was recently introduced, so that alone is an indicator that a dedicated params struct makes sense, and that we shouldn't remove it. I would argue that there should be a av_abuffersink_parameters_set function, instead of using the really unsafe opaque init parameter. I'd also respect if we were to merge AVABufferSinkParams into AVBufferSinkParams, or if this were preparation for adding a similar but more general mechanism for both FFmpeg/Libav (non-AVOption of course), but I haven't noticed such plans. All in all, just deprecating/removing this would be a step backwards, and would force current users of this API to use more awkward API instead. There was also no good (or any) reason given _for_ removing the API. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] Fixes bug https://trac.ffmpeg.org/ticket/6700.
---
libavformat/isom.h | 2 +-
libavformat/mov.c | 6 +-
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/libavformat/isom.h b/libavformat/isom.h
index fdd98c28f5..a32b92ccdd 100644
--- a/libavformat/isom.h
+++ b/libavformat/isom.h
@@ -52,7 +52,7 @@ struct AVAESCTR;
*/
typedef struct MOVStts {
-int count;
+unsigned int count;
int duration;
} MOVStts;
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 2de60b2159..9cfc860c18 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -2658,15 +2658,11 @@ static int mov_read_stts(MOVContext *c, AVIOContext
*pb, MOVAtom atom)
for (i = 0; i < entries && !pb->eof_reached; i++) {
int sample_duration;
-int sample_count;
+unsigned int sample_count;
sample_count=avio_rb32(pb);
sample_duration = avio_rb32(pb);
-if (sample_count < 0) {
-av_log(c->fc, AV_LOG_ERROR, "Invalid sample_count=%d\n",
sample_count);
-return AVERROR_INVALIDDATA;
-}
sc->stts_data[i].count= sample_count;
sc->stts_data[i].duration= sample_duration;
--
2.13.3.windows.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] Decklink question
Are there known issues with DeckLink as of recent? Which SDK version was the DeckLink support compiled against? I downloaded 3.3.4 and the latest Blackmagic Design SDK for a (recently) purchased 'DeckLink Studio 4K' I purchased... Built a custom .deb set of packages based on 3.3.4: dx@x299:~/deb/decklink-ffmpeg-3.3.4$ ls -la total 22748 drwxrwxr-x 2 dx dx4096 Sep 24 18:27 . drwxrwxr-x 5 dx dx4096 Sep 24 18:27 .. -rw-r--r-- 1 dx dx 1534142 Sep 24 18:22 ffmpeg_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 1738990 Sep 24 18:22 ffmpeg-doc_3.3.4-1_all.deb -rw-r--r-- 1 dx dx 4466548 Sep 24 18:22 libavcodec57_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 4935942 Sep 24 18:22 libavcodec-dev_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 24536 Sep 24 18:22 libavcodec-extra_3.3.4-1_all.deb -rw-r--r-- 1 dx dx 4469096 Sep 24 18:22 libavcodec-extra57_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 91360 Sep 24 18:22 libavdevice57_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 108806 Sep 24 18:22 libavdevice-dev_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 811824 Sep 24 18:22 libavfilter6_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 944842 Sep 24 18:22 libavfilter-dev_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 24530 Sep 24 18:22 libavfilter-extra_3.3.4-1_all.deb -rw-r--r-- 1 dx dx 820978 Sep 24 18:22 libavfilter-extra6_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 921742 Sep 24 18:22 libavformat57_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 1101246 Sep 24 18:22 libavformat-dev_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 63048 Sep 24 18:22 libavresample3_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 72302 Sep 24 18:22 libavresample-dev_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 24754 Sep 24 18:22 libav-tools_3.3.4-1_all.deb -rw-r--r-- 1 dx dx 192106 Sep 24 18:22 libavutil55_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 293600 Sep 24 18:22 libavutil-dev_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 60226 Sep 24 18:22 libpostproc54_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 60948 Sep 24 18:22 libpostproc-dev_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 65412 Sep 24 18:22 libswresample2_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 77884 Sep 24 18:22 libswresample-dev_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 157836 Sep 24 18:22 libswscale4_3.3.4-1_amd64.deb -rw-r--r-- 1 dx dx 174864 Sep 24 18:22 libswscale-dev_3.3.4-1_amd64.deb I've installed them and run the following command and get: dx@x299:~/capture$ ffmpeg -f decklink -video_input hdmi -audio_input embedded -bm_v210 1 -i 'DeckLink Studio 4K' -acodec copy -vcodec copy bleh.avi ffmpeg version 3.3.4-1 Copyright (c) 2000-2017 the FFmpeg developers built with gcc 5.4.0 (Ubuntu 5.4.0-6ubuntu1~16.04.4) 20160609 configuration: --prefix=/usr --extra-version=1 --toolchain=hardened --libdir=/usr/lib/x86_64-linux-gnu --incdir=/usr/include/x86_64-linux-gnu --enable-gpl --disable-stripping --enable-avresample --enable-avisynth --enable-gnutls --enable-ladspa --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libmp3lame --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librubberband --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxvid --enable-libzmq --enable-libzvbi --enable-omx --enable-openal --enable-opengl --enable-sdl2 --enable-decklink --enable-nonfree --enable-libdc1394 --enable-libiec61883 --enable-chromaprint --enable-frei0r --enable-libopencv --enable-libx264 --enable-shared WARNING: library configuration mismatch avcodec configuration: --prefix=/usr --extra-version=1 --toolchain=hardened --libdir=/usr/lib/x86_64-linux-gnu --incdir=/usr/include/x86_64-linux-gnu --enable-gpl --disable-stripping --enable-avresample --enable-avisynth --enable-gnutls --enable-ladspa --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libmp3lame --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librubberband --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxvid --enable-libzmq --enable-libzvbi --enable-omx --enable-openal --enable-opengl --enable-sdl2 --enable-decklink --enable-nonfree --enable-libdc1394 --enable-libiec61883 --enable-chromaprint --enable-frei0r --enable-libopencv --enable-libx264 --enable-shared --enable-version3 --disable-doc --disable-programs
Re: [FFmpeg-devel] [PATCH] Fixes bug https://trac.ffmpeg.org/ticket/6700.
On Thu, 28 Sep 2017 12:11:48 -0300
Pablo Montilla wrote:
> ---
> libavformat/isom.h | 2 +-
> libavformat/mov.c | 6 +-
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/libavformat/isom.h b/libavformat/isom.h
> index fdd98c28f5..a32b92ccdd 100644
> --- a/libavformat/isom.h
> +++ b/libavformat/isom.h
> @@ -52,7 +52,7 @@ struct AVAESCTR;
> */
>
> typedef struct MOVStts {
> -int count;
> +unsigned int count;
> int duration;
> } MOVStts;
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 2de60b2159..9cfc860c18 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -2658,15 +2658,11 @@ static int mov_read_stts(MOVContext *c, AVIOContext
> *pb, MOVAtom atom)
>
> for (i = 0; i < entries && !pb->eof_reached; i++) {
> int sample_duration;
> -int sample_count;
> +unsigned int sample_count;
>
> sample_count=avio_rb32(pb);
> sample_duration = avio_rb32(pb);
>
> -if (sample_count < 0) {
> -av_log(c->fc, AV_LOG_ERROR, "Invalid sample_count=%d\n",
> sample_count);
> -return AVERROR_INVALIDDATA;
> -}
> sc->stts_data[i].count= sample_count;
> sc->stts_data[i].duration= sample_duration;
>
Needs a complete description of the issue on the commit message. The
ticket number is rather useless. The commit message subject line should
follow the usual project conventions.
Regarding the actual change, did you check all users of the .count
field?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] lavfi/buffersink: deprecate non-AVOption init.
On 9/28/2017 11:29 AM, Nicolas George wrote: > [ Replying in private so as not to escalate the troll. ] No. I'm CCing to the list as this is a public discussion. > > Le septidi 7 vendémiaire, an CCXXVI, James Almer a écrit : >> That's not how things are done and you know it. You do not simply ignore >> another developer's email just because you don't like them. And > > I could answer just: watch me. But I like to be more constructive. I say it again, you don't ignore other developer's emails. That "watch me do whatever i want" attitude is what nobody likes or wants in any kind of OSS project, and is absolutely unacceptable. > >> *especially* not when it's a veto to an API change. > > There are no vetos in this project, only arguments. The message you > pointed me is devoid of it. If there are developers against a patch, unless they're outnumbered then it works as a veto. Then of course we also have the voting system to make it official if things are too tied or heated up. > >> This is a project handled by several people and it doesn't care about >> your personal grudges. So please, ask him to elaborate why he's against >> this patch, and don't push it until both parts are satisfied or other >> people intervene to argue in favor or one side of the discussion or the >> other. > > If they had anything to elaborate, they could have done, and they still > can. I wrote that I will push *if there are no objections*. There are > none, the message you pointed is not an objection, it is a tantrum. You didn't explain why you want the patch applied either. The commit message is empty. And since now wm4 explained why he's against, it's your turn to both explain why you're in favor and to address his argument. Don't escalate this thing any further. We don't need more drama or flamewars here. Nothing good ever comes from that. You two argue why you're in favor or against this patch, and don't commit anything until that's solved. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/2 v3] movenc: Add an option for enabling negative CTS offsets
On Tue, Sep 26, 2017 at 02:55:30AM +0300, Jan Ekström wrote: > From: Martin Storsjö > > This reduces the need for an edit list; streams that start with > e.g. dts=-1, pts=0 can be encoded as dts=0, pts=0 (which is valid > in mov/mp4) by shifting the dts values of all packets forward. > This avoids the need for edit lists for such streams (while they > still are needed for audio streams with encoder delay). > > This eases conformance with the DASH-IF interoperability guidelines. > > Signed-off-by: Martin Storsjö > --- > doc/muxers.texi | 6 ++ > libavformat/movenc.c | 28 > libavformat/movenc.h | 2 ++ > 3 files changed, 32 insertions(+), 4 deletions(-) will apply the patchset thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everything ms did were stupid they would be bankrupt already. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCHv13] libavcodec: v4l2: add support for v4l2 mem2mem codecs
Am 23.09.17 um 16:48 schrieb Michael Niedermayer: > On Sat, Sep 23, 2017 at 12:28:01AM -0700, Jorge Ramirez-Ortiz wrote: >> On 09/22/2017 11:49 PM, wm4 wrote: >>> On Wed, 20 Sep 2017 18:55:40 -0700 >>> Jorge Ramirez-Ortiz wrote: >>> This patchset enhances Alexis Ballier's original patch and validates it using Qualcomm's Venus hardware (driver recently landed upstream [1]). >>> Pushed to master. >> >> thanks! >> will add DRM support over the coming weeks. >> >> btw would you know the process to add a new board to the fate farm? > > If you wish to run the fate tests regularly and submit results to the > server see: https://ffmpeg.org/fate.html Someone donated a dragonboard-410c for that purpose during ELCE 2016. I plan to set it up as a FATE client during the next weeks. When creating test cases, please consider to reuse files already in the fate-suite. -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCHv13] libavcodec: v4l2: add support for v4l2 mem2mem codecs
On 09/28/2017 09:48 AM, Thilo Borgmann wrote: Am 23.09.17 um 16:48 schrieb Michael Niedermayer: On Sat, Sep 23, 2017 at 12:28:01AM -0700, Jorge Ramirez-Ortiz wrote: On 09/22/2017 11:49 PM, wm4 wrote: On Wed, 20 Sep 2017 18:55:40 -0700 Jorge Ramirez-Ortiz wrote: This patchset enhances Alexis Ballier's original patch and validates it using Qualcomm's Venus hardware (driver recently landed upstream [1]). Pushed to master. thanks! will add DRM support over the coming weeks. btw would you know the process to add a new board to the fate farm? If you wish to run the fate tests regularly and submit results to the server see: https://ffmpeg.org/fate.html Someone donated a dragonboard-410c for that purpose during ELCE 2016. I plan to set it up as a FATE client during the next weeks. When creating test cases, please consider to reuse files already in the fate-suite. sounds great. I was just re-testing on 410c and there are a couple of issues in the kernel that will need address I will post this one to ffmpeg once I know the fix has been merged in kernel.org: https://github.com/ldts/FFmpeg/commit/7189e0fd03634a4322ac024fb047c9ec9550e668 For the time being, this kernel patch is required needed for ffmpeg to work with the latest 410c release: diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c index 82b4d32..d4badf0 100644 --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c @@ -145,9 +145,11 @@ find_format_by_index(struct venus_inst *inst, unsigned int index, u32 type) if (i == size) return NULL; +#if 0 if (type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE && !venus_helper_check_codec(inst, fmt->pixfmt)) return NULL; +#endif return &fmt[i]; } @@ -489,7 +491,6 @@ vdec_decoder_cmd(struct file *file, void *fh, struct v4l2_decoder_cmd *cmd) inst->cmd_stop = true; mutex_unlock(&inst->lock); - hfi_session_flush(inst); return 0; } -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixes bug https://trac.ffmpeg.org/ticket/6700.
Sorry, this is my first patch, so I'm learning how it's done. I'm new to git,
and work on Windows, so everything is against me! 😉
I did not check all the count uses...the compiler didn't barf, so I thought it
was a harmless change (I understand unsigned vs signed is not so small a
change, but one can only hope).
I'll do the check and repost the patch with proper messages (if that is good
with you).
Thank you,
Pablo
-Original Message-
From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of wm4
Sent: Thursday, September 28, 2017 12:25 PM
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] Fixes bug
https://trac.ffmpeg.org/ticket/6700.
On Thu, 28 Sep 2017 12:11:48 -0300
Pablo Montilla wrote:
> ---
> libavformat/isom.h | 2 +-
> libavformat/mov.c | 6 +-
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/libavformat/isom.h b/libavformat/isom.h index
> fdd98c28f5..a32b92ccdd 100644
> --- a/libavformat/isom.h
> +++ b/libavformat/isom.h
> @@ -52,7 +52,7 @@ struct AVAESCTR;
> */
>
> typedef struct MOVStts {
> -int count;
> +unsigned int count;
> int duration;
> } MOVStts;
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c index
> 2de60b2159..9cfc860c18 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -2658,15 +2658,11 @@ static int mov_read_stts(MOVContext *c,
> AVIOContext *pb, MOVAtom atom)
>
> for (i = 0; i < entries && !pb->eof_reached; i++) {
> int sample_duration;
> -int sample_count;
> +unsigned int sample_count;
>
> sample_count=avio_rb32(pb);
> sample_duration = avio_rb32(pb);
>
> -if (sample_count < 0) {
> -av_log(c->fc, AV_LOG_ERROR, "Invalid sample_count=%d\n",
> sample_count);
> -return AVERROR_INVALIDDATA;
> -}
> sc->stts_data[i].count= sample_count;
> sc->stts_data[i].duration= sample_duration;
>
Needs a complete description of the issue on the commit message. The ticket
number is rather useless. The commit message subject line should follow the
usual project conventions.
Regarding the actual change, did you check all users of the .count field?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] Fixes bug https://trac.ffmpeg.org/ticket/6700.
---
libavformat/isom.h | 2 +-
libavformat/mov.c | 6 +-
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/libavformat/isom.h b/libavformat/isom.h
index fdd98c28f5..a32b92ccdd 100644
--- a/libavformat/isom.h
+++ b/libavformat/isom.h
@@ -52,7 +52,7 @@ struct AVAESCTR;
*/
typedef struct MOVStts {
-int count;
+unsigned int count;
int duration;
} MOVStts;
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 2de60b2159..9cfc860c18 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -2658,15 +2658,11 @@ static int mov_read_stts(MOVContext *c, AVIOContext
*pb, MOVAtom atom)
for (i = 0; i < entries && !pb->eof_reached; i++) {
int sample_duration;
-int sample_count;
+unsigned int sample_count;
sample_count=avio_rb32(pb);
sample_duration = avio_rb32(pb);
-if (sample_count < 0) {
-av_log(c->fc, AV_LOG_ERROR, "Invalid sample_count=%d\n",
sample_count);
-return AVERROR_INVALIDDATA;
-}
sc->stts_data[i].count= sample_count;
sc->stts_data[i].duration= sample_duration;
--
2.13.3.windows.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCHv13] libavcodec: v4l2: add support for v4l2 mem2mem codecs
Am 28.09.17 um 19:29 schrieb Jorge Ramirez-Ortiz: > On 09/28/2017 09:48 AM, Thilo Borgmann wrote: >> Am 23.09.17 um 16:48 schrieb Michael Niedermayer: >>> On Sat, Sep 23, 2017 at 12:28:01AM -0700, Jorge Ramirez-Ortiz wrote: On 09/22/2017 11:49 PM, wm4 wrote: > On Wed, 20 Sep 2017 18:55:40 -0700 > Jorge Ramirez-Ortiz wrote: > >> This patchset enhances Alexis Ballier's original patch and validates >> it using Qualcomm's Venus hardware (driver recently landed upstream >> [1]). > Pushed to master. thanks! will add DRM support over the coming weeks. btw would you know the process to add a new board to the fate farm? >>> If you wish to run the fate tests regularly and submit results to the >>> server see: https://ffmpeg.org/fate.html >> Someone donated a dragonboard-410c for that purpose during ELCE 2016. >> I plan to set it up as a FATE client during the next weeks. >> >> When creating test cases, please consider to reuse files already in the >> fate-suite. > > sounds great. > I was just re-testing on 410c and there are a couple of issues in the kernel > that will need address > > I will post this one to ffmpeg once I know the fix has been merged in > kernel.org: > https://github.com/ldts/FFmpeg/commit/7189e0fd03634a4322ac024fb047c9ec9550e668 > > For the time being, this kernel patch is required needed for ffmpeg to work > with the latest 410c release: > > diff --git a/drivers/media/platform/qcom/venus/vdec.c > b/drivers/media/platform/qcom/venus/vdec.c > index 82b4d32..d4badf0 100644 > --- a/drivers/media/platform/qcom/venus/vdec.c > +++ b/drivers/media/platform/qcom/venus/vdec.c I'm building via OpenEmbedded using meta-qcom to specifiy the dragonboard machine. Are these builds also in need of that kernel patch? -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCHv13] libavcodec: v4l2: add support for v4l2 mem2mem codecs
Am 28.09.17 um 19:57 schrieb Thilo Borgmann: > Am 28.09.17 um 19:29 schrieb Jorge Ramirez-Ortiz: >> On 09/28/2017 09:48 AM, Thilo Borgmann wrote: >>> Am 23.09.17 um 16:48 schrieb Michael Niedermayer: On Sat, Sep 23, 2017 at 12:28:01AM -0700, Jorge Ramirez-Ortiz wrote: > On 09/22/2017 11:49 PM, wm4 wrote: >> On Wed, 20 Sep 2017 18:55:40 -0700 >> Jorge Ramirez-Ortiz wrote: >> >>> This patchset enhances Alexis Ballier's original patch and >>> validates >>> it using Qualcomm's Venus hardware (driver recently landed upstream >>> [1]). >> Pushed to master. > thanks! > will add DRM support over the coming weeks. > > btw would you know the process to add a new board to the fate farm? If you wish to run the fate tests regularly and submit results to the server see: https://ffmpeg.org/fate.html >>> Someone donated a dragonboard-410c for that purpose during ELCE 2016. >>> I plan to set it up as a FATE client during the next weeks. >>> >>> When creating test cases, please consider to reuse files already in the >>> fate-suite. >> >> sounds great. >> I was just re-testing on 410c and there are a couple of issues in the kernel >> that will need address >> >> I will post this one to ffmpeg once I know the fix has been merged in >> kernel.org: >> https://github.com/ldts/FFmpeg/commit/7189e0fd03634a4322ac024fb047c9ec9550e668 >> >> For the time being, this kernel patch is required needed for ffmpeg to work >> with the latest 410c release: >> >> diff --git a/drivers/media/platform/qcom/venus/vdec.c >> b/drivers/media/platform/qcom/venus/vdec.c >> index 82b4d32..d4badf0 100644 >> --- a/drivers/media/platform/qcom/venus/vdec.c >> +++ b/drivers/media/platform/qcom/venus/vdec.c > > I'm building via OpenEmbedded using meta-qcom to specifiy the dragonboard > machine. > Are these builds also in need of that kernel patch? p.s.: https://layers.openembedded.org/layerindex/branch/master/layer/meta-qcom/ -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Added HW accelerated H.264 and HEVC encoding for AMD GPUs based on AMF SDK
On Thu, 28 Sep 2017 13:58:02 -0500 mmironov wrote: > From 4a47f0e1ee57239fbbc597c0084f486e815ec267 Mon Sep 17 00:00:00 2001 > From: mmironov > Date: Thu, 28 Sep 2017 12:30:30 -0400 > Subject: [PATCH] Added HW accelerated H.264 and HEVC encoding for AMD GPUs > based on AMF SDK > > Signed-off-by: mmironov > --- > Changelog |2 + > compat/amd/amf/LICENSE.txt | 31 + > compat/amd/amf/README.md | 32 + > .../include/components/Ambisonic2SRenderer.h | 79 + > .../amd/amf/public/include/components/Component.h | 393 + > .../amf/public/include/components/ComponentCaps.h | 172 ++ > .../include/components/FFMPEGAudioConverter.h | 62 + > .../public/include/components/FFMPEGAudioDecoder.h | 68 + > .../public/include/components/FFMPEGAudioEncoder.h | 66 + > .../public/include/components/FFMPEGComponents.h | 50 + > .../public/include/components/FFMPEGFileDemuxer.h | 88 + > .../public/include/components/FFMPEGFileMuxer.h| 80 + > .../amf/public/include/components/MediaSource.h| 79 + > .../amf/public/include/components/VideoConverter.h | 87 + > .../public/include/components/VideoDecoderUVD.h| 87 + > .../public/include/components/VideoEncoderHEVC.h | 189 +++ > .../public/include/components/VideoEncoderVCE.h| 222 +++ > compat/amd/amf/public/include/core/AudioBuffer.h | 184 +++ > compat/amd/amf/public/include/core/Buffer.h| 160 ++ > compat/amd/amf/public/include/core/Compute.h | 284 > .../amd/amf/public/include/core/ComputeFactory.h | 146 ++ First thing first... I don't think we can dump the entire AMF API into the compat dir. I know we have some copies of external APIs there (like nvenc for nvidia), but these are tiny and subsets. The AMF API has a considerable size. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: add mailing list faq
On Wed, Sep 27, 2017, at 03:59 PM, Lou Logan wrote: > Signed-off-by: Lou Logan > --- > doc/Makefile | 1 + > doc/mailing-list-faq.texi | 204 > ++ > 2 files changed, 205 insertions(+) > create mode 100644 doc/mailing-list-faq.texi Here's a link to the easier to read HTML output if you just want to take a look at the contents: http://0x0.st/h09.html ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCHv13] libavcodec: v4l2: add support for v4l2 mem2mem codecs
On 09/28/2017 10:59 AM, Thilo Borgmann wrote: Am 28.09.17 um 19:57 schrieb Thilo Borgmann: Am 28.09.17 um 19:29 schrieb Jorge Ramirez-Ortiz: On 09/28/2017 09:48 AM, Thilo Borgmann wrote: Am 23.09.17 um 16:48 schrieb Michael Niedermayer: On Sat, Sep 23, 2017 at 12:28:01AM -0700, Jorge Ramirez-Ortiz wrote: On 09/22/2017 11:49 PM, wm4 wrote: On Wed, 20 Sep 2017 18:55:40 -0700 Jorge Ramirez-Ortiz wrote: This patchset enhances Alexis Ballier's original patch and validates it using Qualcomm's Venus hardware (driver recently landed upstream [1]). Pushed to master. thanks! will add DRM support over the coming weeks. btw would you know the process to add a new board to the fate farm? If you wish to run the fate tests regularly and submit results to the server see: https://ffmpeg.org/fate.html Someone donated a dragonboard-410c for that purpose during ELCE 2016. I plan to set it up as a FATE client during the next weeks. When creating test cases, please consider to reuse files already in the fate-suite. sounds great. I was just re-testing on 410c and there are a couple of issues in the kernel that will need address I will post this one to ffmpeg once I know the fix has been merged in kernel.org: https://github.com/ldts/FFmpeg/commit/7189e0fd03634a4322ac024fb047c9ec9550e668 For the time being, this kernel patch is required needed for ffmpeg to work with the latest 410c release: diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c index 82b4d32..d4badf0 100644 --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c I'm building via OpenEmbedded using meta-qcom to specifiy the dragonboard machine. Are these builds also in need of that kernel patch? yes it is needed - we havent updated the meta-qcom yet if you do it please feel free to send a pull request and we will merge it. p.s.: https://layers.openembedded.org/layerindex/branch/master/layer/meta-qcom/ -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] fate/hapdec : add test for hap alpha only
2017-09-24 11:53 GMT+02:00 Michael Niedermayer : > On Sat, Sep 23, 2017 at 09:53:45PM +0200, Martin Vignali wrote: > > Hello, > > > > sample can be found here : > > https://we.tl/cP0pW9IfBJ > > > > and need to be put inside ./fate-suite/hap > > uploaded > > [...] > New patch in attach (after change of pixfmt in HapAlphaOnly decoding) Martin 0005-fate-hapdec-add-test-for-hap-alpha-only-decoding.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] libavcodec/hap : add HapAlphaOnly decoding/encoding
Hello, After comments about the previous patchs New patchs in attach, for decoding and encoding of HAPAlphaOnly Martin 0001-libavcodec-texturedsp-add-rgtc1u_alpha-decoding-func.patch Description: Binary data 0002-libavcodec-texturedspenc-add-rgtc1_u_alpha-encoding-.patch Description: Binary data 0003-libavcodec-hapdec-add-HapAlphaOnly-decoding.patch Description: Binary data 0004-libavcodec-hapenc-add-support-for-HapAlphaOnly-encod.patch Description: Binary data 0006-libavcodec-texturedsp-indent-after-add-rgtc1u_alpha-.patch Description: Binary data 0007-libavcodec-texturedspenc-indent-after-add-rgtc1u_alp.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avdevice/decklink: new options 'list_pixelformats' and 'pixelformat_code' to allow pixelformat selection by code
On Mon, 25 Sep 2017, Marton Balint wrote: On Thu, 21 Sep 2017, Gildas Fargeas wrote: Hey, do you need more stuff changed on this patch ? No, just waiting for other pending decklink patches to push (and test) them at once. Finally applied. Thanks, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC
On Thu, 28 Sep 2017, Jeyapal, Karthick wrote: Sorry, still not quite there... Here are some further comments: Thanks for your comments and patience. Please find the updated patch attached, with all the comments taken. Also, I have rebased this patch with the latest ffmpeg, as avcodec version numbers have changed in the meantime. Also please test your patches with real CC data before posting them, I know it is tedious work with all the patch iterations, but I do the same with teletext. Sorry about that. I did test that patch with real CC data and corrected the inverted checks, but I forgot and attached the older patch in a hurry. Sorry for wasting your time there. Fingers crossed for the next patch version :) Well, me too :) Applied the series, thanks! Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: add mailing list faq
Just one typo below, thanks for providing the html as well.
On 28 Sep 2017 01:00, "Lou Logan" wrote:
Signed-off-by: Lou Logan
---
doc/Makefile | 1 +
doc/mailing-list-faq.texi | 204 ++
2 files changed, 205 insertions(+)
create mode 100644 doc/mailing-list-faq.texi
diff --git a/doc/Makefile b/doc/Makefile
index b670f0bd4c..9a4d225e65 100644
--- a/doc/Makefile
+++ b/doc/Makefile
@@ -24,6 +24,7 @@ HTMLPAGES = $(AVPROGS-yes:%=doc/%.html)
$(AVPROGS-yes:%=doc/%-all.html) $(COMP
doc/fate.html \
doc/general.html \
doc/git-howto.html\
+ doc/mailing-list-faq.html \
doc/nut.html \
doc/platform.html \
diff --git a/doc/mailing-list-faq.texi b/doc/mailing-list-faq.texi
new file mode 100644
index 00..a047fdcd51
--- /dev/null
+++ b/doc/mailing-list-faq.texi
@@ -0,0 +1,204 @@
+\input texinfo @c -*- texinfo -*-
+@documentencoding UTF-8
+
+@settitle FFmpeg Mailing List FAQ
+@titlepage
+@center @titlefont{FFmpeg Mailing List FAQ}
+@end titlepage
+
+@top
+
+@contents
+
+@chapter General Questions
+
+@section What is a mailing list?
+
+A mailing list is not much different than emailing someone, but the
+main difference is that your message is received by everyone who
+subscribes to the list. It is somewhat like a forum but in email form.
+
+See the @url{https://lists.ffmpeg.org/pipermail/ffmpeg-user/, ffmpeg-user
archives}
+for examples.
+
+@section What type of questions can I ask?
+
+@url{https://lists.ffmpeg.org/mailman/listinfo/ffmpeg-user/, ffmpeg-user}:
+For questions involving unscripted usage or compilation of the FFmpeg
+command-line tools (@command{ffmpeg}, @command{ffprobe}, @command{ffplay},
+@command{ffserver}).
+
+@url{https://lists.ffmpeg.org/mailman/listinfo/libav-user/, libav-user}:
+For questions involving the FFmpeg libav* libraries (libavcodec,
+libavformat, libavfilter, etc).
+
+@url{https://lists.ffmpeg.org/mailman/listinfo/ffmpeg-devel/,
ffmpeg-devel}:
+Only for discussions involving the development of FFmpeg and for
+submitting patches. User questions should be asked at ffmpeg-user or
+libav-user.
+
+To report a bug see @url{https://ffmpeg.org/bugreports.html}.
+
+We cannot provide help for scripts and/or third-party tools.
+
+@section How do I ask a question or send a message to the mailing list?
+
+E-mail @email{ffmpeg-user@@ffmpeg.org}.
+
+If you are not subscribed to the mailing list then your question must be
+manually approved. Approval may take several days, but the wait is
+usually less. If you want the message to be sent with no delay then you
+must subscribe first.
+
+Please do not send a message, subscribe, and re-send the message: this
+results in duplicates, causes more work for the admins, and may lower
+your chance at getting an answer. However, you may do so if you first
+@ref{How do I delete my message in the moderation queue, delete your
original message from the moderation queue}.
+
+@chapter Subscribing / Unsubscribing
+
+@section Do I need to subscribe?
+
+No.
+
+However, you will not directly receive replies unless you ask to be CCd
+in your message, but on occasion users will forget to CC you when
+replying. Alternatively, you can view and reply to messages via the
+@ref{Where are the archives, archives}.
+
+@section How do I subscribe?
+
+Email @email{ffmpeg-user-request@@ffmpeg.org} with the subject
+@emph{subscribe}.
+
+Or visit the @url{https://lists.ffmpeg.org/mailman/listinfo/ffmpeg-user/,
ffmpeg-user mailing list info page}
+and refer to the @emph{Subscribing to ffmpeg-user} section.
+
+The process is the same for the other mailing lists.
+
+@section How do I unsubscribe?
+
+Email @email{ffmpeg-user-request@@ffmpeg.org} with subject
@emph{unsubscribe}.
+
+Or visit the @url{https://lists.ffmpeg.org/mailman/listinfo/ffmpeg-user/,
ffmpeg-user mailing list info page},
+scroll to bottom of page, enter your email address in the box, and click
+the @emph{Unsubscribe or edit options} button.
+
+The process is the same for the other mailing lists.
+
+Please avoid asking a mail admin to unsubscribe you: there should be no
+reason to do so.
+
+@anchor{How do I delete my message in the moderation queue}
+@section How do I delete my message in the moderation queue?
+
+You should have received an email with the subject @emph{Your message to
ffmpeg-user awaits moderator approval}.
+A link is in the message that will allow you to delete your message
+unless a mail admin already approved or rejected it.
+
+@chapter Archives
+
+@anchor{Where are the archives}
+@section Where are the archives?
+
+See the @emph{Archives} section on the @url{https://ffmpeg.org/contact.html,
FFmpeg Contact}
+pag
Re: [FFmpeg-devel] Decklink question
On Thu, 28 Sep 2017, ffm...@dx9s.net wrote: Are there known issues with DeckLink as of recent? Which SDK version was the DeckLink support compiled against? I downloaded 3.3.4 and the latest Blackmagic Design SDK for a (recently) purchased 'DeckLink Studio 4K' I purchased... You should try the latest ffmpeg git master, RGB support just got recently committed, and if you are capturing from HDMI maybe you have to use an RGB format. Until now, ffmpeg always requested YUV, and I am not sure if decklink is supposed to do a software conversion by default or not. You wrote a very long letter by the way, try to be more laconic. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] configure: simplify checks for libxcb dependent features
On Wed, Sep 27, 2017 at 03:19:08PM -0300, James Almer wrote: > --- > configure | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) maybe i did something silly but this breaks configure here ./configure: 1275: shift: can't shift that many use_pkg_config needs one more argument [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding the exact solution to an approximation. Benchmarking OTOH is finding an approximation of the exact signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Decklink question
On 2017-09-28 13:32, Marton Balint wrote: You should try the latest ffmpeg git master, RGB support just got recently committed, and if you are capturing from HDMI maybe you have to use an RGB format. Until now, ffmpeg always requested YUV, and I am not sure if decklink is supposed to do a software conversion by default or not. You wrote a very long letter by the way, try to be more laconic. heh.. It's been an ongoing documented (in the Blackmagic forums as well) process. An almost copy-and-paste / SORRY! First post and wasn't sure as to what background info people would want. I saw the patches moments ago (decklink related); was planning on asking about details to where one can pull the latest. (which upstream/origin, branch, etc.). I believe I can find most of that -- I thought I saw that you use github as a mirror and guessing the place to get it is elsewhere. Will report back when I get a chance. --Doug (dx9s) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] configure: simplify checks for libxcb dependent features
On 9/28/2017 5:35 PM, Michael Niedermayer wrote: > On Wed, Sep 27, 2017 at 03:19:08PM -0300, James Almer wrote: >> --- >> configure | 10 +++--- >> 1 file changed, 3 insertions(+), 7 deletions(-) > > maybe i did something silly but this breaks configure here No, you didn't. I actually forgot to reply saying this patch is dropped as a merge i applied breaks it. Should have waited in retrospect until i was done with this configure merge batch. > ./configure: 1275: shift: can't shift that many > > use_pkg_config needs one more argument I'll send an updated version of this set soon. Sorry about that. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: add mailing list faq
On Thu, Sep 28, 2017, at 12:28 PM, Kieran O Leary wrote: > Just one typo below, thanks for providing the html as well. [...] > +Perform a site seach using your favorite search engine. Example: > + > > site search Thanks. Will change locally. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] libavformat/nutenc.c: Use ffv1 as default video encoder for NUT muxing
On Wed, Sep 27, 2017 at 07:14:50PM -0400, Leo Izen wrote:
> ---
> libavformat/nutenc.c| 2 +-
> tests/ref/lavf/nut | 6 +++---
> tests/ref/seek/lavf-nut | 54
> -
> 3 files changed, 31 insertions(+), 31 deletions(-)
>
> diff --git a/libavformat/nutenc.c b/libavformat/nutenc.c
> index a92ff55c01..6e96626ff0 100644
> --- a/libavformat/nutenc.c
> +++ b/libavformat/nutenc.c
> @@ -1221,7 +1221,7 @@ AVOutputFormat ff_nut_muxer = {
> .priv_data_size = sizeof(NUTContext),
> .audio_codec= CONFIG_LIBVORBIS ? AV_CODEC_ID_VORBIS :
>CONFIG_LIBMP3LAME ? AV_CODEC_ID_MP3 : AV_CODEC_ID_MP2,
> -.video_codec= AV_CODEC_ID_MPEG4,
> +.video_codec= AV_CODEC_ID_FFV1,
> .write_header = nut_write_header,
> .write_packet = nut_write_packet,
> .write_trailer = nut_write_trailer,
Why?
also this breaks existing code and command lines which expect mpeg4 as
default
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Added HW accelerated H.264 and HEVC encoding for AMD GPUs based on AMF SDK
2017-09-28 20:58 GMT+02:00 mmironov : > +++ b/compat/amd/amf/LICENSE.txt > @@ -0,0 +1,31 @@ > +Notice Regarding Standards. AMD does not provide a license or sublicense to > +any Intellectual Property Rights relating to any standards, including but not > +limited to any audio and/or video codec technologies such as MPEG-2, MPEG-4; > +AVC/H.264; HEVC/H.265; AAC decode/FFMPEG; AAC encode/FFMPEG; VC-1; and MP3 > +(collectively, the "Media Technologies"). For clarity, you will pay any > +royalties due for such third party technologies, which may include the Media > +Technologies that are owed as a result of AMD providing the Software to you. Is this part of the software license? If yes, this can definitely not be committed to the FFmpeg repository. If not, please remove it. Before removing it, please check with the original author (AMD) that it is not part of the software license. > + > +This software uses libraries from the FFmpeg project under the LGPLv2.1. > + > +MIT license > + > +Copyright (c) 2016 Advanced Micro Devices, Inc. All rights reserved. > + > +Permission is hereby granted, free of charge, to any person obtaining a copy > +of this software and associated documentation files (the "Software"), to deal > +in the Software without restriction, including without limitation the rights > +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell > +copies of the Software, and to permit persons to whom the Software is > +furnished to do so, subject to the following conditions: > + > +The above copyright notice and this permission notice shall be included in > +all copies or substantial portions of the Software. > + > +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, > +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN > +THE SOFTWARE Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH]lavd/decklink_dec: Do not claim to output transparency information
Hi! I don't have decklink hardware but I assume it never outputs actual transparency. Or does it? Please comment, Carl Eugen From 3ab60460c7892b094b01b175f1a3aa735cb3cea6 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 28 Sep 2017 23:18:09 +0200 Subject: [PATCH] lavd/decklink_dec: Do not claim to output transparency information. --- libavdevice/decklink_dec.cpp |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 3ce2cab..17c0d20 100644 --- a/libavdevice/decklink_dec.cpp +++ b/libavdevice/decklink_dec.cpp @@ -973,13 +973,13 @@ av_cold int ff_decklink_read_header(AVFormatContext *avctx) case bmdFormat8BitARGB: st->codecpar->codec_id= AV_CODEC_ID_RAWVIDEO; st->codecpar->codec_tag = avcodec_pix_fmt_to_codec_tag((enum AVPixelFormat)st->codecpar->format);; -st->codecpar->format = AV_PIX_FMT_ARGB; +st->codecpar->format = AV_PIX_FMT_0RGB; st->codecpar->bit_rate= av_rescale(ctx->bmd_width * ctx->bmd_height * 32, st->time_base.den, st->time_base.num); break; case bmdFormat8BitBGRA: st->codecpar->codec_id= AV_CODEC_ID_RAWVIDEO; st->codecpar->codec_tag = avcodec_pix_fmt_to_codec_tag((enum AVPixelFormat)st->codecpar->format); -st->codecpar->format = AV_PIX_FMT_BGRA; +st->codecpar->format = AV_PIX_FMT_BGR0; st->codecpar->bit_rate= av_rescale(ctx->bmd_width * ctx->bmd_height * 32, st->time_base.den, st->time_base.num); break; case bmdFormat10BitRGB: -- 1.7.10.4 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] libavcodec/hap : add HapAlphaOnly decoding/encoding
2017-09-28 21:50 GMT+02:00 Martin Vignali : > After comments about the previous patchs Please explain how this encoder and decoder can be used from the FFmpeg cli: What kind of input could be used, what could be done with the output? I believe you force every user to add an additional filter to do anything useful, please convince me that this is wrong. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avcodec/hevc_sei: Support HEVC paired fields.
On Sun, Sep 24, 2017 at 02:42:20PM -0500, Brian Matherly wrote: > On 9/23/2017 5:22 PM, Michael Niedermayer wrote: > >On Thu, Sep 14, 2017 at 08:39:19PM -0500, Brian Matherly wrote: > >>Correctly set frame.interlaced and frame.top_field_first when pic_struct > >>indicates paired fields. > >Do you have a (small) sample that gets fixed by this ? > > > >Can you make a fate test for this case ? > > > >[...] > > > > Thanks Michael, > > I submitted a V2 patch (sorry about the double e-mail). V2 includes > a fate test which uses probeframes. The reason I test probeframes is > because the pixel data in the frame is exactly the same with/wo the > patch - and the important part of the test is the value of the > interlaced_frame and repeat_first_field fields. > > The sample file is uploaded to the videolan uploader: paired_fields.hevc > It should be placed in: fate-suite/hevc/paired_fields.hevc uploaded [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: add mailing list faq
2017-09-28 1:59 GMT+02:00 Lou Logan : > +@item > +Avoid sending email disclaimers and legalese if possible as this is a > +public list. > However, we are aware that many corporate users are unable > +to avoid this. Since the first sentence already contains "if possible" I believe the second sentence can be omitted. Thank you! Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Fixes bug https://trac.ffmpeg.org/ticket/6700.
2017-09-28 17:11 GMT+02:00 Pablo Montilla :
> ---
> libavformat/isom.h | 2 +-
> libavformat/mov.c | 6 +-
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/libavformat/isom.h b/libavformat/isom.h
> index fdd98c28f5..a32b92ccdd 100644
> --- a/libavformat/isom.h
> +++ b/libavformat/isom.h
> @@ -52,7 +52,7 @@ struct AVAESCTR;
> */
>
> typedef struct MOVStts {
> -int count;
> +unsigned int count;
> int duration;
> } MOVStts;
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 2de60b2159..9cfc860c18 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -2658,15 +2658,11 @@ static int mov_read_stts(MOVContext *c, AVIOContext
> *pb, MOVAtom atom)
>
> for (i = 0; i < entries && !pb->eof_reached; i++) {
> int sample_duration;
> -int sample_count;
> +unsigned int sample_count;
>
> sample_count=avio_rb32(pb);
> sample_duration = avio_rb32(pb);
>
> -if (sample_count < 0) {
> -av_log(c->fc, AV_LOG_ERROR, "Invalid sample_count=%d\n",
> sample_count);
> -return AVERROR_INVALIDDATA;
> -}
> sc->stts_data[i].count= sample_count;
> sc->stts_data[i].duration= sample_duration;
>
Patch applied.
Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH v4] avcodec/hevc_sei: Support HEVC paired fields.
On Wed, Sep 27, 2017 at 08:48:42PM -0500, Brian Matherly wrote: > From: Brian Matherly > > Correctly set the interlaced_frame and top_field_first fields when pic_struct > indicates paired fields. > --- > libavcodec/hevc_sei.c | 4 ++-- > tests/fate/hevc.mak | 6 +- > tests/ref/fate/hevc-paired-fields | 16 > 3 files changed, 23 insertions(+), 3 deletions(-) > create mode 100644 tests/ref/fate/hevc-paired-fields this can be applied in 24h (after the fate sample is synced between fate cliensts) unless someone sees a issue in the patch [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally arises out of democracy, and the most aggravated form of tyranny and slavery out of the most extreme liberty. -- Plato signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] fate: increase fuzz for refcmp filter tests
On Thu, Sep 28, 2017 at 09:27:23AM +0200, Tobias Rapp wrote: > Should fix failing tests on GNU/kFreeBSD x86_32. > > Signed-off-by: Tobias Rapp > --- > Michael: Have put you on CC as you seem to be the owner of the affected > machines. LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and democracies degenerate into despotisms. -- Aristotle signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] doc: add mailing list faq
On Thu, Sep 28, 2017, at 01:43 PM, Carl Eugen Hoyos wrote: > Since the first sentence already contains "if possible" I believe > the second sentence can be omitted. OK. Removed locally. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 1/2 v2] configure: disable libxcb dependent features if libxcb is not enabled
Signed-off-by: James Almer --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index c2f5fc2c98..ebcf48de20 100755 --- a/configure +++ b/configure @@ -6215,6 +6215,8 @@ if enabled libxcb; then add_cflags $xcb_cflags $xcb_shm_cflags $xcb_xfixes_cflags $xcb_shape_cflags add_extralibs $xcb_extralibs $xcb_shm_extralibs $xcb_xfixes_extralibs $xcb_shape_extralibs +else +disable libxcb_shm libxcb_shape libxcb_xfixes fi check_func_headers "windows.h" CreateDIBSection "$gdigrab_indev_extralibs" -- 2.14.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 2/2 v2] configure: simplify checks for libxcb dependent features
Signed-off-by: James Almer --- configure | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/configure b/configure index ebcf48de20..2750605e75 100755 --- a/configure +++ b/configure @@ -6206,15 +6206,12 @@ if enabled libcdio; then die "ERROR: No usable libcdio/cdparanoia found" fi -enabled libxcb && check_pkg_config libxcb "xcb >= 1.4" xcb/xcb.h xcb_connect +enabled libxcb && use_pkg_config libxcb "xcb >= 1.4" xcb/xcb.h xcb_connect if enabled libxcb; then -enabled libxcb_shm&& check_pkg_config libxcb_shmxcb-shm xcb/shm.hxcb_shm_attach -enabled libxcb_shape && check_pkg_config libxcb_shape xcb-shape xcb/shape.h xcb_shape_get_rectangles -enabled libxcb_xfixes && check_pkg_config libxcb_xfixes xcb-xfixes xcb/xfixes.h xcb_xfixes_get_cursor_image - -add_cflags $xcb_cflags $xcb_shm_cflags $xcb_xfixes_cflags $xcb_shape_cflags -add_extralibs $xcb_extralibs $xcb_shm_extralibs $xcb_xfixes_extralibs $xcb_shape_extralibs +enabled libxcb_shm&& use_pkg_config libxcb_shmxcb-shmxcb/shm.h xcb_shm_attach +enabled libxcb_shape && use_pkg_config libxcb_shape xcb-shape xcb/shape.h xcb_shape_get_rectangles +enabled libxcb_xfixes && use_pkg_config libxcb_xfixes xcb-xfixes xcb/xfixes.h xcb_xfixes_get_cursor_image else disable libxcb_shm libxcb_shape libxcb_xfixes fi -- 2.14.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: extract SPS fields required for hvcC construction
On Wed, Sep 27, 2017 at 9:05 AM, Michael Niedermayer wrote: > On Tue, Sep 26, 2017 at 06:08:09PM -0700, Aman Gupta wrote: > > From: Aman Gupta > > > > --- > > libavcodec/hevc_ps.c | 3 ++- > > libavcodec/hevc_ps.h | 2 ++ > > 2 files changed, 4 insertions(+), 1 deletion(-) > > LGTM > applied > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. > User > questions about the command line tools should be sent to the ffmpeg-user > ML. > And questions about how to use libav* should be sent to the libav-user ML. > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: add hevc support
On Wed, Sep 27, 2017 at 9:44 AM, Hendrik Leppkes wrote: > On Wed, Sep 27, 2017 at 6:37 PM, wm4 wrote: > > On Wed, 27 Sep 2017 09:17:36 -0700 > > Aman Gupta wrote: > > > >> On Wed, Sep 27, 2017 at 5:51 AM, wm4 wrote: > >> > >> > On Tue, 26 Sep 2017 18:08:10 -0700 > >> > Aman Gupta wrote: > >> > > >> > > From: Aman Gupta > >> > > > >> > > --- > >> > > configure| 2 + > >> > > libavcodec/allcodecs.c | 1 + > >> > > libavcodec/hevc_refs.c | 3 + > >> > > libavcodec/hevcdec.c | 12 ++- > >> > > libavcodec/vda_vt_internal.h | 1 + > >> > > libavcodec/videotoolbox.c| 203 ++ > >> > + > >> > > 6 files changed, 221 insertions(+), 1 deletion(-) > >> > > >> > PS: A final patch should make sure these symbols don't cause build > >> > failures with older SDKs: > >> > > >> > > +case kCMVideoCodecType_HEVC : > >> > > >> > > +videotoolbox->cm_codec_type = kCMVideoCodecType_HEVC; > >> > > >> > > >> > Maybe with a configure check. > >> > > >> > >> This is available since macOS 10.11. How far back does ffmpeg support? > > > > Really not sure. If VideoToolbox support is never detected before > > 10.11, then it's OK. > > VT is supported since 10.8, if anything newer is required for this, > then it should get a configure check. > pushed to master with configure check > > - Hendrik > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] maintainers: add myself to the general developers list
--- It was recommended to me that I do this, as I do not maintain any specific functionality/module as such. Jan MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 77f48b984b..d08fad80b8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -556,6 +556,7 @@ Pedro Arthur Sebastien Zwickert Vittorio Giovara wm4 +Jan Ekström (this list is incomplete) -- 2.13.6 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Do not claim to output transparency information
On 2017-09-28 14:20, Carl Eugen Hoyos wrote: I don't have decklink hardware but I assume it never outputs actual transparency. Or does it? From what I understand about SDI, it is possible to send alpha information over an SDI link in certain configuration (RGBA) -- from what I read on Wikipedia ( https://en.wikipedia.org/wiki/Serial_digital_interface#Link_numbering ) on SDI. I will assume that it might be possible to access that information from such a decklink card (I don't have and SDI hardware as of yet, but might end up getting one) --Doug (dx9s) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 3/3] avfilter/vf_thumbnail_cuda: Avoid mixing declaration and statements
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_thumbnail_cuda.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c
index 4c08a85121..09377ca7f4 100644
--- a/libavfilter/vf_thumbnail_cuda.c
+++ b/libavfilter/vf_thumbnail_cuda.c
@@ -269,7 +269,8 @@ static int filter_frame(AVFilterLink *inlink, AVFrame
*frame)
if (hw_frames_ctx->sw_format == AV_PIX_FMT_NV12 ||
hw_frames_ctx->sw_format == AV_PIX_FMT_YUV420P ||
hw_frames_ctx->sw_format == AV_PIX_FMT_P010LE ||
hw_frames_ctx->sw_format == AV_PIX_FMT_P016LE)
{
-for (int i = 256; i < HIST_SIZE; i++)
+int i;
+for (i = 256; i < HIST_SIZE; i++)
hist[i] = 4 * hist[i];
}
--
2.14.2
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 2/3] avcodec/v4l2_context: Reduce spelling variations
Signed-off-by: Michael Niedermayer
---
libavcodec/v4l2_context.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c
index d675c55f2b..297792f871 100644
--- a/libavcodec/v4l2_context.c
+++ b/libavcodec/v4l2_context.c
@@ -112,7 +112,7 @@ static inline void v4l2_save_to_context(V4L2Context* ctx,
struct v4l2_format_upd
}
/**
- * returns 1 if reinit was succesful, negative if it failed
+ * returns 1 if reinit was successful, negative if it failed
* returns 0 if reinit was not executed
*/
static int v4l2_handle_event(V4L2Context *ctx)
@@ -266,7 +266,7 @@ static V4L2Buffer* v4l2_dequeue_v4l2buf(V4L2Context *ctx,
int timeout)
return NULL;
}
if (ret) {
-/* if re-init was successfull drop the buffer (if there was one)
+/* if re-init was successful drop the buffer (if there was one)
* since we had to reconfigure capture (unmap all buffers)
*/
return NULL;
--
2.14.2
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 1/3] avcodec/v4l2_buffers: More clear return code documentation
Signed-off-by: Michael Niedermayer
---
libavcodec/v4l2_buffers.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavcodec/v4l2_buffers.h b/libavcodec/v4l2_buffers.h
index b16f694b98..e28a4a650d 100644
--- a/libavcodec/v4l2_buffers.h
+++ b/libavcodec/v4l2_buffers.h
@@ -65,8 +65,8 @@ typedef struct V4L2Buffer {
* @param[in] frame The AVFRame to push the information to
* @param[in] buf The V4L2Buffer to get the information from
*
- * @returns 0 in case of success, EINVAL if the number of planes is incorrect,
- * ENOMEM if the AVBufferRef cant be created.
+ * @returns 0 in case of success, AVERROR(EINVAL) if the number of planes is
incorrect,
+ * AVERROR(ENOMEM) if the AVBufferRef cant be created.
*/
int ff_v4l2_buffer_buf_to_avframe(AVFrame *frame, V4L2Buffer *buf);
@@ -76,8 +76,8 @@ int ff_v4l2_buffer_buf_to_avframe(AVFrame *frame, V4L2Buffer
*buf);
* @param[in] pkt The AVPacket to push the information to
* @param[in] buf The V4L2Buffer to get the information from
*
- * @returns 0 in case of success, EINVAL if the number of planes is incorrect,
- * ENOMEM if the AVBufferRef cant be created.
+ * @returns 0 in case of success, AVERROR(EINVAL) if the number of planes is
incorrect,
+ * AVERROR(ENOMEM) if the AVBufferRef cant be created.
*
*/
int ff_v4l2_buffer_buf_to_avpkt(AVPacket *pkt, V4L2Buffer *buf);
@@ -88,7 +88,7 @@ int ff_v4l2_buffer_buf_to_avpkt(AVPacket *pkt, V4L2Buffer
*buf);
* @param[in] frame AVPacket to get the data from
* @param[in] avbuf V4L2Bfuffer to push the information to
*
- * @returns 0 in case of success, negative otherwise
+ * @returns 0 in case of success, a negative AVERROR code otherwise
*/
int ff_v4l2_buffer_avpkt_to_buf(const AVPacket *pkt, V4L2Buffer *out);
@@ -98,7 +98,7 @@ int ff_v4l2_buffer_avpkt_to_buf(const AVPacket *pkt,
V4L2Buffer *out);
* @param[in] frame AVFrame to get the data from
* @param[in] avbuf V4L2Bfuffer to push the information to
*
- * @returns 0 in case of success, negative otherwise
+ * @returns 0 in case of success, a negative AVERROR code otherwise
*/
int ff_v4l2_buffer_avframe_to_buf(const AVFrame *frame, V4L2Buffer* out);
@@ -108,7 +108,7 @@ int ff_v4l2_buffer_avframe_to_buf(const AVFrame *frame,
V4L2Buffer* out);
* @param[in] avbuf V4L2Bfuffer to initialize
* @param[in] index v4l2 buffer id
*
- * @returns 0 in case of success, negative otherwise
+ * @returns 0 in case of success, a negative AVERROR code otherwise
*/
int ff_v4l2_buffer_initialize(V4L2Buffer* avbuf, int index);
@@ -117,7 +117,7 @@ int ff_v4l2_buffer_initialize(V4L2Buffer* avbuf, int index);
*
* @param[in] avbuf V4L2Bfuffer to push to the driver
*
- * @returns 0 in case of success, negative otherwise
+ * @returns 0 in case of success, a negative AVERROR code otherwise
*/
int ff_v4l2_buffer_enqueue(V4L2Buffer* avbuf);
--
2.14.2
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/3] avcodec/v4l2_context: Reduce spelling variations
On Thu, Sep 28, 2017, at 04:28 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/v4l2_context.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Decklink question
On 2017-09-28 13:32, Marton Balint wrote: You should try the latest ffmpeg git master, RGB support just got recently committed, and if you are capturing from HDMI maybe you have to use an RGB format. Until now, ffmpeg always requested YUV, and I am not sure if decklink is supposed to do a software conversion by default or not. Okay.. Build a custom local build based on commit 3d4f8b9184a4693c577e0b73496e6cc1989c6bbf did some initial testing but still need to test the RGB format: dx@x299:~/capture$ ffmpeg -format_code Hp59 -f decklink -video_input hdmi -audio_input embedded -raw_format yuv422p10 -i 'DeckLink Studio 4K' -acodec pcm_s24le -vcodec dnxhd -vf scale=1920x1080,fps=6/1001,format=yuv422p10 -b:v 440M out.mov ffmpeg version N-87614-g3d4f8b9-dx9s-decklink Copyright (c) 2000-2017 the FFmpeg developers built with gcc 5.4.0 (Ubuntu 5.4.0-6ubuntu1~16.04.4) 20160609 configuration: --prefix=/usr/local/ffmpeg --extra-version=dx9s-decklink --build-suffix=-dx9s-decklink --toolchain=hardened --cc=cc --cxx=g++ --enable-gpl --enable-shared --disable-stripping --disable-decoder=libopenjpeg --enable-avresample --enable-avisynth --enable-gnutls --enable-ladspa --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libmodplug --enable-libmp3lame --enable-libopenjpeg --enable-libopus --enable-libpulse --enable-librtmp --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxvid --enable-libzvbi --enable-openal --enable-opengl --enable-libdc1394 --enable-libiec61883 --enable-libzmq --enable-frei0r --enable-libx264 --enable-libopencv --enable-decklink --enable-nonfree libavutil 55. 77.101 / 55. 77.101 libavcodec 57.106.104 / 57.106.104 libavformat57. 82.102 / 57. 82.102 libavdevice57. 9.101 / 57. 9.101 libavfilter 6.106.100 / 6.106.100 libavresample 3. 6. 0 / 3. 6. 0 libswscale 4. 7.103 / 4. 7.103 libswresample 2. 8.100 / 2. 8.100 libpostproc54. 6.100 / 54. 6.100 [decklink @ 0x55d886094300] Found Decklink mode 1920 x 1080 with rate 59.94 [decklink @ 0x55d886094300] Frame received (#1) - No input signal detected - Frames dropped 1 Guessed Channel Layout for Input Stream #0.0 : stereo Input #0, decklink, from 'DeckLink Studio 4K': Duration: N/A, start: 0.00, bitrate: 2653092 kb/s Stream #0:0: Audio: pcm_s16le, 48000 Hz, stereo, s16, 1536 kb/s Stream #0:1: Video: v210 (V210 / 0x30313256), yuv422p10le(progressive), 1920x1080, 2651556 kb/s, 59.94 tbr, 1000k tbn, 1000k tbc Stream mapping: Stream #0:1 -> #0:0 (v210 (native) -> dnxhd (native)) Stream #0:0 -> #0:1 (pcm_s16le (native) -> pcm_s24le (native)) Press [q] to stop, [?] for help Output #0, mov, to 'out.mov': Metadata: encoder : Lavf57.82.102 Stream #0:0: Video: dnxhd (DNXHD) (AVdn / 0x6E645641), yuv422p10le, 1920x1080, q=2-1024, 44 kb/s, 59.94 fps, 60k tbn, 59.94 tbc Metadata: encoder : Lavc57.106.104 dnxhd Stream #0:1: Audio: pcm_s24le (in24 / 0x34326E69), 48000 Hz, stereo, s32, 2304 kb/s Metadata: encoder : Lavc57.106.104 pcm_s24le frame= 90 fps= 62 q=1.0 Lsize= 81065kB time=00:00:01.50 bitrate=442279.7kbits/s speed=1.03x video:80640kB audio:422kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.003102% output file is black (no bars or anything) and suspect audio is same as before... Initially still see same messages (16 bit audio and no Input signal detected) Will report back once I figure out how to request RGB from the recent patch you mentions about RGB. (is that still too much information) --Doug (dx9s) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] ffmpeg have program decoding ACC ltam audo stream
Thanks Carl; But the first audio track - Stream #0:4[0x3a2](zho): Audio: aac_latm (HE-AAC) ([17][0][0][0] / 0x0011), 48000 Hz, 5.1, fltp Produce funny audio sound Thanks -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Carl Eugen Hoyos Sent: Thursday, September 28, 2017 10:45 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] ffmpeg have program decoding ACC ltam audo stream 2017-09-28 6:09 GMT+02:00 : > TS file http://www99.zippyshare.com/v/UwxzRccM/file.html Thank you for the sample. Damaged transport streams show all kind of messages, but the sample can be decoded. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Decklink question
Will report back once I figure out how to request RGB from the recent patch you mentions about RGB. search the git log: git diff 00a61f30a05a76d10e04253987202e41f8703ebe cb8b729180cc3ccb85f6c0d2fa7190865cbc2cb7 found the additional options for the -raw_format dx@x299:~/git/ffmpeg$ ffmpeg -format_code Hp59 -f decklink -video_input hdmi -audio_input embedded -raw_format rgb10 -i 'DeckLink Studio 4K' -acodec pcm_s24le -vcodec dnxhd -vf scale=1920x1080,fps=6/1001,format=yuv422p10 -b:v 440M out.mov ffmpeg version N-87614-g3d4f8b9-dx9s-decklink Copyright (c) 2000-2017 the FFmpeg developers built with gcc 5.4.0 (Ubuntu 5.4.0-6ubuntu1~16.04.4) 20160609 configuration: --prefix=/usr/local/ffmpeg --extra-version=dx9s-decklink --build-suffix=-dx9s-decklink --toolchain=hardened --cc=cc --cxx=g++ --enable-gpl --enable-shared --disable-stripping --disable-decoder=libopenjpeg --enable-avresample --enable-avisynth --enable-gnutls --enable-ladspa --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libmodplug --enable-libmp3lame --enable-libopenjpeg --enable-libopus --enable-libpulse --enable-librtmp --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxvid --enable-libzvbi --enable-openal --enable-opengl --enable-libdc1394 --enable-libiec61883 --enable-libzmq --enable-frei0r --enable-libx264 --enable-libopencv --enable-decklink --enable-nonfree libavutil 55. 77.101 / 55. 77.101 libavcodec 57.106.104 / 57.106.104 libavformat57. 82.102 / 57. 82.102 libavdevice57. 9.101 / 57. 9.101 libavfilter 6.106.100 / 6.106.100 libavresample 3. 6. 0 / 3. 6. 0 libswscale 4. 7.103 / 4. 7.103 libswresample 2. 8.100 / 2. 8.100 libpostproc54. 6.100 / 54. 6.100 [decklink @ 0x55e837135300] Found Decklink mode 1920 x 1080 with rate 59.94 Guessed Channel Layout for Input Stream #0.0 : stereo Input #0, decklink, from 'DeckLink Studio 4K': Duration: N/A, start: 0.00, bitrate: 3730287 kb/s Stream #0:0: Audio: pcm_s16le, 48000 Hz, stereo, s16, 1536 kb/s Stream #0:1: Video: r210 (R210 / 0x30313252), rgb48le(10 bpc, progressive), 1920x1080, 3728751 kb/s, 59.94 tbr, 1000k tbn, 1000k tbc File 'out.mov' already exists. Overwrite ? [y/N] y Stream mapping: Stream #0:1 -> #0:0 (r210 (native) -> dnxhd (native)) Stream #0:0 -> #0:1 (pcm_s16le (native) -> pcm_s24le (native)) Press [q] to stop, [?] for help Output #0, mov, to 'out.mov': Metadata: encoder : Lavf57.82.102 Stream #0:0: Video: dnxhd (DNXHD) (AVdn / 0x6E645641), yuv422p10le, 1920x1080, q=2-1024, 44 kb/s, 59.94 fps, 60k tbn, 59.94 tbc Metadata: encoder : Lavc57.106.104 dnxhd Stream #0:1: Audio: pcm_s24le (in24 / 0x34326E69), 48000 Hz, stereo, s32, 2304 kb/s Metadata: encoder : Lavc57.106.104 pcm_s24le [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=370825.6kbits/s speed=0.327x Last message repeated 41 times [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=405042.1kbits/s speed=0.389x Last message repeated 49 times [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=415794.5kbits/s speed=0.418x Last message repeated 49 times [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=421479.6kbits/s speed=0.436x Last message repeated 49 times [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=424998.7kbits/s speed=0.448x Last message repeated 47 times [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=428648.9kbits/s speed=0.457x Last message repeated 49 times [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=430208.3kbits/s speed=0.464x Last message repeated 49 times [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=431393.8kbits/s speed=0.469x Last message repeated 47 times [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=433168.8kbits/s speed=0.473x Last message repeated 52 times [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=392545.3kbits/s speed=0.497x Last message repeated 45 times [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=330666.6kbits/s speed=0.543x Last message repeated 47 times [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=284429.5kbits/s speed=0.584x Last message repeated 45 times [decklink @ 0x55e837135300] Decklink input buffer overrun! bitrate=249536.8kbits/s speed=0.619x Last message repeated 12 times [decklink @ 0x55e837135300] Decklink input buffer overrun! Last message repeated 5 times f
[FFmpeg-devel] [PATCH V2 1/2] ffmpeg: re-enable hwaccel_lax_profile_check use hwaccel_flags.
From e2a7cce88d2a47c7e598b59d24258fea8d809c22 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 21 Sep 2017 02:41:29 -0400 Subject: [PATCH V2 1/2] ffmpeg: re-enable hwaccel_lax_profile_check use hwaccel_flags. re-enable hwaccel_lax_profile_check option use hwaccel_flags. Signed-off-by: Jun Zhao --- ffmpeg.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ffmpeg.c b/ffmpeg.c index 1d248bc269..4f2b9d69d9 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -2859,6 +2859,9 @@ static enum AVPixelFormat get_format(AVCodecContext *s, const enum AVPixelFormat ist->active_hwaccel_id = hwaccel->id; ist->hwaccel_pix_fmt = *p; + +if (hwaccel_lax_profile_check) +s->hwaccel_flags |= AV_HWACCEL_FLAG_ALLOW_PROFILE_MISMATCH; break; } -- 2.11.0 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH V2 2/2] lavc/vaapi_decode: fix profile search when disable exact profile match.
From 94604d623de1fec6f363dcda4d61712865257a0a Mon Sep 17 00:00:00 2001
From: Jun Zhao
Date: Thu, 21 Sep 2017 02:44:42 -0400
Subject: [PATCH V2 2/2] lavc/vaapi_decode: fix profile search when disable
exact profile match.
when disable exact profile, use the alt_profile for VAAPI HWAccel
decoder.
Signed-off-by: Jun Zhao
---
libavcodec/vaapi_decode.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c
index cf58aae4c6..f0dccf481b 100644
--- a/libavcodec/vaapi_decode.c
+++ b/libavcodec/vaapi_decode.c
@@ -328,7 +328,7 @@ static int vaapi_decode_make_config(AVCodecContext *avctx)
if (j < profile_count) {
if (exact_match)
break;
-alt_profile = vaapi_profile_map[i].codec_profile;
+alt_profile = vaapi_profile_map[i].va_profile;
}
}
av_freep(&profile_list);
@@ -348,6 +348,7 @@ static int vaapi_decode_make_config(AVCodecContext *avctx)
av_log(avctx, AV_LOG_WARNING, "Using possibly-"
"incompatible profile %d instead.\n",
alt_profile);
+profile = alt_profile;
} else {
av_log(avctx, AV_LOG_VERBOSE, "Codec %s profile %d not "
"supported for hardware decode.\n",
--
2.11.0
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC
On 9/28/2017 1:17 AM, Jeyapal, Karthick wrote:
>> Sorry, still not quite there... Here are some further comments:
> Thanks for your comments and patience. Please find the updated patch
> attached, with all the comments taken.
> Also, I have rebased this patch with the latest ffmpeg, as avcodec version
> numbers have changed in the meantime.
>
>> Also please test your patches with real CC data before posting them, I
>> know it is tedious work with all the patch iterations, but I do the same
>> with teletext.
> Sorry about that. I did test that patch with real CC data and corrected the
> inverted checks, but I forgot and attached the older patch in a hurry.
> Sorry for wasting your time there.
>
>> Fingers crossed for the next patch version :)
> Well, me too :)
>
> Thanks and Regards,
> Karthick
> diff --git a/libavcodec/version.h b/libavcodec/version.h
> index 39d9ad9..7aee6f9 100644
> --- a/libavcodec/version.h
> +++ b/libavcodec/version.h
> @@ -29,7 +29,7 @@
>
> #define LIBAVCODEC_VERSION_MAJOR 57
> #define LIBAVCODEC_VERSION_MINOR 106
> -#define LIBAVCODEC_VERSION_MICRO 103
> +#define LIBAVCODEC_VERSION_MICRO 104
>
> #define LIBAVCODEC_VERSION_INT AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \
> LIBAVCODEC_VERSION_MINOR, \
> diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp
> index 38e6bd8..3c283e0 100644
> --- a/libavdevice/decklink_dec.cpp
> +++ b/libavdevice/decklink_dec.cpp
> @@ -1,6 +1,7 @@
> /*
> * Blackmagic DeckLink input
> * Copyright (c) 2013-2014 Luca Barbato, Deti Fliegl
> + * Copyright (c) 2014 Rafaël Carré
> * Copyright (c) 2017 Akamai Technologies, Inc.
> *
> * This file is part of FFmpeg.
> @@ -105,6 +106,42 @@ static int get_vanc_line_idx(BMDDisplayMode mode)
> return i - 1;
> }
>
> +static inline uint16_t parity (uint16_t x)
> +{
> +uint16_t i;
> +for (i = 4 * sizeof (x); i > 0; i /= 2)
> +x ^= x >> i;
> +return x & 1;
> +}
Can't you use av_parity() instead?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Decklink question
I will continue to do testing.. ffmpeg -format_code Hp59 -f decklink -video_input hdmi -audio_input embedded -raw_format argb -i 'DeckLink Studio 4K' -acodec pcm_s16le -vcodec dnxhd -vf scale=1920x1080,fps=6/1001,format=yuv422p10 -b:v 440M out.mov (mediainfo dump): General Complete name: out.mov Format : MPEG-4 Format profile : QuickTime Codec ID : qt .02 (qt ) File size: 2.75 GiB Duration : 53 s 487 ms Overall bit rate mode: Constant Overall bit rate : 442 Mb/s Writing application : Lavf57.82.102 Video ID : 1 Format : VC-3 Format version : Version 1 Format profile : HD@HQX Codec ID : AVdn Codec ID/Info: Avid DNxHD Duration : 53 s 487 ms Bit rate mode: Constant Bit rate : 440 Mb/s Width: 1 920 pixels Height : 1 080 pixels Display aspect ratio : 16:9 Frame rate mode : Constant Frame rate : 59.940 (6/1001) FPS Color space : YUV Chroma subsampling : 4:2:2 Bit depth: 10 bits Scan type: Progressive Bits/(Pixel*Frame) : 3.540 Stream size : 2.74 GiB (100%) Language : English Audio ID : 2 Format : PCM Format settings : Little / Signed Format settings, Endianness : Little Format settings, Sign: Signed Codec ID : sowt Duration : 53 s 487 ms Bit rate mode: Constant Bit rate : 1 536 kb/s Channel(s) : 2 channels Channel positions: Front: L R Sampling rate: 48.0 kHz Bit depth: 16 bits Stream size : 9.79 MiB (0%) Language : English Default : Yes Alternate group : 1 This works and captures full range (data levels, but the captured data happens to be video levels 64-940) to the output file and the out.mov file looks good/clean. Not sure how to flag (metadata) output color space and levels, but can always force it in most programs (KDEnlive, Resolve). ... audio (16 bits, don't see option for 24-bits) .. probably will look though code sometime a week out and see out the reference code from BMD gets 24-bits and (if I can figure it out) look into seeing if it can be added with a patch. Sometimes the audio is heard during capture via the capture output (but seems to always be captured), so the audio code needs reviewing in any case. On a side note: SDI supports data levels 0-1023 but the first 4 and last for color values (0-3 1020-1023 are reserved) whereas the full range can be used in HDMI. I am curious as to what people know about this? Assuming any converter will clip the color values. --Doug (dx9s) (sorry too wordy again) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] ffmpeg have program decoding ACC ltam audo stream
how to download the ts file TS file http://www99.zippyshare.com/v/UwxzRccM/file.html On Fri, Sep 29, 2017 at 9:50 AM, wrote: > Thanks Carl; > > But the first audio track - Stream #0:4[0x3a2](zho): Audio: aac_latm > (HE-AAC) ([17][0][0][0] / 0x0011), 48000 Hz, 5.1, fltp > > Produce funny audio sound > > Thanks > > > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Carl Eugen Hoyos > Sent: Thursday, September 28, 2017 10:45 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] ffmpeg have program decoding ACC ltam audo > stream > > 2017-09-28 6:09 GMT+02:00 : > > > TS file http://www99.zippyshare.com/v/UwxzRccM/file.html > > Thank you for the sample. > > Damaged transport streams show all kind of messages, but the sample can be > decoded. > > Carl Eugen > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC
>Applied the series, thanks! > >Marton Thanks a lot! Regards, Karthick ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] ffmpeg have program decoding ACC ltam audo stream
pls click on the link which will direct you to zippyshare - TS is there -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Bang He Sent: Friday, September 29, 2017 10:43 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] ffmpeg have program decoding ACC ltam audo stream how to download the ts file TS file http://www99.zippyshare.com/v/UwxzRccM/file.html On Fri, Sep 29, 2017 at 9:50 AM, wrote: > Thanks Carl; > > But the first audio track - Stream #0:4[0x3a2](zho): Audio: aac_latm > (HE-AAC) ([17][0][0][0] / 0x0011), 48000 Hz, 5.1, fltp > > Produce funny audio sound > > Thanks > > > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Thursday, September 28, 2017 10:45 PM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] ffmpeg have program decoding ACC ltam audo > stream > > 2017-09-28 6:09 GMT+02:00 : > > > TS file http://www99.zippyshare.com/v/UwxzRccM/file.html > > Thank you for the sample. > > Damaged transport streams show all kind of messages, but the sample > can be decoded. > > Carl Eugen > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH v4] avcodec/hevc_sei: Support HEVC paired fields.
On 9/28/2017 7:09 PM, Michael Niedermayer wrote: > On Wed, Sep 27, 2017 at 08:48:42PM -0500, Brian Matherly wrote: >> From: Brian Matherly >> >> Correctly set the interlaced_frame and top_field_first fields when pic_struct >> indicates paired fields. >> --- >> libavcodec/hevc_sei.c | 4 ++-- >> tests/fate/hevc.mak | 6 +- >> tests/ref/fate/hevc-paired-fields | 16 >> 3 files changed, 23 insertions(+), 3 deletions(-) >> create mode 100644 tests/ref/fate/hevc-paired-fields > > this can be applied in 24h (after the fate sample is synced between > fate cliensts) > unless someone sees a issue in the patch I thought we had dropped the waiting period? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC
>On 9/29/17, 7:36 AM, "James Almer" wrote:
>>
>> +static inline uint16_t parity (uint16_t x)
>> +{
>> +uint16_t i;
>> +for (i = 4 * sizeof (x); i > 0; i /= 2)
>> +x ^= x >> i;
>> +return x & 1;
>> +}
>
>Can't you use av_parity() instead?
Yes, I can. Thanks for pointing it out. But that patch has been submitted
already. Hence, I have attached a fresh patch with this suggested change.
Regards,
Karthick
0001-avdevice-decklink_dec-Used-av_parity-instead-of-dupl.patch
Description: 0001-avdevice-decklink_dec-Used-av_parity-instead-of-dupl.patch
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time
On 09/26/2017 05:12 PM, Michael Niedermayer wrote: Hi On Mon, Sep 25, 2017 at 02:12:26PM -0700, John Stebbins wrote: On 09/25/2017 01:12 PM, Carl Eugen Hoyos wrote: 2017-09-25 19:10 GMT+02:00 John Stebbins : When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. Append new "trun" index entries to the end of the index instead of sorting by timestamp. Sorting by timestamp causes packets to be read out of decode order and results in decode errors. --- libavformat/mov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2519707345..b2bc7c2c3d 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4339,8 +4339,8 @@ static int mov_read_trun(MOVContext *c, AVIOContext *pb, MOVAtom atom) MOV_FRAG_SAMPLE_FLAG_DEPENDS_YES)); if (keyframe) distance = 0; -ctts_index = av_add_index_entry(st, offset, dts, sample_size, distance, -keyframe ? AVINDEX_KEYFRAME : 0); +ctts_index = add_index_entry(st, offset, dts, sample_size, distance, + keyframe ? AVINDEX_KEYFRAME : 0); I can confirm that this fixes playback with FFplay but it shows many warnings (Non-monotonous DTS) with ffmpeg: Is this unavoidable? Fixing the non-monotonous DTS in ffmpeg would require more consideration. The overlapping frames need to be dropped somewhere after they are decoded and before they are presented. I've given this some thought, but other ideas are certainly welcome. The demuxer is probably the most appropriate place for marking the frames as needing to be dropped since it has the "knowledge" about why there are overlapping timestamps. I.e. you only want to drop frames in this particular scenario and not generally when timestamps go backwards. I don't think there is currently any facility for marking frames to be dropped after decoding, but it seems like AVPacketSideData would be the appropriate mechanism for such marking. FYI, such a facility for marking frames to drop would also be useful for frame accurate playback of MP4 edit lists. This sounds like: /** * Flag is used to discard packets which are required to maintain valid * decoder state but are not required for output and should be dropped * after decoding. **/ #define AV_PKT_FLAG_DISCARD 0x0004 Oh, that's awesome. Thanks for pointing that out. There's even a sample flag that can be set in the index which is the next thing I was "worried" about. I'll follow up with a patch to fix the non-monotonous DTS. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] fate: increase fuzz for refcmp filter tests
On 29.09.2017 00:10, Michael Niedermayer wrote: On Thu, Sep 28, 2017 at 09:27:23AM +0200, Tobias Rapp wrote: Should fix failing tests on GNU/kFreeBSD x86_32. Signed-off-by: Tobias Rapp --- Michael: Have put you on CC as you seem to be the owner of the affected machines. LGTM Pushed, thanks. Regards, Tobias ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
