[FFmpeg-devel] [PATCH 1/3] avutil/frame: Document avcodec_get_frame_class() and the option naming system
Missing docs found by: nevcairiel
Signed-off-by: Michael Niedermayer
---
libavutil/frame.h |4
1 file changed, 4 insertions(+)
diff --git a/libavutil/frame.h b/libavutil/frame.h
index 2d6299b..b30aa47 100644
--- a/libavutil/frame.h
+++ b/libavutil/frame.h
@@ -176,6 +176,10 @@ typedef struct AVFrameSideData {
* Similarly fields that are marked as to be only accessed by
* av_opt_ptr() can be reordered. This allows 2 forks to add fields
* without breaking compatibility with each other.
+ *
+ * Fields can be accessed through AVOptions, the name string used, matches the
+ * C structure field name for fields accessable through AVOptions. The AVClass
+ * for AVFrame can be obtained from avcodec_get_frame_class()
*/
typedef struct AVFrame {
#define AV_NUM_DATA_POINTERS 8
--
1.7.9.5
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 2/3] avcodec: Document where the AVOption names can be found for the fields of AVCodecContext
Missing docs found by: nevcairiel
RFC: should we add support so that the C field names always work as av option
names/keys ?
Signed-off-by: Michael Niedermayer
---
libavcodec/avcodec.h |4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 00d0ef8..aa309c3 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -1637,6 +1637,10 @@ enum AVFieldOrder {
* version bump.
* Please use AVOptions (av_opt* / av_set/get*()) to access these fields from
user
* applications.
+ * The name string for AVOptions options matches the associated command line
+ * parameter name and can be found in libavcodec/options_table.h
+ * The AVOption/command line parameter names differ in some cases from the C
+ * structure field names for historic reasons or brevity.
* sizeof(AVCodecContext) must not be used outside libav*.
*/
typedef struct AVCodecContext {
--
1.7.9.5
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 3/3] avformat: Document where the AVOption names can be found for the fields of AVFormatContext
Missing docs found by: nevcairiel
RFC: should we add support so that the C field names always work as av option
names/keys ?
Signed-off-by: Michael Niedermayer
---
libavformat/avformat.h |6 ++
1 file changed, 6 insertions(+)
diff --git a/libavformat/avformat.h b/libavformat/avformat.h
index 3eeeb9a..f66c39b 100644
--- a/libavformat/avformat.h
+++ b/libavformat/avformat.h
@@ -1305,6 +1305,12 @@ typedef struct AVFormatInternal AVFormatInternal;
* version bump.
* sizeof(AVFormatContext) must not be used outside libav*, use
* avformat_alloc_context() to create an AVFormatContext.
+ *
+ * Fields can be accessed through AVOptions (av_opt*),
+ * the name string used matches the associated command line parameter name and
+ * can be found in libavformat/options_table.h.
+ * The AVOption/command line parameter names differ in some cases from the C
+ * structure field names for historic reasons or brevity.
*/
typedef struct AVFormatContext {
/**
--
1.7.9.5
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] fate: add aemphasis test
Hi there, Here is a patch with a new test for libavfilter/aemphasis. I tested the test in x64 and x32. Any idea how to test this on MIPS and ARM architectures? Is there any guide? Thanks. Regards, Petru Rares.From 7d64b876a3e90e57cb319c0a4bd94ec650ba1dd0 Mon Sep 17 00:00:00 2001 From: Petru Rares Sincraian Date: Sat, 28 May 2016 17:20:25 +0200 Subject: [PATCH] fate: add aemphasis test --- tests/fate/filter-audio.mak | 12 + tests/ref/fate/filter-aemphasis | 528 +++ tests/ref/fate/filter-aemphasis-50fm | 264 ++ tests/ref/fate/filter-aemphasis-75kf | 264 ++ 4 files changed, 1068 insertions(+) create mode 100644 tests/ref/fate/filter-aemphasis create mode 100644 tests/ref/fate/filter-aemphasis-50fm create mode 100644 tests/ref/fate/filter-aemphasis-75kf diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak index 5e5f1f9..a87452f 100644 --- a/tests/fate/filter-audio.mak +++ b/tests/fate/filter-audio.mak @@ -8,6 +8,18 @@ fate-filter-aecho: tests/data/asynth-44100-2.wav fate-filter-aecho: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav fate-filter-aecho: CMD = framecrc -i $(SRC) -af aecho=0.5:0.5:32:0.5 +FATE_FILTER_AEMPHASIS += fate-filter-aemphasis-50fm +fate-filter-aemphasis-50fm: tests/data/asynth-44100-2.wav +fate-filter-aemphasis-50fm: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav +fate-filter-aemphasis-50fm: CMD = framecrc -i $(SRC) -af aemphasis=1:5:reproduction:50fm + +FATE_FILTER_AEMPHASIS += fate-filter-aemphasis-75kf +fate-filter-aemphasis-75kf: tests/data/asynth-44100-2.wav +fate-filter-aemphasis-75kf: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav +fate-filter-aemphasis-75kf: CMD = framecrc -i $(SRC) -af aemphasis=2:8:reproduction:75kf + +FATE_AFILTER-$(call FILTERDEMDECENCMUX, AEMPHASIS, WAV, PCM_S16LE, PCM_S16LE, WAV) += $(FATE_FILTER_AEMPHASIS) + tests/data/hls-list.m3u8: TAG = GEN tests/data/hls-list.m3u8: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data $(M)$(TARGET_EXEC) $(TARGET_PATH)/$< \ diff --git a/tests/ref/fate/filter-aemphasis b/tests/ref/fate/filter-aemphasis new file mode 100644 index 000..9509e43 --- /dev/null +++ b/tests/ref/fate/filter-aemphasis @@ -0,0 +1,528 @@ +#tb 0: 1/44100 +#media_type 0: audio +#codec_id 0: pcm_s16le +#sample_rate 0: 44100 +#channel_layout 0: 3 +0, 0, 0, 1024, 4096, 0xb9c5fefd +0, 1024, 1024, 1024, 4096, 0xb2ae0a90 +0, 2048, 2048, 1024, 4096, 0x97e6e9f3 +0, 3072, 3072, 1024, 4096, 0x5837f26f +0, 4096, 4096, 1024, 4096, 0x71500376 +0, 5120, 5120, 1024, 4096, 0xb4650378 +0, 6144, 6144, 1024, 4096, 0xd261f5b1 +0, 7168, 7168, 1024, 4096, 0x3038f3fd +0, 8192, 8192, 1024, 4096, 0x8e1908c6 +0, 9216, 9216, 1024, 4096, 0x1d6bfd33 +0, 10240, 10240, 1024, 4096, 0x7036f23f +0, 11264, 11264, 1024, 4096, 0xaf73e9a1 +0, 12288, 12288, 1024, 4096, 0x0ba70404 +0, 13312, 13312, 1024, 4096, 0xd34bf249 +0, 14336, 14336, 1024, 4096, 0x0c88fc2b +0, 15360, 15360, 1024, 4096, 0x55ebf9cf +0, 16384, 16384, 1024, 4096, 0xc16df0bd +0, 17408, 17408, 1024, 4096, 0xa635eac5 +0, 18432, 18432, 1024, 4096, 0xb41d059e +0, 19456, 19456, 1024, 4096, 0xa905f4d3 +0, 20480, 20480, 1024, 4096, 0x2736f1fb +0, 21504, 21504, 1024, 4096, 0x1a89f007 +0, 22528, 22528, 1024, 4096, 0x81d1fdab +0, 23552, 23552, 1024, 4096, 0x6156f97d +0, 24576, 24576, 1024, 4096, 0x1971ec89 +0, 25600, 25600, 1024, 4096, 0xdca1ec4f +0, 26624, 26624, 1024, 4096, 0x116ffcf5 +0, 27648, 27648, 1024, 4096, 0xc391fdc9 +0, 28672, 28672, 1024, 4096, 0x85e0ef45 +0, 29696, 29696, 1024, 4096, 0x81d3012c +0, 30720, 30720, 1024, 4096, 0x403ef11b +0, 31744, 31744, 1024, 4096, 0x3ca6f16d +0, 32768, 32768, 1024, 4096, 0x6775feb1 +0, 33792, 33792, 1024, 4096, 0xb2ae0a90 +0, 34816, 34816, 1024, 4096, 0x97e6e9f3 +0, 35840, 35840, 1024, 4096, 0x5837f26f +0, 36864, 36864, 1024, 4096, 0x71500376 +0, 37888, 37888, 1024, 4096, 0xb4650378 +0, 38912, 38912, 1024, 4096, 0xd261f5b1 +0, 39936, 39936, 1024, 4096, 0x3038f3fd +0, 40960, 40960, 1024, 4096, 0x8e1908c6 +0, 41984, 41984, 1024, 4096, 0x1d6bfd33 +0, 43008, 43008, 1024, 4096, 0x7036f23f +0, 44032, 44032, 1024, 4096, 0xabb8fbdb +0, 45056, 45056, 1024,
Re: [FFmpeg-devel] IRC meeting
On Wed, May 18, 2016 at 10:33:23PM +0200, Paul B Mahol wrote: > Hi, > > I want to propose to have an FFmpeg IRC meeting on > the Saturday of the next week, Saturday May 28, > UTC 17. > So I suppose this happens in about half an hour. Can you remind us the IRC channel? -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] IRC meeting
On 5/28/16, Clement Boesch wrote: > On Wed, May 18, 2016 at 10:33:23PM +0200, Paul B Mahol wrote: >> Hi, >> >> I want to propose to have an FFmpeg IRC meeting on >> the Saturday of the next week, Saturday May 28, >> UTC 17. >> > > So I suppose this happens in about half an hour. Can you remind us the > IRC channel? It could be #ffmpeg-devel or any other channel. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] IRC meeting
On date Saturday 2016-05-28 18:57:00 +0200, Paul B Mahol encoded: > On 5/28/16, Clement Boesch wrote: > > On Wed, May 18, 2016 at 10:33:23PM +0200, Paul B Mahol wrote: > >> Hi, > >> > >> I want to propose to have an FFmpeg IRC meeting on > >> the Saturday of the next week, Saturday May 28, > >> UTC 17. > >> > > > > So I suppose this happens in about half an hour. Can you remind us the > > IRC channel? > > It could be #ffmpeg-devel or any other channel. The FFmpeg IRC meeting will start soon (17:15 UTC) on the #ffmpeg-meeting2016 channel. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] fate: add aemphasis test
On Sat, May 28, 2016 at 03:55:34PM +, Petru Rares Sincraian wrote: > > Hi there, > > Here is a patch with a new test for libavfilter/aemphasis. I tested the test > in x64 and x32. applied > > Any idea how to test this on MIPS and ARM architectures? Is there any guide? > Thanks. you need qemu, a cross compiler and environment to run things in mine is from emdebian, sadly emdebian is dead. I probably wont look into seting a new up before the old emdebian stuff stops working. But that makes me unable to really give goode tips on how to set that up i cannot recommand anymore to use that old stuff qemu is easy to install though, your favorite distribution also likely has packages that work for that thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Avoid a single point of failure, be that a person or equipment. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] AVClass & AVOption [VOTE]
Hi It was suggested in the IRC meeting today that i start a vote to resolve if AVClass & AVOption should be added to AVCodecParameters This question needs to be awnsered before the next release because the ABI would be broken if its added afterwards the lack of any decission blocks the release which is worse than either decission, otherwise a vote might be silly for such technical question but eve a bad decission is better than no decission here The disadvanatges are: 1 more field in the struct a high level API that some feel is unneeded for AVCodecParameters it could be confusing to some that there are 2 different ways to access the fields people might use it as av_log() context when they intended to use a different context for it There are probably more please help fill the list if you know more The advanatges are: More consistent availability of AVOptions and AVClass in public structs Makes supporting multiple FFmpeg versions and distros easier and cleaner for applications. (reduces lists of #if version checks) Provides default/min/max values, allows basic validity checking within min/max Avoids mysterious crashes if an application uses avoption functions on AVCodecParameters Introspection Serialization support that may be usefull for ffserver or an application replacing ffserver An application that doesnt want to use AVOptions or AVClass can completey ignore them. Please state clearly if you agree to add AVClass&AVOption to AVCodecParameters or if you disagree about adding it or if you dont care either way The vote will end 1 week from now, simple 50% majority (Yes vs no) I dont really know who should be eligible for voting, so i suggest everyone from the vote comittee but iam happy with anything, just stating somethng ... -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
