Re: [Ffc] [Branch ~ffc-core/ffc/dev] Rev 1348: Simple functionality now in place in compute_dof_ir. Missing tabulate_* and

2009-12-17 Thread Anders Logg 
On Thu, Dec 17, 2009 at 02:32:19PM -, nore...@launchpad.net wrote:
> 
> revno: 1348
> committer: m...@simula.no
> branch nick: ffc-dev
> timestamp: Thu 2009-12-17 15:29:05 +0100
> message:
>   Simple functionality now in place in compute_dof_ir. Missing tabulate_* and
>   create_sub_dof_map.
>
>   What is init_cell and init_cell_finalize used for?

It was added to UFC to allow a form compiler to precompute the dofmap
by iterating over the mesh. If you look at DofMap.cpp in DOLFIN you
will see this:

 // Initialize UFC dof map
 const bool init_cells = dofmap.init_mesh(ufc_mesh);
 if (init_cells)
 {
   UFCCell ufc_cell(dolfin_mesh);
   for (CellIterator cell(dolfin_mesh); !cell.end(); ++cell)
   {
 ufc_cell.update(*cell);
 dofmap.init_cell(ufc_mesh, ufc_cell);
   }
   dofmap.init_cell_finalize();
 }

init_cell and init_cell_finalize are not used by FFC only SyFi so
init_mesh should return false and the other two should be empty.

We probably need something like

  format["do_nothing"] --> "// Do nothing"

in the format dictionary.

--
Anders


signature.asc
Description: Digital signature
___
Mailing list: https://launchpad.net/~ffc
Post to : ffc@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ffc
More help   : https://help.launchpad.net/ListHelp

Re: [Ffc] [Branch ~ffc-core/ffc/dev] Rev 1348: Simple functionality now in place in compute_dof_ir. Missing tabulate_* and

2009-12-17 Thread Marie Rognes 

Anders Logg wrote:

On Thu, Dec 17, 2009 at 02:32:19PM -, nore...@launchpad.net wrote:
  


revno: 1348
committer: m...@simula.no
branch nick: ffc-dev
timestamp: Thu 2009-12-17 15:29:05 +0100
message:
  Simple functionality now in place in compute_dof_ir. Missing tabulate_* and
  create_sub_dof_map.

  What is init_cell and init_cell_finalize used for?



It was added to UFC to allow a form compiler to precompute the dofmap
by iterating over the mesh. If you look at DofMap.cpp in DOLFIN you
will see this:

 // Initialize UFC dof map
 const bool init_cells = dofmap.init_mesh(ufc_mesh);
 if (init_cells)
 {
   UFCCell ufc_cell(dolfin_mesh);
   for (CellIterator cell(dolfin_mesh); !cell.end(); ++cell)
   {
 ufc_cell.update(*cell);
 dofmap.init_cell(ufc_mesh, ufc_cell);
   }
   dofmap.init_cell_finalize();
 }

init_cell and init_cell_finalize are not used by FFC only SyFi so
init_mesh should return false and the other two should be empty.

  


I copied the previous, so init_mesh initializes the global_dimension 
(and returns false)



We probably need something like

  format["do_nothing"] --> "// Do nothing"

in the format dictionary.

  


Check (from previous).

--
Marie



___
Mailing list: https://launchpad.net/~ffc
Post to : ffc@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ffc
More help   : https://help.launchpad.net/ListHelp
  



___
Mailing list: https://launchpad.net/~ffc
Post to : ffc@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ffc
More help   : https://help.launchpad.net/ListHelp

Re: [Ffc] [Branch ~ffc-core/ffc/dev] Rev 1348: Simple functionality now in place in compute_dof_ir. Missing tabulate_* and

2009-12-17 Thread Anders Logg 
On Thu, Dec 17, 2009 at 09:09:07PM +0100, Marie Rognes wrote:
> Anders Logg wrote:
> >On Thu, Dec 17, 2009 at 02:32:19PM -, nore...@launchpad.net wrote:
> >>
> >>revno: 1348
> >>committer: m...@simula.no
> >>branch nick: ffc-dev
> >>timestamp: Thu 2009-12-17 15:29:05 +0100
> >>message:
> >>  Simple functionality now in place in compute_dof_ir. Missing tabulate_* 
> >> and
> >>  create_sub_dof_map.
> >>
> >>  What is init_cell and init_cell_finalize used for?
> >
> >It was added to UFC to allow a form compiler to precompute the dofmap
> >by iterating over the mesh. If you look at DofMap.cpp in DOLFIN you
> >will see this:
> >
> > // Initialize UFC dof map
> > const bool init_cells = dofmap.init_mesh(ufc_mesh);
> > if (init_cells)
> > {
> >   UFCCell ufc_cell(dolfin_mesh);
> >   for (CellIterator cell(dolfin_mesh); !cell.end(); ++cell)
> >   {
> > ufc_cell.update(*cell);
> > dofmap.init_cell(ufc_mesh, ufc_cell);
> >   }
> >   dofmap.init_cell_finalize();
> > }
> >
> >init_cell and init_cell_finalize are not used by FFC only SyFi so
> >init_mesh should return false and the other two should be empty.
> >
>
> I copied the previous, so init_mesh initializes the global_dimension
> (and returns false)

Yes! Exactly.

> >We probably need something like
> >
> >  format["do_nothing"] --> "// Do nothing"
> >
> >in the format dictionary.
> >
>
> Check (from previous).

ok.

--
Anders


signature.asc
Description: Digital signature
___
Mailing list: https://launchpad.net/~ffc
Post to : ffc@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ffc
More help   : https://help.launchpad.net/ListHelp