Re: [9.4] LOGBOOK visibility

2020-07-04 Thread Kévin Le Gouguec
Ihor Radchenko  writes:

>   (see the discussion in [1]). 

Ah, that makes sense!  No idea how I managed to miss that thread.

> I am currently working on a patch to rewrite the whole folding system.
> Your issue should disappear once it is applied.

Good to know!

> Meanwhile, you may, for example, advice
> org-fold--isearch-filter-predicate to re-fold drawers during isearch. 

Duly noted, thanks for the advice.

And thank you and Nicolas for all the hard work!



Re: [9.4] LOGBOOK visibility

2020-07-04 Thread Nicolas Goaziou
Hello,

Ihor Radchenko  writes:

> There used to be several types of overlays for headline folding, drawer
> folding, and block folding. One of the recent commits made all the
> overlays use headline type. As a result all the overlays are merged into
> a single overlay upon folding. This was done to reduce the total number
> of overlays present in an org buffer, which degrades Emacs performance
> on huge org files (see the discussion in [1]). 
>
> What you observe is a consequence of that change. Now, all the drawer
> overlays are destroyed when you fold a heading. Isearch would
> only see a single huge overlay and unfold it alltogether.

For completeness, at the beginning drawers and outline shared the same
invisibility value. 

At some point during 9.X development, I gave drawers their own
invisibility value. It provided an overall nicer behaviour, but also
introduced some serious slowdown in large files.

Recently, as pointed out by Ihor, I switched drawers back to their
initial state, i.e., they now share the same invisibility value as the
outline. At least, Org on very large files is slightly more manageable,
but the behaviour is less nice. With overlays, you can't have your cake
and eat it too.

> I am currently working on a patch to rewrite the whole folding system.
> Your issue should disappear once it is applied.

Yes, hopefully, switching to text properties will get us out of this sad
situation.

Regards,
-- 
Nicolas Goaziou



Re: [9.4] LOGBOOK visibility

2020-07-04 Thread Kévin Le Gouguec
Thank you for taking the time to make this write-up.

Nicolas Goaziou  writes:

> With overlays, you can't have your cake
> and eat it too.

FWIW, I think Emacs has a branch (feature/noverlay) which has been
reported to improve performance with overlays.  AFAICT it's just hanging
there waiting to be merged (though a naive "git merge" reveals some
conflicts); some quick Googling suggests it has last been discussed two
years ago:

https://lists.gnu.org/archive/html/emacs-devel/2018-03/msg00565.html




Re: [PATCH] allow for multiline headers

2020-07-04 Thread Nicolas Goaziou
Hello,

Mario Frasca  writes:

> I'm happy it exists.  it has a very low entrance threshold, just use
> it and tweak it bit by bit.  the other methods, apart from gnuplot
> itself, are out of reach on my system, a Maemo-freemantle N900.  it's
> not my original system, just a recent replacement, and I had some
> trouble to find all software I was used to.
>
>
>> I don't know if there's much difference between writing multiple PLOT
>> lines and writing a gnuplot script. It may be interesting to compare use
>> cases.
>
> it's data about the pandemic that I'm collecting, http://ix.io/2qDf. 
> as said, I have never used ob-gnuplot, so I would not know how would
> the equivalent code look like.
>
> I wanted to comment out a couple of lines, then switch them back
> again, and it was easier to do it with the new `use´ keyword.

I'm sure this PLOT extension is useful. 

My point is that complexity should be moved to Org Babel, if possible,
not into affiliated keywords. IOW, it would be nice if gnuplot source
code blocks were as easy to use as your extension.

It already might be as simple, or there may be some work to do. I'd
appreciate some enlightenment on the topic. For example, could you show
what code your extension generates with the table above?

Regards,
-- 
Nicolas Goaziou



Habit error

2020-07-04 Thread Colin Baxter
Hello,

With the latest pull of org-mode I now find habits are not displayed
correctly in agenda. The graph bar is missing, with the error

org-habit-insert-consistency-graphs: Wrong type argument:
number-or-marker-p, nil

- Begin debugger output --

Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
  (org-habit-build-graph (737610 1 737613 4 nil ".+") (24292 37530 669050 
863000) (24320 16922 669050 863000) (24329 31898 669050 863000))
  (org-habit-insert-consistency-graphs)
  (org-agenda-finalize)
  (org-agenda-list nil)
  (funcall-interactively org-agenda-list nil)
  (call-interactively org-agenda-list)
  (org-agenda nil)
  (funcall-interactively org-agenda nil)
  (call-interactively org-agenda nil nil)
  (command-execute org-agenda)

- End debugger output --

The error does not occur with the 'built-in' Org mode version 9.3 for
emacs-27.

Best wishes,

Colin.


Colin Baxter
URL: http://www.Colin-Baxter.com




Re: Habit error

2020-07-04 Thread Milan Zamazal
> "CB" == Colin Baxter  writes:

CB> Hello,
CB> With the latest pull of org-mode I now find habits are not displayed
CB> correctly in agenda. The graph bar is missing, with the error

CB> org-habit-insert-consistency-graphs: Wrong type argument:
CB> number-or-marker-p, nil

Hi, I've hit the same error.  It was introduced in commit
f471768a54d8921ff383516af6a605adc061af30 -- if all-done-dates is nil
(i.e. a new habit is introduced), it signals an error.

CB> - Begin debugger output --

CB> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p 
nil)
CB>   (org-habit-build-graph (737610 1 737613 4 nil ".+") (24292 37530
CB> 669050 863000) (24320 16922 669050 863000) (24329 31898 669050
CB> 863000))
CB>   (org-habit-insert-consistency-graphs)
CB>   (org-agenda-finalize)
CB>   (org-agenda-list nil)
CB>   (funcall-interactively org-agenda-list nil)
CB>   (call-interactively org-agenda-list)
CB>   (org-agenda nil)
CB>   (funcall-interactively org-agenda nil)
CB>   (call-interactively org-agenda nil nil)
CB>   (command-execute org-agenda)

CB> - End debugger output --

CB> The error does not occur with the 'built-in' Org mode version 9.3 for
CB> emacs-27.

CB> Best wishes,

CB> Colin.


CB> Colin Baxter
CB> URL: http://www.Colin-Baxter.com







Re: Habit error

2020-07-04 Thread Marco Wahl
Hello Colin,

Colin Baxter  writes:
> With the latest pull of org-mode I now find habits are not displayed
> correctly in agenda. The graph bar is missing, with the error
>
> org-habit-insert-consistency-graphs: Wrong type argument:
> number-or-marker-p, nil

I guess this was due to my attempt to fix of the color of the first done
date for a habit. Sorry for any inconvenience.

Didn't check the case when no done dates are available. I hope that's
been the issue.

Thanks for reporting. Please check again with the latest from the repo.


Best regards,
-- Marco



Re: [9.4] LOGBOOK visibility

2020-07-04 Thread Ihor Radchenko
> FWIW, I think Emacs has a branch (feature/noverlay) which has been
> reported to improve performance with overlays.  AFAICT it's just hanging
> there waiting to be merged (though a naive "git merge" reveals some
> conflicts); some quick Googling suggests it has last been discussed two
> years ago:

That branch is around for a very long time. The last attempt on it was
back in December [1]. However, all the progress was only in tests, not in
actual code. As I mentioned in the discussion about using properties
instead of overlays, I prefer to modify org now rather than waiting for
someone to finalise and merge that branch.

Also, text properties appear to use less memory.

Best,
Ihor

[1] https://lists.gnu.org/archive/html/emacs-devel/2019-12/msg00115.html

Kévin Le Gouguec  writes:

> Thank you for taking the time to make this write-up.
>
> Nicolas Goaziou  writes:
>
>> With overlays, you can't have your cake
>> and eat it too.
>
> FWIW, I think Emacs has a branch (feature/noverlay) which has been
> reported to improve performance with overlays.  AFAICT it's just hanging
> there waiting to be merged (though a naive "git merge" reveals some
> conflicts); some quick Googling suggests it has last been discussed two
> years ago:
>
> https://lists.gnu.org/archive/html/emacs-devel/2018-03/msg00565.html
>

-- 
Ihor Radchenko,
PhD,
Center for Advancing Materials Performance from the Nanoscale (CAMP-nano)
State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong 
University, Xi'an, China
Email: yanta...@gmail.com, ihor_radche...@alumni.sutd.edu.sg



Re: Habit error

2020-07-04 Thread Colin Baxter
Hello Marco,
> Marco Wahl  writes:

> Hello Colin, Colin Baxter  writes:
>> With the latest pull of org-mode I now find habits are not
>> displayed correctly in agenda. The graph bar is missing, with the
>> error
>> 
>> org-habit-insert-consistency-graphs: Wrong type argument:
>> number-or-marker-p, nil

> I guess this was due to my attempt to fix of the color of the
> first done date for a habit. Sorry for any inconvenience.

> Didn't check the case when no done dates are available. I hope
> that's been the issue.

> Thanks for reporting. Please check again with the latest from the
> repo.

Yes, commit 5427a7 seems to fix the problem. My habits are displaying as
they should. Thanks.

Best wishes,

Colin.




Colin Baxter
URL: http://www.Colin-Baxter.com




Re: [PATCH] allow for multiline headers

2020-07-04 Thread Mario Frasca

Hi Nicolas,

On 04/07/2020 03:58, Nicolas Goaziou wrote:

I'm sure this PLOT extension is useful.

My point is that complexity should be moved to Org Babel, if possible,
not into affiliated keywords. IOW, it would be nice if gnuplot source
code blocks were as easy to use as your extension.


I do not use org-babel, and I do not plan to move to it.  I'm happy with 
my extension, but I do see that there's no positive reaction from users, 
only the group of reviewers who doesn't like the idea.  as said, let's 
just keep it this way.




It already might be as simple, or there may be some work to do. I'd
appreciate some enlightenment on the topic. For example, could you show
what code your extension generates with the table above?


your above request suggests me you're missing the point.  there is 
nothing to be seen in the generated gnuplot source, because all is 
solved in lisp.  or it's me missing your point, that can be, too.


anyhow, these are a couple of webpastes for you:

this is the complete gnuplot session, showing the code produced with 
`use:1' and then with `use:2', given the table I already shared.


http://ix.io/2qRq

what will show you the logic is the lisp code, which I thought I already 
shared, but I guess I did not insist up to the latest version.  anyhow, 
here are a couple of snippets, partial or complete rewrites of 
org-plot.el code.


http://ix.io/2qRs/elisp

http://ix.io/2qRt/elisp

http://ix.io/2qRu

best regards,

MF





Re: Habit error

2020-07-04 Thread Colin Baxter
> Milan Zamazal  writes:

> "CB" == Colin Baxter  writes:
CB> Hello, With the latest pull of org-mode I now find habits are
CB> not displayed correctly in agenda. The graph bar is missing,
CB> with the error

CB> org-habit-insert-consistency-graphs: Wrong type argument:
CB> number-or-marker-p, nil

> Hi, I've hit the same error.  It was introduced in commit
> f471768a54d8921ff383516af6a605adc061af30 -- if all-done-dates is
> nil (i.e. a new habit is introduced), it signals an error.

Thanks for the information - it's good to know. The issue seems now to
be fixed in the latest pull.

Best wishes,

Colin.


Colin Baxter
URL: http://www.Colin-Baxter.com




Bug: org-html-export-as-html changes numbered sections to number one exclusively [9.3.7 (9.3.7-elpa @ /home/dalanicolai/.my_emacs.d/elpa/org-20200602/)]

2020-07-04 Thread dalanicolai
WHAT HAPPENS:

When exporting a simple org-buffer, org-html-export-as-html, containing
text as follows:

1. hello
bye

2. ola
ciao

Then the numbers get changed to 1's exclusively, so that the html file
is rendered in the browser as follows:



   1. Hello

Deoi

   1.  Ola

Daag

Author: Daniel Laurens Nicolai

Created: 2020-07-04 Sat 18:06

Validate


EXPECTED TO HAPPEN:

Numbers get exported to 1, 2 etc.


Emacs  : GNU Emacs 26.3 (build 2, x86_64-pc-linux-gnu, GTK+ Version
3.24.13, cairo version 1.16.0)
 of 2020-03-28
Package: Org mode version 9.3.7 (9.3.7-elpa @
/home/dalanicolai/.my_emacs.d/elpa/org-20200602/)

current state:
==
(setq
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-
configure-edit-buffer)
 org-link-shell-confirm-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-html-format-inlinetask-function 'org-html-format-inlinetask-
default-function
 org-odt-format-headline-function 'org-odt-format-headline-default-
function
 org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-
default
 org-reveal-start-hook '(org-decrypt-entry)
 org-mode-hook '(#[0 "\301\211\207" [imenu-create-index-function org-
imenu-get-tree] 2]
 jupyter-org-interaction-mode
 #[0 "\300\301\302\303\304$\207"
   [add-hook change-major-mode-hook org-show-all append
local] 5]
 #[0 "\300\301\302\303\304$\207"
   [add-hook change-major-mode-hook org-babel-show-
result-all append local] 5]
 org-babel-result-hide-spec org-babel-hide-all-hashes
org-eldoc-load)
 org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME
CONTENTS)"]
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-journal-mode-hook '(#[0 "\301\302\303\304$\207"
   [org-journal-encrypt-on add-hook org-
journal-encryption-hook nil t]
   5]
 (lambda nil
  (add-hook org-journal-encrypt-on (quote org-
journal-encryption-hook)
   nil t)
  )
 )
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3
"\n\n(fn ENTRY)"]
 org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _
CONTENTS)"]
 org-babel-pre-tangle-hook '(save-buffer)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-
header-arg-expand)
 org-babel-load-languages '((python . t) (jupyter . t) (shell . t)
(mathematica . t)
(template . t))
 org-ascii-format-drawer-function #[771 "\207" [] 4 "\n\n(fn NAME
CONTENTS WIDTH)"]
 org-src-lang-modes '(("mathematica" . "mma") ("jupyter-Wolfram-
Language" . wolfram-language)
  ("jupyter-bash" . sh) ("jupyter-python" . python)
("arduino" . arduino)
  ("redis" . redis) ("php" . php) ("C" . c) ("C++"
. c++)
  ("asymptote" . asy) ("bash" . sh) ("beamer" .
latex)
  ("calc" . fundamental) ("cpp" . c++) ("ditaa" .
artist)
  ("dot" . fundamental) ("elisp" . emacs-lisp)
("ocaml" . tuareg)
  ("screen" . shell-script) ("shell" . sh)
("sqlite" . sql))
 org-occur-hook '(org-first-headline-recenter)
 org-export-before-processing-hook '(org-babel-jupyter-setup-export)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-show-
empty-lines
  org-optimize-window-after-visibility-change)
 org-speed-command-hook '(org-speed-command-activate org-babel-speed-
command-activate)
 org-odt-format-inlinetask-function 'org-odt-format-inlinetask-default-
function
 org-babel-tangle-lang-exts '(("mathematica" . "m") ("jupyter-python" .
"py")
  ("python" . "py") ("template" . "tmp")
("emacs-lisp" . "el")
  ("elisp" . "el"))
 org-export-before-parsing-hook '(org-babel-jupyter-strip-ansi-escapes)
 org-confirm-shell-link-function 'yes-or-no-p
 org-link-parameters '(("attachment" :follow org-attach-open-link
:export
org-attach-export-link :complete org-attach-
complete-link)
   ("id" :follow org-id-open)
   ("eww" :follow eww :store org-eww-store-link)
   ("rmail" :follow org-rmail-open :store org-
rmail-store-link)
   ("mhe" :follow org-mhe-open :store org-mhe-
store-link)
   ("irc" :follow org-irc-visit :store org-irc-
store-link :export
org-irc-export)
   ("info" :follow org-info-open :export org-info-
export :store
org-info-store-link)
   ("gnus" :follow org-gnus-open :store org-gnus-

Re: bug#42199: Suggestion: Offer Emacs manual, org-mode manual, org-guide in double-sided fashion for printing

2020-07-04 Thread Eli Zaretskii
> From: Jan Teubel 
> Date: Sat, 4 Jul 2020 12:44:09 +
> 
> This email is not a bug report, but a polite suggestion to
> provide/offer Emacs manual, org-mode manual and org-guide in
> double-sided fashion for printing (PDF files).
> 
> I would like to print out the whole Emacs manual, org-mode manual and
> org-guide on paper in double-sided fashion using the provided PDF
> files [1][2]. In the PDF file of the Emacs and org-mode manuals (and
> org-guide), every page number is located on the right side, which is
> only suitable for single-sided printing (in my opinion). That is why I
> have refrained from printing the whole manuals.

We don't provide the PDF files in the Emacs tarballs.  We provide the
Texinfo sources.  So you should be able to modify the Texinfo as you
describe, and then print the manuals as you'd like.

IOW, I don't think I understand why there's a need to make a change in
Emacs to support your request: you can do that yourself.

Am I missing something?



[PATCH] org-id: Fix behavior when `org-id-extra-values' is a symbol

2020-07-04 Thread Erik Hetzner
* lisp/org-id.el (org-id-update-id-locations): When
`org-id-extra-values' is a symbol, it should be evaluated as a
variable.

In 37a5020bb, `org-id-update-id-locations' was rewritten, and the
functionality to allow the variable `org-id-extra-values' to be a
symbol that references another variable was removed.  This change
restores that functionality.
---
 lisp/org-id.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/org-id.el b/lisp/org-id.el
index 9456b0629..387d8268b 100644
--- a/lisp/org-id.el
+++ b/lisp/org-id.el
@@ -495,7 +495,9 @@ When FILES is given, scan also these files."
 ;; Agenda files and all associated archives.
 (org-agenda-files t org-id-search-archives)
 ;; Explicit extra files.
-(unless (symbolp org-id-extra-files) org-id-extra-files)
+(if (symbolp org-id-extra-files)
+   (symbol-value org-id-extra-files)
+ org-id-extra-files)
 ;; All files known to have IDs.
 org-id-files
 ;; Additional files from function call.
-- 
2.27.0




Get generators working in an src block?

2020-07-04 Thread George Mauer
I prefer to use source blocks for pretty much all my language learning.

I am trying to figure out generators in emacs-lisp but can't seem to run it
in a block.

I have

```
#+begin_src emacs-lisp :results output
  (setq lexical-binding t)
  (require 'generator)

  (iter-defun my-iter (x)
(let (val (iter-yield (1+ x)))
  (iter-yield (1+ val)))
-1)

  (let* ((it1 (my-iter 5))
 (it2 (my-itr 0)))
(print (iter-next it1))
(print (iter-next it1 8))
(print (iter-next it2 nil))
(condition-case x
(iter-next it1)
  (iter-end-of-sequence
   (print (cdr x)
#+end_src
```

But running that gives me

> executing Emacs-Lisp code block...
> cl--assertion-failed: Assertion failed: lexical-binding

I thought that setting lexical-binding to t was enough, but apparently
something else is needed?


Re: Get generators working in an src block?

2020-07-04 Thread Kyle Meyer
George Mauer writes:

> #+begin_src emacs-lisp :results output
>   (setq lexical-binding t)
[...]
> But running that gives me
>
>> executing Emacs-Lisp code block...
>> cl--assertion-failed: Assertion failed: lexical-binding
>
> I thought that setting lexical-binding to t was enough, but apparently
> something else is needed?

As far as I understand, the way to activate lexical binding here is to
add ":lexical yes" to the header.



Re: Bug: org-html-export-as-html changes numbered sections to number one exclusively [9.3.7 (9.3.7-elpa @ /home/dalanicolai/.my_emacs.d/elpa/org-20200602/)]

2020-07-04 Thread Kyle Meyer
dalanico...@gmail.com writes:

> WHAT HAPPENS:
>
> When exporting a simple org-buffer, org-html-export-as-html, containing
> text as follows:
>
> 1. hello
> bye
>
> 2. ola
> ciao
>
> Then the numbers get changed to 1's exclusively, so that the html file
> is rendered in the browser as follows:
[...]
> EXPECTED TO HAPPEN:
>
> Numbers get exported to 1, 2 etc.

I believe you'll see the same thing across different export backends.
Due the indentation level of "bye", your example has two separate
ordered lists.  If you want to force another start value for a list, you
can add [@N] to the item (e.g., "2. [@2] ola").



Re: [PATCH] org-id: Fix behavior when `org-id-extra-values' is a symbol

2020-07-04 Thread Erik Hetzner
On Sat, 04 Jul 2020 12:32:11 -0700, Erik Hetzner  wrote:
> 
> * lisp/org-id.el (org-id-update-id-locations): When
> `org-id-extra-values' is a symbol, it should be evaluated as a
> variable.
>
> […]

Sorry, got the variable name wrong in the description. That should be
`org-id-extra-files'. See attached, fixed, patch.

filename="0001-org-id-Fix-behavior-when-org-id-extra-files-is-a-sym.patch"
Content-Transfer-Encoding: 8bit

>From a87a4b567f2cc86a2eb502fd40238f463ca83daa Mon Sep 17 00:00:00 2001
From: Erik Hetzner  Date: Sat, 4 Jul 2020 12:12:00 -0700
Subject: [PATCH] org-id: Fix behavior when `org-id-extra-files' is a
symbol

* lisp/org-id.el (org-id-update-id-locations): When
`org-id-extra-files' is a symbol, it should be evaluated as a
variable.

In 37a5020bb, `org-id-update-id-locations' was rewritten, and the
functionality to allow the variable `org-id-extra-files' to be a
symbol that references another variable was removed. This changes
restores that functionality.
---
 lisp/org-id.el | 4 +++- 1 file changed, 3 insertions(+), 1
 deletion(-)

diff --git a/lisp/org-id.el b/lisp/org-id.el index
9456b0629..387d8268b 100644 --- a/lisp/org-id.el +++ b/lisp/org-id.el
@@ -495,7 +495,9 @@ When FILES is given, scan also these files."
 ;; Agenda files and all associated archives.
 (org-agenda-files t org-id-search-archives)
 ;; Explicit extra files.
- (unless (symbolp org-id-extra-files) org-id-extra-files) + (if
(symbolp org-id-extra-files) + (symbol-value org-id-extra-files) +
org-id-extra-files)
 ;; All files known to have IDs. org-id-files
 ;; Additional files from function call.
-- 
2.27.0



Re: [PATCH] capture: respect KEYS with GOTO arg [9.3.7 (release_9.3.7-661-g4aa4dd @ /home/n/.emacs.d/straight/build/org/)]

2020-07-04 Thread No Wayman



Kyle Meyer  writes:


After applying, I added "lisp/" in front of the file name and
capitalized "pass".

Pushed (99b8f36ab).


Thanks, Kyle. Noted for future patches.