Re: [O] [PATCH] Fix two false failures in org's test suite

2017-08-10 Thread Nicolas Goaziou
Hello,

"Galen Menzel"  writes:

> * testing/lisp/test-org.el (test-org/deadline-close-p): Fix false
> failures due to time-zone differences.
> (test-org/refile-get-targets): Fix false failures when test temp-file
> path contains a symlink.

Thank you.

> -  (lambda () '(22353 6425 905205 644000
> +  (lambda ()
> +(apply #'encode-time
> +   (org-parse-time-string "2016-06-03 Fri 01:43")

Shouldn't this be 

  (org-parse-time-string "..." nil t)

to force UTC?

Regards,

-- 
Nicolas Goaziou



Re: [O] Bug: Beamer export error

2017-08-10 Thread Nicolas Goaziou
Hello,

Rasmus  writes:

> This is caused by this commit, which changes how org-split-string works.
>
> f776e65373fa135fffb51e201698823fbfb3865b
>
> Before (org-split-string "" ",") would return ‘nil’.  Now it returns "".
>
> Depending on whether the new behavior is desired or not, the fix should
> either be in ‘org-split-string’ or in ‘org-beamer--format-frame’.  I’ll
> wait for Nicolas’ verdict.

I think the new behaviour is correct, because it is equivalent to

  (split-string "" ",")

Do you want to fix it?

Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] [PATCH] Fix org-open-at-point to work with tags

2017-08-10 Thread Nicolas Goaziou
Hello,

"Galen Menzel"  writes:

> Subject: [PATCH] org.el: Fix org-open-at-point for tags.
>
> lisp/org.el (org-open-at-point): Move case for tags up so that it's
> not shortcutted by the case for no valid context.

Applied, with some refactoring. Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] Add-Easy-Template-for-COMMENT-C to org.el

2017-08-10 Thread Nicolas Goaziou
Hello,

Grant Rettke  writes:

> Does my init file get used during execution of the tests?

I didn't check, but I think so.

Anyway, we found the culprit: the test does not follow symlinks. It
should be fixed soon.

> Subject: [PATCH] Add Easy Template for COMMENT (C)
>
> * lisp/org.el: (org-structure-template-alist): Added `COMMENT' block template
>   bound to `C'
>
> * doc/org.texi: Add documentation for `COMMENT' Easy Template.
>
> * contrib/orgmanual.org: Add documentation for `COMMENT' Easy
>   Template.
>
> * etc/ORG-NEWS: Added note for 9.1 release under Miscellaneous

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou0x80A93738



Re: [O] Change in appearance of org-todo-keywords

2017-08-10 Thread Colin Baxter
Dear Adam,
> "Adam" == Adam Porter  writes:

Adam> Colin Baxter  writes:
>> Considering how fundamental keywords and tags are to org-mode,
>> I'm a little surprised that only two other users have reported
>> the issue.

Adam> It's because of the bravery of users like you that I don't run
Adam> master.  ;)

You might have a point there!

-- 
--
Colin Baxter
m43...@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8



[O] Can't remove deadline or schedule in bulk mode

2017-08-10 Thread Julien Cubizolles
In an agenda buffer, C-u B d should clear the deadline of the entries
marked the way C-u does on a single entry. I think it's what it used to
do some time ago. Instead, I get:

--8<---cut here---start->8---
org-agenda-deadline: Invalid function: 4
--8<---cut here---end--->8---

Julien.




[O] Property header :session... really working?

2017-08-10 Thread Igor Sosa Mayor
Hi,

I have in an org file the following

#+PROPERTY: header-args:R :session *R-cities*

I open a R session, rename it to *R-cities*, open the org file. If I go
then to a babel block and send it to the R session with C-c C-c it is
sent to the right session.

But: if I edit the block with org-edit-src-code (C-c '), then the source
buffer has no R-session attached and I'm asked which one I want to use.

Is this maybe a small bug?

I'm using:

Org mode version 9.0.9
GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.16) of
2017-07-16

Many thanks in advance.


-- 
:: Igor Sosa Mayor :: joseleopoldo1...@gmail.com ::
:: GnuPG: 0x1C1E2890   :: http://www.gnupg.org/  ::
:: jabberid: rogorido  ::::




Re: [O] remove TODO state in agenda view

2017-08-10 Thread Julien Cubizolles
Julien Cubizolles  writes:

> Adam Porter  writes:
>
>> Julien Cubizolles  writes:
>>
>>> Choosing "space" when changing the TODO state of an entry with C-c C-t
>>> in an org buffer clears the TODO state. However it doesn't work in the
>>> agenda view.
>>
>> Hi Julien,
>>
>> Just tried it, and it works for me.  What version of Org are you using?
>
> It's working for me too now. Don't know what I was doing wrong, sorry.

Got it: the problem occurs when trying to clear the TODO state of
several entries through a bulk action:

* mark several entries

* "B t" doesn't offer to clear the TODO state with space like "t" does
  on a single entry.

Julien.




Re: [O] LaTeX Export

2017-08-10 Thread Richard Lawrence

Hi Scott,

Scott Randby  writes:

I tried this in the properties associated with a subtree:  

:export_latex_header: 
\hypersetup{pdfauthor={foo},pdftitle={foo},pdfsubject={foo},pdfkeywords={foo},pdfproducer={foo},pdfcreator={foo}} 

Unfortunately, all the other LaTeX headers are unrecognized when 
I do this.  


If you put the subtree-specific hypersetup in each subtree's 
EXPORT_LATEX_HEADER_EXTRA property, and the common stuff in 
#+LATEX_HEADER lines, I think it should do what you want.  Org 
should combine these properties rather than using the subtree 
property to override the global ones. 


Hope that helps!

--
Best,
Richard



Re: [O] LaTeX Export

2017-08-10 Thread Scott Randby
On 08/10/2017 11:35 AM, Richard Lawrence wrote:> Hi Scott,
> 
> Scott Randby  writes:
> 
>> I tried this in the properties associated with a subtree: 
>> :export_latex_header: 
>> \hypersetup{pdfauthor={foo},pdftitle={foo},pdfsubject={foo},pdfkeywords={foo},pdfproducer={foo},pdfcreator={foo}}
>>  Unfortunately, all the other LaTeX headers are unrecognized when I do this.
> 
> If you put the subtree-specific hypersetup in each subtree's 
> EXPORT_LATEX_HEADER_EXTRA property, and the common stuff in #+LATEX_HEADER 
> lines, I think it should do what you want.  Org should combine these 
> properties rather than using the subtree property to override the global 
> ones.  Hope that helps!

Works perfectly. Thanks.

Scott



Re: [O] Property header :session... really working?

2017-08-10 Thread Berry, Charles

> On Aug 10, 2017, at 5:54 AM, Igor Sosa Mayor  
> wrote:
> 
> Hi,
> 
> I have in an org file the following
> 
> #+PROPERTY: header-args:R :session *R-cities*
> 
> I open a R session, rename it to *R-cities*, open the org file. If I go
> then to a babel block and send it to the R session with C-c C-c it is
> sent to the right session.
> 
> But: if I edit the block with org-edit-src-code (C-c '), then the source
> buffer has no R-session attached and I'm asked which one I want to use.
> 
> Is this maybe a small bug?
> 

If you have more than one session running, it is a consequence of ESS's 
handling of multiple sessions.

This issue is closely related to the one in this longish thread:

Subject: org babel, ess, R
Date: Sat, 1 Jul 2017 07:06:43 +0530 
Message-ID: 

Getting stuff like this to work seamlessly looks to be a good challenge. I 
notice that  this function

,[ C-h f org-babel-R-associate-session RET ]
| org-babel-R-associate-session is a compiled Lisp function in
| ‘ob-R.el’.
| 
| (org-babel-R-associate-session SESSION)
| 
| Associate R code buffer with an R session.
| Make SESSION be the inferior ESS process associated with the
| current code buffer.
| 
| [back]
`


looks like it aims to do something like what is needed, but never got used.  I 
suspect the author took a few steps in this direction and saw it was going to 
be a heavy lift and gave up.

It isn't obvious to me how one would put a ruleset together that would work 
well across a variety of situations with multiple sessions. That is, you may 
want :session headers to be honored or ignored depending on circumstance.

HTM,

Chuck



Re: [O] Property header :session... really working?

2017-08-10 Thread Igor Sosa Mayor
"Berry, Charles"  writes:

>
> If you have more than one session running, it is a consequence of ESS's 
> handling of multiple sessions.

Yes, I have. That explains at least a little bit the issue... Thanks for
your very informative answer. 

-- 
:: Igor Sosa Mayor :: joseleopoldo1...@gmail.com ::
:: GnuPG: 0x1C1E2890   :: http://www.gnupg.org/  ::
:: jabberid: rogorido  ::::




Re: [O] [PATCH] Fix two false failures in org's test suite

2017-08-10 Thread Galen Menzel

Hi Nicolas,

On 10 Aug 2017, at 3:16, Nicolas Goaziou wrote:


-(lambda () '(22353 6425 905205 644000
+(lambda ()
+  (apply #'encode-time
+ (org-parse-time-string "2016-06-03 Fri 01:43")


Shouldn't this be

  (org-parse-time-string "..." nil t)

to force UTC?


I don't believe so.

org-deadline-close-p interprets its timestamp-string argument as being 
in the local time zone (i.e., the call to encode-time that results from 
calling org-deadline-close-p always has a nil zone argument). Since we 
are using "2016-06-03 Fri 01:43" as the ersatz current time to check if 
deadlines are close, then "2016-06-03 Fri 01:43" should be in the local 
time zone as well.


As I would expect, forcing UTC here makes the test fail on my machine.

Best,

Galen



Re: [O] Bug: Beamer export error

2017-08-10 Thread Rasmus
Nicolas Goaziou  writes:

> Hello,
>
> Rasmus  writes:
>
>> This is caused by this commit, which changes how org-split-string works.
>>
>> f776e65373fa135fffb51e201698823fbfb3865b
>>
>> Before (org-split-string "" ",") would return ‘nil’.  Now it returns "".
>>
>> Depending on whether the new behavior is desired or not, the fix should
>> either be in ‘org-split-string’ or in ‘org-beamer--format-frame’.  I’ll
>> wait for Nicolas’ verdict.
>
> I think the new behaviour is correct, because it is equivalent to
>
>   (split-string "" ",")
>
> Do you want to fix it?

It should be fixed by commit 323fc95b4.

Thanks,
Rasmus

-- 
Tack, ni svenska vakttorn. Med plutonium tvingar vi dansken på knä!




[O] [PATCH] lisp/org.el: make org-open-at-point handle parens in encoded urls correctly

2017-08-10 Thread Marc Ihm

Hi,

the attached patch changes org-open-at-point in org.el:

Currently, when opening an url the function org-open-at-point uses the 
variable path, which is the result of applying org-link-unescape on the 
original url. Thus, all special chars like '() "' etc. which were 
originally encoded like %20%28 etc. are reverted to their clear text 
form. This worked for me in most cases, but gives me errors when my url 
contains encoded chars like '()', i.e. %28%29.


The submitted patch fixes this by simply using the original url with all 
special chars still encoded.


Please consider applying it, if fit.


Thanks,
Marc


--- a/lisp/org.el
+++ b/lisp/org.el
@@ -10707,7 +10707,7 @@ a timestamp or a link."
   (t (list nil
(org-link-unescape 
option)

   ((functionp (org-link-get-parameter type :follow))
-   (funcall (org-link-get-parameter type :follow) path))
+   (funcall (org-link-get-parameter type :follow) 
(org-element-property :path link)))

   ((member type '("coderef" "custom-id" "fuzzy" "radio"))
(unless (run-hook-with-args-until-success
 'org-open-link-functions path)
--


0001-make-org-open-at-point-handle-parens-in-encoded-urls.patch
Description: application/empty


Re: [O] Bug: Beamer export error

2017-08-10 Thread Nicolas Goaziou
Hello,

Rasmus  writes:

> It should be fixed by commit 323fc95b4.

Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] [PATCH] Fix two false failures in org's test suite

2017-08-10 Thread Nicolas Goaziou
Hello,

"Galen Menzel"  writes:

> org-deadline-close-p interprets its timestamp-string argument as being
> in the local time zone (i.e., the call to encode-time that results
> from calling org-deadline-close-p always has a nil zone argument).
> Since we are using "2016-06-03 Fri 01:43" as the ersatz current time
> to check if deadlines are close, then "2016-06-03 Fri 01:43" should be
> in the local time zone as well.
>
> As I would expect, forcing UTC here makes the test fail on my machine.

OK! Applied. Thank you.

Regards,

-- 
Nicolas Goaziou



[O] Unbundling contrib from org-plus-contrib package?

2017-08-10 Thread Simon Guest
Hiding in the ox-taskjuggler thread is a discussion of some of the problems
caused by having contrib bundled up in the org-plus-contrib package.  (See
that thread for the details.)

However, a general question remains, as asked by Tim Cross, whom I will
quote if I may:

There are also some other alternatives on the emacs-devel list from when
> I asked as a general question regarding package.el and dependencies.
> Should be noted that this issue is primarily caused because, fro the
> package.el perspective, org-plus-contrib is different to the org
> package. Other ELPA/MELPA/etc packages have org as a dependency and not
> org-plus-contrib. There is no support in package.el for alternative
> dependencies.
> I would be interested in understanding the rationale for having
> org-plus-contrib rather than just an org package and an org-contrib
> package? It should be possible to just have an org-contrib package which
> depends on an org package (of same version). This would then avoid this
> issue. As this is an obvious solution, I suspect there is something
> subtle which unpins the rationale to have an org and org-plus-contrib
> package approach, but don't know what that is.


So, is there an answer to this good and as-yet unanswered question about
unbundling contrib into its own package?

cheers,
Simon


Re: [O] remove TODO state in agenda view

2017-08-10 Thread Adam Porter
Julien Cubizolles  writes:

> Got it: the problem occurs when trying to clear the TODO state of
> several entries through a bulk action:
>
> * mark several entries
>
> * "B t" doesn't offer to clear the TODO state with space like "t" does
>   on a single entry.

Yes, I guess that's because it uses completing-read to complete the
tags, instead of using the single-key tag selection.  At least, that's
how it works for me.




Re: [O] Can't remove deadline or schedule in bulk mode

2017-08-10 Thread Adam Porter
Julien Cubizolles  writes:

> In an agenda buffer, C-u B d should clear the deadline of the entries
> marked the way C-u does on a single entry. I think it's what it used to
> do some time ago. Instead, I get:
>
> org-agenda-deadline: Invalid function: 4

FWIW, works for me on Org 9.0.5.