[Bug libelf/32311] elf_compress_gnu.c: gcc warns null-dereference with lto
https://sourceware.org/bugzilla/show_bug.cgi?id=32311 Mark Wielaard changed: What|Removed |Added CC||mark at klomp dot org --- Comment #1 from Mark Wielaard --- Odd this wasn't seen before. There have been various lto enabled builds in other distros. The compiler seems to assume elf(32|64)_getshdr can fail and return NULL. Which it theoretically could. But if that was true we wouldn't have reached this code because there is another elf(32|64)_getshdr earlier in the function that does do a NULL check and returns early. We could maybe rewrite the function a bit to reuse the result of this earlier function calls(s). -- You are receiving this mail because: You are on the CC list for the bug.
Re: [PATCH] config: fix globing error for zsh
On Sat, Oct 26, 2024 at 10:19 AM RocketDev wrote: > > Zsh treat unmatched glob as error while bash treat that as the original > string. Substitute globing with find to solve. > > * config/profile.sh.in: Fix globing error for zsh > > Signed-off-by: RocketDev > --- > config/profile.sh.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/config/profile.sh.in b/config/profile.sh.in > index 5e86f433..9f3e415a 100644 > --- a/config/profile.sh.in > +++ b/config/profile.sh.in > @@ -6,12 +6,12 @@ > > prefix="@prefix@" > if [ -z "$DEBUGINFOD_URLS" ]; then > -DEBUGINFOD_URLS=$(cat /dev/null "@sysconfdir@/debuginfod"/*.urls > 2>/dev/null | tr '\n' ' ' || :) > +DEBUGINFOD_URLS=$(find "@sysconfdir@/debuginfod" -name "*.urls" -print0 > 2>/dev/null | xargs -0 cat 2>/dev/null | tr '\n' ' ' || :) > [ -n "$DEBUGINFOD_URLS" ] && export DEBUGINFOD_URLS || unset > DEBUGINFOD_URLS > fi > > if [ -z "$DEBUGINFOD_IMA_CERT_PATH" ]; then > -DEBUGINFOD_IMA_CERT_PATH=$(cat /dev/null > "@sysconfdir@/debuginfod"/*.certpath 2>/dev/null | tr '\n' ':' || :) > +DEBUGINFOD_IMA_CERT_PATH=$(find "@sysconfdir@/debuginfod" -name > "*.certpath" -print0 2>/dev/null | xargs -0 cat 2>/dev/null | tr '\n' ':' || > :) > [ -n "$DEBUGINFOD_IMA_CERT_PATH" ] && export DEBUGINFOD_IMA_CERT_PATH || > unset DEBUGINFOD_IMA_CERT_PATH > fi > unset prefix > -- > 2.47.0 Thanks, pushed as commit 00cb3efe36. Aaron
☺ Buildbot (Sourceware): elfutils - build successful (main)
A restored build has been detected on builder elfutils-fedora-s390x while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#/builders/43/builds/371 Build state: build successful Revision: 00cb3efe36337f27925dbff9b2e7d97c7df95bf8 Worker: fedora-s390x Build Reason: (unknown) Blamelist: Mark Wielaard , RocketDev Steps: - 0: worker_preparation ( success ) - 1: set package name ( success ) - 2: git checkout ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/2/logs/stdio - 3: autoreconf ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/3/logs/stdio - 4: configure ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/4/logs/stdio - config.log: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/4/logs/config_log - 5: get version ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/5/logs/stdio - property changes: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/5/logs/property_changes - 6: make ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/6/logs/stdio - warnings (3): https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/6/logs/warnings__3_ - 7: make check ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/7/logs/stdio - test-suite.log: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/7/logs/test-suite_log - 8: prep ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/8/logs/stdio - 9: build bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/9/logs/stdio - 10: fetch bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/10/logs/stdio - 11: unpack bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/11/logs/stdio - 12: pass .bunsen.source.* ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/12/logs/stdio - 13: upload to bunsen ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/13/logs/stdio - 14: clean up ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/14/logs/stdio - 15: make distclean ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#/builders/43/builds/371/steps/15/logs/stdio
[COMMITTED] tests/.gitignore: Add newzdata
Signed-off-by: Aaron Merey --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 30f5800b..14620fc3 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -91,6 +91,7 @@ /newdata /newfile /newscn +/newzdata /next-files /next-lines /next_cfi -- 2.47.0
[COMMITTED] configure.ac: Fix ENABLE_IMA_VERIFICATION conditional
Fix test statement for ENABLE_IMA_VERIFICATION always evalutating to false due to a missing 'x'. Signed-off-by: Aaron Merey --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 072bd4e2..380ff060 100644 --- a/configure.ac +++ b/configure.ac @@ -891,7 +891,7 @@ AS_IF([test "x$enable_debuginfod" != "xno"],AC_DEFINE([ENABLE_DEBUGINFOD],[1],[B AM_CONDITIONAL([DEBUGINFOD],[test "x$enable_debuginfod" = "xyes"]) AS_IF([test "x$enable_debuginfod_ima_verification" = "xyes"],AC_DEFINE([ENABLE_IMA_VERIFICATION],[1],[Build IMA verification])) AS_IF([test "x$have_libarchive" = "xyes"],AC_DEFINE([HAVE_LIBARCHIVE],[1],[Define to 1 if libarchive is available])) -AM_CONDITIONAL([ENABLE_IMA_VERIFICATION],[test "$enable_debuginfod_ima_verification" = "xyes"]) +AM_CONDITIONAL([ENABLE_IMA_VERIFICATION],[test "x$enable_debuginfod_ima_verification" = "xyes"]) AM_CONDITIONAL([OLD_LIBMICROHTTPD],[test "x$old_libmicrohttpd" = "xyes"]) AC_CHECK_LIB(pthread, pthread_setname_np, [AC_DEFINE([HAVE_PTHREAD_SETNAME_NP],[1],[Enable pthread_setname_np])]) -- 2.47.0
