Re: [PATCH] config: Enable Debuginfod RPM sig checking and eu-stacktrace in spec

[Mark Wielaard]

Hi Aaron,

On Thu, 2024-10-24 at 10:23 -0400, Aaron Merey wrote:
> On Thu, Oct 24, 2024 at 5:34 AM Mark Wielaard  wrote:
> > 
> > For testing that the eu-stacktrace and debuginfod ima verification
> > code builds correctly explicitly add --enable-stacktrace and
> > --enable-debuginfod-ima-verification to configure.
> > 
> >  * config/elfutils.spec.in (enable_stacktrace): New global,
> >  depends on arch.
> >  (BuildRequires): Add sysprof-capture-devel.
> >  (configure): Add --enable-stacktrace and
> >  --enable-debuginfod-ima-verification.
> >  (files): Add eu-stacktrace.
> 
> LGTM.

Thanks, pushed.
I also updated the try builder to make sure it builds the rpm with
these new settings.
https://sourceware.org/cgit/builder/commit/?id=b94f4171fcbc4a055047daeeb640d2b58bae20bd

Cheers,

Mark

[PATCH] stacktrace: Init elf_fd in sysprof_init_dwfl

[Mark Wielaard]

When building with LTO gcc believes elf_fd can be used uninitialized:

In function ‘sysprof_init_dwfl’,
inlined from ‘sysprof_unwind_cb’ at stacktrace.c:1235:16:
stacktrace.c:1087:7: error: ‘elf_fd’ may be used uninitialized 
[-Werror=maybe-uninitialized]
 1087 |   close (elf_fd);
  |   ^

This code won't be reached because if find_procfile doesn't initialize
elf_fd, it will return an error. But help the compiler by initializing
elf_fd to -1.

* src/stacktrace.c (sysprof_init_dwfl): Init elf_fd to -1.

Signed-off-by: Mark Wielaard 
---
 src/stacktrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/stacktrace.c b/src/stacktrace.c
index 438cb1dd0d38..b912ca5de502 100644
--- a/src/stacktrace.c
+++ b/src/stacktrace.c
@@ -1033,7 +1033,7 @@ sysprof_init_dwfl (struct sysprof_unwind_info *sui,
 }
 
   Elf *elf = NULL;
-  int elf_fd;
+  int elf_fd = -1;
   err = find_procfile (dwfl, &pid, &elf, &elf_fd);
   if (err < 0)
 {
-- 
2.47.0

[Bug debuginfod/32294] configure fails without json-c support

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32294

Mark Wielaard  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Mark Wielaard  ---
commit 42b19e54393f031e6355cf0658e9518571e85ed3
Author: Mark Wielaard 
Date:   Tue Oct 22 18:19:09 2024 +0200

configure: better error message for [lib]debuginfod missing dependencies

When dependencies for libdebuginfod, debuginfod or ima verification are
missing and these features are explicitly enabled the user might not
immediately know which of the dependicies are missing. Move the checks
around a little so checks for dependencies are done immediately before
the enable error message. And add the possible reason to the error to
make things more clear.

 * configure.ac: Move libcurl and json-c tests before libdebuginfod
 check, move libmicrohttpd, sqlite3 and libarchive tests before
 debuginfod check and move librpm, libcrypto and imaevm.h tests
 before ima verification check.

https://sourceware.org/bugzilla/show_bug.cgi?id=32294

Signed-off-by: Mark Wielaard 

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Re: ☠ Buildbot (Sourceware): elfutils - failed test (failure) (main)

[Mark Wielaard]

On Wed, 2024-10-23 at 23:51 +, buil...@sourceware.org wrote:
> A new failure has been detected on builder elfutils-fedora-s390x while 
> building elfutils.
> 
> Full details are available at:
> https://builder.sourceware.org/buildbot/#/builders/43/builds/367
> 
> Build state: failed test (failure)
> Revision: f5d6e088f84dd05278c4698a21cbf1ff4569978d
> Worker: fedora-s390x
> Build Reason: (unknown)
> Blamelist: Mark Wielaard 

And this was because the s390x box was overloaded. Dan is looking into
it.

Re: [PATCH] stacktrace: Init elf_fd in sysprof_init_dwfl

[Aaron Merey]

On Thu, Oct 24, 2024 at 5:08 AM Mark Wielaard  wrote:
>
> When building with LTO gcc believes elf_fd can be used uninitialized:
>
> In function ‘sysprof_init_dwfl’,
> inlined from ‘sysprof_unwind_cb’ at stacktrace.c:1235:16:
> stacktrace.c:1087:7: error: ‘elf_fd’ may be used uninitialized 
> [-Werror=maybe-uninitialized]
>  1087 |   close (elf_fd);
>   |   ^
>
> This code won't be reached because if find_procfile doesn't initialize
> elf_fd, it will return an error. But help the compiler by initializing
> elf_fd to -1.
>
> * src/stacktrace.c (sysprof_init_dwfl): Init elf_fd to -1.
>
> Signed-off-by: Mark Wielaard 
> ---
>  src/stacktrace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/stacktrace.c b/src/stacktrace.c
> index 438cb1dd0d38..b912ca5de502 100644
> --- a/src/stacktrace.c
> +++ b/src/stacktrace.c
> @@ -1033,7 +1033,7 @@ sysprof_init_dwfl (struct sysprof_unwind_info *sui,
>  }
>
>Elf *elf = NULL;
> -  int elf_fd;
> +  int elf_fd = -1;
>err = find_procfile (dwfl, &pid, &elf, &elf_fd);
>if (err < 0)
>  {
> --
> 2.47.0
>

LGTM

Thanks,
Aaron