[COMMITTED] configure.ac: Restore HAVE_LIBARCHIVE

2024-09-06 Thread Aaron Merey
src/srcfiles.cxx depends on the HAVE_LIBARCHIVE macro to enable the
srcfiles --zip option.  The defining of this macro was accidentally
removed from configure.ac in commit 30b5592a3.

Signed-off-by: Aaron Merey 
---
Committing as obvious

 configure.ac | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure.ac b/configure.ac
index 9c5f7e51..8f5901a2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -891,6 +891,7 @@ AM_CONDITIONAL([DUMMY_LIBDEBUGINFOD],[test 
"x$enable_libdebuginfod" = "xdummy"])
 AS_IF([test "x$enable_debuginfod" != 
"xno"],AC_DEFINE([ENABLE_DEBUGINFOD],[1],[Build debuginfod]))
 AM_CONDITIONAL([DEBUGINFOD],[test "x$enable_debuginfod" = "xyes"])
 AS_IF([test "x$enable_debuginfod_ima_verification" = 
"xyes"],AC_DEFINE([ENABLE_IMA_VERIFICATION],[1],[Build IMA verification]))
+AS_IF([test "x$have_libarchive" = 
"xyes"],AC_DEFINE([HAVE_LIBARCHIVE],[1],[Define to 1 if libarchive is 
available]))
 AM_CONDITIONAL([ENABLE_IMA_VERIFICATION],[test 
"$enable_debuginfod_ima_verification" = "xyes"])
 AM_CONDITIONAL([OLD_LIBMICROHTTPD],[test "x$old_libmicrohttpd" = "xyes"])
 
-- 
2.46.0



☠ Buildbot (Sourceware): elfutils-snapshots-coverage - failed compile (failure) (main)

2024-09-06 Thread builder
A new failure has been detected on builder elfutils-snapshots-coverage while 
building elfutils.

Full details are available at:
https://builder.sourceware.org/buildbot/#/builders/250/builds/162

Build state: failed compile (failure)
Revision: b9fd1dda0ba6ddf7dd14ff6745ea3e884a2f553a
Worker: snapshots
Build Reason: (unknown)
Blamelist: Aaron Merey 

Steps:

- 0: worker_preparation ( success )

- 1: git checkout ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#/builders/250/builds/162/steps/1/logs/stdio

- 2: autoreconf ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#/builders/250/builds/162/steps/2/logs/stdio

- 3: configure ( success )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#/builders/250/builds/162/steps/3/logs/stdio
- config.log: 
https://builder.sourceware.org/buildbot/#/builders/250/builds/162/steps/3/logs/config_log

- 4: make ( failure )
Logs:
- stdio: 
https://builder.sourceware.org/buildbot/#/builders/250/builds/162/steps/4/logs/stdio
- warnings (1): 
https://builder.sourceware.org/buildbot/#/builders/250/builds/162/steps/4/logs/warnings__1_



[COMMITTED] readelf: Fix printing of .gdb_index symbol table offset.

2024-09-06 Thread Mark Wielaard
We were printing the addr_off instead of the sym_off. And the
testcases all expected the address offset instead of the symbol table
offset.

* src/readelf.c (print_gdb_index_section): Print sym_off as
Symbol table offset.
* tests/run-readelf-gdb_index.sh: Fix up all symbol table
offsets that were the same as the address offset.

Signed-off-by: Mark Wielaard 
---
 src/readelf.c  | 2 +-
 tests/run-readelf-gdb_index.sh | 8 
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/readelf.c b/src/readelf.c
index 48035264be13..8d96443daa83 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -11699,7 +11699,7 @@ print_gdb_index_section (Dwfl_Module *dwflmod, Ebl *ebl,
 
   printf (_("\n Symbol table at offset %#" PRIx32
   " contains %zu slots:\n"),
- addr_off, sym_nr);
+ sym_off, sym_nr);
 
   n = 0;
   while (dataend - readp >= 8 && n < sym_nr)
diff --git a/tests/run-readelf-gdb_index.sh b/tests/run-readelf-gdb_index.sh
index cd437f523ec6..8efc2e805f5a 100755
--- a/tests/run-readelf-gdb_index.sh
+++ b/tests/run-readelf-gdb_index.sh
@@ -86,7 +86,7 @@ GDB section [33] '.gdb_index' at offset 0xe76 contains 8383 
bytes :
  [   0] 0x0040049c ..0x004004d1 , CU index:   
  0
  [   1] 0x004004d4 ..0x0040050b , CU index:   
  1
 
- Symbol table at offset 0x50 contains 1024 slots:
+ Symbol table at offset 0x78 contains 1024 slots:
  [ 123] symbol: global, CUs: 1
  [ 489] symbol: main, CUs: 0
  [ 518] symbol: char, CUs: 0
@@ -117,7 +117,7 @@ GDB section [33] '.gdb_index' at offset 0xe76 contains 8399 
bytes :
  [   0] 0x0040049c ..0x004004d1 , CU index:   
  0
  [   1] 0x004004d4 ..0x0040050b , CU index:   
  1
 
- Symbol table at offset 0x50 contains 1024 slots:
+ Symbol table at offset 0x78 contains 1024 slots:
  [ 123] symbol: global, CUs: 1 (var:G)
  [ 489] symbol: main, CUs: 0 (func:G)
  [ 518] symbol: char, CUs: 0 (type:S)
@@ -150,7 +150,7 @@ GDB section [33] '.gdb_index' at offset 0x38e1 contains 
8415 bytes :
  [   0] 0x00401106 ..0x0040113b , CU index:   
  1
  [   1] 0x0040113c ..0x00401173 , CU index:   
  2
 
- Symbol table at offset 0x54 contains 1024 slots:
+ Symbol table at offset 0x7c contains 1024 slots:
  [ 123] symbol: global, CUs: 1 (var:G), 0T (var:G)
  [ 489] symbol: main, CUs: 1 (func:G)
  [ 518] symbol: char, CUs: 0 (type:S)
@@ -204,7 +204,7 @@ GDB section [35] '.gdb_index' at offset 0x37d9 contains 
8395 bytes :
  Address list at offset 0x2c contains 1 entries:
  [   0] 0x00401166 ..0x004013f0 , CU index: 
0
 
- Symbol table at offset 0x2c contains 1024 slots:
+ Symbol table at offset 0x40 contains 1024 slots:
  [  61] symbol: small_stride, CUs: 0 (type:S)
  [  71] symbol: integer(kind=8), CUs: 0 (type:S)
  [ 161] symbol: character(kind=1), CUs: 0 (type:S)
-- 
2.46.0