Re: [PATCH] Prevent binaries in src from colliding with libc++ headers

2024-08-09 Thread Aaron Merey 
Hi Tristan,

(elfutils-devel CC'ed)

On Thu, Aug 8, 2024 at 6:09 PM Tristan ross  wrote:
>
> > Can you also provide a reproducer for the error you are seeing?
>
> I think this can be reproduced if you build elfutils with Clang and Clang is 
> using libc++ (LLVM's C++ implementation). Build with like `make -j10` and 
> then you will get an error which looks like this:
>
>   CCLD nm
>   CCLD ar
>   CCLD elfcompress
>   CCLD strip
>   CCLD unstrip
> In file included from srcfiles.cxx:50:
> In file included from 
> /nix/store/649b79xp5hfmjc5a5xwq7nxw8lrwjs5y-libcxx-aarch64-unknown-linux-gnu-18.1.8-dev/include/c++/v1/iostream:44:
> In file included from 
> /nix/store/649b79xp5hfmjc5a5xwq7nxw8lrwjs5y-libcxx-aarch64-unknown-linux-gnu-18.1.8-dev/include/c++/v1/istream:170:
> In file included from 
> /nix/store/649b79xp5hfmjc5a5xwq7nxw8lrwjs5y-libcxx-aarch64-unknown-linux-gnu-18.1.8-dev/include/c++/v1/ostream:189:
> In file included from 
> /nix/store/649b79xp5hfmjc5a5xwq7nxw8lrwjs5y-libcxx-aarch64-unknown-linux-gnu-18.1.8-dev/include/c++/v1/format:195:
> In file included from 
> /nix/store/649b79xp5hfmjc5a5xwq7nxw8lrwjs5y-libcxx-aarch64-unknown-linux-gnu-18.1.8-dev/include/c++/v1/__format/container_adaptor.h:25:
> ./stack:1:1: error: expected unqualified-id

Thanks. There was discussion about this bug on IRC, it looks like it's
the same bug as https://bugs.gentoo.org/925241.  This bug was fixed in
gentoo with a simpler patch [1] than what I proposed.  I suggest we
use the gentoo patch instead.

Aaron

[1] 
https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/elfutils/files/elfutils-0.191-avoid-overriding-libcxx-system-header.patch?id=631d30345702f6c5aa323808f8ebbae1c0fbd5ea

Re: [PATCH] Prevent binaries in src from colliding with libc++ headers

2024-08-09 Thread Aaron Merey 
(elfutils-devel CC'ed)

On Fri, Aug 9, 2024 at 10:32 AM Tristan ross  wrote:
>
> The Gentoo patch looks essentially the same as what we started with which 
> might bring that warning back. It also uses `-iquote .` but from what I've 
> seen, no files in src import with quotes. But that patch will work.

I built elfutils with the gentoo patch and there were no autoreconf warnings.

Aaron