Re: [PATCH v2 0/5] Add support for MIPS

2024-01-23 Thread Ying Huang
Ping,

Thanks.


在 2023/11/9 11:00, Ying Huang 写道:
> Hi,
>
> 在 2023/11/3 19:56, Mark Wielaard 写道:
>> Hi Yimg,
>>
>> On Thu, 2023-11-02 at 14:55 +0800, Ying Huang wrote:
>>> This is a series of modifications about MIPS.
>>> Support src/readelf, strip, elflint, objdump related tools.
>> Thanks. What are the changes compared to v1?
>> https://patchwork.sourceware.org/project/elfutils/list/?series=18813
>>
>>> Pass all previous test cases that failed due to MIPS non-support.
>>> The following are the test results on mips64el.
>>> # TOTAL: 271
>>> # PASS:  263
>>> # SKIP:  8
>>> # XFAIL: 0
>>> # FAIL:  0
>>> # XPASS: 0
>>> # ERROR: 0
>> That looks pretty good. What distro/gcc/glibc/kernel was this against?
>>
>> Cheers,
>>
>> Mark
> Debian GNU/Linux 11
>
> gcc version 12.2.0
>
> glibc  2.36-9
>
> kernel version 5.10.0-22-loongson-3
>
>
> Thanks,
>
> Ying


[Bug libelf/31225] Crash when using elf_memory() on a compressed section; fixed with s/ELF_C_READ/ELF_C_READ_MMAP/

2024-01-23 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=31225

Mark Wielaard  changed:

   What|Removed |Added

 CC||mark at klomp dot org

--- Comment #1 from Mark Wielaard  ---
Would you be able to give us a reproducer? And/or provide the 
I don't fully understand how you get at
cffc5784c4a469d09348e3f7ec53a74096fbd3.debug file? Are you using a standard eu
tool or something written by hand using the libdw and libelf libraries.

I think the issue is that something is providing unwritable to elf_memory and
that isn't expected. This might be a bug in elf_compress. And/or a design flaw
in elf_memory since you cannot provide a "mode".

Your fix fix might be correct. I have to think a bit more about it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libelf/31225] Crash when using elf_memory() on a compressed section; fixed with s/ELF_C_READ/ELF_C_READ_MMAP/

2024-01-23 Thread bruening at google dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=31225

--- Comment #2 from Derek Bruening  ---
Our usage is inside a large complex code base that mmaps the file on its own. 
It seems that any use of elf_memory() that has mapped the file on their own as
read-only will hit this.

I know it may not be easy to read random code inside our code base but FTR
elf_memory is called here:
https://github.com/DynamoRIO/dynamorio/blob/master/ext/drsyms/drsyms_elf.c#L283

This is our own code which maps the file (this is pre-existing code that worked
with the libelf from elftoolchain):
https://github.com/DynamoRIO/dynamorio/blob/master/ext/drsyms/drsyms_unix_common.c#L134

It looks like we are passing MAP_PRIVATE, so we may be able to change our
mapping to include write privileges (as copy-on-write): is that what elfutils
expects?  I had thought with the ELF_C_READ_MMAP support elfutils deliberately
supported read-only mappings in general?

-- 
You are receiving this mail because:
You are on the CC list for the bug.