Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' 'hello3.spec.' -> 'hello3.spec'
Thanks, works fine On Mon, Oct 31, 2022 at 9:29 PM Mark Wielaard wrote: > > Hi, > > On Thu, 2022-10-20 at 18:07 +0200, Mark Wielaard wrote: > > So maybe we just should rename them to .specfile? > > That is what the attached patch does, plus some other cleanups. > > - We forgot to include the hello3.specfile > > - Remove the --sign from rpmbuild > > - escape the % in spec comments > > > > That makes make rpm work out of the box without warnings. > > Does it also help the windows git thing? > > I pushed this. Please let me know if it works for you. > > Thanks, > > Mark -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo
[Bug tools/29826] New: eu-readelf prints out LOOS+0 instead of "IFUNC"
https://sourceware.org/bugzilla/show_bug.cgi?id=29826 Bug ID: 29826 Summary: eu-readelf prints out LOOS+0 instead of "IFUNC" Product: elfutils Version: unspecified Status: NEW Severity: normal Priority: P2 Component: tools Assignee: unassigned at sourceware dot org Reporter: mliska at suse dot cz CC: elfutils-devel at sourceware dot org Target Milestone: --- The same issue as reported for binutils (PR29718). -- You are receiving this mail because: You are on the CC list for the bug.
[PATCH] libebl: Do not require EI_OSABI for IFUNC.
Similar fix to: https://sourceware.org/bugzilla/show_bug.cgi?id=29718 Ready for master? Thanks, Martin PR 29826 libebl/ChangeLog: * eblsymboltypename.c (ebl_symbol_type_name): Do not require EI_OSABI for IFUNC --- libebl/eblsymboltypename.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libebl/eblsymboltypename.c b/libebl/eblsymboltypename.c index 0ff1722a..3b8e7ee9 100644 --- a/libebl/eblsymboltypename.c +++ b/libebl/eblsymboltypename.c @@ -65,9 +65,9 @@ ebl_symbol_type_name (Ebl *ebl, int symbol, char *buf, size_t len) snprintf (buf, len, "LOPROC+%d", symbol - STT_LOPROC); else if (symbol == STT_GNU_IFUNC && ebl != NULL - && (ident = elf_getident (ebl->elf, NULL)) != NULL - && ident[EI_OSABI] == ELFOSABI_LINUX) - return "GNU_IFUNC"; + && (ident = elf_getident (ebl->elf, NULL)) != NULL) + return "GNU_IFUNC"; /* Ignore EI_OSABI + as STT_GNU_IFUNC is a reserved name. */ else if (symbol >= STT_LOOS && symbol <= STT_HIOS) snprintf (buf, len, "LOOS+%d", symbol - STT_LOOS); else -- 2.38.1
[Bug tools/29826] eu-readelf prints out LOOS+0 instead of "IFUNC"
https://sourceware.org/bugzilla/show_bug.cgi?id=29826 Martin Liska changed: What|Removed |Added Assignee|unassigned at sourceware dot org |mliska at suse dot cz Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug.
Re: [PATCH] libebl: Do not require EI_OSABI for IFUNC.
Hi Martin, On Thu, 2022-11-24 at 13:23 +0100, Martin Liška wrote: > Similar fix to: > https://sourceware.org/bugzilla/show_bug.cgi?id=29718 > > Ready for master? Assuming runtime, glibc/ld.so, accepts this without EI_OSABI set to ELFOSABI_LINUX, it seems ok to print it as GNU_IFUNC. > else if (symbol == STT_GNU_IFUNC > && ebl != NULL > -&& (ident = elf_getident (ebl->elf, NULL)) != NULL > -&& ident[EI_OSABI] == ELFOSABI_LINUX) > - return "GNU_IFUNC"; > +&& (ident = elf_getident (ebl->elf, NULL)) != NULL) > + return "GNU_IFUNC"; /* Ignore EI_OSABI > + as STT_GNU_IFUNC is a reserved name. */ Note that you technically also don't need the elf_getident call anymore, except as sanity check that the ELF header can be read properly. OK, with and without that change. Cheers, Mark
