Re: [PATCH] debuginfod-client: Stick to http:// + https:// + file:// protocols
Hi, On Fri, 2021-10-15 at 15:25 +0200, Mark Wielaard wrote: > Make sure we don't use any of the more experimental protocols > libcurl might support. URLs can be redirected and we might want > to follow http -> https, but not e.g. gopher or pop3. On irc Frank said he didn't have any objections to this, so pushed. Cheers, Mark
[Bug libdw/28294] dwarf_aggregate_size fails on some array types
https://sourceware.org/bugzilla/show_bug.cgi?id=28294 --- Comment #4 from Mark Wielaard --- Pushed as: commit c3a6a9dfc6ed0c24ab2d11b2d71f425b479575c9 Author: Mark Wielaard Date: Wed Oct 6 22:41:29 2021 +0200 libdw: Use signedness of subrange type to determine array bounds When calculating the array size check if the subrange has an associate type, if it does then check the type to determine whether the upper and lower values need to be interpreted as signed of unsigned values. We default to signed because that is what the testcase run-aggregate-size.sh testfile-size4 expects (this is an hardwritten testcase, we could have chosen a different default). https://sourceware.org/bugzilla/show_bug.cgi?id=28294 Signed-off-by: Mark Wielaard Please reopen or file a new bug if this didn't fully resolve your issue. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug libdw/28294] dwarf_aggregate_size fails on some array types
https://sourceware.org/bugzilla/show_bug.cgi?id=28294 Mark Wielaard changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #5 from Mark Wielaard --- Patch pushed -- You are receiving this mail because: You are on the CC list for the bug.
[COMMITTED] libdw: Don't pass NULL to dwarf_peel_type
commit c3a6a9dfc "libdw: Use signedness of subrange type to determine array bounds" introduced a type check on a DIE which exposed a latent bug in the get_type function. Even if the type of a DIE couldn't be determined it would call dwarf_peel_type on it. The gcc undefined sanitizer would flag this as being undefined behaviour because the second argument of the function is marked as non-NULL. Fix this by checking we actually have a non-NULL type DIE. Signed-off-by: Mark Wielaard --- libdw/ChangeLog | 5 + libdw/dwarf_aggregate_size.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libdw/ChangeLog b/libdw/ChangeLog index 4275b830..311f34b5 100644 --- a/libdw/ChangeLog +++ b/libdw/ChangeLog @@ -1,3 +1,8 @@ +2021-10-18 Mark Wielaard + + * dwarf_aggregate_size.c (get_type): Don't pass NULL to + dwarf_peel_type. + 2021-10-06 Mark Wielaard * dwarf_aggregate_size.c (array_size): Check signedness of child DIE diff --git a/libdw/dwarf_aggregate_size.c b/libdw/dwarf_aggregate_size.c index 96023d69..89f2029e 100644 --- a/libdw/dwarf_aggregate_size.c +++ b/libdw/dwarf_aggregate_size.c @@ -40,7 +40,7 @@ get_type (Dwarf_Die *die, Dwarf_Attribute *attr_mem, Dwarf_Die *type_mem) Dwarf_Die *type = INTUSE(dwarf_formref_die) (INTUSE(dwarf_attr_integrate) (die, DW_AT_type, attr_mem), type_mem); - if (INTUSE(dwarf_peel_type) (type, type) != 0) + if (type == NULL || INTUSE(dwarf_peel_type) (type, type) != 0) return NULL; return type; -- 2.18.4
Buildbot failure in Wildebeest Builder on whole buildset
The Buildbot has detected a new failure on builder elfutils-debian-amd64 while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/2/builds/841 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: debian-amd64 Build Reason: Blamelist: Mark Wielaard BUILD FAILED: failed test (failure) Sincerely, -The BuildbotThe Buildbot has detected a new failure on builder elfutils-fedora-x86_64 while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/3/builds/841 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: fedora-x86_64 Build Reason: Blamelist: Mark Wielaard BUILD FAILED: failed test (failure) Sincerely, -The BuildbotThe Buildbot has detected a new failure on builder elfutils-debian-i386 while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/4/builds/839 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: debian-i386 Build Reason: Blamelist: Mark Wielaard BUILD FAILED: failed test (failure) Sincerely, -The BuildbotThe Buildbot has detected a new failure on builder elfutils-fedora-s390x while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/10/builds/807 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: fedora-s390x Build Reason: Blamelist: Mark Wielaard BUILD FAILED: failed test (failure) Sincerely, -The BuildbotThe Buildbot has detected a new failure on builder elfutils-fedora-ppc64le while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/11/builds/792 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: fedora-ppc64le Build Reason: Blamelist: Mark Wielaard BUILD FAILED: failed test (failure) Sincerely, -The Buildbot
Re: Buildbot failure in Wildebeest Builder on whole buildset
Hi, On Mon, 2021-10-18 at 13:45 +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a new failure on builder elfutils-debian- > amd64 while building elfutils. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/2/builds/841 > > Buildbot URL: https://builder.wildebeest.org/buildbot/ > > Worker for this Build: debian-amd64 > > Build Reason: > Blamelist: Mark Wielaard > > BUILD FAILED: failed test (failure) I already saw this earlier and it is resolved by: commit e3e70782a1d1a246844215991bbd2d6b60d0aa41 Author: Mark Wielaard Date: Mon Oct 18 14:35:20 2021 +0200 libdw: Don't pass NULL to dwarf_peel_type https://builder.wildebeest.org/buildbot/#/changes/6894 All green again. Cheers, Mark
