[PATCH] readelf: allow build with LLVM/clang
convert last nested function to allow build with LLVM/clang. Original patch
comes from
https://github.com/OpenMandrivaAssociation/elfutils/blob/master/elfutils-0.185-clang.patch
Tested with OpenMandriva Lx cooker and LLVM/clang-12.0.1
Signed-off-by: Tomasz Paweł Gajc
---
configure.ac | 2 +-
src/readelf.c | 18 +++---
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/configure.ac b/configure.ac
index b348a717..2b998c9c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -127,7 +127,7 @@ void baz (int n)
ac_cv_c99=yes, ac_cv_c99=no)
CFLAGS="$old_CFLAGS"])
AS_IF([test "x$ac_cv_c99" != xyes],
- AC_MSG_ERROR([gcc with GNU99 support required]))
+ AC_MSG_WARN([gcc with GNU99 support required]))
AC_CACHE_CHECK([whether gcc supports __attribute__((visibility()))],
ac_cv_visibility, [dnl
diff --git a/src/readelf.c b/src/readelf.c
index 161d7e65..3d6f263e 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -8763,13 +8763,17 @@ print_debug_line_section (Dwfl_Module *dwflmod, Ebl
*ebl, GElf_Ehdr *ehdr,
/* Apply the "operation advance" from a special opcode
or DW_LNS_advance_pc (as per DWARF4 6.2.5.1). */
unsigned int op_addr_advance;
- inline void advance_pc (unsigned int op_advance)
- {
- op_addr_advance = minimum_instr_len * ((op_index + op_advance)
- / max_ops_per_instr);
- address += op_addr_advance;
- op_index = (op_index + op_advance) % max_ops_per_instr;
- }
+ bool show_op_index;
+ #define advance_pc(op_advance_arg) \
+ ( { \
+unsigned int op_advance = op_advance_arg; \
+ op_addr_advance = minimum_instr_len * ((op_index +
(op_advance)) \
+ / max_ops_per_instr); \
+ address += (op_advance); \
+ show_op_index = (op_index > 0 || \
+ (op_index + (op_advance)) % max_ops_per_instr > 0); \
+ op_index = (op_index + (op_advance)) % max_ops_per_instr; \
+ } )
if (max_ops_per_instr == 0)
{
--
2.32.0
Re: Specifying CA certificates for libdebuginfod
Thank you for your reply, and apologies about getting back to you so late. On Fri, May 28 2021, Frank Ch. Eigler wrote: > Hi - > > On Fri, May 28, 2021 at 06:36:17PM +0100, Magne Hov via Elfutils-devel wrote: >> [...] >> Other components that my application uses already have ways of >> specifying a certificate bundle. [...] >> There is also an option of recognising CURL_CA_BUNDLE as that >> environment variable is already established by the curl tool, but it >> could also be good to keep the name separate to libdebuginfod. > > Sure; I have no strong opinion on this. ISTM of no particular > advantage to invent a debuginfod-oriented env var for this, > as opposed to reusing "CURL_CA_BUNDLE" (but not "SSL_CERT_DIR" > or "SSL_CERT_FILE", right?). The exact name of the environment variable is not important to me. I have no problem reusing "CURL_CA_BUNDLE". I wanted to share my patch in case other people found it useful, but for the time being I'm content with patching my own builds. I'm also not sure what the best approach is for deciding on a name for this environment variable. It might be best to leave this issue until the feature is potentially wanted by more users? > > - FChE
[Bug debuginfod/25607] debuginfod-client: paranoid federation mode
https://sourceware.org/bugzilla/show_bug.cgi?id=25607 Noah Sanci changed: What|Removed |Added CC||nsanci at redhat dot com Assignee|unassigned at sourceware dot org |nsanci at redhat dot com -- You are receiving this mail because: You are on the CC list for the bug.
[Bug debuginfod/28034] debuginfod server: preserve + etc. elements in incoming webapi url
https://sourceware.org/bugzilla/show_bug.cgi?id=28034 Noah Sanci changed: What|Removed |Added Assignee|unassigned at sourceware dot org |nsanci at redhat dot com CC||nsanci at redhat dot com -- You are receiving this mail because: You are on the CC list for the bug.
