Re: [PATCH] libdwfl: fix crash when reading link map

2021-06-10 Thread Dmitry V. Levin
On Wed, Jun 09, 2021 at 05:45:57PM -0700, Omar Sandoval wrote:
> From: Omar Sandoval 
> 
> When read_addrs() was converted was converted from a nested function to
> a normal function, there was a mistake in converting "buffer" from a
> closure variable to a parameter: we are checking whether the pointer
> argument is NULL, not whether the buffer itself is NULL. This causes a
> NULL pointer dereference when we try to use the NULL buffer later.
> 
> Fixes: 3bf41d458fb6 ("link_map: Pull read_addrs() into file scope") made
> Signed-off-by: Omar Sandoval 

Applied, thanks.


-- 
ldv


[Bug debuginfod/27783] file-based default DEBUGINFOD_URLS

2021-06-10 Thread fche at redhat dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27783

Frank Ch. Eigler  changed:

   What|Removed |Added

 Resolution|WONTFIX |---
 Status|RESOLVED|REOPENED

--- Comment #2 from Frank Ch. Eigler  ---
In the context of fedora https://bugzilla.redhat.com/show_bug.cgi?id=1970312 we
should reexamine this.  Here's another idea.

- retain /etc/profile.d/debuginfod* but change its behaviour:
- instead of containing one hardcoded path, let it search a config file/dir
  such as /etc/debuginfod-urls.d/ and assemble the environment variable
- the --with-debuginfod-urls=FOO elfutils option would arrange to drop in one
  file into this directory (say /etc/debuginfod-urls.d/elfutils.url)
  with the content FOO
- other add-on distros (rpmfusion?  ISVs?  local administrator?) can do the
same

That way a local admin can remove or update or add more files.  A user can
of course still override it in their .profile.

-- 
You are receiving this mail because:
You are on the CC list for the bug.