[PATCH] Staging: rtl8188eu: fix code indention error and block comments found by checkpatch.
ERROR: code indent should use tabs where possible
+^I^Iuint in_len, uint initial_out_len);$
WARNING: Block comments use * on subsequent lines
Signed-off-by: victor carvajal
---
drivers/staging/rtl8188eu/include/rtw_mlme.h | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme.h
b/drivers/staging/rtl8188eu/include/rtw_mlme.h
index d1eea2b..2d2a92d 100644
--- a/drivers/staging/rtl8188eu/include/rtw_mlme.h
+++ b/drivers/staging/rtl8188eu/include/rtw_mlme.h
@@ -87,16 +87,16 @@ enum SCAN_RESULT_TYPE {
};
/*
-there are several "locks" in mlme_priv,
-since mlme_priv is a shared resource between many threads,
-like ISR/Call-Back functions, the OID handlers, and even timer functions.
-
-Each _queue has its own locks, already.
-Other items are protected by mlme_priv.lock.
-
-To avoid possible dead lock, any thread trying to modifiying mlme_priv
-SHALL not lock up more than one lock at a time!
-*/
+ * there are several "locks" in mlme_priv,
+ * since mlme_priv is a shared resource between many threads,
+ * like ISR/Call-Back functions, the OID handlers, and even timer functions.
+ *
+ * Each _queue has its own locks, already.
+ * Other items are protected by mlme_priv.lock.
+ *
+ * To avoid possible dead lock, any thread trying to modifiying mlme_priv
+ * SHALL not lock up more than one lock at a time!
+ */
#define traffic_threshold 10
#definetraffic_scan_period 500
@@ -502,9 +502,9 @@ void rtw_indicate_scan_done(struct adapter *padapter, bool
aborted);
void rtw_scan_abort(struct adapter *adapter);
int rtw_restruct_sec_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie,
- uint in_len);
+ uint in_len);
int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie,
- uint in_len, uint initial_out_len);
+ uint in_len, uint initial_out_len);
void rtw_init_registrypriv_dev_network(struct adapter *adapter);
void rtw_update_registrypriv_dev_network(struct adapter *adapter);
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: rtl8188eu: fix Block comments warning found by checkpatch.
WARNING: Block comments use * on subsequent lines
Signed-off-by: victor carvajal
---
drivers/staging/rtl8188eu/include/rtw_event.h | 39 +--
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_event.h
b/drivers/staging/rtl8188eu/include/rtw_event.h
index df68948..11e048f 100644
--- a/drivers/staging/rtl8188eu/include/rtw_event.h
+++ b/drivers/staging/rtl8188eu/include/rtw_event.h
@@ -22,42 +22,41 @@
#include
/*
-Used to report a bss has been scanned
-*/
+ * Used to report a bss has been scanned
+ */
struct survey_event{
struct wlan_bssid_ex bss;
};
/*
-Used to report that the requested site survey has been done.
-
-bss_cnt indicates the number of bss that has been reported.
-
-
-*/
+ * Used to report that the requested site survey has been done.
+ *
+ * bss_cnt indicates the number of bss that has been reported.
+ *
+ */
struct surveydone_event {
unsigned intbss_cnt;
};
/*
-Used to report the link result of joinning the given bss
-
-
-join_res:
--1: authentication fail
--2: association fail
-> 0: TID
-
-*/
+ * Used to report the link result of joinning the given bss
+ *
+ *
+ *join_res:
+ * -1: authentication fail
+ *-2: association fail
+ *> 0: TID
+ *
+ */
struct joinbss_event {
struct wlan_networknetwork;
};
/*
-Used to report a given STA has joinned the created BSS.
-It is used in AP/Ad-HoC(M) mode.
-*/
+ *Used to report a given STA has joinned the created BSS.
+ *It is used in AP/Ad-HoC(M) mode.
+ */
struct stassoc_event {
unsigned char macaddr[6];
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3] Staging: rtl8188eu: fix Block comments warning found by checkpatch.
Signed-off-by: Victor Carvajal
---
Changes in v3:
- Be consistent with spacing before text against previous patch.
Changes in v2:
- Be consistent with spacing before text.
---
drivers/staging/rtl8188eu/include/rtw_event.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_event.h
b/drivers/staging/rtl8188eu/include/rtw_event.h
index 11e048f..ff40809 100644
--- a/drivers/staging/rtl8188eu/include/rtw_event.h
+++ b/drivers/staging/rtl8188eu/include/rtw_event.h
@@ -43,10 +43,10 @@ struct surveydone_event {
* Used to report the link result of joinning the given bss
*
*
- *join_res:
+ * join_res:
* -1: authentication fail
- *-2: association fail
- *> 0: TID
+ * -2: association fail
+ * > 0: TID
*
*/
struct joinbss_event {
@@ -54,8 +54,8 @@ struct joinbss_event {
};
/*
- *Used to report a given STA has joinned the created BSS.
- *It is used in AP/Ad-HoC(M) mode.
+ * Used to report a given STA has joinned the created BSS.
+ * It is used in AP/Ad-HoC(M) mode.
*/
struct stassoc_event {
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3] Staging: rtl8188eu: fix Block comments warning found by checkpatch.
On Wed, Oct 12, 2016 at 03:53:18PM +0200, Greg KH wrote: > On Mon, Oct 10, 2016 at 11:42:26PM -0700, Victor Carvajal wrote: > > Signed-off-by: Victor Carvajal > > --- > > Changes in v3: > > - Be consistent with spacing before text against previous patch. > > Changes in v2: > > - Be consistent with spacing before text. > > --- > > drivers/staging/rtl8188eu/include/rtw_event.h | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > This patch doesn't apply to my tree at all. Are you sure you are making > it against the staging-testing branch? > > thanks, > > greg k-h There lies my problem then. I've been using one of the latest branches of linux-next. I appreciate your patience in all this, this is all part of a eudyptula task. I'll circle back after I create a patch against the appropriate branch. Thanks again, Victor ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: rtl8188eu: Fix code indention found by checkpatch.
ERROR: code indent should use tabs where possible +^I^Iuint in_len, uint initial_out_len);$ Signed-off-by: Victor Carvajal --- drivers/staging/rtl8188eu/include/rtw_mlme.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme.h b/drivers/staging/rtl8188eu/include/rtw_mlme.h index 9434b86..18fb7e7 100644 --- a/drivers/staging/rtl8188eu/include/rtw_mlme.h +++ b/drivers/staging/rtl8188eu/include/rtw_mlme.h @@ -504,7 +504,7 @@ void rtw_scan_abort(struct adapter *adapter); int rtw_restruct_sec_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_len); int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, - uint in_len, uint initial_out_len); + uint in_len, uint initial_out_len); void rtw_init_registrypriv_dev_network(struct adapter *adapter); void rtw_update_registrypriv_dev_network(struct adapter *adapter); -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
