[PATCH] staging:lustre:lnet:lnet Function must be static
From: Sun Wang
Function must be static if function will not be used in other files.
Signed-off-by: Sun Wang
---
drivers/staging/lustre/lnet/lnet/{module.c.org => module.c} | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/module.c.org
b/drivers/staging/lustre/lnet/lnet/module.c
index e84d59d..4ca7b1d 100644
--- a/drivers/staging/lustre/lnet/lnet/module.c.org
+++ b/drivers/staging/lustre/lnet/lnet/module.c
@@ -43,7 +43,7 @@ MODULE_PARM_DESC(config_on_load, "configure network at module
load");
static struct mutex lnet_config_mutex;
-int
+static int
lnet_configure(void *arg)
{
/* 'arg' only there so I can be passed to cfs_create_thread() */
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging:lustre:lnet: Incorrect type in assignment
From: Sun Wang
Incorrect type when assign value to varible iov_base.
Signed-off-by: Sun Wang
---
.../drivers => drivers}/staging/lustre/lnet/lnet/lib-move.c| 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c
b/drivers/staging/lustre/lnet/lnet/lib-move.c
index 4b9567d..7b22c6e 100644
--- a/drivers/staging/lustre/lnet/lnet/lib-move.c
+++ b/drivers/staging/lustre/lnet/lnet/lib-move.c
@@ -256,7 +256,8 @@ lnet_extract_iov(int dst_niov, struct iovec *dst,
LASSERT((int)niov <= dst_niov);
frag_len = src->iov_len - offset;
- dst->iov_base = ((char *)src->iov_base) + offset;
+ dst->iov_base = (void __user *)
+ (((char *)src->iov_base) + offset);
if (len <= frag_len) {
dst->iov_len = len;
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging:lustre:lnet: Incorrect type in assignment
From: Sun Wang
Incorrect type when assign value to varible iov_base.
Signed-off-by: Sun Wang
---
.../drivers => drivers}/staging/lustre/lnet/lnet/lib-move.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c
b/drivers/staging/lustre/lnet/lnet/lib-move.c
index 4b9567d..fa29c6d 100644
--- a/drivers/staging/lustre/lnet/lnet/lib-move.c
+++ b/drivers/staging/lustre/lnet/lnet/lib-move.c
@@ -256,7 +256,7 @@ lnet_extract_iov(int dst_niov, struct iovec *dst,
LASSERT((int)niov <= dst_niov);
frag_len = src->iov_len - offset;
- dst->iov_base = ((char *)src->iov_base) + offset;
+ dst->iov_base = src->iov_base + offset;
if (len <= frag_len) {
dst->iov_len = len;
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging:vt6655 Add extern variable in head file
From: Sun Wang Subject: [PATCH] staging:vt6655 Add extern variable in head file Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes. Signed-off-by: Sun Wang --- drivers/staging/vt6655/ioctl.c | 1 - drivers/staging/vt6655/ioctl.h | 5 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c index 970e80d..716fc89 100644 --- a/drivers/staging/vt6655/ioctl.c +++ b/drivers/staging/vt6655/ioctl.c @@ -31,7 +31,6 @@ */ #include "ioctl.h" -#include "iocmd.h" #include "mac.h" #include "card.h" #include "hostap.h" diff --git a/drivers/staging/vt6655/ioctl.h b/drivers/staging/vt6655/ioctl.h index 2dc5a57..42f6910 100644 --- a/drivers/staging/vt6655/ioctl.h +++ b/drivers/staging/vt6655/ioctl.h @@ -30,6 +30,11 @@ #define __IOCTL_H__ #include "device.h" +#include "iocmd.h" + +#ifdef WPA_SM_Transtatus +extern SWPAResult wpa_Result; +#endif int private_ioctl(struct vnt_private *, struct ifreq *rq); ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: lustre: lustre: mdc: mdc_reint: fix coding style issue
From: Sun Wang
Coding style issues, the changes include:
-Remove '{}'
Signed-off-by: Sun Wang
---
drivers/staging/lustre/lustre/mdc/mdc_reint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_reint.c
b/drivers/staging/lustre/lustre/mdc/mdc_reint.c
index 01af30a..5e9c629 100644
--- a/drivers/staging/lustre/lustre/mdc/mdc_reint.c
+++ b/drivers/staging/lustre/lustre/mdc/mdc_reint.c
@@ -57,9 +57,9 @@ static int mdc_reint(struct ptlrpc_request *request,
mdc_put_rpc_lock(rpc_lock, NULL);
if (rc)
CDEBUG(D_INFO, "error in handling %d\n", rc);
- else if (!req_capsule_server_get(&request->rq_pill, &RMF_MDT_BODY)) {
+ else if (!req_capsule_server_get(&request->rq_pill, &RMF_MDT_BODY))
rc = -EPROTO;
- }
+
return rc;
}
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[no subject]
From: Sun Wang
Subject: [PATCH] staging: unisys: visorutil: procobjecttree: fix coding style
issue
Coding style issues, the changes include:
-Remove '{}'
Signed-off-by: Sun Wang
---
drivers/staging/unisys/visorutil/procobjecttree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorutil/procobjecttree.c
b/drivers/staging/unisys/visorutil/procobjecttree.c
index 5c8c95c..c81467e 100644
--- a/drivers/staging/unisys/visorutil/procobjecttree.c
+++ b/drivers/staging/unisys/visorutil/procobjecttree.c
@@ -250,9 +250,9 @@ MYPROCOBJECT *visor_proc_CreateObject(MYPROCTYPE *type,
}
strcpy(obj->name, name);
obj->procDir = createProcDir(obj->name, type->procDir);
- if (obj->procDir == NULL) {
+ if (obj->procDir == NULL)
goto Away;
- }
+
}
obj->procDirPropertyContexts =
kzalloc((type->nProperties + 1) * sizeof(PROCDIRENTRYCONTEXT),
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[no subject]
From: Sun Wang
Subject: [PATCH] staging: lustre: lov_pack: fix coding style issue
Fix the style error checking by checkpatch.pl
ERROR: space required after that ','
Signed-off-by: Sun Wang
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c
b/drivers/staging/lustre/lustre/lov/lov_pack.c
index 20e5870..62ea223 100644
--- a/drivers/staging/lustre/lustre/lov/lov_pack.c
+++ b/drivers/staging/lustre/lustre/lov/lov_pack.c
@@ -95,7 +95,7 @@ void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm)
void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm)
{
lov_dump_lmm_common(level, lmm);
- CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
+ CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
lov_dump_lmm_objects(level, lmm->lmm_objects,
le16_to_cpu(lmm->lmm_stripe_count));
}
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: lustre: lov_pack: fix coding style issue
From: Sun Wang
Fix the style error checking by checkpatch.pl
ERROR: space required after that ','
Signed-off-by: Sun Wang
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c
b/drivers/staging/lustre/lustre/lov/lov_pack.c
index 20e5870..62ea223 100644
--- a/drivers/staging/lustre/lustre/lov/lov_pack.c
+++ b/drivers/staging/lustre/lustre/lov/lov_pack.c
@@ -95,7 +95,7 @@ void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm)
void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm)
{
lov_dump_lmm_common(level, lmm);
- CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
+ CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
lov_dump_lmm_objects(level, lmm->lmm_objects,
le16_to_cpu(lmm->lmm_stripe_count));
}
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
