Staging:et131x: change memcpy() ether_addr_copy()
>From 63f3c8948d5264ab22695502b201ff50edb9028d Mon Sep 17 00:00:00 2001
From: Paul McQuade
Date: Fri, 28 Mar 2014 22:16:22 +
Subject: [PATCH] Staging:et131x: change memcpy() ether_addr_copy()
replace memcpy() with ether_addr_copy()
make checkpatch.pl clean
Signed-off-by: Paul McQuade
---
drivers/staging/et131x/et131x.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index e516bb6..a35d3c8 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x/et131x.c
@@ -3523,7 +3523,7 @@ static int et131x_pci_init(struct et131x_adapter *adapter,
goto err_out;
}
}
-memcpy(adapter->addr, adapter->rom_addr, ETH_ALEN);
+ether_addr_copy(adapter->addr, adapter->rom_addr, ETH_ALEN);
out:
return rc;
err_out:
@@ -3770,7 +3770,7 @@ static struct et131x_adapter *et131x_adapter_init(struct
net_device *netdev,
adapter->registry_jumbo_packet = 1514;/* 1514-9216 */
/* Set the MAC address to a default */
-memcpy(adapter->addr, default_mac, ETH_ALEN);
+ether_addr_copy(adapter->addr, default_mac, ETH_ALEN);
return adapter;
}
@@ -4337,7 +4337,7 @@ static void et131x_multicast(struct net_device *netdev)
netdev_for_each_mc_addr(ha, netdev) {
if (i == NIC_MAX_MCAST_LIST)
break;
-memcpy(adapter->multicast_list[i++], ha->addr, ETH_ALEN);
+ether_addr_copy(adapter->multicast_list[i++], ha->addr, ETH_ALEN);
}
adapter->multicast_addr_count = i;
@@ -4473,7 +4473,7 @@ static int et131x_change_mtu(struct net_device *netdev,
int new_mtu)
et131x_init_send(adapter);
et131x_hwaddr_init(adapter);
-memcpy(netdev->dev_addr, adapter->addr, ETH_ALEN);
+ether_addr_copy(netdev->dev_addr, adapter->addr, ETH_ALEN);
/* Init the device with the new settings */
et131x_adapter_setup(adapter);
@@ -4644,7 +4644,7 @@ static int et131x_pci_setup(struct pci_dev *pdev,
INIT_WORK(&adapter->task, et131x_isr_handler);
/* Copy address into the net_device struct */
-memcpy(netdev->dev_addr, adapter->addr, ETH_ALEN);
+ether_addr_copy(netdev->dev_addr, adapter->addr, ETH_ALEN);
/* Init variable for counting how long we do not have link status */
adapter->boot_coma = 0;
--
1.8.3.2
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: Line indentation
>From df22d80899d343314d212e1750dc6ae2a54fa364 Mon Sep 17 00:00:00 2001
From: Paul McQuade
Date: Sat, 29 Mar 2014 17:37:38 +
Subject: [PATCH] Staging: comedi: Line indentation
Fix line format in comedidev.h
Signed-off-by: Paul McQuade
---
drivers/staging/comedi/comedidev.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi/comedidev.h
index f82bd42..588e9e7 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -61,29 +61,29 @@ struct comedi_subdevice {
unsigned int *chanlist;/* driver-owned chanlist (not used) */
-int (*insn_read) (struct comedi_device *, struct comedi_subdevice *,
+int (*insn_read)(struct comedi_device *, struct comedi_subdevice *,
struct comedi_insn *, unsigned int *);
-int (*insn_write) (struct comedi_device *, struct comedi_subdevice *,
+int (*insn_write)(struct comedi_device *, struct comedi_subdevice *,
struct comedi_insn *, unsigned int *);
-int (*insn_bits) (struct comedi_device *, struct comedi_subdevice *,
+int (*insn_bits)(struct comedi_device *, struct comedi_subdevice *,
struct comedi_insn *, unsigned int *);
-int (*insn_config) (struct comedi_device *, struct comedi_subdevice *,
+int (*insn_config)(struct comedi_device *, struct comedi_subdevice *,
struct comedi_insn *, unsigned int *);
-int (*do_cmd) (struct comedi_device *, struct comedi_subdevice *);
-int (*do_cmdtest) (struct comedi_device *, struct comedi_subdevice *,
+int (*do_cmd)(struct comedi_device *, struct comedi_subdevice *);
+int (*do_cmdtest)(struct comedi_device *, struct comedi_subdevice *,
struct comedi_cmd *);
-int (*poll) (struct comedi_device *, struct comedi_subdevice *);
-int (*cancel) (struct comedi_device *, struct comedi_subdevice *);
+int (*poll)(struct comedi_device *, struct comedi_subdevice *);
+int (*cancel)(struct comedi_device *, struct comedi_subdevice *);
/* int (*do_lock)(struct comedi_device *, struct comedi_subdevice *); */
/* int (*do_unlock)(struct comedi_device *, \
struct comedi_subdevice *); */
/* called when the buffer changes */
-int (*buf_change) (struct comedi_device *dev,
+int (*buf_change)(struct comedi_device *dev,
struct comedi_subdevice *s, unsigned long new_size);
-void (*munge) (struct comedi_device *dev, struct comedi_subdevice *s,
+void (*munge)(struct comedi_device *dev, struct comedi_subdevice *s,
void *data, unsigned int num_bytes,
unsigned int start_chan_index);
enum dma_data_direction async_dma_dir;
@@ -146,7 +146,7 @@ struct comedi_async {
unsigned int cb_mask;
-int (*inttrig) (struct comedi_device *dev, struct comedi_subdevice *s,
+int (*inttrig)(struct comedi_device *dev, struct comedi_subdevice *s,
unsigned int x);
};
@@ -155,9 +155,9 @@ struct comedi_driver {
const char *driver_name;
struct module *module;
-int (*attach) (struct comedi_device *, struct comedi_devconfig *);
-void (*detach) (struct comedi_device *);
-int (*auto_attach) (struct comedi_device *, unsigned long);
+int (*attach)(struct comedi_device *, struct comedi_devconfig *);
+void (*detach)(struct comedi_device *);
+int (*auto_attach)(struct comedi_device *, unsigned long);
/* number of elements in board_name and board_id arrays */
unsigned int num_names;
@@ -202,8 +202,8 @@ struct comedi_device {
struct fasync_struct *async_queue;
-int (*open) (struct comedi_device *dev);
-void (*close) (struct comedi_device *dev);
+int (*open)(struct comedi_device *dev);
+void (*close)(struct comedi_device *dev);
};
static inline const void *comedi_board(const struct comedi_device *dev)
--
1.8.3.2
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: panel: Unnecessary space
>From 411c46d97c06fba1e45312342fa1618eef8429cd Mon Sep 17 00:00:00 2001
From: Paul McQuade
Date: Sat, 29 Mar 2014 18:01:19 +
Subject: [PATCH] Staging: panel: Unnecessary space
Removed space after function pointer name
Signed-off-by: Paul McQuade
---
drivers/staging/panel/panel.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index ec4b1fd..35e00f0 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -171,8 +171,8 @@ struct logical_input {
union {
struct {/* valid when type == INPUT_TYPE_STD */
-void (*press_fct) (int);
-void (*release_fct) (int);
+void (*press_fct)(int);
+void (*release_fct)(int);
int press_data;
int release_data;
} std;
@@ -417,9 +417,9 @@ static char lcd_must_clear;
static char lcd_left_shift;
static char init_in_progress;
-static void (*lcd_write_cmd) (int);
-static void (*lcd_write_data) (int);
-static void (*lcd_clear_fast) (void);
+static void (*lcd_write_cmd)(int);
+static void (*lcd_write_data)(int);
+static void (*lcd_clear_fast)(void);
static DEFINE_SPINLOCK(pprt_lock);
static struct timer_list scan_timer;
@@ -2017,9 +2017,9 @@ static struct logical_input *panel_bind_key(const char
*name, const char *press,
* be bound.
*/
static struct logical_input *panel_bind_callback(char *name,
- void (*press_fct) (int),
+ void (*press_fct)(int),
int press_data,
- void (*release_fct) (int),
+ void (*release_fct)(int),
int release_data)
{
struct logical_input *callback;
--
1.8.3.2
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging:ft1000_debug.c:Renaming __FUNCTION__
>From f548b09a0fc387b94fee3372c0f7c4de1f281f80 Mon Sep 17 00:00:00 2001
From: Paul McQuade
Date: Thu, 3 Apr 2014 17:12:20 +0100
Subject: [PATCH] Staging:ft1000_debug.c:Renaming __FUNCTION__
__Function__ gets renamed with __func__
Signed-off-by: Paul McQuade
---
drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
index ffdc7f5..dc7647f 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
@@ -785,7 +785,7 @@ static int ft1000_release(struct inode *inode, struct file
*file)
/* initialize application information */
ft1000dev->appcnt--;
-DEBUG("ft1000_chdev:%s:appcnt = %d\n", __FUNCTION__, ft1000dev->appcnt);
+DEBUG("ft1000_chdev:%s:appcnt = %d\n", __func__, ft1000dev->appcnt);
ft1000dev->app_info[i].fileobject = NULL;
return 0;
--
1.8.3.2
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: vt6655: Renamed uRATE to rate
From: Paul McQuade
Renamed uRATE to rate to avoid camelcase
Signed-off-by: Paul McQuade
---
drivers/staging/vt6655/rf.c | 12 ++--
drivers/staging/vt6655/rf.h | 4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index c537321..4c22bb3 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -768,7 +768,7 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned
char byRFType,
*/
bool RFbSetPower(
struct vnt_private *priv,
- unsigned int uRATE,
+ unsigned int rate,
u16 uCH
)
{
@@ -782,7 +782,7 @@ bool RFbSetPower(
if ((uCH < 1) || (uCH > CB_MAX_CHANNEL))
return false;
- switch (uRATE) {
+ switch (rate) {
case RATE_1M:
case RATE_2M:
case RATE_5M:
@@ -818,7 +818,7 @@ bool RFbSetPower(
if (priv->byCurPwr == byPwr)
return true;
- bResult = RFbRawSetPower(priv, byPwr, uRATE);
+ bResult = RFbRawSetPower(priv, byPwr, rate);
if (bResult)
priv->byCurPwr = byPwr;
@@ -842,7 +842,7 @@ bool RFbSetPower(
bool RFbRawSetPower(
struct vnt_private *priv,
unsigned char byPwr,
- unsigned int uRATE
+ unsigned int rate
)
{
bool bResult = true;
@@ -854,7 +854,7 @@ bool RFbRawSetPower(
switch (priv->byRFType) {
case RF_AIROHA:
bResult &= IFRFbWriteEmbedded(priv, dwAL2230PowerTable[byPwr]);
- if (uRATE <= RATE_11M)
+ if (rate <= RATE_11M)
bResult &= IFRFbWriteEmbedded(priv,
0x0001B400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW);
else
bResult &= IFRFbWriteEmbedded(priv,
0x0005A400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW);
@@ -863,7 +863,7 @@ bool RFbRawSetPower(
case RF_AL2230S:
bResult &= IFRFbWriteEmbedded(priv, dwAL2230PowerTable[byPwr]);
- if (uRATE <= RATE_11M) {
+ if (rate <= RATE_11M) {
bResult &= IFRFbWriteEmbedded(priv,
0x040C1400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW);
bResult &= IFRFbWriteEmbedded(priv,
0x00299B00+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW);
} else {
diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
index b5fc3ee..e9c7869 100644
--- a/drivers/staging/vt6655/rf.h
+++ b/drivers/staging/vt6655/rf.h
@@ -79,11 +79,11 @@ bool RFbInit(
struct vnt_private *
);
bool RFvWriteWakeProgSyn(struct vnt_private *, unsigned char byRFType, u16);
-bool RFbSetPower(struct vnt_private *, unsigned int uRATE, u16);
+bool RFbSetPower(struct vnt_private *, unsigned int rate, u16);
bool RFbRawSetPower(
struct vnt_private *,
unsigned char byPwr,
- unsigned int uRATE
+ unsigned int rate
);
void
--
2.5.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
