from:"navin patidar"

[PATCH 2/3] staging: rtl8188eu: remove header file ip.h

2014-02-09 Thread navin patidar

"ip.h" is included in four files but not being used, so
remove "include/ip.h" header file and inclusion of this header file.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c  |1 -
 drivers/staging/rtl8188eu/core/rtw_xmit.c  |1 -
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
 drivers/staging/rtl8188eu/include/ip.h |  126 
 drivers/staging/rtl8188eu/os_dep/xmit_linux.c  |1 -
 5 files changed, 130 deletions(-)
 delete mode 100644 drivers/staging/rtl8188eu/include/ip.h

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 92fb12e..b49a246 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c 
b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index aa77270..ca7a25a 100644
--- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
+++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index 6e84f08..540c5ad 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -22,7 +22,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include 
diff --git a/drivers/staging/rtl8188eu/include/ip.h 
b/drivers/staging/rtl8188eu/include/ip.h
deleted file mode 100644
index 9fdac6d..000
--- a/drivers/staging/rtl8188eu/include/ip.h
+++ /dev/null
@@ -1,126 +0,0 @@
-/**
- *
- * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
- *
- 
**/
-#ifndef _LINUX_IP_H
-#define _LINUX_IP_H
-
-/* SOL_IP socket options */
-
-#define IPTOS_TOS_MASK 0x1E
-#define IPTOS_TOS(tos) ((tos)&IPTOS_TOS_MASK)
-#defineIPTOS_LOWDELAY  0x10
-#defineIPTOS_THROUGHPUT0x08
-#defineIPTOS_RELIABILITY   0x04
-#defineIPTOS_MINCOST   0x02
-
-#define IPTOS_PREC_MASK0xE0
-#define IPTOS_PREC(tos)((tos)&IPTOS_PREC_MASK)
-#define IPTOS_PREC_NETCONTROL   0xe0
-#define IPTOS_PREC_INTERNETCONTROL  0xc0
-#define IPTOS_PREC_CRITIC_ECP   0xa0
-#define IPTOS_PREC_FLASHOVERRIDE0x80
-#define IPTOS_PREC_FLASH0x60
-#define IPTOS_PREC_IMMEDIATE0x40
-#define IPTOS_PREC_PRIORITY 0x20
-#define IPTOS_PREC_ROUTINE  0x00
-
-
-/* IP options */
-#define IPOPT_COPY 0x80
-#define IPOPT_CLASS_MASK   0x60
-#define IPOPT_NUMBER_MASK  0x1f
-
-#defineIPOPT_COPIED(o) ((o)&IPOPT_COPY)
-#defineIPOPT_CLASS(o)  ((o)&IPOPT_CLASS_MASK)
-#defineIPOPT_NUMBER(o) ((o)&IPOPT_NUMBER_MASK)
-
-#defineIPOPT_CONTROL   0x00
-#defineIPOPT_RESERVED1 0x20
-#defineIPOPT_MEASUREMENT   0x40
-#defineIPOPT_RESERVED2 0x60
-
-#define IPOPT_END  (0 | IPOPT_CONTROL)
-#define IPOPT_NOOP (1 | IPOPT_CONTROL)
-#define IPOPT_SEC  (2 | IPOPT_CONTROL | IPOPT_COPY)
-#define IPOPT_LSRR (3 | IPOPT_CONTROL | IPOPT_COPY)
-#define IPOPT_TIMESTAMP(4 | IPOPT_MEASUREMENT)
-#define IPOPT_RR   (7 | IPOPT_CONTROL)
-#define IPOPT_SID  (8 | IPOPT_CONTROL | IPOPT_COPY)
-#define IPOPT_SSRR (9 | IPOPT_CONTROL | IPOPT_COPY)
-#define IPOPT_RA   (20 | IPOPT_CONTROL | IPOPT_COPY)
-
-#define IPVERSION  4
-#define MAXTTL 255
-#define IPDEFTTL   64
-#define IPOPT_OPTVAL 0
-#define IPOPT_OLEN   1
-#define IPOPT_OFFSET 2
-#define IPOPT_MINOFF 4
-#define MAX_IPOPTLEN 40
-#define IPOPT_NOP IPOPT_NOOP
-#define IPOPT_EOL IPOPT_END
-#define IPOPT_TS  IPOPT_TIMESTAMP
-
-#defineIPOPT_TS_TSONLY 0   /* timestamps only */
-#defineIPOPT_TS_TSANDADDR  1   /* timestamps and addresses */
-#defineIPOPT_TS_PRESPEC3

[PATCH 1/3] staging: rtl8188eu: remove header file if_ether.h

2014-02-09 Thread navin patidar

"if_ether.h" is included in three files but not being used, so
remove "include/if_ether.h" header file and inclusion of this header file.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c  |1 -
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
 drivers/staging/rtl8188eu/include/if_ether.h   |  111 
 drivers/staging/rtl8188eu/os_dep/xmit_linux.c  |1 -
 4 files changed, 114 deletions(-)
 delete mode 100644 drivers/staging/rtl8188eu/include/if_ether.h

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 8490d51..92fb12e 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -24,7 +24,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index 17c94f4..6e84f08 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include 
diff --git a/drivers/staging/rtl8188eu/include/if_ether.h 
b/drivers/staging/rtl8188eu/include/if_ether.h
deleted file mode 100644
index db15771..000
--- a/drivers/staging/rtl8188eu/include/if_ether.h
+++ /dev/null
@@ -1,111 +0,0 @@
-/**
- *
- * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
- *
- 
**/
-
-#ifndef _LINUX_IF_ETHER_H
-#define _LINUX_IF_ETHER_H
-
-/*
- * IEEE 802.3 Ethernet magic constants.  The frame sizes omit the preamble
- * and FCS/CRC (frame check sequence).
- */
-
-#define ETH_ALEN   6   /* Octets in one ethernet addr   */
-#define ETH_HLEN   14  /* Total octets in header.   */
-#define ETH_ZLEN   60  /* Min. octets in frame sans FCS */
-#define ETH_DATA_LEN   1500/* Max. octets in payload*/
-#define ETH_FRAME_LEN  1514/* Max. octets in frame sans FCS */
-
-/*
- * These are the defined Ethernet Protocol ID's.
- */
-
-#define ETH_P_LOOP 0x0060  /* Ethernet Loopback packet */
-#define ETH_P_PUP  0x0200  /* Xerox PUP packet */
-#define ETH_P_PUPAT0x0201  /* Xerox PUP Addr Trans packet  */
-#define ETH_P_IP   0x0800  /* Internet Protocol packet */
-#define ETH_P_X25  0x0805  /* CCITT X.25   */
-#define ETH_P_ARP  0x0806  /* Address Resolution packet*/
-#defineETH_P_BPQ   0x08FF  /* G8BPQ AX.25 Ethernet Packet  
*/
-#define ETH_P_IEEEPUP  0x0a00  /* Xerox IEEE802.3 PUP packet   */
-#define ETH_P_IEEEPUPAT0x0a01  /* Xerox IEEE802.3 PUP  
*/
-#define ETH_P_DEC   0x6000  /* DEC Assigned proto   */
-#define ETH_P_DNA_DL0x6001  /* DEC DNA Dump/Load*/
-#define ETH_P_DNA_RC0x6002  /* DEC DNA Remote Console   */
-#define ETH_P_DNA_RT0x6003  /* DEC DNA Routing  */
-#define ETH_P_LAT   0x6004  /* DEC LAT  */
-#define ETH_P_DIAG  0x6005  /* DEC Diagnostics  */
-#define ETH_P_CUST  0x6006  /* DEC Customer use */
-#define ETH_P_SCA   0x6007  /* DEC Systems Comms Arch   */
-#define ETH_P_RARP  0x8035 /* Reverse Addr Res packet  */
-#define ETH_P_ATALK0x809B  /* Appletalk DDP*/
-#define ETH_P_AARP 0x80F3  /* Appletalk AARP   */
-#define ETH_P_8021Q0x8100  /* 802.1Q VLAN Extended Header  */
-#define ETH_P_IPX  0x8137  /* IPX over DIX */
-#define ETH_P_IPV6 0x86DD  /* IPv6 over bluebook   */
-#define ETH_P_PPP_DISC 0x8863  /* PPPoE discovery messages */
-#define ETH_P_PPP_SES  0x8864  /* PPPoE session messages   */
-#define ETH_P_ATMMPOA  0x884c  /* MultiProtocol Over ATM   */
-#define ETH_P_ATMFATE  0x888

[PATCH 3/3] staging: rtl8188eu: remove header file ethernet.h

2014-02-09 Thread navin patidar

"ethernet.h" is included in three files but only "rtw_recv.c" using two macros
defined in "ethernet.h", so move used macros in "rtw_recv.c" and
remove "include/ethernet.h" header file and inclusion of this header file.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c  |4 ++-
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
 drivers/staging/rtl8188eu/include/ethernet.h   |   42 
 drivers/staging/rtl8188eu/os_dep/recv_linux.c  |1 -
 4 files changed, 3 insertions(+), 45 deletions(-)
 delete mode 100644 drivers/staging/rtl8188eu/include/ethernet.h

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index b49a246..b9d86cd 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -23,10 +23,12 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 

+#define ETHERNET_HEADER_SIZE   14  /*  Ethernet Header Length */
+#define LLC_HEADER_SIZE6   /*  LLC Header Length */
+
 static u8 SNAP_ETH_TYPE_IPX[2] = {0x81, 0x37};
 static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80, 0xf3};

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index 540c5ad..b1b1584 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -22,7 +22,6 @@
 #include 
 #include 
 #include 
-#include 

 #include 
 #include 
diff --git a/drivers/staging/rtl8188eu/include/ethernet.h 
b/drivers/staging/rtl8188eu/include/ethernet.h
deleted file mode 100644
index a59f912..000
--- a/drivers/staging/rtl8188eu/include/ethernet.h
+++ /dev/null
@@ -1,42 +0,0 @@
-/**
- *
- * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
- *
- 
**/
-/*! \file */
-#ifndef __INC_ETHERNET_H
-#define __INC_ETHERNET_H
-
-#define ETHERNET_ADDRESS_LENGTH6   /*  Ethernet Address 
Length */
-#define ETHERNET_HEADER_SIZE   14  /*  Ethernet Header Length */
-#define LLC_HEADER_SIZE6   /*  LLC Header Length */
-#define TYPE_LENGTH_FIELD_SIZE 2   /*  Type/Length Size */
-#define MINIMUM_ETHERNET_PACKET_SIZE   60  /*  Min Ethernet Packet Size */
-#define MAXIMUM_ETHERNET_PACKET_SIZE   1514/*  Max Ethernet Packet Size */
-
-/*  Is Multicast Address? */
-#define RT_ETH_IS_MULTICAST(_addr) u8 *)(_addr))[0]&0x01) != 0)
-#define RT_ETH_IS_BROADCAST(_addr) (   \
-   ((u8 *)(_addr))[0] == 0xff &&   \
-   ((u8 *)(_addr))[1] == 0xff &&   \
-   ((u8 *)(_addr))[2] == 0xff &&   \
-   ((u8 *)(_addr))[3] == 0xff &&   \
-   ((u8 *)(_addr))[4] == 0xff &&   \
-   ((u8 *)(_addr))[5] == 0xff) /*  Is Broadcast Address? */
-
-
-#endif /*  #ifndef __INC_ETHERNET_H */
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 2a18b32..b4f44f2 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -26,7 +26,6 @@
 #include 

 #include 
-#include 
 #include 

 /* init os related resource in struct recv_priv */
--
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 3/3] staging: rtl8188eu: remove header file ethernet.h

2014-02-12 Thread navin patidar

"ethernet.h" is included in three files but only "rtw_recv.c" using two macros
defined in "ethernet.h", so move used macros in "rtw_recv.c" and
remove "include/ethernet.h" header file and inclusion of this header file.

v2:
First version of this patch failed to apply.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c  |4 ++-
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
 drivers/staging/rtl8188eu/include/ethernet.h   |   42 
 drivers/staging/rtl8188eu/os_dep/recv_linux.c  |1 -
 4 files changed, 3 insertions(+), 45 deletions(-)
 delete mode 100644 drivers/staging/rtl8188eu/include/ethernet.h

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index c8491f6..4de98b6 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -23,11 +23,13 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 

+#define ETHERNET_HEADER_SIZE   14  /*  Ethernet Header Length */
+#define LLC_HEADER_SIZE6   /*  LLC Header Length */
+
 static u8 SNAP_ETH_TYPE_IPX[2] = {0x81, 0x37};
 static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80, 0xf3};

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index 540c5ad..b1b1584 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -22,7 +22,6 @@
 #include 
 #include 
 #include 
-#include 

 #include 
 #include 
diff --git a/drivers/staging/rtl8188eu/include/ethernet.h 
b/drivers/staging/rtl8188eu/include/ethernet.h
deleted file mode 100644
index a59f912..000
--- a/drivers/staging/rtl8188eu/include/ethernet.h
+++ /dev/null
@@ -1,42 +0,0 @@
-/**
- *
- * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
- *
- 
**/
-/*! \file */
-#ifndef __INC_ETHERNET_H
-#define __INC_ETHERNET_H
-
-#define ETHERNET_ADDRESS_LENGTH6   /*  Ethernet Address 
Length */
-#define ETHERNET_HEADER_SIZE   14  /*  Ethernet Header Length */
-#define LLC_HEADER_SIZE6   /*  LLC Header Length */
-#define TYPE_LENGTH_FIELD_SIZE 2   /*  Type/Length Size */
-#define MINIMUM_ETHERNET_PACKET_SIZE   60  /*  Min Ethernet Packet Size */
-#define MAXIMUM_ETHERNET_PACKET_SIZE   1514/*  Max Ethernet Packet Size */
-
-/*  Is Multicast Address? */
-#define RT_ETH_IS_MULTICAST(_addr) u8 *)(_addr))[0]&0x01) != 0)
-#define RT_ETH_IS_BROADCAST(_addr) (   \
-   ((u8 *)(_addr))[0] == 0xff &&   \
-   ((u8 *)(_addr))[1] == 0xff &&   \
-   ((u8 *)(_addr))[2] == 0xff &&   \
-   ((u8 *)(_addr))[3] == 0xff &&   \
-   ((u8 *)(_addr))[4] == 0xff &&   \
-   ((u8 *)(_addr))[5] == 0xff) /*  Is Broadcast Address? */
-
-
-#endif /*  #ifndef __INC_ETHERNET_H */
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index fd8ca60..3eff225 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -26,7 +26,6 @@
 #include 

 #include 
-#include 
 #include 

 /* init os related resource in struct recv_priv */
--
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/3] staging: rtl8188eu: remove header file ethernet.h

2014-02-12 Thread navin patidar

I've submitted second version of this patch.

regards,
--navin-patidar

On Wed, Feb 12, 2014 at 2:03 AM, Greg KH  wrote:
> On Sun, Feb 09, 2014 at 02:10:46PM +0530, navin patidar wrote:
>> "ethernet.h" is included in three files but only "rtw_recv.c" using two 
>> macros
>> defined in "ethernet.h", so move used macros in "rtw_recv.c" and
>> remove "include/ethernet.h" header file and inclusion of this header file.
>>
>> Signed-off-by: navin patidar 
>> ---
>>  drivers/staging/rtl8188eu/core/rtw_recv.c  |4 ++-
>>  drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
>>  drivers/staging/rtl8188eu/include/ethernet.h   |   42 
>> 
>>  drivers/staging/rtl8188eu/os_dep/recv_linux.c  |1 -
>>  4 files changed, 3 insertions(+), 45 deletions(-)
>>  delete mode 100644 drivers/staging/rtl8188eu/include/ethernet.h
>
> This patch fails to apply (2/3 had fuzz, but I fixed that up), can you
> redo this against linux-next and resend it?
>
> thanks,
>
> greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8188eu: remove unused header files

2014-02-12 Thread navin patidar

Remove h2clbk.h and nic_spec.h header files.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/h2clbk.h   |   35 
 drivers/staging/rtl8188eu/include/nic_spec.h |   44 --
 2 files changed, 79 deletions(-)
 delete mode 100644 drivers/staging/rtl8188eu/include/h2clbk.h
 delete mode 100644 drivers/staging/rtl8188eu/include/nic_spec.h

diff --git a/drivers/staging/rtl8188eu/include/h2clbk.h 
b/drivers/staging/rtl8188eu/include/h2clbk.h
deleted file mode 100644
index e595030..000
--- a/drivers/staging/rtl8188eu/include/h2clbk.h
+++ /dev/null
@@ -1,35 +0,0 @@
-/**
- *
- * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
- *
- 
**/
-
-
-#define _H2CLBK_H_
-
-
-#include 
-#include 
-
-
-void _lbk_cmd(struct adapter *adapter);
-
-void _lbk_rsp(struct adapter *adapter);
-
-void _lbk_evt(IN struct adapter *adapter);
-
-void h2c_event_callback(unsigned char *dev, unsigned char *pbuf);
diff --git a/drivers/staging/rtl8188eu/include/nic_spec.h 
b/drivers/staging/rtl8188eu/include/nic_spec.h
deleted file mode 100644
index d422447..000
--- a/drivers/staging/rtl8188eu/include/nic_spec.h
+++ /dev/null
@@ -1,44 +0,0 @@
-/**
- *
- * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
- *
- 
**/
-
-
-#ifndef __NIC_SPEC_H__
-#define __NIC_SPEC_H__
-
-#define RTL8711_MCTRL_ (0x2)
-#define RTL8711_UART_  (0x3)
-#define RTL8711_TIMER_ (0x4)
-#define RTL8711_FINT_  (0x5)
-#define RTL8711_HINT_  (0x5)
-#define RTL8711_GPIO_  (0x6)
-#define RTL8711_WLANCTRL_  (0x20)
-#define RTL8711_WLANFF_(0xe0)
-#define RTL8711_HCICTRL_   (0x60)
-#define RTL8711_SYSCFG_(0x62)
-#define RTL8711_SYSCTRL_   (0x62)
-#define RTL8711_MCCTRL_(0x02)
-
-
-#include 
-
-#include 
-
-
-#endif /*  __RTL8711_SPEC_H__ */
--
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 00/10] staging: rtl8188eu: Refactor and cleanup led related code.

2014-04-20 Thread navin . patidar

From: navin patidar 

This patch series refactors and performs various cleanups on the driver's code
responsible for led functionality.

navin patidar (10):
  staging: rtl8188eu: Remove empty header file
  staging: rtl8188eu: Remove rtw_led_blink_cmd() function.
  staging: rtl8188eu: Remove _ReadLEDSetting() function.
  staging: rtl8188eu: Remove _InitHWLed() function.
  staging: rtl8188eu: Simplify led blinking strategy code.
  staging: rtl8188eu: Remove enum LED_STRATEGY_871x .
  staging: rtl8188eu: refactor led related structures.
  staging: rtl8188eu: Remove unused macros.
  staging: rtl8188eu: Remove unused enum LED_STATE_871x members.
  staging: rtl8188eu: Remove unused enum LED_CTL_MODE members.

 drivers/staging/rtl8188eu/core/rtw_cmd.c   |   35 -
 drivers/staging/rtl8188eu/core/rtw_led.c   | 1415 ++--
 drivers/staging/rtl8188eu/hal/rtl8188eu_led.c  |   43 +-
 drivers/staging/rtl8188eu/hal/usb_halinit.c|   26 -
 drivers/staging/rtl8188eu/include/drv_types.h  |1 -
 .../staging/rtl8188eu/include/drv_types_linux.h|   24 -
 drivers/staging/rtl8188eu/include/rtw_cmd.h|1 -
 drivers/staging/rtl8188eu/include/rtw_led.h|  119 +-
 8 files changed, 137 insertions(+), 1527 deletions(-)
 delete mode 100644 drivers/staging/rtl8188eu/include/drv_types_linux.h

--
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 01/10] staging: rtl8188eu: Remove empty header file

2014-04-20 Thread navin patidar

drv_types_linux.h is empty, so remove the header file and its
reference.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/drv_types.h  |1 -
 .../staging/rtl8188eu/include/drv_types_linux.h|   24 
 2 files changed, 25 deletions(-)
 delete mode 100644 drivers/staging/rtl8188eu/include/drv_types_linux.h

diff --git a/drivers/staging/rtl8188eu/include/drv_types.h 
b/drivers/staging/rtl8188eu/include/drv_types.h
index 936c196..10cc1a1 100644
--- a/drivers/staging/rtl8188eu/include/drv_types.h
+++ b/drivers/staging/rtl8188eu/include/drv_types.h
@@ -31,7 +31,6 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/staging/rtl8188eu/include/drv_types_linux.h 
b/drivers/staging/rtl8188eu/include/drv_types_linux.h
deleted file mode 100644
index 812b744..000
--- a/drivers/staging/rtl8188eu/include/drv_types_linux.h
+++ /dev/null
@@ -1,24 +0,0 @@
-/**
- *
- * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
- *
- 
**/
-#ifndef __DRV_TYPES_LINUX_H__
-#define __DRV_TYPES_LINUX_H__
-
-
-#endif
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 02/10] staging: rtl8188eu: Remove rtw_led_blink_cmd() function.

2014-04-20 Thread navin patidar

rtw_led_blink_cmd() isn't being used by driver.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_cmd.c|   35 ---
 drivers/staging/rtl8188eu/include/rtw_cmd.h |1 -
 2 files changed, 36 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c 
b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index c2fb050..1e0b8b4 100644
--- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
+++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
@@ -1431,41 +1431,6 @@ exit:
return res;
 }
 
-u8 rtw_led_blink_cmd(struct adapter *padapter, struct LED_871x *pLed)
-{
-   struct  cmd_obj *pcmdobj;
-   struct  LedBlink_param *ledBlink_param;
-   struct  cmd_priv   *pcmdpriv = &padapter->cmdpriv;
-
-   u8  res = _SUCCESS;
-
-
-   RT_TRACE(_module_rtl871x_cmd_c_, _drv_notice_, 
("+rtw_led_blink_cmd\n"));
-
-   pcmdobj = (struct cmd_obj *)rtw_zmalloc(sizeof(struct   cmd_obj));
-   if (pcmdobj == NULL) {
-   res = _FAIL;
-   goto exit;
-   }
-
-   ledBlink_param = (structLedBlink_param 
*)rtw_zmalloc(sizeof(struct  LedBlink_param));
-   if (ledBlink_param == NULL) {
-   kfree(pcmdobj);
-   res = _FAIL;
-   goto exit;
-   }
-
-   ledBlink_param->pLed = pLed;
-
-   init_h2fwcmd_w_parm_no_rsp(pcmdobj, ledBlink_param, 
GEN_CMD_CODE(_LedBlink));
-   res = rtw_enqueue_cmd(pcmdpriv, pcmdobj);
-
-exit:
-
-
-   return res;
-}
-
 u8 rtw_set_csa_cmd(struct adapter *padapter, u8 new_ch_no)
 {
struct  cmd_obj *pcmdobj;
diff --git a/drivers/staging/rtl8188eu/include/rtw_cmd.h 
b/drivers/staging/rtl8188eu/include/rtw_cmd.h
index 3d34702..66467f7 100644
--- a/drivers/staging/rtl8188eu/include/rtw_cmd.h
+++ b/drivers/staging/rtl8188eu/include/rtw_cmd.h
@@ -807,7 +807,6 @@ u8 rtw_chk_hi_queue_cmd(struct adapter *padapter);
 u8 rtw_set_ch_cmd(struct adapter *padapter, u8 ch, u8 bw, u8 ch_offset,
  u8 enqueue);
 u8 rtw_set_chplan_cmd(struct adapter *padapter, u8 chplan, u8 enqueue);
-u8 rtw_led_blink_cmd(struct adapter *padapter, struct LED_871x *pLed);
 u8 rtw_set_csa_cmd(struct adapter *padapter, u8 new_ch_no);
 u8 rtw_tdls_cmd(struct adapter *padapter, u8 *addr, u8 option);
 
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 05/10] staging: rtl8188eu: Simplify led blinking strategy code.

2014-04-20 Thread navin patidar

driver has code to blink the led in 7 different ways.
struct led_priv contains an enum LED_STRATEGY_871x variable which is
initialized to SW_LED_MODE1 inside rtl8188eu_InitSwLeds() function.
it means driver is hard coded to use only SW_LED_MODE1 blinking strategy.
so we can remove the code related to other blinking strategies
e.g. SW_LED_MODE[0|2|3|4|5|6].

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_led.c | 1412 +++---
 1 file changed, 101 insertions(+), 1311 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c 
b/drivers/staging/rtl8188eu/core/rtw_led.c
index 42b41ab..c42e176 100644
--- a/drivers/staging/rtl8188eu/core/rtw_led.c
+++ b/drivers/staging/rtl8188eu/core/rtw_led.c
@@ -40,7 +40,6 @@ void BlinkTimerCallback(void *data)
 /*  */
 /* Description: */
 /* Callback function of LED BlinkWorkItem. */
-/* We dispatch acture LED blink action according to LedStrategy. */
 /*  */
 void BlinkWorkItemCallback(struct work_struct *work)
 {
@@ -101,87 +100,6 @@ void DeInitLed871x(struct LED_871x *pLed)
 /* It toggle off LED and schedule corresponding timer if 
necessary. */
 /*  */
 
-static void SwLedBlink(struct LED_871x *pLed)
-{
-   struct adapter *padapter = pLed->padapter;
-   struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
-   u8 bStopBlinking = false;
-
-   /*  Change LED according to BlinkingLedState specified. */
-   if (pLed->BlinkingLedState == RTW_LED_ON) {
-   SwLedOn(padapter, pLed);
-   RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("Blinktimes (%d): 
turn on\n", pLed->BlinkTimes));
-   } else {
-   SwLedOff(padapter, pLed);
-   RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("Blinktimes (%d): 
turn off\n", pLed->BlinkTimes));
-   }
-
-   /*  Determine if we shall change LED state again. */
-   pLed->BlinkTimes--;
-   switch (pLed->CurrLedState) {
-   case LED_BLINK_NORMAL:
-   if (pLed->BlinkTimes == 0)
-   bStopBlinking = true;
-   break;
-   case LED_BLINK_StartToBlink:
-   if (check_fwstate(pmlmepriv, _FW_LINKED) && 
check_fwstate(pmlmepriv, WIFI_STATION_STATE))
-   bStopBlinking = true;
-   if (check_fwstate(pmlmepriv, _FW_LINKED) &&
-   (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) ||
-   check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)))
-   bStopBlinking = true;
-   else if (pLed->BlinkTimes == 0)
-   bStopBlinking = true;
-   break;
-   case LED_BLINK_WPS:
-   if (pLed->BlinkTimes == 0)
-   bStopBlinking = true;
-   break;
-   default:
-   bStopBlinking = true;
-   break;
-   }
-
-   if (bStopBlinking) {
-   /* if (padapter->pwrctrlpriv.cpwm >= PS_STATE_S2) */
-   if (0) {
-   SwLedOff(padapter, pLed);
-   } else if ((check_fwstate(pmlmepriv, _FW_LINKED)) && 
(!pLed->bLedOn)) {
-   SwLedOn(padapter, pLed);
-   } else if ((check_fwstate(pmlmepriv, _FW_LINKED)) &&  
pLed->bLedOn) {
-   SwLedOff(padapter, pLed);
-   }
-   pLed->BlinkTimes = 0;
-   pLed->bLedBlinkInProgress = false;
-   } else {
-   /*  Assign LED state to toggle. */
-   if (pLed->BlinkingLedState == RTW_LED_ON)
-   pLed->BlinkingLedState = RTW_LED_OFF;
-   else
-   pLed->BlinkingLedState = RTW_LED_ON;
-
-   /*  Schedule a timer to toggle LED state. */
-   switch (pLed->CurrLedState) {
-   case LED_BLINK_NORMAL:
-   _set_timer(&(pLed->BlinkTimer), 
LED_BLINK_NORMAL_INTERVAL);
-   break;
-   case LED_BLINK_SLOWLY:
-   case LED_BLINK_StartToBlink:
-   _set_timer(&(pLed->BlinkTimer), 
LED_BLINK_SLOWLY_INTERVAL);
-   break;
-   case LED_BLINK_WPS:
-   if (pLed->BlinkingLedState == RTW_LED_ON)
-   _set_timer(&(pLed->BlinkTimer), 
LED_BLINK_LONG_INTERVAL);
-   else
-   _set_timer(&(pLed->BlinkTimer), 
LED_BLINK_LONG_INTERVAL);
-   break;
-   default:
-   _set_timer(&(pLed->BlinkTimer), 
LED_BLINK_SLOWLY_INTERVAL);
-   break;
-   }
-   }
-}
-
 static void SwLedBlink1(struct LED_871x *pLed)
 {
struct adapter *padapter = pLed->padapter;
@@ -277,1051 +1

[PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

2014-04-20 Thread navin patidar

_ReadLEDSetting() doesn't read led settings this function actually
initialize  member variables of struct led_priv, we should do that
inside rtl8188eu_InitSwLeds().

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188eu_led.c |4 
 drivers/staging/rtl8188eu/hal/usb_halinit.c   |   12 
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
index 08dfd94..01eeb70 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
@@ -92,8 +92,12 @@ exit:
 void rtl8188eu_InitSwLeds(struct adapter *padapter)
 {
struct led_priv *pledpriv = &(padapter->ledpriv);
+   struct hal_data_8188e   *haldata = GET_HAL_DATA(padapter);
 
+   pledpriv->bRegUseLed = true;
+   pledpriv->LedStrategy = SW_LED_MODE1;
pledpriv->LedControlHandler = LedControl8188eu;
+   haldata->bLedOpenDrain = true;
 
InitLed871x(padapter, &(pledpriv->SwLed0), LED_PIN_LED0);
 
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c 
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index c92067f..0dfd62b 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -1129,16 +1129,6 @@ static unsigned int rtl8188eu_inirp_deinit(struct 
adapter *Adapter)
 /* EEPROM/EFUSE Content Parsing */
 /*  */
 /*  */
-static void _ReadLEDSetting(struct adapter *Adapter, u8 *PROMContent, bool 
AutoloadFail)
-{
-   struct led_priv *pledpriv = &(Adapter->ledpriv);
-   struct hal_data_8188e   *haldata = GET_HAL_DATA(Adapter);
-
-   pledpriv->bRegUseLed = true;
-   pledpriv->LedStrategy = SW_LED_MODE1;
-   haldata->bLedOpenDrain = true;/*  Support Open-drain arrangement for 
controlling the LED. */
-}
-
 static void Hal_EfuseParsePIDVID_8188EU(struct adapter *adapt, u8 *hwinfo, 
bool AutoLoadFail)
 {
struct hal_data_8188e   *haldata = GET_HAL_DATA(adapt);
@@ -1215,8 +1205,6 @@ readAdapterInfo_8188EU(
/*  */
Hal_InitChannelPlan(adapt);
Hal_CustomizeByCustomerID_8188EU(adapt);
-
-   _ReadLEDSetting(adapt, eeprom->efuse_eeprom_data, 
eeprom->bautoload_fail_flag);
 }
 
 static void _ReadPROMContent(
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 04/10] staging: rtl8188eu: Remove _InitHWLed() function.

2014-04-20 Thread navin patidar

_InitHWLed() function does nothing.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c |   14 --
 1 file changed, 14 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c 
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 0dfd62b..617e4c6 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -424,18 +424,6 @@ static void _InitBeaconMaxError(struct adapter *Adapter, 
bool  InfraMode)
 {
 }
 
-static void _InitHWLed(struct adapter *Adapter)
-{
-   struct led_priv *pledpriv = &(Adapter->ledpriv);
-
-   if (pledpriv->LedStrategy != HW_LED)
-   return;
-
-/*  HW led control */
-/*  to do  */
-/* must consider cases of antenna diversity/ commbo card/solo card/mini card */
-}
-
 static void _InitRDGSetting(struct adapter *Adapter)
 {
rtw_write8(Adapter, REG_RD_CTRL, 0xFF);
@@ -870,8 +858,6 @@ static u32 rtl8188eu_hal_init(struct adapter *Adapter)
rtw_write16(Adapter, REG_PKT_VO_VI_LIFE_TIME, 0x0400);  /*  unit: 
256us. 256ms */
rtw_write16(Adapter, REG_PKT_BE_BK_LIFE_TIME, 0x0400);  /*  unit: 
256us. 256ms */
 
-   _InitHWLed(Adapter);
-
/* Keep RfRegChnlVal for later use. */
haldata->RfRegChnlVal[0] = PHY_QueryRFReg(Adapter, (enum 
rf_radio_path)0, RF_CHNLBW, bRFRegOffsetMask);
haldata->RfRegChnlVal[1] = PHY_QueryRFReg(Adapter, (enum 
rf_radio_path)1, RF_CHNLBW, bRFRegOffsetMask);
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 06/10] staging: rtl8188eu: Remove enum LED_STRATEGY_871x .

2014-04-20 Thread navin patidar

 Now driver has only one type of led blinking strategy, so we don't
 need enum LED_STRATEGY_871x variable to store led blinking strategy
 type.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188eu_led.c |1 -
 drivers/staging/rtl8188eu/include/rtw_led.h   |   18 --
 2 files changed, 19 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
index 01eeb70..e3c86f7 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
@@ -95,7 +95,6 @@ void rtl8188eu_InitSwLeds(struct adapter *padapter)
struct hal_data_8188e   *haldata = GET_HAL_DATA(padapter);
 
pledpriv->bRegUseLed = true;
-   pledpriv->LedStrategy = SW_LED_MODE1;
pledpriv->LedControlHandler = LedControl8188eu;
haldata->bLedOpenDrain = true;
 
diff --git a/drivers/staging/rtl8188eu/include/rtw_led.h 
b/drivers/staging/rtl8188eu/include/rtw_led.h
index 0da4e27..690c82a 100644
--- a/drivers/staging/rtl8188eu/include/rtw_led.h
+++ b/drivers/staging/rtl8188eu/include/rtw_led.h
@@ -143,30 +143,12 @@ struct LED_871x {
(((struct LED_871x *)_LED_871x)->bLedWPSBlinkInProgress ||  \
((struct LED_871x *)_LED_871x)->bLedScanBlinkInProgress)
 
-/*  LED customization. */
-
-enum LED_STRATEGY_871x {
-   SW_LED_MODE0 = 0, /* SW control 1 LED via GPIO0. It is default option.*/
-   SW_LED_MODE1 = 1, /*  2 LEDs, through LED0 and LED1. For ALPHA. */
-   SW_LED_MODE2 = 2, /*  SW control 1 LED via GPIO0, customized for AzWave
-  * 8187 minicard. */
-   SW_LED_MODE3 = 3, /*  SW control 1 LED via GPIO0, customized for Sercomm
-  * Printer Server case. */
-   SW_LED_MODE4 = 4, /* for Edimax / Belkin */
-   SW_LED_MODE5 = 5, /* for Sercomm / Belkin */
-   SW_LED_MODE6 = 6, /* for 88CU minicard, porting from ce SW_LED_MODE7 */
-   HW_LED = 50, /*  HW control 2 LEDs, LED0 and LED1 (there are 4
- * different control modes, see MAC.CONFIG1 for details.)*/
-   LED_ST_NONE = 99,
-};
-
 void LedControl8188eu(struct adapter *padapter, enum LED_CTL_MODE  
LedAction);
 
 struct led_priv{
/* add for led control */
struct LED_871x SwLed0;
struct LED_871x SwLed1;
-   enum LED_STRATEGY_871x  LedStrategy;
u8  bRegUseLed;
void (*LedControlHandler)(struct adapter *padapter,
  enum LED_CTL_MODE LedAction);
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 07/10] staging: rtl8188eu: refactor led related structures.

2014-04-20 Thread navin patidar

struct led_priv contains two variables SwLed0 and SwLed1 but only
SwLed0 is being used by SwLedControlModel1() function.

SwLedControlModel1() function performs led operations.

This patch removes SwLed1 and code which uses SwLed1.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_led.c  |3 +-
 drivers/staging/rtl8188eu/hal/rtl8188eu_led.c |   40 ++---
 drivers/staging/rtl8188eu/include/rtw_led.h   |   14 +
 3 files changed, 11 insertions(+), 46 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c 
b/drivers/staging/rtl8188eu/core/rtw_led.c
index c42e176..87d6f06 100644
--- a/drivers/staging/rtl8188eu/core/rtw_led.c
+++ b/drivers/staging/rtl8188eu/core/rtw_led.c
@@ -70,10 +70,9 @@ void ResetLedStatus(struct LED_871x *pLed)
 
 /*Description: */
 /* Initialize an LED_871x object. */
-void InitLed871x(struct adapter *padapter, struct LED_871x *pLed, enum 
LED_PIN_871x LedPin)
+void InitLed871x(struct adapter *padapter, struct LED_871x *pLed)
 {
pLed->padapter = padapter;
-   pLed->LedPin = LedPin;
 
ResetLedStatus(pLed);
 
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
index e3c86f7..77dce58 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
@@ -35,16 +35,7 @@ void SwLedOn(struct adapter *padapter, struct LED_871x *pLed)
if (padapter->bSurpriseRemoved || padapter->bDriverStopped)
return;
LedCfg = rtw_read8(padapter, REG_LEDCFG2);
-   switch (pLed->LedPin) {
-   case LED_PIN_LED0:
-   rtw_write8(padapter, REG_LEDCFG2, (LedCfg&0xf0)|BIT5|BIT6); /*  
SW control led0 on. */
-   break;
-   case LED_PIN_LED1:
-   rtw_write8(padapter, REG_LEDCFG2, (LedCfg&0x0f)|BIT5); /*  SW 
control led1 on. */
-   break;
-   default:
-   break;
-   }
+   rtw_write8(padapter, REG_LEDCFG2, (LedCfg&0xf0)|BIT5|BIT6); /*  SW 
control led0 on. */
pLed->bLedOn = true;
 }
 
@@ -60,25 +51,15 @@ void SwLedOff(struct adapter *padapter, struct LED_871x 
*pLed)
 
LedCfg = rtw_read8(padapter, REG_LEDCFG2);/* 0x4E */
 
-   switch (pLed->LedPin) {
-   case LED_PIN_LED0:
-   if (pHalData->bLedOpenDrain) {
+   if (pHalData->bLedOpenDrain) {
/*  Open-drain arrangement for controlling the LED) */
-   LedCfg &= 0x90; /*  Set to software control. */
-   rtw_write8(padapter, REG_LEDCFG2, (LedCfg|BIT3));
-   LedCfg = rtw_read8(padapter, REG_MAC_PINMUX_CFG);
-   LedCfg &= 0xFE;
-   rtw_write8(padapter, REG_MAC_PINMUX_CFG, LedCfg);
-   } else {
-   rtw_write8(padapter, REG_LEDCFG2, 
(LedCfg|BIT3|BIT5|BIT6));
-   }
-   break;
-   case LED_PIN_LED1:
-   LedCfg &= 0x0f; /*  Set to software control. */
+   LedCfg &= 0x90; /*  Set to software control. */
rtw_write8(padapter, REG_LEDCFG2, (LedCfg|BIT3));
-   break;
-   default:
-   break;
+   LedCfg = rtw_read8(padapter, REG_MAC_PINMUX_CFG);
+   LedCfg &= 0xFE;
+   rtw_write8(padapter, REG_MAC_PINMUX_CFG, LedCfg);
+   } else {
+   rtw_write8(padapter, REG_LEDCFG2, (LedCfg|BIT3|BIT5|BIT6));
}
 exit:
pLed->bLedOn = false;
@@ -98,9 +79,7 @@ void rtl8188eu_InitSwLeds(struct adapter *padapter)
pledpriv->LedControlHandler = LedControl8188eu;
haldata->bLedOpenDrain = true;
 
-   InitLed871x(padapter, &(pledpriv->SwLed0), LED_PIN_LED0);
-
-   InitLed871x(padapter, &(pledpriv->SwLed1), LED_PIN_LED1);
+   InitLed871x(padapter, &(pledpriv->SwLed0));
 }
 
 /* Description: */
@@ -110,5 +89,4 @@ void rtl8188eu_DeInitSwLeds(struct adapter *padapter)
struct led_priv *ledpriv = &(padapter->ledpriv);
 
DeInitLed871x(&(ledpriv->SwLed0));
-   DeInitLed871x(&(ledpriv->SwLed1));
 }
diff --git a/drivers/staging/rtl8188eu/include/rtw_led.h 
b/drivers/staging/rtl8188eu/include/rtw_led.h
index 690c82a..ed1c687 100644
--- a/drivers/staging/rtl8188eu/include/rtw_led.h
+++ b/drivers/staging/rtl8188eu/include/rtw_led.h
@@ -96,19 +96,9 @@ enum LED_STATE_871x {
LED_BLINK_ALWAYS_ON = 16,
 };
 
-enum LED_PIN_871x {
-   LED_PIN_NULL = 0,
-   LED_PIN_LED0 = 1,
-   LED_PIN_LED1 = 2,
-   LED_PIN_LED2 = 3,
-   LED_PIN_GPIO0 = 4,
-};
-
 struct LED_871x {
struct adapter *padapter;
 
-   enum LED_PIN_871x   LedPin; /* Identify how to implement this
-* SW led. */
enum LED_STATE_871x CurrLed

[PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

2014-04-20 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/rtw_led.h |   30 +--
 1 file changed, 10 insertions(+), 20 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_led.h 
b/drivers/staging/rtl8188eu/include/rtw_led.h
index 2f81fab..2ad7e4a 100644
--- a/drivers/staging/rtl8188eu/include/rtw_led.h
+++ b/drivers/staging/rtl8188eu/include/rtw_led.h
@@ -47,26 +47,16 @@ enum LED_CTL_MODE {
 };
 
 enum LED_STATE_871x {
-   LED_UNKNOWN = 0,
-   RTW_LED_ON = 1,
-   RTW_LED_OFF = 2,
-   LED_BLINK_NORMAL = 3,
-   LED_BLINK_SLOWLY = 4,
-   LED_BLINK_POWER_ON = 5,
-   LED_BLINK_SCAN = 6, /*  LED is blinking during scanning period,
-* the # of times to blink is depend on time
-* for scanning. */
-   LED_BLINK_NO_LINK = 7, /*  LED is blinking during no link state. */
-   LED_BLINK_StartToBlink = 8,/*  Customzied for Sercomm Printer
-   * Server case */
-   LED_BLINK_TXRX = 9,
-   LED_BLINK_WPS = 10, /*  LED is blinkg during WPS communication */
-   LED_BLINK_WPS_STOP = 11,/* for ALPHA */
-   LED_BLINK_WPS_STOP_OVERLAP = 12,/* for BELKIN */
-   LED_BLINK_RUNTOP = 13, /*  Customized for RunTop */
-   LED_BLINK_CAMEO = 14,
-   LED_BLINK_XAVI = 15,
-   LED_BLINK_ALWAYS_ON = 16,
+   LED_UNKNOWN,
+   RTW_LED_ON,
+   RTW_LED_OFF,
+   LED_BLINK_NORMAL,
+   LED_BLINK_SLOWLY,
+   LED_BLINK_POWER_ON,
+   LED_BLINK_SCAN,
+   LED_BLINK_TXRX,
+   LED_BLINK_WPS,
+   LED_BLINK_WPS_STOP
 };
 
 struct LED_871x {
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 08/10] staging: rtl8188eu: Remove unused macros.

2014-04-20 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/rtw_led.h |   31 ---
 1 file changed, 31 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_led.h 
b/drivers/staging/rtl8188eu/include/rtw_led.h
index ed1c687..2f81fab 100644
--- a/drivers/staging/rtl8188eu/include/rtw_led.h
+++ b/drivers/staging/rtl8188eu/include/rtw_led.h
@@ -23,39 +23,12 @@
 #include 
 #include 
 
-#define MSECS(t)(HZ * ((t) / 1000) + (HZ * ((t) % 1000)) / 1000)
-
-#define LED_BLINK_NORMAL_INTERVAL  100
-#define LED_BLINK_SLOWLY_INTERVAL  200
-#define LED_BLINK_LONG_INTERVAL400
-
 #define LED_BLINK_NO_LINK_INTERVAL_ALPHA   1000
 #define LED_BLINK_LINK_INTERVAL_ALPHA  500 /* 500 */
 #define LED_BLINK_SCAN_INTERVAL_ALPHA  180 /* 150 */
 #define LED_BLINK_FASTER_INTERVAL_ALPHA50
 #define LED_BLINK_WPS_SUCESS_INTERVAL_ALPHA5000
 
-#define LED_BLINK_NORMAL_INTERVAL_NETTRONIX100
-#define LED_BLINK_SLOWLY_INTERVAL_NETTRONIX2000
-
-#define LED_BLINK_SLOWLY_INTERVAL_PORNET   1000
-#define LED_BLINK_NORMAL_INTERVAL_PORNET   100
-
-#define LED_BLINK_FAST_INTERVAL_BITLAND30
-
-/*  060403, rcnjko: Customized for AzWave. */
-#define LED_CM2_BLINK_ON_INTERVAL  250
-#define LED_CM2_BLINK_OFF_INTERVAL 4750
-
-#define LED_CM8_BLINK_INTERVAL 500 /* for QMI */
-#define LED_CM8_BLINK_OFF_INTERVAL 3750/* for QMI */
-
-/*  080124, lanhsin: Customized for RunTop */
-#define LED_RunTop_BLINK_INTERVAL  300
-
-/*  060421, rcnjko: Customized for Sercomm Printer Server case. */
-#define LED_CM3_BLINK_INTERVAL 1500
-
 enum LED_CTL_MODE {
LED_CTL_POWER_ON = 1,
LED_CTL_LINK = 2,
@@ -129,10 +102,6 @@ struct LED_871x {
((struct LED_871x *)_LED_871x)->CurrLedState == LED_BLINK_WPS_STOP || \
((struct LED_871x *)_LED_871x)->bLedWPSBlinkInProgress)
 
-#define IS_LED_BLINKING(_LED_871x) \
-   (((struct LED_871x *)_LED_871x)->bLedWPSBlinkInProgress ||  \
-   ((struct LED_871x *)_LED_871x)->bLedScanBlinkInProgress)
-
 void LedControl8188eu(struct adapter *padapter, enum LED_CTL_MODE  
LedAction);
 
 struct led_priv{
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 10/10] staging: rtl8188eu: Remove unused enum LED_CTL_MODE members.

2014-04-20 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/rtw_led.h |   26 --
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_led.h 
b/drivers/staging/rtl8188eu/include/rtw_led.h
index 2ad7e4a..c5194b6 100644
--- a/drivers/staging/rtl8188eu/include/rtw_led.h
+++ b/drivers/staging/rtl8188eu/include/rtw_led.h
@@ -30,20 +30,18 @@
 #define LED_BLINK_WPS_SUCESS_INTERVAL_ALPHA5000
 
 enum LED_CTL_MODE {
-   LED_CTL_POWER_ON = 1,
-   LED_CTL_LINK = 2,
-   LED_CTL_NO_LINK = 3,
-   LED_CTL_TX = 4,
-   LED_CTL_RX = 5,
-   LED_CTL_SITE_SURVEY = 6,
-   LED_CTL_POWER_OFF = 7,
-   LED_CTL_START_TO_LINK = 8,
-   LED_CTL_START_WPS = 9,
-   LED_CTL_STOP_WPS = 10,
-   LED_CTL_START_WPS_BOTTON = 11, /* added for runtop */
-   LED_CTL_STOP_WPS_FAIL = 12, /* added for ALPHA */
-   LED_CTL_STOP_WPS_FAIL_OVERLAP = 13, /* added for BELKIN */
-   LED_CTL_CONNECTION_NO_TRANSFER = 14,
+   LED_CTL_POWER_ON,
+   LED_CTL_LINK,
+   LED_CTL_NO_LINK,
+   LED_CTL_TX,
+   LED_CTL_RX ,
+   LED_CTL_SITE_SURVEY,
+   LED_CTL_POWER_OFF,
+   LED_CTL_START_TO_LINK,
+   LED_CTL_START_WPS,
+   LED_CTL_STOP_WPS,
+   LED_CTL_START_WPS_BOTTON,
+   LED_CTL_STOP_WPS_FAIL
 };
 
 enum LED_STATE_871x {
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

2014-04-22 Thread navin patidar

Hi dan

it's just a cleanup patch and i also tested all patches of this patch
series on the hardware (TP-LINK  TL-WN723N).
my mistake i should have added "Tested-by" tag for all patches.

Tested-by: navin patidar 

regards,
--navin-patidar

On Tue, Apr 22, 2014 at 3:41 PM, Dan Carpenter  wrote:
> On Sun, Apr 20, 2014 at 02:17:11PM +0530, navin patidar wrote:
>> _ReadLEDSetting() doesn't read led settings this function actually
>> initialize  member variables of struct led_priv, we should do that
>> inside rtl8188eu_InitSwLeds().
>>
>
> This seems like a bugfix or is it just a cleanup?  It's not clear to me
> from the patch description.  Have you tested this patch?
>
> regards,
> dan carpenter
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members.

2014-04-22 Thread navin patidar

dan, It is ok to rearrange and remove members of  enum LED_STATE_871x
and  enum LED_CTL_MODE.
these enum are not related to firmware .

regards,
--navin-patidar

On Tue, Apr 22, 2014 at 4:05 PM, Dan Carpenter  wrote:
> It's ok to renumber all of these?  It's not something the firmware will
> care about?  Have you tested this?  Same for patch 10/10.
>
> (These questions are just questions.  I don't ask rhetorical questions
> on email.  I don't know the answers).
>
> regards,
> dan carpenter
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

2014-04-22 Thread navin patidar

On Tue, Apr 22, 2014 at 7:58 PM, Larry Finger  wrote:
>
> To me, the opposite case is true. If you have not tested, then you need to
> explicitly state "compile tested only" in the commit message. Without saying
> that, your signed-off-by is implying that you have tested, as well as
> declaring that you own the copyright to the material.

I didn't know that  signed-off-by implies both tested and authored.
thanks for clearing that up.

regards,
--navin-patidar
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8188eu: Use USB subsystem functions to check endpoint type

2014-04-26 Thread navin patidar

Use inline functions provided by USB subsystem to check endpoint type,
instead of macros implemented by driver to do the same.

Unnecessary debugging messages are also removed.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/os_dep/usb_intf.c |   92 ---
 1 file changed, 14 insertions(+), 78 deletions(-)

diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c 
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 49a4ce4..2960602 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -80,46 +80,6 @@ static struct rtw_usb_drv rtl8188e_usb_drv = {
 
 static struct rtw_usb_drv *usb_drv = &rtl8188e_usb_drv;
 
-static inline int RT_usb_endpoint_dir_in(const struct usb_endpoint_descriptor 
*epd)
-{
-   return (epd->bEndpointAddress & USB_ENDPOINT_DIR_MASK) == USB_DIR_IN;
-}
-
-static inline int RT_usb_endpoint_dir_out(const struct usb_endpoint_descriptor 
*epd)
-{
-   return (epd->bEndpointAddress & USB_ENDPOINT_DIR_MASK) == USB_DIR_OUT;
-}
-
-static inline int RT_usb_endpoint_xfer_int(const struct 
usb_endpoint_descriptor *epd)
-{
-   return (epd->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) == 
USB_ENDPOINT_XFER_INT;
-}
-
-static inline int RT_usb_endpoint_xfer_bulk(const struct 
usb_endpoint_descriptor *epd)
-{
-   return (epd->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) == 
USB_ENDPOINT_XFER_BULK;
-}
-
-static inline int RT_usb_endpoint_is_bulk_in(const struct 
usb_endpoint_descriptor *epd)
-{
-   return RT_usb_endpoint_xfer_bulk(epd) && RT_usb_endpoint_dir_in(epd);
-}
-
-static inline int RT_usb_endpoint_is_bulk_out(const struct 
usb_endpoint_descriptor *epd)
-{
-   return RT_usb_endpoint_xfer_bulk(epd) && RT_usb_endpoint_dir_out(epd);
-}
-
-static inline int usb_endpoint_is_int(const struct usb_endpoint_descriptor 
*epd)
-{
-   return RT_usb_endpoint_xfer_int(epd) && RT_usb_endpoint_dir_in(epd);
-}
-
-static inline int RT_usb_endpoint_num(const struct usb_endpoint_descriptor 
*epd)
-{
-   return epd->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK;
-}
-
 static u8 rtw_init_intf_priv(struct dvobj_priv *dvobj)
 {
u8 rst = _SUCCESS;
@@ -183,60 +143,36 @@ static struct dvobj_priv *usb_dvobj_init(struct 
usb_interface *usb_intf)
pdvobjpriv->nr_endpoint = piface_desc->bNumEndpoints;
 
for (i = 0; i < pdvobjpriv->nr_endpoint; i++) {
+
+   int ep_num;
phost_endp = phost_iface->endpoint + i;
+
if (phost_endp) {
pendp_desc = &phost_endp->desc;
+   ep_num = usb_endpoint_num(pendp_desc);
 
-   DBG_88E("\nusb_endpoint_descriptor(%d):\n", i);
-   DBG_88E("bLength=%x\n", pendp_desc->bLength);
-   DBG_88E("bDescriptorType=%x\n",
-   pendp_desc->bDescriptorType);
-   DBG_88E("bEndpointAddress=%x\n",
-   pendp_desc->bEndpointAddress);
-   DBG_88E("wMaxPacketSize=%d\n",
-   le16_to_cpu(pendp_desc->wMaxPacketSize));
-   DBG_88E("bInterval=%x\n", pendp_desc->bInterval);
-
-   if (RT_usb_endpoint_is_bulk_in(pendp_desc)) {
-   DBG_88E("RT_usb_endpoint_is_bulk_in = %x\n",
-   RT_usb_endpoint_num(pendp_desc));
-   pdvobjpriv->RtInPipe[pdvobjpriv->RtNumInPipes] 
= RT_usb_endpoint_num(pendp_desc);
+   if (usb_endpoint_is_bulk_in(pendp_desc)) {
+   pdvobjpriv->RtInPipe[pdvobjpriv->RtNumInPipes] 
= ep_num;
pdvobjpriv->RtNumInPipes++;
-   } else if (usb_endpoint_is_int(pendp_desc)) {
-   DBG_88E("usb_endpoint_is_int = %x, Interval = 
%x\n",
-   RT_usb_endpoint_num(pendp_desc),
-   pendp_desc->bInterval);
-   pdvobjpriv->RtInPipe[pdvobjpriv->RtNumInPipes] 
= RT_usb_endpoint_num(pendp_desc);
+   } else if (usb_endpoint_is_int_in(pendp_desc)) {
+   pdvobjpriv->RtInPipe[pdvobjpriv->RtNumInPipes] 
= ep_num;
pdvobjpriv->RtNumInPipes++;
-   } else if (RT_usb_endpoint_is_bulk_out(pendp_desc)) {
-   DBG_88E("RT_usb_endpoint_is_bulk_out = %x\n",
-   RT_usb_endpoint_num(pendp_desc));
-   
pdvobjpriv->RtOutPipe[pdvobjpriv->RtNumOutPipes] = 
RT_usb_endpoint_num(pendp_de

[PATCH 1/2] staging: rtl8188eu: Remove debugging messages from usb_dvobj_init()

2014-04-28 Thread navin patidar

Unnecessary debugging messages are removed from usb_dvobj_init().

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/os_dep/usb_intf.c |   34 +++
 1 file changed, 3 insertions(+), 31 deletions(-)

diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c 
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 49a4ce4..8a52829 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -187,30 +187,13 @@ static struct dvobj_priv *usb_dvobj_init(struct 
usb_interface *usb_intf)
if (phost_endp) {
pendp_desc = &phost_endp->desc;
 
-   DBG_88E("\nusb_endpoint_descriptor(%d):\n", i);
-   DBG_88E("bLength=%x\n", pendp_desc->bLength);
-   DBG_88E("bDescriptorType=%x\n",
-   pendp_desc->bDescriptorType);
-   DBG_88E("bEndpointAddress=%x\n",
-   pendp_desc->bEndpointAddress);
-   DBG_88E("wMaxPacketSize=%d\n",
-   le16_to_cpu(pendp_desc->wMaxPacketSize));
-   DBG_88E("bInterval=%x\n", pendp_desc->bInterval);
-
if (RT_usb_endpoint_is_bulk_in(pendp_desc)) {
-   DBG_88E("RT_usb_endpoint_is_bulk_in = %x\n",
-   RT_usb_endpoint_num(pendp_desc));
pdvobjpriv->RtInPipe[pdvobjpriv->RtNumInPipes] 
= RT_usb_endpoint_num(pendp_desc);
pdvobjpriv->RtNumInPipes++;
} else if (usb_endpoint_is_int(pendp_desc)) {
-   DBG_88E("usb_endpoint_is_int = %x, Interval = 
%x\n",
-   RT_usb_endpoint_num(pendp_desc),
-   pendp_desc->bInterval);
pdvobjpriv->RtInPipe[pdvobjpriv->RtNumInPipes] 
= RT_usb_endpoint_num(pendp_desc);
pdvobjpriv->RtNumInPipes++;
} else if (RT_usb_endpoint_is_bulk_out(pendp_desc)) {
-   DBG_88E("RT_usb_endpoint_is_bulk_out = %x\n",
-   RT_usb_endpoint_num(pendp_desc));

pdvobjpriv->RtOutPipe[pdvobjpriv->RtNumOutPipes] = 
RT_usb_endpoint_num(pendp_desc);
pdvobjpriv->RtNumOutPipes++;
}
@@ -218,25 +201,14 @@ static struct dvobj_priv *usb_dvobj_init(struct 
usb_interface *usb_intf)
}
}
 
-   DBG_88E("nr_endpoint=%d, in_num=%d, out_num=%d\n\n",
-   pdvobjpriv->nr_endpoint, pdvobjpriv->RtNumInPipes,
-   pdvobjpriv->RtNumOutPipes);
-
-   if (pusbd->speed == USB_SPEED_HIGH) {
+   if (pusbd->speed == USB_SPEED_HIGH)
pdvobjpriv->ishighspeed = true;
-   DBG_88E("USB_SPEED_HIGH\n");
-   } else {
+   else
pdvobjpriv->ishighspeed = false;
-   DBG_88E("NON USB_SPEED_HIGH\n");
-   }
 
-   if (rtw_init_intf_priv(pdvobjpriv) == _FAIL) {
-   RT_TRACE(_module_os_intfs_c_, _drv_err_,
-("\n Can't INIT rtw_init_intf_priv\n"));
+   if (rtw_init_intf_priv(pdvobjpriv) == _FAIL)
goto free_dvobj;
-   }
 
-   /* 3 misc */
sema_init(&(pdvobjpriv->usb_suspend_sema), 0);
rtw_reset_continual_urb_error(pdvobjpriv);
 
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/2] staging: rtl8188eu: Use USB subsystem functions to check endpoint type

2014-04-28 Thread navin patidar

Use inline functions provided by USB subsystem to check endpoint type,
instead of inline functions implemented by driver to do the same.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/os_dep/usb_intf.c |   57 +--
 1 file changed, 10 insertions(+), 47 deletions(-)

diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c 
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 8a52829..8ed2ac8 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -80,46 +80,6 @@ static struct rtw_usb_drv rtl8188e_usb_drv = {
 
 static struct rtw_usb_drv *usb_drv = &rtl8188e_usb_drv;
 
-static inline int RT_usb_endpoint_dir_in(const struct usb_endpoint_descriptor 
*epd)
-{
-   return (epd->bEndpointAddress & USB_ENDPOINT_DIR_MASK) == USB_DIR_IN;
-}
-
-static inline int RT_usb_endpoint_dir_out(const struct usb_endpoint_descriptor 
*epd)
-{
-   return (epd->bEndpointAddress & USB_ENDPOINT_DIR_MASK) == USB_DIR_OUT;
-}
-
-static inline int RT_usb_endpoint_xfer_int(const struct 
usb_endpoint_descriptor *epd)
-{
-   return (epd->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) == 
USB_ENDPOINT_XFER_INT;
-}
-
-static inline int RT_usb_endpoint_xfer_bulk(const struct 
usb_endpoint_descriptor *epd)
-{
-   return (epd->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) == 
USB_ENDPOINT_XFER_BULK;
-}
-
-static inline int RT_usb_endpoint_is_bulk_in(const struct 
usb_endpoint_descriptor *epd)
-{
-   return RT_usb_endpoint_xfer_bulk(epd) && RT_usb_endpoint_dir_in(epd);
-}
-
-static inline int RT_usb_endpoint_is_bulk_out(const struct 
usb_endpoint_descriptor *epd)
-{
-   return RT_usb_endpoint_xfer_bulk(epd) && RT_usb_endpoint_dir_out(epd);
-}
-
-static inline int usb_endpoint_is_int(const struct usb_endpoint_descriptor 
*epd)
-{
-   return RT_usb_endpoint_xfer_int(epd) && RT_usb_endpoint_dir_in(epd);
-}
-
-static inline int RT_usb_endpoint_num(const struct usb_endpoint_descriptor 
*epd)
-{
-   return epd->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK;
-}
-
 static u8 rtw_init_intf_priv(struct dvobj_priv *dvobj)
 {
u8 rst = _SUCCESS;
@@ -183,21 +143,24 @@ static struct dvobj_priv *usb_dvobj_init(struct 
usb_interface *usb_intf)
pdvobjpriv->nr_endpoint = piface_desc->bNumEndpoints;
 
for (i = 0; i < pdvobjpriv->nr_endpoint; i++) {
+   int ep_num;
phost_endp = phost_iface->endpoint + i;
+
if (phost_endp) {
pendp_desc = &phost_endp->desc;
+   ep_num = usb_endpoint_num(pendp_desc);
 
-   if (RT_usb_endpoint_is_bulk_in(pendp_desc)) {
-   pdvobjpriv->RtInPipe[pdvobjpriv->RtNumInPipes] 
= RT_usb_endpoint_num(pendp_desc);
+   if (usb_endpoint_is_bulk_in(pendp_desc)) {
+   pdvobjpriv->RtInPipe[pdvobjpriv->RtNumInPipes] 
= ep_num;
pdvobjpriv->RtNumInPipes++;
-   } else if (usb_endpoint_is_int(pendp_desc)) {
-   pdvobjpriv->RtInPipe[pdvobjpriv->RtNumInPipes] 
= RT_usb_endpoint_num(pendp_desc);
+   } else if (usb_endpoint_is_int_in(pendp_desc)) {
+   pdvobjpriv->RtInPipe[pdvobjpriv->RtNumInPipes] 
= ep_num;
pdvobjpriv->RtNumInPipes++;
-   } else if (RT_usb_endpoint_is_bulk_out(pendp_desc)) {
-   
pdvobjpriv->RtOutPipe[pdvobjpriv->RtNumOutPipes] = 
RT_usb_endpoint_num(pendp_desc);
+   } else if (usb_endpoint_is_bulk_out(pendp_desc)) {
+   
pdvobjpriv->RtOutPipe[pdvobjpriv->RtNumOutPipes] = ep_num;
pdvobjpriv->RtNumOutPipes++;
}
-   pdvobjpriv->ep_num[i] = RT_usb_endpoint_num(pendp_desc);
+   pdvobjpriv->ep_num[i] = ep_num;
}
}
 
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8188eu: Use USB subsystem functions to check endpoint type

2014-04-28 Thread navin patidar

On Mon, Apr 28, 2014 at 2:55 PM, Dan Carpenter  wrote:
> On Sat, Apr 26, 2014 at 10:13:55PM +0530, navin patidar wrote:
>> Use inline functions provided by USB subsystem to check endpoint type,
>> instead of macros implemented by driver to do the same.
>>
>> Unnecessary debugging messages are also removed.
>>
>
> I like both these changes but they would have been so much easier to
> review if you deleted the debugging messagese in [patch 1/2] and then
> changed the endpoint functions in [patch 2/2].
>
>> @@ -183,60 +143,36 @@ static struct dvobj_priv *usb_dvobj_init(struct 
>> usb_interface *usb_intf)
>>   pdvobjpriv->nr_endpoint = piface_desc->bNumEndpoints;
>>
>>   for (i = 0; i < pdvobjpriv->nr_endpoint; i++) {
>> +
>
> Don't put a blank line here, btw.
>
>> + int ep_num;
>>   phost_endp = phost_iface->endpoint + i;
>
> Anyway, please resend because it needs to be broken into two patches.

dan, I just did that.

regards,
navin patidar
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 00/15] staging: rtl8188eu: clean-up struct recv_buf

2014-05-03 Thread navin patidar

Following patches remove unnecessary member variables of struct recv_buf.

navin patidar (15):
  staging: rtl8188eu: Remove function rtw_dequeue_recvbuf()
  staging: rtl8188eu: Remove function rtw_enqueue_recvbuf_to_head()
  staging: rtl8188eu: Remove function rtw_enqueue_recvbuf()
  staging: rtl8188eu: Remove 'struct list_head list' from struct
recv_buf
  staging: rtl8188eu: Remove 'spinlock_t recvbuf_lock' from struct
recv_buf
  staging: rtl8188eu: Remove 'dma_addr_t dma_transfer_addr' from struct
recv_buf
  staging: rtl8188eu: Remove 'int transfer_len' from struct recv_buf
  staging: rtl8188eu: Remove pdata, phead, ptail and pend from struct
recv_buf
  staging: rtl8188eu: Remove 'irp_pending' from struct recv_buf
  staging: rtl8188eu: Remove 'pallocated_buf' from struct recv_buf
  staging: rtl8188eu: Remove 'alloc_sz' from struct recv_buf
  staging: rtl8188eu: Remove 'u32 len' from struct recv_buf
  staging: rtl8188eu: Remove 'u32 ref_cnt' from struct recv_buf
  staging: rtl8188eu: Remove rtl8188eu_init_recvbuf() function
  staging: rtl8188eu: Remove 'u8 *pbuf' from struct recv_buf

 drivers/staging/rtl8188eu/core/rtw_recv.c |   49 -
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c|   20 -
 drivers/staging/rtl8188eu/hal/usb_ops_linux.c |   17 +--
 drivers/staging/rtl8188eu/include/rtl8188e_recv.h |1 -
 drivers/staging/rtl8188eu/include/rtw_recv.h  |   17 ---
 drivers/staging/rtl8188eu/os_dep/recv_linux.c |   15 +--
 6 files changed, 3 insertions(+), 116 deletions(-)

--
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 01/15] staging: rtl8188eu: Remove function rtw_dequeue_recvbuf()

2014-05-03 Thread navin patidar

rtw_dequeue_recvbuf() is not being used by driver.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c|   25 -
 drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
 2 files changed, 26 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 5c1d2d2..eac5260 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -313,31 +313,6 @@ int rtw_enqueue_recvbuf(struct recv_buf *precvbuf, struct 
__queue *queue)
return _SUCCESS;
 }
 
-struct recv_buf *rtw_dequeue_recvbuf (struct __queue *queue)
-{
-   unsigned long irqL;
-   struct recv_buf *precvbuf;
-   struct list_head *plist, *phead;
-
-   spin_lock_irqsave(&queue->lock, irqL);
-
-   if (_rtw_queue_empty(queue)) {
-   precvbuf = NULL;
-   } else {
-   phead = get_list_head(queue);
-
-   plist = phead->next;
-
-   precvbuf = container_of(plist, struct recv_buf, list);
-
-   rtw_list_delete(&precvbuf->list);
-   }
-
-   spin_unlock_irqrestore(&queue->lock, irqL);
-
-   return precvbuf;
-}
-
 static int recvframe_chkmic(struct adapter *adapter,
struct recv_frame *precvframe)
 {
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index bcbce46..7b95860 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -304,7 +304,6 @@ void rtw_free_recvframe_queue(struct __queue *pframequeue,
 u32 rtw_free_uc_swdec_pending_queue(struct adapter *adapter);
 int rtw_enqueue_recvbuf_to_head(struct recv_buf *buf, struct __queue *queue);
 int rtw_enqueue_recvbuf(struct recv_buf *precvbuf, struct __queue *queue);
-struct recv_buf *rtw_dequeue_recvbuf(struct __queue *queue);
 
 void rtw_reordering_ctrl_timeout_handler(void *pcontext);
 
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 03/15] staging: rtl8188eu: Remove function rtw_enqueue_recvbuf()

2014-05-03 Thread navin patidar

rtw_enqueue_recvbuf() is not being used by driver.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c|   12 
 drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
 2 files changed, 13 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 21aa89d..da26fa5c 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -289,18 +289,6 @@ u32 rtw_free_uc_swdec_pending_queue(struct adapter 
*adapter)
return cnt;
 }
 
-int rtw_enqueue_recvbuf(struct recv_buf *precvbuf, struct __queue *queue)
-{
-   unsigned long irqL;
-   spin_lock_irqsave(&queue->lock, irqL);
-
-   rtw_list_delete(&precvbuf->list);
-
-   rtw_list_insert_tail(&precvbuf->list, get_list_head(queue));
-   spin_unlock_irqrestore(&queue->lock, irqL);
-   return _SUCCESS;
-}
-
 static int recvframe_chkmic(struct adapter *adapter,
struct recv_frame *precvframe)
 {
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 21ce405..677859e 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -302,7 +302,6 @@ int rtw_enqueue_recvframe(struct recv_frame *precvframe, 
struct __queue *queue);
 void rtw_free_recvframe_queue(struct __queue *pframequeue,
  struct __queue *pfree_recv_queue);
 u32 rtw_free_uc_swdec_pending_queue(struct adapter *adapter);
-int rtw_enqueue_recvbuf(struct recv_buf *precvbuf, struct __queue *queue);
 
 void rtw_reordering_ctrl_timeout_handler(void *pcontext);
 
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 02/15] staging: rtl8188eu: Remove function rtw_enqueue_recvbuf_to_head()

2014-05-03 Thread navin patidar

rtw_enqueue_recvbuf_to_head() is not being used by driver.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c|   12 
 drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
 2 files changed, 13 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index eac5260..21aa89d 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -289,18 +289,6 @@ u32 rtw_free_uc_swdec_pending_queue(struct adapter 
*adapter)
return cnt;
 }
 
-int rtw_enqueue_recvbuf_to_head(struct recv_buf *precvbuf, struct __queue 
*queue)
-{
-   spin_lock_bh(&queue->lock);
-
-   rtw_list_delete(&precvbuf->list);
-   rtw_list_insert_head(&precvbuf->list, get_list_head(queue));
-
-   spin_unlock_bh(&queue->lock);
-
-   return _SUCCESS;
-}
-
 int rtw_enqueue_recvbuf(struct recv_buf *precvbuf, struct __queue *queue)
 {
unsigned long irqL;
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 7b95860..21ce405 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -302,7 +302,6 @@ int rtw_enqueue_recvframe(struct recv_frame *precvframe, 
struct __queue *queue);
 void rtw_free_recvframe_queue(struct __queue *pframequeue,
  struct __queue *pfree_recv_queue);
 u32 rtw_free_uc_swdec_pending_queue(struct adapter *adapter);
-int rtw_enqueue_recvbuf_to_head(struct recv_buf *buf, struct __queue *queue);
 int rtw_enqueue_recvbuf(struct recv_buf *precvbuf, struct __queue *queue);
 
 void rtw_reordering_ctrl_timeout_handler(void *pcontext);
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 04/15] staging: rtl8188eu: Remove 'struct list_head list' from struct recv_buf

2014-05-03 Thread navin patidar

Users of 'struct list_head list' variable e.g. rtw_enqueue_recvbuf(),
rtw_enqueue_recvbuf_to_head() and rtw_dequeue_recvbuf() are
already removed.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
 drivers/staging/rtl8188eu/include/rtw_recv.h   |1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index b1b1584..98a79ba 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -71,7 +71,6 @@ int   rtl8188eu_init_recv_priv(struct adapter *padapter)
precvbuf = (struct recv_buf *)precvpriv->precv_buf;
 
for (i = 0; i < NR_RECVBUFF; i++) {
-   _rtw_init_listhead(&precvbuf->list);
spin_lock_init(&precvbuf->recvbuf_lock);
precvbuf->alloc_sz = MAX_RECVBUF_SZ;
res = rtw_os_recvbuf_resource_alloc(padapter, precvbuf);
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 677859e..103849f 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -235,7 +235,6 @@ struct sta_recv_priv {
 };
 
 struct recv_buf {
-   struct list_head list;
spinlock_t recvbuf_lock;
u32 ref_cnt;
struct adapter *adapter;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 05/15] staging: rtl8188eu: Remove 'spinlock_t recvbuf_lock' from struct recv_buf

2014-05-03 Thread navin patidar

recvbuf_lock is initialized inside rtl8188eu_init_recv_priv() but never used.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
 drivers/staging/rtl8188eu/include/rtw_recv.h   |1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index 98a79ba..52d83a4 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -71,7 +71,6 @@ int   rtl8188eu_init_recv_priv(struct adapter *padapter)
precvbuf = (struct recv_buf *)precvpriv->precv_buf;
 
for (i = 0; i < NR_RECVBUFF; i++) {
-   spin_lock_init(&precvbuf->recvbuf_lock);
precvbuf->alloc_sz = MAX_RECVBUF_SZ;
res = rtw_os_recvbuf_resource_alloc(padapter, precvbuf);
if (res == _FAIL)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 103849f..4a19a06 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -235,7 +235,6 @@ struct sta_recv_priv {
 };
 
 struct recv_buf {
-   spinlock_t recvbuf_lock;
u32 ref_cnt;
struct adapter *adapter;
u8  *pbuf;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 06/15] staging: rtl8188eu: Remove 'dma_addr_t dma_transfer_addr' from struct recv_buf

2014-05-03 Thread navin patidar

Remove unused variable dma_transfer_addr.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 4a19a06..bf9af77 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -245,7 +245,6 @@ struct recv_buf {
u8  *ptail;
u8  *pend;
struct urb *purb;
-   dma_addr_t dma_transfer_addr;   /* (in) dma addr for transfer_buffer */
u32 alloc_sz;
u8  irp_pending;
int  transfer_len;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 07/15] staging: rtl8188eu: Remove 'int transfer_len' from struct recv_buf

2014-05-03 Thread navin patidar

Driver is not making any use of value stored in this variable.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |2 --
 drivers/staging/rtl8188eu/hal/usb_ops_linux.c  |1 -
 drivers/staging/rtl8188eu/include/rtw_recv.h   |1 -
 drivers/staging/rtl8188eu/os_dep/recv_linux.c  |1 -
 4 files changed, 5 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index 52d83a4..ee7fa64 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -30,8 +30,6 @@
 
 void rtl8188eu_init_recvbuf(struct adapter *padapter, struct recv_buf 
*precvbuf)
 {
-   precvbuf->transfer_len = 0;
-
precvbuf->len = 0;
 
precvbuf->ref_cnt = 0;
diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c 
b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
index 1fa5370..285cb5f 100644
--- a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
+++ b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
@@ -518,7 +518,6 @@ static void usb_read_port_complete(struct urb *purb, struct 
pt_regs *regs)
} else {
rtw_reset_continual_urb_error(adapter_to_dvobj(adapt));
 
-   precvbuf->transfer_len = purb->actual_length;
skb_put(precvbuf->pskb, purb->actual_length);
skb_queue_tail(&precvpriv->rx_skb_queue, 
precvbuf->pskb);
 
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index bf9af77..cac8acb 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -247,7 +247,6 @@ struct recv_buf {
struct urb *purb;
u32 alloc_sz;
u8  irp_pending;
-   int  transfer_len;
struct sk_buff *pskb;
u8  reuse;
 };
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index da397e4..0838339 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -67,7 +67,6 @@ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter,
precvbuf->phead = NULL;
precvbuf->ptail = NULL;
precvbuf->pend = NULL;
-   precvbuf->transfer_len = 0;
precvbuf->len = 0;
return res;
 }
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 08/15] staging: rtl8188eu: Remove pdata, phead, ptail and pend from struct recv_buf

2014-05-03 Thread navin patidar

Driver is not making use of value stored in removed variables.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |8 
 drivers/staging/rtl8188eu/hal/usb_ops_linux.c  |9 -
 drivers/staging/rtl8188eu/include/rtw_recv.h   |4 
 drivers/staging/rtl8188eu/os_dep/recv_linux.c  |4 
 4 files changed, 25 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index ee7fa64..41a0c0d 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -31,15 +31,7 @@
 void rtl8188eu_init_recvbuf(struct adapter *padapter, struct recv_buf 
*precvbuf)
 {
precvbuf->len = 0;
-
precvbuf->ref_cnt = 0;
-
-   if (precvbuf->pbuf) {
-   precvbuf->pdata = precvbuf->pbuf;
-   precvbuf->phead = precvbuf->pbuf;
-   precvbuf->ptail = precvbuf->pbuf;
-   precvbuf->pend = precvbuf->pdata + MAX_RECVBUF_SZ;
-   }
 }
 
 intrtl8188eu_init_recv_priv(struct adapter *padapter)
diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c 
b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
index 285cb5f..654c5b3 100644
--- a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
+++ b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
@@ -615,18 +615,9 @@ static u32 usb_read_port(struct intf_hdl *pintfhdl, u32 
addr, u32 cnt, u8 *rmem)
alignment = tmpaddr & (RECVBUFF_ALIGN_SZ-1);
skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
 
-   precvbuf->phead = precvbuf->pskb->head;
-   precvbuf->pdata = precvbuf->pskb->data;
-   precvbuf->ptail = skb_tail_pointer(precvbuf->pskb);
-   precvbuf->pend = skb_end_pointer(precvbuf->pskb);
precvbuf->pbuf = precvbuf->pskb->data;
} else { /* reuse skb */
-   precvbuf->phead = precvbuf->pskb->head;
-   precvbuf->pdata = precvbuf->pskb->data;
-   precvbuf->ptail = skb_tail_pointer(precvbuf->pskb);
-   precvbuf->pend = skb_end_pointer(precvbuf->pskb);
precvbuf->pbuf = precvbuf->pskb->data;
-
precvbuf->reuse = false;
}
 
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index cac8acb..8d3424b 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -240,10 +240,6 @@ struct recv_buf {
u8  *pbuf;
u8  *pallocated_buf;
u32 len;
-   u8  *phead;
-   u8  *pdata;
-   u8  *ptail;
-   u8  *pend;
struct urb *purb;
u32 alloc_sz;
u8  irp_pending;
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 0838339..99b5910 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -63,10 +63,6 @@ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter,
precvbuf->reuse = false;
precvbuf->pallocated_buf = NULL;
precvbuf->pbuf = NULL;
-   precvbuf->pdata = NULL;
-   precvbuf->phead = NULL;
-   precvbuf->ptail = NULL;
-   precvbuf->pend = NULL;
precvbuf->len = 0;
return res;
 }
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 10/15] staging: rtl8188eu: Remove 'pallocated_buf' from struct recv_buf

2014-05-03 Thread navin patidar

pallocated_buf is not being used by driver.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/rtw_recv.h  |1 -
 drivers/staging/rtl8188eu/os_dep/recv_linux.c |1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 987445a..b955d73 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -238,7 +238,6 @@ struct recv_buf {
u32 ref_cnt;
struct adapter *adapter;
u8  *pbuf;
-   u8  *pallocated_buf;
u32 len;
struct urb *purb;
u32 alloc_sz;
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 7f9b654..25358fb 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -60,7 +60,6 @@ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter,
res = _FAIL;
precvbuf->pskb = NULL;
precvbuf->reuse = false;
-   precvbuf->pallocated_buf = NULL;
precvbuf->pbuf = NULL;
precvbuf->len = 0;
return res;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 11/15] staging: rtl8188eu: Remove 'alloc_sz' from struct recv_buf

2014-05-03 Thread navin patidar

Driver isn't making any use of value stored in alloc_sz variable.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
 drivers/staging/rtl8188eu/include/rtw_recv.h   |1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index 41a0c0d..3edc2cd 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -61,7 +61,6 @@ int   rtl8188eu_init_recv_priv(struct adapter *padapter)
precvbuf = (struct recv_buf *)precvpriv->precv_buf;
 
for (i = 0; i < NR_RECVBUFF; i++) {
-   precvbuf->alloc_sz = MAX_RECVBUF_SZ;
res = rtw_os_recvbuf_resource_alloc(padapter, precvbuf);
if (res == _FAIL)
break;
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index b955d73..519ed4e 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -240,7 +240,6 @@ struct recv_buf {
u8  *pbuf;
u32 len;
struct urb *purb;
-   u32 alloc_sz;
struct sk_buff *pskb;
u8  reuse;
 };
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 12/15] staging: rtl8188eu: Remove 'u32 len' from struct recv_buf

2014-05-03 Thread navin patidar

Remove unused variable 'u32 len'.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
 drivers/staging/rtl8188eu/include/rtw_recv.h   |1 -
 drivers/staging/rtl8188eu/os_dep/recv_linux.c  |1 -
 3 files changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index 3edc2cd..740818a5 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -30,7 +30,6 @@
 
 void rtl8188eu_init_recvbuf(struct adapter *padapter, struct recv_buf 
*precvbuf)
 {
-   precvbuf->len = 0;
precvbuf->ref_cnt = 0;
 }
 
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 519ed4e..3f43f11 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -238,7 +238,6 @@ struct recv_buf {
u32 ref_cnt;
struct adapter *adapter;
u8  *pbuf;
-   u32 len;
struct urb *purb;
struct sk_buff *pskb;
u8  reuse;
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 25358fb..2577ceb6 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -61,7 +61,6 @@ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter,
precvbuf->pskb = NULL;
precvbuf->reuse = false;
precvbuf->pbuf = NULL;
-   precvbuf->len = 0;
return res;
 }
 
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 09/15] staging: rtl8188eu: Remove 'irp_pending' from struct recv_buf

2014-05-03 Thread navin patidar

irp_pending is initialized to false inside rtw_os_recvbuf_resource_alloc()
and value of irq_pending never changed after that, so 'if 
(!precvbuf->irp_pending)'
inside rtw_os_read_port() function will be always true.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/rtw_recv.h  |1 -
 drivers/staging/rtl8188eu/os_dep/recv_linux.c |6 ++
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 8d3424b..987445a 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -242,7 +242,6 @@ struct recv_buf {
u32 len;
struct urb *purb;
u32 alloc_sz;
-   u8  irp_pending;
struct sk_buff *pskb;
u8  reuse;
 };
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 99b5910..7f9b654 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -55,7 +55,6 @@ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter,
 {
int res = _SUCCESS;
 
-   precvbuf->irp_pending = false;
precvbuf->purb = usb_alloc_urb(0, GFP_KERNEL);
if (precvbuf->purb == NULL)
res = _FAIL;
@@ -229,9 +228,8 @@ void rtw_os_read_port(struct adapter *padapter, struct 
recv_buf *precvbuf)
dev_kfree_skb_any(precvbuf->pskb);
precvbuf->pskb = NULL;
precvbuf->reuse = false;
-   if (!precvbuf->irp_pending)
-   rtw_read_port(padapter, precvpriv->ff_hwaddr, 0,
- (unsigned char *)precvbuf);
+   rtw_read_port(padapter, precvpriv->ff_hwaddr, 0,
+   (unsigned char *)precvbuf);
 }
 
 static void _rtw_reordering_ctrl_timeout_handler(void *func_context)
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 13/15] staging: rtl8188eu: Remove 'u32 ref_cnt' from struct recv_buf

2014-05-03 Thread navin patidar

Driver isn't making any use of value stored in variable ref_cnt.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |2 --
 drivers/staging/rtl8188eu/include/rtw_recv.h   |1 -
 drivers/staging/rtl8188eu/os_dep/recv_linux.c  |1 -
 3 files changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index 740818a5..fc06991 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -30,7 +30,6 @@
 
 void rtl8188eu_init_recvbuf(struct adapter *padapter, struct recv_buf 
*precvbuf)
 {
-   precvbuf->ref_cnt = 0;
 }
 
 intrtl8188eu_init_recv_priv(struct adapter *padapter)
@@ -63,7 +62,6 @@ int   rtl8188eu_init_recv_priv(struct adapter *padapter)
res = rtw_os_recvbuf_resource_alloc(padapter, precvbuf);
if (res == _FAIL)
break;
-   precvbuf->ref_cnt = 0;
precvbuf->adapter = padapter;
precvbuf++;
}
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 3f43f11..8dadf30 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -235,7 +235,6 @@ struct sta_recv_priv {
 };
 
 struct recv_buf {
-   u32 ref_cnt;
struct adapter *adapter;
u8  *pbuf;
struct urb *purb;
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 2577ceb6..c1664b7 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -221,7 +221,6 @@ void rtw_os_read_port(struct adapter *padapter, struct 
recv_buf *precvbuf)
 {
struct recv_priv *precvpriv = &padapter->recvpriv;
 
-   precvbuf->ref_cnt--;
/* free skb in recv_buf */
dev_kfree_skb_any(precvbuf->pskb);
precvbuf->pskb = NULL;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 14/15] staging: rtl8188eu: Remove rtl8188eu_init_recvbuf() function

2014-05-03 Thread navin patidar

rtl8188eu_init_recvbuf() function definition is empty now,
so remove it.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c|4 
 drivers/staging/rtl8188eu/hal/usb_ops_linux.c |2 --
 drivers/staging/rtl8188eu/include/rtl8188e_recv.h |1 -
 3 files changed, 7 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index fc06991..2b45564 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -28,10 +28,6 @@
 
 #include 
 
-void rtl8188eu_init_recvbuf(struct adapter *padapter, struct recv_buf 
*precvbuf)
-{
-}
-
 intrtl8188eu_init_recv_priv(struct adapter *padapter)
 {
struct recv_priv*precvpriv = &padapter->recvpriv;
diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c 
b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
index 654c5b3..d3c5ed3 100644
--- a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
+++ b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
@@ -600,8 +600,6 @@ static u32 usb_read_port(struct intf_hdl *pintfhdl, u32 
addr, u32 cnt, u8 *rmem)
precvbuf->reuse = true;
}
 
-   rtl8188eu_init_recvbuf(adapter, precvbuf);
-
/* re-assign for linux based on skb */
if ((!precvbuf->reuse) || (precvbuf->pskb == NULL)) {
precvbuf->pskb = netdev_alloc_skb(adapter->pnetdev, 
MAX_RECVBUF_SZ + RECVBUFF_ALIGN_SZ);
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_recv.h 
b/drivers/staging/rtl8188eu/include/rtl8188e_recv.h
index 07e5f52..5fed30d 100644
--- a/drivers/staging/rtl8188eu/include/rtl8188e_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtl8188e_recv.h
@@ -56,7 +56,6 @@ enum rx_packet_type {
 };
 
 #define INTERRUPT_MSG_FORMAT_LEN 60
-void rtl8188eu_init_recvbuf(struct adapter *padapter, struct recv_buf *buf);
 s32 rtl8188eu_init_recv_priv(struct adapter *padapter);
 void rtl8188eu_free_recv_priv(struct adapter *padapter);
 void rtl8188eu_recv_hdl(struct adapter *padapter, struct recv_buf *precvbuf);
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 15/15] staging: rtl8188eu: Remove 'u8 *pbuf' from struct recv_buf

2014-05-03 Thread navin patidar

Instead of using pbuf to pass sbk data pointer to usb_fill_bulk_urb(),
we can use precvbuf->pskb->data to do that.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/usb_ops_linux.c |5 +
 drivers/staging/rtl8188eu/include/rtw_recv.h  |1 -
 drivers/staging/rtl8188eu/os_dep/recv_linux.c |1 -
 3 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c 
b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
index d3c5ed3..d8fc747 100644
--- a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
+++ b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
@@ -612,10 +612,7 @@ static u32 usb_read_port(struct intf_hdl *pintfhdl, u32 
addr, u32 cnt, u8 *rmem)
tmpaddr = (size_t)precvbuf->pskb->data;
alignment = tmpaddr & (RECVBUFF_ALIGN_SZ-1);
skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
-
-   precvbuf->pbuf = precvbuf->pskb->data;
} else { /* reuse skb */
-   precvbuf->pbuf = precvbuf->pskb->data;
precvbuf->reuse = false;
}
 
@@ -627,7 +624,7 @@ static u32 usb_read_port(struct intf_hdl *pintfhdl, u32 
addr, u32 cnt, u8 *rmem)
pipe = ffaddr2pipehdl(pdvobj, addr);
 
usb_fill_bulk_urb(purb, pusbd, pipe,
- precvbuf->pbuf,
+ precvbuf->pskb->data,
  MAX_RECVBUF_SZ,
  usb_read_port_complete,
  precvbuf);/* context is precvbuf */
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 8dadf30..971dd16 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -236,7 +236,6 @@ struct sta_recv_priv {
 
 struct recv_buf {
struct adapter *adapter;
-   u8  *pbuf;
struct urb *purb;
struct sk_buff *pskb;
u8  reuse;
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index c1664b7..29ec014 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -60,7 +60,6 @@ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter,
res = _FAIL;
precvbuf->pskb = NULL;
precvbuf->reuse = false;
-   precvbuf->pbuf = NULL;
return res;
 }
 
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 04/13] staging: rtl8188eu: Remove struct zero_bulkout_context

2014-05-06 Thread navin . patidar

From: navin patidar 

Remove unused struct zero_bulkout_context.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |7 ---
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c 
b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
index fb0bba8..ba2a8ab 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
@@ -39,13 +39,6 @@ unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 
addr)
return pipe;
 }
 
-struct zero_bulkout_context {
-   void *pbuf;
-   void *purb;
-   void *pirp;
-   void *padapter;
-};
-
 void usb_read_mem(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *rmem)
 {
 }
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 00/13]staging: rtl8188eu: Remove unused functions and variables

2014-05-06 Thread navin . patidar

From: navin patidar 

Following patches remove unused functions, variables and functions with empty
definition.

navin patidar (13):
  staging: rtl8188eu: Remove 'semaphore allrxreturnevt' from struct
recv_priv
  staging: rtl8188eu: Remove unused member variables of struct
recv_priv
  staging: rtl8188eu: Remove 'spinlock_t lock' from struct recv_priv
  staging: rtl8188eu: Remove struct zero_bulkout_context
  staging: rtl8188eu: Remove function rtw_os_recv_resource_init()
  staging: rtl8188eu: Remove function rtw_os_recv_resource_free()
  staging: rtl8188eu: Remove function rtw_hostapd_mlme_rx()
  staging: rtl8188eu: Remove function rtw_os_recvbuf_resource_free()
  staging: rtl8188eu: Remove unused inline function recvframe_push()
  staging: rtl8188eu: Remove unused inline function get_rx_status()
  staging: rtl8188eu: Remove 'void  *precvbuf' from struct recv_frame
  staging: rtl8188eu: Remove 'int frame_tag' from struct recv_frame
  staging: rtl8188eu: Remove 'u8 fragcnt' from struct recv_frame

 drivers/staging/rtl8188eu/core/rtw_mlme_ext.c|2 --
 drivers/staging/rtl8188eu/core/rtw_recv.c|8 -
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c   |2 +-
 drivers/staging/rtl8188eu/hal/usb_ops_linux.c|1 -
 drivers/staging/rtl8188eu/include/recv_osdep.h   |4 ---
 drivers/staging/rtl8188eu/include/rtw_recv.h |   36 --
 drivers/staging/rtl8188eu/os_dep/recv_linux.c|   25 ---
 drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |7 -
 8 files changed, 1 insertion(+), 84 deletions(-)

--
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 03/13] staging: rtl8188eu: Remove 'spinlock_t lock' from struct recv_priv

2014-05-06 Thread navin . patidar

From: navin patidar 

Remove unused variable 'spinlock_t lock'.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c|2 --
 drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
 2 files changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index a065a7f..5260fe5 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -63,8 +63,6 @@ int _rtw_init_recv_priv(struct recv_priv *precvpriv, struct 
adapter *padapter)
 
int res = _SUCCESS;
 
-   spin_lock_init(&precvpriv->lock);
-
_rtw_init_queue(&precvpriv->free_recv_queue);
_rtw_init_queue(&precvpriv->recv_pending_queue);
_rtw_init_queue(&precvpriv->uc_swdec_pending_queue);
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index d52cfe8..68c2ad5f 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -175,7 +175,6 @@ recv_thread(passive) ; returnpkt(dispatch)
 using enter_critical section to protect
 */
 struct recv_priv {
-   spinlock_t lock;
struct __queue free_recv_queue;
struct __queue recv_pending_queue;
struct __queue uc_swdec_pending_queue;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 05/13] staging: rtl8188eu: Remove function rtw_os_recv_resource_init()

2014-05-06 Thread navin . patidar

From: navin patidar 

rtw_os_recv_resource_init() has empty defination, so we can remove it.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c  |2 --
 drivers/staging/rtl8188eu/include/recv_osdep.h |1 -
 drivers/staging/rtl8188eu/os_dep/recv_linux.c  |7 ---
 3 files changed, 10 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 5260fe5..56b1ef1 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -71,8 +71,6 @@ int _rtw_init_recv_priv(struct recv_priv *precvpriv, struct 
adapter *padapter)
 
precvpriv->free_recvframe_cnt = NR_RECVFRAME;
 
-   rtw_os_recv_resource_init(precvpriv, padapter);
-
precvpriv->pallocated_frame_buf = vzalloc(NR_RECVFRAME * sizeof(struct 
recv_frame) + RXFRAME_ALIGN_SZ);
 
if (precvpriv->pallocated_frame_buf == NULL) {
diff --git a/drivers/staging/rtl8188eu/include/recv_osdep.h 
b/drivers/staging/rtl8188eu/include/recv_osdep.h
index d76cc2d..f49ac56 100644
--- a/drivers/staging/rtl8188eu/include/recv_osdep.h
+++ b/drivers/staging/rtl8188eu/include/recv_osdep.h
@@ -39,7 +39,6 @@ void rtw_handle_tkip_mic_err(struct adapter *padapter, u8 
bgroup);
 int rtw_init_recv_priv(struct recv_priv *precvpriv, struct adapter *padapter);
 void rtw_free_recv_priv(struct recv_priv *precvpriv);
 
-int rtw_os_recv_resource_init(struct recv_priv *recvpr, struct adapter *adapt);
 int rtw_os_recv_resource_alloc(struct adapter *adapt,
   struct recv_frame *recvfr);
 void rtw_os_recv_resource_free(struct recv_priv *precvpriv);
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 29ec014..c1fbe8d 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -28,13 +28,6 @@
 #include 
 #include 
 
-/* init os related resource in struct recv_priv */
-int rtw_os_recv_resource_init(struct recv_priv *precvpriv,
- struct adapter *padapter)
-{
-   return _SUCCESS;
-}
-
 /* alloc os related resource in struct recv_frame */
 int rtw_os_recv_resource_alloc(struct adapter *padapter,
   struct recv_frame *precvframe)
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 02/13] staging: rtl8188eu: Remove unused member variables of struct recv_priv

2014-05-06 Thread navin . patidar

From: navin patidar 

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/rtw_recv.h |6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 5b3bf29..d52cfe8 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -189,10 +189,6 @@ struct recv_priv {
u64 rx_drop;
u64 last_rx_bytes;
 
-   uint  rx_icv_err;
-   uint  rx_largepacket_crcerr;
-   uint  rx_smallpacket_crcerr;
-   uint  rx_middlepacket_crcerr;
uintff_hwaddr;
u8  rx_pending_cnt;
 
@@ -212,9 +208,7 @@ struct recv_priv {
u8 signal_strength;
u8 signal_qual;
u8 noise;
-   int RxSNRdB[2];
s8 RxRssi[2];
-   int FalseAlmCnt_all;
 
struct timer_list signal_stat_timer;
u32 signal_stat_sampling_interval;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 01/13] staging: rtl8188eu: Remove 'semaphore allrxreturnevt' from struct recv_priv

2014-05-06 Thread navin . patidar

From: navin patidar 

Remove unused variable 'semaphore allrxreturnevt'.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c|2 --
 drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
 2 files changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index da26fa5c..a065a7f 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -101,8 +101,6 @@ int _rtw_init_recv_priv(struct recv_priv *precvpriv, struct 
adapter *padapter)
}
precvpriv->rx_pending_cnt = 1;
 
-   sema_init(&precvpriv->allrxreturnevt, 0);
-
res = rtw_hal_init_recv_priv(padapter);
 
_init_timer(&precvpriv->signal_stat_timer, padapter->pnetdev, 
RTW_TIMER_HDL_NAME(signal_stat), padapter);
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 971dd16..5b3bf29 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -193,7 +193,6 @@ struct recv_priv {
uint  rx_largepacket_crcerr;
uint  rx_smallpacket_crcerr;
uint  rx_middlepacket_crcerr;
-   struct semaphore allrxreturnevt;
uintff_hwaddr;
u8  rx_pending_cnt;
 
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 07/13] staging: rtl8188eu: Remove function rtw_hostapd_mlme_rx()

2014-05-06 Thread navin . patidar

From: navin patidar 

rtw_hostapd_mlme_rx() has empty defination, so we can remove it.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_mlme_ext.c  |2 --
 drivers/staging/rtl8188eu/include/recv_osdep.h |1 -
 drivers/staging/rtl8188eu/os_dep/recv_linux.c  |5 -
 3 files changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c 
b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
index 55be52f..e854732 100644
--- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
@@ -502,8 +502,6 @@ void mgt_dispatcher(struct adapter *padapter, struct 
recv_frame *precv_frame)
break;
default:
_mgt_dispatcher(padapter, ptable, precv_frame);
-   if (check_fwstate(pmlmepriv, WIFI_AP_STATE))
-   rtw_hostapd_mlme_rx(padapter, precv_frame);
break;
}
 #else
diff --git a/drivers/staging/rtl8188eu/include/recv_osdep.h 
b/drivers/staging/rtl8188eu/include/recv_osdep.h
index 44caea9..5333598 100644
--- a/drivers/staging/rtl8188eu/include/recv_osdep.h
+++ b/drivers/staging/rtl8188eu/include/recv_osdep.h
@@ -33,7 +33,6 @@ int rtw_recv_indicatepkt(struct adapter *adapter,
 struct recv_frame *recv_frame);
 void rtw_recv_returnpacket(struct  net_device *cnxt, struct sk_buff *retpkt);
 
-void rtw_hostapd_mlme_rx(struct adapter *padapter, struct recv_frame *recv_fr);
 void rtw_handle_tkip_mic_err(struct adapter *padapter, u8 bgroup);
 
 int rtw_init_recv_priv(struct recv_priv *precvpriv, struct adapter *padapter);
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index d1ce639..edb7969 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -95,11 +95,6 @@ void rtw_handle_tkip_mic_err(struct adapter *padapter, u8 
bgroup)
&wrqu, (char *)&ev);
 }
 
-void rtw_hostapd_mlme_rx(struct adapter *padapter,
-struct recv_frame *precv_frame)
-{
-}
-
 int rtw_recv_indicatepkt(struct adapter *padapter,
 struct recv_frame *precv_frame)
 {
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 06/13] staging: rtl8188eu: Remove function rtw_os_recv_resource_free()

2014-05-06 Thread navin . patidar

From: navin patidar 

rtw_os_recv_resource_free() has empty defination, so we can remove it.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c  |2 --
 drivers/staging/rtl8188eu/include/recv_osdep.h |1 -
 drivers/staging/rtl8188eu/os_dep/recv_linux.c  |5 -
 3 files changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 56b1ef1..db6ab4f 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -117,8 +117,6 @@ void _rtw_free_recv_priv (struct recv_priv *precvpriv)
 
rtw_free_uc_swdec_pending_queue(padapter);
 
-   rtw_os_recv_resource_free(precvpriv);
-
if (precvpriv->pallocated_frame_buf) {
vfree(precvpriv->pallocated_frame_buf);
}
diff --git a/drivers/staging/rtl8188eu/include/recv_osdep.h 
b/drivers/staging/rtl8188eu/include/recv_osdep.h
index f49ac56..44caea9 100644
--- a/drivers/staging/rtl8188eu/include/recv_osdep.h
+++ b/drivers/staging/rtl8188eu/include/recv_osdep.h
@@ -41,7 +41,6 @@ void rtw_free_recv_priv(struct recv_priv *precvpriv);
 
 int rtw_os_recv_resource_alloc(struct adapter *adapt,
   struct recv_frame *recvfr);
-void rtw_os_recv_resource_free(struct recv_priv *precvpriv);
 
 int rtw_os_recvbuf_resource_alloc(struct adapter *adapt, struct recv_buf *buf);
 int rtw_os_recvbuf_resource_free(struct adapter *adapt, struct recv_buf *buf);
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index c1fbe8d..d1ce639 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -37,11 +37,6 @@ int rtw_os_recv_resource_alloc(struct adapter *padapter,
return _SUCCESS;
 }
 
-/* free os related resource in struct recv_frame */
-void rtw_os_recv_resource_free(struct recv_priv *precvpriv)
-{
-}
-
 /* alloc os related resource in struct recv_buf */
 int rtw_os_recvbuf_resource_alloc(struct adapter *padapter,
  struct recv_buf *precvbuf)
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 08/13] staging: rtl8188eu: Remove function rtw_os_recvbuf_resource_free()

2014-05-06 Thread navin . patidar

From: navin patidar 

Use usb_free_urb() instead of rtw_os_recvbuf_resource_free() to free URB.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |2 +-
 drivers/staging/rtl8188eu/include/recv_osdep.h |1 -
 drivers/staging/rtl8188eu/os_dep/recv_linux.c  |8 
 3 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c 
b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index 2b45564..0f6222d 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -97,7 +97,7 @@ void rtl8188eu_free_recv_priv(struct adapter *padapter)
precvbuf = (struct recv_buf *)precvpriv->precv_buf;
 
for (i = 0; i < NR_RECVBUFF; i++) {
-   rtw_os_recvbuf_resource_free(padapter, precvbuf);
+   usb_free_urb(precvbuf->purb);
precvbuf++;
}
 
diff --git a/drivers/staging/rtl8188eu/include/recv_osdep.h 
b/drivers/staging/rtl8188eu/include/recv_osdep.h
index 5333598..a4fd957 100644
--- a/drivers/staging/rtl8188eu/include/recv_osdep.h
+++ b/drivers/staging/rtl8188eu/include/recv_osdep.h
@@ -42,7 +42,6 @@ int rtw_os_recv_resource_alloc(struct adapter *adapt,
   struct recv_frame *recvfr);
 
 int rtw_os_recvbuf_resource_alloc(struct adapter *adapt, struct recv_buf *buf);
-int rtw_os_recvbuf_resource_free(struct adapter *adapt, struct recv_buf *buf);
 
 void rtw_os_read_port(struct adapter *padapter, struct recv_buf *precvbuf);
 
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c 
b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index edb7969..c0fa8fd 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -51,14 +51,6 @@ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter,
return res;
 }
 
-/* free os related resource in struct recv_buf */
-int rtw_os_recvbuf_resource_free(struct adapter *padapter,
-struct recv_buf *precvbuf)
-{
-   usb_free_urb(precvbuf->purb);
-   return _SUCCESS;
-}
-
 void rtw_handle_tkip_mic_err(struct adapter *padapter, u8 bgroup)
 {
union iwreq_data wrqu;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 10/13] staging: rtl8188eu: Remove unused inline function get_rx_status()

2014-05-06 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/rtw_recv.h |5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index e5b4e10..dac2e0c 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -291,11 +291,6 @@ static inline u8 *get_rxmem(struct recv_frame *precvframe)
return precvframe->rx_head;
 }
 
-static inline u8 *get_rx_status(struct recv_frame *precvframe)
-{
-   return get_rxmem(precvframe);
-}
-
 static inline u8 *recvframe_pull(struct recv_frame *precvframe, int sz)
 {
/*  rx_data += sz; move rx_data sz bytes  hereafter */
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 11/13] staging: rtl8188eu: Remove 'void *precvbuf' from struct recv_frame

2014-05-06 Thread navin patidar

Remove unused variable 'void *precvbuf'.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/usb_ops_linux.c |1 -
 drivers/staging/rtl8188eu/include/rtw_recv.h  |1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c 
b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
index d8fc747..fc73147 100644
--- a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
+++ b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
@@ -333,7 +333,6 @@ static int recvbuf2recvframe(struct adapter *adapt, struct 
sk_buff *pskb)
}
 
_rtw_init_listhead(&precvframe->list);
-   precvframe->precvbuf = NULL;/* can't access the precvbuf 
for new arch. */
precvframe->len = 0;
 
update_recvframe_attrib_88e(precvframe, prxstat);
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index dac2e0c..e14ba98 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -261,7 +261,6 @@ struct recv_frame {
u8 *rx_data;
u8 *rx_tail;
u8 *rx_end;
-   void *precvbuf;
struct sta_info *psta;
/* for A-MPDU Rx reordering buffer control */
struct recv_reorder_ctrl *preorder_ctrl;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 09/13] staging: rtl8188eu: Remove unused inline function recvframe_push()

2014-05-06 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/rtw_recv.h |   20 
 1 file changed, 20 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 68c2ad5f..e5b4e10 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -296,26 +296,6 @@ static inline u8 *get_rx_status(struct recv_frame 
*precvframe)
return get_rxmem(precvframe);
 }
 
-static inline u8 *recvframe_push(struct recv_frame *precvframe, int sz)
-{
-   /*  append data before rx_data */
-
-   /* add data to the start of recv_frame
- *
- *  This function extends the used data area of the recv_frame at the 
buffer
- *  start. rx_data must be still larger than rx_head, after pushing.
- */
-   if (precvframe == NULL)
-   return NULL;
-   precvframe->rx_data -= sz;
-   if (precvframe->rx_data < precvframe->rx_head) {
-   precvframe->rx_data += sz;
-   return NULL;
-   }
-   precvframe->len += sz;
-   return precvframe->rx_data;
-}
-
 static inline u8 *recvframe_pull(struct recv_frame *precvframe, int sz)
 {
/*  rx_data += sz; move rx_data sz bytes  hereafter */
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 13/13] staging: rtl8188eu: Remove 'u8 fragcnt' from struct recv_frame

2014-05-06 Thread navin patidar

Remove unused variable 'u8 fragcnt'.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index b0fbdbd..f0c26ef 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -253,7 +253,6 @@ struct recv_frame {
struct sk_buff   *pkt;
struct sk_buff   *pkt_newalloc;
struct adapter  *adapter;
-   u8 fragcnt;
struct rx_pkt_attrib attrib;
uint  len;
u8 *rx_head;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 12/13] staging: rtl8188eu: Remove 'int frame_tag' from struct recv_frame

2014-05-06 Thread navin patidar

Remove unused variable 'int frame_tag'.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h 
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index e14ba98..b0fbdbd 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -254,7 +254,6 @@ struct recv_frame {
struct sk_buff   *pkt_newalloc;
struct adapter  *adapter;
u8 fragcnt;
-   int frame_tag;
struct rx_pkt_attrib attrib;
uint  len;
u8 *rx_head;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 00/28] staging: rtl8188eu: Remove unnecessary functions.

2014-05-18 Thread navin patidar

Following patches remove functions which are unused or have empty
definition.

navin patidar (28):
  staging: rtl8188eu: Remove function with empty definition
_InitBeaconMaxError().
  staging: rtl8188eu: Remove function with empty definition
_InitOperationMode()
  staging: rtl8188eu: Remove function with empty definition
_ps_open_RF()
  staging: rtl8188eu: Remove unused function _ps_close_RF()
  staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()
  staging:rtl8188eu:Remove funtion Hal_CustomizeByCustomerID_8188EU()
  staging: rtl8188eu: Remove unused function
rtl8188e_PHY_ConfigRFWithParaFile()
  staging: rtl8188eu: Remove unused function
rtl8192c_PHY_GetHWRegOriginalValue()
  staging: rtl8188eu: Remove unused function
PHY_UpdateTxPowerDbm8188E()
  staging:rtl8188eu: Remove unused function phy_DbmToTxPwrIdx()
  staging: rtl8188eu: Remove unused funtion PHY_GetTxPowerLevel8188E()
  staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()
  staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()
  staging: rtl8188eu: Remove unused structure rf_shadow
  staging: rtl8188eu: Remove unused function rtl8188e_RF_ChangeTxPath()
  staging: rtl8188eu: Remove unused function odm_DIGbyRSSI_LPS()
  staging: rtl8188eu: Remove function odm_DynamicBBPowerSaving()
  staging: rtl8188eu: Remove unused function
odm_DynamicBBPowerSavingInit()
  staging:rtl8188eu: Remove unused function iodm_1R_CCA()
  staging: rtl8188eu: Remove unused function
odm_RefreshRateAdaptiveMaskMP()
  staging: rtl8188eu: Remove unused function
odm_RefreshRateAdaptiveMaskAPADSL()
  staging: rtl8188eu: Remove unused funtion odm_DynamicTxPowerNIC()
  staging: rtl8188eu: Remove unused function
odm_SwAntDivChkAntSwitchCallback()
  staging: rtl8188eu: Remove unused function ConvertTo_dB()
  staging: rtl8188eu: Remove function with empty defination
ODM_CheckPowerStatus()
  staging: rtl8188eu: Remove unused function DM_DIG_LowerBound_88E()
  staging: rtl8188eu: Remove unused function
ODM_DynamicPrimaryCCA_DupRTS()
  staging: rtl8188eu:Remove function with empty defination
odm_DynamicPrimaryCCA()

 drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c |   14 --
 drivers/staging/rtl8188eu/hal/odm.c|  159 ---
 drivers/staging/rtl8188eu/hal/odm_RTL8188E.c   |   24 ---
 drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c|  208 
 drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c|   45 -
 drivers/staging/rtl8188eu/hal/usb_halinit.c|   40 
 drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |1 -
 drivers/staging/rtl8188eu/include/odm_RTL8188E.h   |2 -
 drivers/staging/rtl8188eu/include/rtl8188e_hal.h   |1 -
 9 files changed, 494 deletions(-)

--
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 01/28] staging: rtl8188eu: Remove function with empty definition _InitBeaconMaxError().

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c |8 
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c 
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 617e4c6..9ce6173 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -420,10 +420,6 @@ static void _InitEDCA(struct adapter *Adapter)
rtw_write32(Adapter, REG_EDCA_VO_PARAM, 0x002FA226);
 }
 
-static void _InitBeaconMaxError(struct adapter *Adapter, bool  
InfraMode)
-{
-}
-
 static void _InitRDGSetting(struct adapter *Adapter)
 {
rtw_write8(Adapter, REG_RD_CTRL, 0xFF);
@@ -830,12 +826,8 @@ static u32 rtl8188eu_hal_init(struct adapter *Adapter)
InitUsbAggregationSetting(Adapter);
_InitOperationMode(Adapter);/* todo */
_InitBeaconParameters(Adapter);
-   _InitBeaconMaxError(Adapter, true);
-
-   /*  */
/*  Init CR MACTXEN, MACRXEN after setting RxFF boundary REG_TRXFF_BNDY 
to patch */
/*  Hw bug which Hw initials RxFF boundary size to a value which is 
larger than the real Rx buffer size in 88E. */
-   /*  */
/*  Enable MACTXEN/MACRXEN block */
value16 = rtw_read16(Adapter, REG_CR);
value16 |= (MACTXEN | MACRXEN);
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 03/28] staging: rtl8188eu: Remove function with empty definition _ps_open_RF()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c  |7 ---
 drivers/staging/rtl8188eu/include/rtl8188e_hal.h |1 -
 2 files changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c 
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 2e7b81ce..2fe1135 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -693,7 +693,6 @@ static u32 rtl8188eu_hal_init(struct adapter *Adapter)
HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_BEGIN);
 
if (Adapter->pwrctrlpriv.bkeepfwalive) {
-   _ps_open_RF(Adapter);
 
if (haldata->odmpriv.RFCalibrateInfo.bIQKInitialized) {
PHY_IQCalibrate_8188E(Adapter, true);
@@ -943,12 +942,6 @@ HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_END);
return status;
 }
 
-void _ps_open_RF(struct adapter *adapt)
-{
-   /* here call with bRegSSPwrLvl 1, bRegSSPwrLvl 2 needs to be verified */
-   /* phy_SsPwrSwitch92CU(adapt, rf_on, 1); */
-}
-
 static void _ps_close_RF(struct adapter *adapt)
 {
/* here call with bRegSSPwrLvl 1, bRegSSPwrLvl 2 needs to be verified */
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_hal.h 
b/drivers/staging/rtl8188eu/include/rtl8188e_hal.h
index 75e41c4..fe3b454 100644
--- a/drivers/staging/rtl8188eu/include/rtl8188e_hal.h
+++ b/drivers/staging/rtl8188eu/include/rtl8188e_hal.h
@@ -471,6 +471,5 @@ void rtl8188e_stop_thread(struct adapter *padapter);
 void rtw_IOL_cmd_tx_pkt_buf_dump(struct adapter  *Adapter, int len);
 s32 rtl8188e_iol_efuse_patch(struct adapter *padapter);
 void rtw_cancel_all_timer(struct adapter *padapter);
-void _ps_open_RF(struct adapter *adapt);
 
 #endif /* __RTL8188E_HAL_H__ */
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 02/28] staging: rtl8188eu: Remove function with empty definition _InitOperationMode()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c |5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c 
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 9ce6173..2e7b81ce 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -583,10 +583,6 @@ static void InitUsbAggregationSetting(struct adapter 
*Adapter)
haldata->UsbRxHighSpeedMode = false;
 }
 
-static void _InitOperationMode(struct adapter *Adapter)
-{
-}
-
 static void _InitBeaconParameters(struct adapter *Adapter)
 {
struct hal_data_8188e   *haldata = GET_HAL_DATA(Adapter);
@@ -824,7 +820,6 @@ static u32 rtl8188eu_hal_init(struct adapter *Adapter)
_InitEDCA(Adapter);
_InitRetryFunction(Adapter);
InitUsbAggregationSetting(Adapter);
-   _InitOperationMode(Adapter);/* todo */
_InitBeaconParameters(Adapter);
/*  Init CR MACTXEN, MACRXEN after setting RxFF boundary REG_TRXFF_BNDY 
to patch */
/*  Hw bug which Hw initials RxFF boundary size to a value which is 
larger than the real Rx buffer size in 88E. */
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 04/28] staging: rtl8188eu: Remove unused function _ps_close_RF()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c |7 ---
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c 
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 2fe1135..1a83d31 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -942,12 +942,6 @@ HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_END);
return status;
 }
 
-static void _ps_close_RF(struct adapter *adapt)
-{
-   /* here call with bRegSSPwrLvl 1, bRegSSPwrLvl 2 needs to be verified */
-   /* phy_SsPwrSwitch92CU(adapt, rf_off, 1); */
-}
-
 static void CardDisableRTL8188EU(struct adapter *Adapter)
 {
u8 val8;
@@ -1025,7 +1019,6 @@ static u32 rtl8188eu_hal_deinit(struct adapter *Adapter)
 
DBG_88E("bkeepfwalive(%x)\n", Adapter->pwrctrlpriv.bkeepfwalive);
if (Adapter->pwrctrlpriv.bkeepfwalive) {
-   _ps_close_RF(Adapter);
if ((Adapter->pwrctrlpriv.bHWPwrPindetect) && 
(Adapter->pwrctrlpriv.bHWPowerdown))
rtl8192cu_hw_power_down(Adapter);
} else {
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 06/28] staging:rtl8188eu:Remove funtion Hal_CustomizeByCustomerID_8188EU()

2014-05-18 Thread navin patidar

Function has empty defination.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c |5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c 
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 4c3f8c8..141f85a 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -1133,10 +1133,6 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter 
*adapt, u8 *hwinfo, bool
 eeprom->mac_addr[4], eeprom->mac_addr[5]));
 }
 
-static void Hal_CustomizeByCustomerID_8188EU(struct adapter *adapt)
-{
-}
-
 static void
 readAdapterInfo_8188EU(
struct adapter *adapt
@@ -1163,7 +1159,6 @@ readAdapterInfo_8188EU(
/*  The following part initialize some vars by PG info. */
/*  */
Hal_InitChannelPlan(adapt);
-   Hal_CustomizeByCustomerID_8188EU(adapt);
 }
 
 static void _ReadPROMContent(
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c |8 
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c 
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 1a83d31..4c3f8c8 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -2231,12 +2231,6 @@ static void rtl8188eu_init_default_value(struct adapter 
*adapt)
haldata->odmpriv.RFCalibrateInfo.ThermalValue_HP[i] = 0;
 }
 
-static u8 rtl8188eu_ps_func(struct adapter *Adapter, enum hal_intf_ps_func 
efunc_id, u8 *val)
-{
-   u8 bResult = true;
-   return bResult;
-}
-
 void rtl8188eu_set_hal_ops(struct adapter *adapt)
 {
struct hal_ops  *halfunc = &adapt->HalFunc;
@@ -2277,7 +2271,5 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt)
halfunc->hal_xmit = &rtl8188eu_hal_xmit;
halfunc->mgnt_xmit = &rtl8188eu_mgnt_xmit;
 
-   halfunc->interface_ps_func = &rtl8188eu_ps_func;
-
rtl8188e_set_hal_ops(halfunc);
 }
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 07/28] staging: rtl8188eu: Remove unused function rtl8188e_PHY_ConfigRFWithParaFile()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |   21 -
 1 file changed, 21 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index 8079fc6..b50df3e 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
@@ -631,27 +631,6 @@ int PHY_RFConfig8188E(struct adapter *Adapter)
return rtStatus;
 }
 
-
-/*-
- * Function:PHY_ConfigRFWithParaFile()
- *
- * Overview:This function read RF parameters from general file format, and 
do RF 3-wire
- *
- * Input:  struct adapter *Adapter
- * ps8 pFileName
- * enum rf_radio_path eRFPath
- *
- * Output:  NONE
- *
- * Return:  RT_STATUS_SUCCESS: configuration file exist
- *
- * Note:   Delay may be required for RF configuration
- *---*/
-int rtl8188e_PHY_ConfigRFWithParaFile(struct adapter *Adapter, u8 *pFileName, 
enum rf_radio_path eRFPath)
-{
-   return _SUCCESS;
-}
-
 void
 rtl8192c_PHY_GetHWRegOriginalValue(
struct adapter *Adapter
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 08/28] staging: rtl8188eu: Remove unused function rtl8192c_PHY_GetHWRegOriginalValue()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |   18 --
 1 file changed, 18 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index b50df3e..79f86db 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
@@ -631,24 +631,6 @@ int PHY_RFConfig8188E(struct adapter *Adapter)
return rtStatus;
 }
 
-void
-rtl8192c_PHY_GetHWRegOriginalValue(
-   struct adapter *Adapter
-   )
-{
-   struct hal_data_8188e   *pHalData = GET_HAL_DATA(Adapter);
-
-   /*  read rx initial gain */
-   pHalData->DefaultInitialGain[0] = (u8)PHY_QueryBBReg(Adapter, 
rOFDM0_XAAGCCore1, bMaskByte0);
-   pHalData->DefaultInitialGain[1] = (u8)PHY_QueryBBReg(Adapter, 
rOFDM0_XBAGCCore1, bMaskByte0);
-   pHalData->DefaultInitialGain[2] = (u8)PHY_QueryBBReg(Adapter, 
rOFDM0_XCAGCCore1, bMaskByte0);
-   pHalData->DefaultInitialGain[3] = (u8)PHY_QueryBBReg(Adapter, 
rOFDM0_XDAGCCore1, bMaskByte0);
-
-   /*  read framesync */
-   pHalData->framesync = (u8)PHY_QueryBBReg(Adapter, rOFDM0_RxDetector3, 
bMaskByte0);
-   pHalData->framesyncC34 = PHY_QueryBBReg(Adapter, rOFDM0_RxDetector2, 
bMaskDWord);
-}
-
 /*  */
 /* Description: */
 /* Map dBm into Tx power index according to */
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 09/28] staging: rtl8188eu: Remove unused function PHY_UpdateTxPowerDbm8188E()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c|   37 
 drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |1 -
 2 files changed, 38 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index 79f86db..7cc7f44 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
@@ -878,43 +878,6 @@ PHY_SetTxPowerLevel8188E(
rtl8188e_PHY_RF6052SetOFDMTxPower(Adapter, &ofdmPowerLevel[0], 
&BW20PowerLevel[0], &BW40PowerLevel[0], channel);
 }
 
-/*  */
-/* Description: */
-/* Update transmit power level of all channel supported. */
-/*  */
-/* TODO: */
-/* A mode. */
-/* By Bruce, 2008-02-04. */
-/*  */
-bool
-PHY_UpdateTxPowerDbm8188E(
-   struct adapter *Adapter,
-   int powerInDbm
-   )
-{
-   struct hal_data_8188e   *pHalData = GET_HAL_DATA(Adapter);
-   u8 idx;
-   u8 rf_path;
-
-   /*  TODO: A mode Tx power. */
-   u8 CckTxPwrIdx = phy_DbmToTxPwrIdx(Adapter, WIRELESS_MODE_B, 
powerInDbm);
-   u8 OfdmTxPwrIdx = phy_DbmToTxPwrIdx(Adapter, WIRELESS_MODE_N_24G, 
powerInDbm);
-
-   if (OfdmTxPwrIdx - pHalData->LegacyHTTxPowerDiff > 0)
-   OfdmTxPwrIdx -= pHalData->LegacyHTTxPowerDiff;
-   else
-   OfdmTxPwrIdx = 0;
-
-   for (idx = 0; idx < 14; idx++) {
-   for (rf_path = 0; rf_path < 2; rf_path++) {
-   pHalData->TxPwrLevelCck[rf_path][idx] = CckTxPwrIdx;
-   pHalData->TxPwrLevelHT40_1S[rf_path][idx] =
-   pHalData->TxPwrLevelHT40_2S[rf_path][idx] = 
OfdmTxPwrIdx;
-   }
-   }
-   return true;
-}
-
 void
 PHY_ScanOperationBackup8188E(
struct adapter *Adapter,
diff --git a/drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h 
b/drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h
index 25cae81..260ea6b 100644
--- a/drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h
+++ b/drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h
@@ -224,7 +224,6 @@ void rtl8192c_PHY_GetHWRegOriginalValue(struct adapter 
*adapter);
 /*  BB TX Power R/W */
 void PHY_GetTxPowerLevel8188E(struct adapter *adapter, u32 *powerlevel);
 void PHY_SetTxPowerLevel8188E(struct adapter *adapter, u8 channel);
-bool PHY_UpdateTxPowerDbm8188E(struct adapter *adapter, int power);
 
 void PHY_ScanOperationBackup8188E(struct adapter *Adapter, u8 Operation);
 
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 10/28] staging:rtl8188eu: Remove unused function phy_DbmToTxPwrIdx()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |   44 ---
 1 file changed, 44 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index 7cc7f44..16f46c3 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
@@ -633,50 +633,6 @@ int PHY_RFConfig8188E(struct adapter *Adapter)
 
 /*  */
 /* Description: */
-/* Map dBm into Tx power index according to */
-/* current HW model, for example, RF and PA, and */
-/* current wireless mode. */
-/* By Bruce, 2008-01-29. */
-/*  */
-static u8 phy_DbmToTxPwrIdx(struct adapter *Adapter, enum wireless_mode 
WirelessMode, int PowerInDbm)
-{
-   u8 TxPwrIdx = 0;
-   int Offset = 0;
-
-
-   /*  */
-   /*  Tested by MP, we found that CCK Index 0 equals to 8dbm, OFDM legacy 
equals to */
-   /*  3dbm, and OFDM HT equals to 0dbm respectively. */
-   /*  Note: */
-   /*  The mapping may be different by different NICs. Do not use this 
formula for what needs accurate result. */
-   /*  By Bruce, 2008-01-29. */
-   /*  */
-   switch (WirelessMode) {
-   case WIRELESS_MODE_B:
-   Offset = -7;
-   break;
-
-   case WIRELESS_MODE_G:
-   case WIRELESS_MODE_N_24G:
-   default:
-   Offset = -8;
-   break;
-   }
-
-   if ((PowerInDbm - Offset) > 0)
-   TxPwrIdx = (u8)((PowerInDbm - Offset) * 2);
-   else
-   TxPwrIdx = 0;
-
-   /*  Tx Power Index is too large. */
-   if (TxPwrIdx > MAX_TXPWR_IDX_NMODE_92S)
-   TxPwrIdx = MAX_TXPWR_IDX_NMODE_92S;
-
-   return TxPwrIdx;
-}
-
-/*  */
-/* Description: */
 /* Map Tx power index into dBm according to */
 /* current HW model, for example, RF and PA, and */
 /* current wireless mode. */
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 11/28] staging: rtl8188eu: Remove unused funtion PHY_GetTxPowerLevel8188E()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |   46 ---
 1 file changed, 46 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index 16f46c3..099345f 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
@@ -665,52 +665,6 @@ static int phy_TxPwrIdxToDbm(struct adapter *Adapter, enum 
wireless_mode Wireles
return PwrOutDbm;
 }
 
-
-/*-
- * Function:GetTxPowerLevel8190()
- *
- * Overview:This function is export to "common" moudule
- *
- * Input:   struct adapter *Adapter
- * psByte  Power Level
- *
- * Output:  NONE
- *
- * Return:  NONE
- *
- *---*/
-void PHY_GetTxPowerLevel8188E(struct adapter *Adapter, u32 *powerlevel)
-{
-   struct hal_data_8188e   *pHalData = GET_HAL_DATA(Adapter);
-   u8 TxPwrLevel = 0;
-   int TxPwrDbm;
-
-   /*  */
-   /*  Because the Tx power indexes are different, we report the maximum 
of them to */
-   /*  meet the CCX TPC request. By Bruce, 2008-01-31. */
-   /*  */
-
-   /*  CCK */
-   TxPwrLevel = pHalData->CurrentCckTxPwrIdx;
-   TxPwrDbm = phy_TxPwrIdxToDbm(Adapter, WIRELESS_MODE_B, TxPwrLevel);
-
-   /*  Legacy OFDM */
-   TxPwrLevel = pHalData->CurrentOfdm24GTxPwrIdx + 
pHalData->LegacyHTTxPowerDiff;
-
-   /*  Compare with Legacy OFDM Tx power. */
-   if (phy_TxPwrIdxToDbm(Adapter, WIRELESS_MODE_G, TxPwrLevel) > TxPwrDbm)
-   TxPwrDbm = phy_TxPwrIdxToDbm(Adapter, WIRELESS_MODE_G, 
TxPwrLevel);
-
-   /*  HT OFDM */
-   TxPwrLevel = pHalData->CurrentOfdm24GTxPwrIdx;
-
-   /*  Compare with HT OFDM Tx power. */
-   if (phy_TxPwrIdxToDbm(Adapter, WIRELESS_MODE_N_24G, TxPwrLevel) > 
TxPwrDbm)
-   TxPwrDbm = phy_TxPwrIdxToDbm(Adapter, WIRELESS_MODE_N_24G, 
TxPwrLevel);
-
-   *powerlevel = TxPwrDbm;
-}
-
 static void getTxPowerIndex88E(struct adapter *Adapter, u8 channel, u8 
*cckPowerLevel,
   u8 *ofdmPowerLevel, u8 *BW20PowerLevel,
   u8 *BW40PowerLevel)
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 12/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |   34 ---
 1 file changed, 34 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index 099345f..a7872c8 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
@@ -631,40 +631,6 @@ int PHY_RFConfig8188E(struct adapter *Adapter)
return rtStatus;
 }
 
-/*  */
-/* Description: */
-/* Map Tx power index into dBm according to */
-/* current HW model, for example, RF and PA, and */
-/* current wireless mode. */
-/* By Bruce, 2008-01-29. */
-/*  */
-static int phy_TxPwrIdxToDbm(struct adapter *Adapter, enum wireless_mode 
WirelessMode, u8 TxPwrIdx)
-{
-   int Offset = 0;
-   int PwrOutDbm = 0;
-
-   /*  */
-   /*  Tested by MP, we found that CCK Index 0 equals to -7dbm, OFDM 
legacy equals to -8dbm. */
-   /*  Note: */
-   /*  The mapping may be different by different NICs. Do not use this 
formula for what needs accurate result. */
-   /*  By Bruce, 2008-01-29. */
-   /*  */
-   switch (WirelessMode) {
-   case WIRELESS_MODE_B:
-   Offset = -7;
-   break;
-   case WIRELESS_MODE_G:
-   case WIRELESS_MODE_N_24G:
-   default:
-   Offset = -8;
-   break;
-   }
-
-   PwrOutDbm = TxPwrIdx / 2 + Offset; /*  Discard the decimal part. */
-
-   return PwrOutDbm;
-}
-
 static void getTxPowerIndex88E(struct adapter *Adapter, u8 channel, u8 
*cckPowerLevel,
   u8 *ofdmPowerLevel, u8 *BW20PowerLevel,
   u8 *BW40PowerLevel)
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 13/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |8 
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index a7872c8..941ff74 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
@@ -754,14 +754,6 @@ PHY_SetTxPowerLevel8188E(
rtl8188e_PHY_RF6052SetOFDMTxPower(Adapter, &ofdmPowerLevel[0], 
&BW20PowerLevel[0], &BW40PowerLevel[0], channel);
 }
 
-void
-PHY_ScanOperationBackup8188E(
-   struct adapter *Adapter,
-   u8 Operation
-   )
-{
-}
-
 /*-
  * Function:PHY_SetBWModeCallback8192C()
  *
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 14/28] staging: rtl8188eu: Remove unused structure rf_shadow

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c |   22 --
 1 file changed, 22 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c
index b1cb5c4..2f1348f 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c
@@ -46,28 +46,6 @@
 
 #include 
 
-/*---Define Local Constant---*/
-/*  Define local structure for debug! */
-struct rf_shadow {
-   /*  Shadow register value */
-   u32 Value;
-   /*  Compare or not flag */
-   u8 Compare;
-   /*  Record If it had ever modified unpredicted */
-   u8 ErrorOrNot;
-   /*  Recorver Flag */
-   u8 Recorver;
-   /*  */
-   u8 Driver_Write;
-};
-
-/*---Define Local Constant---*/
-
-
-/*Define global variable-*/
-
-/*Define local variable--*/
-
 /*-
  * Function:   RF_ChangeTxPath
  *
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 15/28] staging: rtl8188eu: Remove unused function rtl8188e_RF_ChangeTxPath()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c |   23 ---
 1 file changed, 23 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c
index 2f1348f..52103da 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c
@@ -47,29 +47,6 @@
 #include 
 
 /*-
- * Function:   RF_ChangeTxPath
- *
- * Overview:   For RL6052, we must change some RF settign for 1T or 2T.
- *
- * Input:  u16 DataRate0x80-8f, 0x90-9f
- *
- * Output:  NONE
- *
- * Return:  NONE
- *
- * Revised History:
- * WhenWho Remark
- * 09/25/2008  MHC Create Version 0.
- * Firmwaer support the utility 
later.
- *
- *---*/
-void rtl8188e_RF_ChangeTxPath(struct adapter *Adapter, u16 DataRate)
-{
-/*  We do not support gain table change inACUT now  Delete later !!! */
-}  /* RF_ChangeTxPath */
-
-
-/*-
  * Function:PHY_RF6052SetBandwidth()
  *
  * Overview:This function is called by SetBWModeCallback8190Pci() only
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 16/28] staging: rtl8188eu: Remove unused function odm_DIGbyRSSI_LPS()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm.c |   45 ---
 1 file changed, 45 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm.c 
b/drivers/staging/rtl8188eu/hal/odm.c
index 89a26e3..d8482ab 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -529,51 +529,6 @@ void ODM_Write_DIG(struct odm_dm_struct *pDM_Odm, u8 
CurrentIGI)
 /*  Add by Neil Chen to enable edcca to MP Platform */
 }
 
-/* Need LPS mode for CE platform --2012--08--24--- */
-/* 8723AS/8189ES */
-void odm_DIGbyRSSI_LPS(struct odm_dm_struct *pDM_Odm)
-{
-   struct adapter *pAdapter = pDM_Odm->Adapter;
-   struct false_alarm_stats *pFalseAlmCnt = &pDM_Odm->FalseAlmCnt;
-
-   u8 RSSI_Lower = DM_DIG_MIN_NIC;   /* 0x1E or 0x1C */
-   u8 bFwCurrentInPSMode = false;
-   u8 CurrentIGI = pDM_Odm->RSSI_Min;
-
-   CurrentIGI = CurrentIGI + RSSI_OFFSET_DIG;
-   bFwCurrentInPSMode = pAdapter->pwrctrlpriv.bFwCurrentInPSMode;
-
-   /*  Using FW PS mode to make IGI */
-   if (bFwCurrentInPSMode) {
-   ODM_RT_TRACE(pDM_Odm, ODM_COMP_DIG, ODM_DBG_LOUD, 
("---Neil---odm_DIG is in LPS mode\n"));
-   /* Adjust by  FA in LPS MODE */
-   if (pFalseAlmCnt->Cnt_all > DM_DIG_FA_TH2_LPS)
-   CurrentIGI = CurrentIGI+2;
-   else if (pFalseAlmCnt->Cnt_all > DM_DIG_FA_TH1_LPS)
-   CurrentIGI = CurrentIGI+1;
-   else if (pFalseAlmCnt->Cnt_all < DM_DIG_FA_TH0_LPS)
-   CurrentIGI = CurrentIGI-1;
-   } else {
-   CurrentIGI = RSSI_Lower;
-   }
-
-   /* Lower bound checking */
-
-   /* RSSI Lower bound check */
-   if ((pDM_Odm->RSSI_Min-10) > DM_DIG_MIN_NIC)
-   RSSI_Lower = (pDM_Odm->RSSI_Min-10);
-   else
-   RSSI_Lower = DM_DIG_MIN_NIC;
-
-   /* Upper and Lower Bound checking */
-if (CurrentIGI > DM_DIG_MAX_NIC)
-   CurrentIGI = DM_DIG_MAX_NIC;
-else if (CurrentIGI < RSSI_Lower)
-   CurrentIGI = RSSI_Lower;
-
-   ODM_Write_DIG(pDM_Odm, CurrentIGI);/* ODM_Write_DIG(pDM_Odm, 
pDM_DigTable->CurIGValue); */
-}
-
 void odm_DIGInit(struct odm_dm_struct *pDM_Odm)
 {
struct adapter *adapter = pDM_Odm->Adapter;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 17/28] staging: rtl8188eu: Remove function odm_DynamicBBPowerSaving()

2014-05-18 Thread navin patidar

odm_DynamicBBPowerSaving() has empty defination.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm.c |6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm.c 
b/drivers/staging/rtl8188eu/hal/odm.c
index d8482ab..2e105b4 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -183,7 +183,6 @@ void ODM_DMInit(struct odm_dm_struct *pDM_Odm)
odm_RateAdaptiveMaskInit(pDM_Odm);
 
odm_PrimaryCCA_Init(pDM_Odm);/*  Gary */
-   odm_DynamicBBPowerSavingInit(pDM_Odm);
odm_DynamicTxPowerInit(pDM_Odm);
odm_TXPowerTrackingInit(pDM_Odm);
ODM_EdcaTurboInit(pDM_Odm);
@@ -215,7 +214,6 @@ void ODM_DMWatchdog(struct odm_dm_struct *pDM_Odm)
 
odm_RefreshRateAdaptiveMask(pDM_Odm);
 
-   odm_DynamicBBPowerSaving(pDM_Odm);
odm_DynamicPrimaryCCA(pDM_Odm);
if ((pDM_Odm->AntDivType ==  CG_TRX_HW_ANTDIV)  ||
(pDM_Odm->AntDivType == CGCS_RX_HW_ANTDIV)  ||
@@ -865,10 +863,6 @@ void odm_DynamicBBPowerSavingInit(struct odm_dm_struct 
*pDM_Odm)
pDM_PSTable->initialize = 0;
 }
 
-void odm_DynamicBBPowerSaving(struct odm_dm_struct *pDM_Odm)
-{
-}
-
 void odm_1R_CCA(struct odm_dm_struct *pDM_Odm)
 {
struct adapter *adapter = pDM_Odm->Adapter;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 18/28] staging: rtl8188eu: Remove unused function odm_DynamicBBPowerSavingInit()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm.c |   15 ---
 1 file changed, 15 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm.c 
b/drivers/staging/rtl8188eu/hal/odm.c
index 2e105b4..e8ad880 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -848,21 +848,6 @@ void ODM_Write_CCK_CCA_Thres(struct odm_dm_struct 
*pDM_Odm, u8 CurCCK_CCAThres)
pDM_DigTable->CurCCK_CCAThres = CurCCK_CCAThres;
 }
 
-/* 3 */
-/* 3 BB Power Save */
-/* 3 */
-void odm_DynamicBBPowerSavingInit(struct odm_dm_struct *pDM_Odm)
-{
-   struct rtl_ps *pDM_PSTable = &pDM_Odm->DM_PSTable;
-
-   pDM_PSTable->PreCCAState = CCA_MAX;
-   pDM_PSTable->CurCCAState = CCA_MAX;
-   pDM_PSTable->PreRFState = RF_MAX;
-   pDM_PSTable->CurRFState = RF_MAX;
-   pDM_PSTable->Rssi_val_min = 0;
-   pDM_PSTable->initialize = 0;
-}
-
 void odm_1R_CCA(struct odm_dm_struct *pDM_Odm)
 {
struct adapter *adapter = pDM_Odm->Adapter;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 19/28] staging:rtl8188eu: Remove unused function iodm_1R_CCA()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm.c |   34 --
 1 file changed, 34 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm.c 
b/drivers/staging/rtl8188eu/hal/odm.c
index e8ad880..7319b3e 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -848,40 +848,6 @@ void ODM_Write_CCK_CCA_Thres(struct odm_dm_struct 
*pDM_Odm, u8 CurCCK_CCAThres)
pDM_DigTable->CurCCK_CCAThres = CurCCK_CCAThres;
 }
 
-void odm_1R_CCA(struct odm_dm_struct *pDM_Odm)
-{
-   struct adapter *adapter = pDM_Odm->Adapter;
-   struct rtl_ps *pDM_PSTable = &pDM_Odm->DM_PSTable;
-
-   if (pDM_Odm->RSSI_Min != 0xFF) {
-   if (pDM_PSTable->PreCCAState == CCA_2R) {
-   if (pDM_Odm->RSSI_Min >= 35)
-   pDM_PSTable->CurCCAState = CCA_1R;
-   else
-   pDM_PSTable->CurCCAState = CCA_2R;
-   } else {
-   if (pDM_Odm->RSSI_Min <= 30)
-   pDM_PSTable->CurCCAState = CCA_2R;
-   else
-   pDM_PSTable->CurCCAState = CCA_1R;
-   }
-   } else {
-   pDM_PSTable->CurCCAState = CCA_MAX;
-   }
-
-   if (pDM_PSTable->PreCCAState != pDM_PSTable->CurCCAState) {
-   if (pDM_PSTable->CurCCAState == CCA_1R) {
-   if (pDM_Odm->RFType == ODM_2T2R)
-   PHY_SetBBReg(adapter, 0xc04, bMaskByte0, 0x13);
-   else
-   PHY_SetBBReg(adapter, 0xc04, bMaskByte0, 0x23);
-   } else {
-   PHY_SetBBReg(adapter, 0xc04, bMaskByte0, 0x33);
-   }
-   pDM_PSTable->PreCCAState = pDM_PSTable->CurCCAState;
-   }
-}
-
 void ODM_RF_Saving(struct odm_dm_struct *pDM_Odm, u8 bForceInNormal)
 {
struct adapter *adapter = pDM_Odm->Adapter;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 20/28] staging: rtl8188eu: Remove unused function odm_RefreshRateAdaptiveMaskMP()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm.c |4 
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm.c 
b/drivers/staging/rtl8188eu/hal/odm.c
index 7319b3e..01946cc 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -1033,10 +1033,6 @@ void odm_RefreshRateAdaptiveMask(struct odm_dm_struct 
*pDM_Odm)
odm_RefreshRateAdaptiveMaskCE(pDM_Odm);
 }
 
-void odm_RefreshRateAdaptiveMaskMP(struct odm_dm_struct *pDM_Odm)
-{
-}
-
 void odm_RefreshRateAdaptiveMaskCE(struct odm_dm_struct *pDM_Odm)
 {
u8 i;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 21/28] staging: rtl8188eu: Remove unused function odm_RefreshRateAdaptiveMaskAPADSL()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm.c |4 
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm.c 
b/drivers/staging/rtl8188eu/hal/odm.c
index 01946cc..cc73188 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -1061,10 +1061,6 @@ void odm_RefreshRateAdaptiveMaskCE(struct odm_dm_struct 
*pDM_Odm)
}
 }
 
-void odm_RefreshRateAdaptiveMaskAPADSL(struct odm_dm_struct *pDM_Odm)
-{
-}
-
 /*  Return Value: bool */
 /*  - true: RATRState is changed. */
 bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool 
bForceUpdate, u8 *pRATRState)
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 22/28] staging: rtl8188eu: Remove unused funtion odm_DynamicTxPowerNIC()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm.c |9 -
 1 file changed, 9 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm.c 
b/drivers/staging/rtl8188eu/hal/odm.c
index cc73188..8dd5f7e 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -1131,15 +1131,6 @@ void odm_DynamicTxPower(struct odm_dm_struct *pDM_Odm)
/*  2012/01/12 MH According to Luke's suggestion, only high power will 
support the feature. */
if (!pDM_Odm->ExtPA)
return;
-
-   /*  2011/09/29 MH In HW integration first stage, we provide 4 different 
handle to operate */
-   /*  at the same time. In the stage2/3, we need to prive universal 
interface and merge all */
-   /*  HW dynamic mechanism. */
-   odm_DynamicTxPowerNIC(pDM_Odm);
-}
-
-void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
-{
 }
 
 /* 3 */
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 23/28] staging: rtl8188eu: Remove unused function odm_SwAntDivChkAntSwitchCallback()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm.c |   16 
 1 file changed, 16 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm.c 
b/drivers/staging/rtl8188eu/hal/odm.c
index 8dd5f7e..4442181 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -1269,22 +1269,6 @@ void odm_TXPowerTrackingCheckCE(struct odm_dm_struct 
*pDM_Odm)
}
 }
 
-/* antenna mapping info */
-/*  1: right-side antenna */
-/*  2/0: left-side antenna */
-/* PDM_SWAT_Table->CCK_Ant1_Cnt /OFDM_Ant1_Cnt:  for right-side antenna:   
Ant:1RxDefaultAnt1 */
-/* PDM_SWAT_Table->CCK_Ant2_Cnt /OFDM_Ant2_Cnt:  for left-side antenna: 
Ant:0RxDefaultAnt2 */
-/*  We select left antenna as default antenna in initial process, modify it as 
needed */
-/*  */
-
-/* 3 */
-/* 3 SW Antenna Diversity */
-/* 3 */
-
-void odm_SwAntDivChkAntSwitchCallback(void *FunctionContext)
-{
-}
-
 /* 3 */
 /* 3 SW Antenna Diversity */
 /* 3 */
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 24/28] staging: rtl8188eu: Remove unused function ConvertTo_dB()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm.c |   25 -
 1 file changed, 25 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm.c 
b/drivers/staging/rtl8188eu/hal/odm.c
index 4442181..425c50a4 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -1394,28 +1394,3 @@ dm_CheckEdcaTurbo_EXIT:
pxmitpriv->last_tx_bytes = pxmitpriv->tx_bytes;
precvpriv->last_rx_bytes = precvpriv->rx_bytes;
 }
-
-u32 ConvertTo_dB(u32 Value)
-{
-   u8 i;
-   u8 j;
-   u32 dB;
-
-   Value = Value & 0x;
-   for (i = 0; i < 8; i++) {
-   if (Value <= dB_Invert_Table[i][11])
-   break;
-   }
-
-   if (i >= 8)
-   return 96;  /*  maximum 96 dB */
-
-   for (j = 0; j < 12; j++) {
-   if (Value <= dB_Invert_Table[i][j])
-   break;
-   }
-
-   dB = i*12 + j + 1;
-
-   return dB;
-}
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 25/28] staging: rtl8188eu: Remove function with empty defination ODM_CheckPowerStatus()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c |   14 --
 1 file changed, 14 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c 
b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
index 056052d..7c22658 100644
--- a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
+++ b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
@@ -804,24 +804,12 @@ static void pathb_fill_iqk(struct adapter *adapt, bool 
iqkok, s32 result[][8], u
}
 }
 
-/*  */
-/*  2011/07/26 MH Add an API for testing IQK fail case. */
-/*  */
-/*  MP Already declare in odm.c */
-static bool ODM_CheckPowerStatus(struct adapter *Adapter)
-{
-   return  true;
-}
-
 void _PHY_SaveADDARegisters(struct adapter *adapt, u32 *ADDAReg, u32 
*ADDABackup, u32 RegisterNum)
 {
u32 i;
struct hal_data_8188e   *pHalData = GET_HAL_DATA(adapt);
struct odm_dm_struct *dm_odm = &pHalData->odmpriv;
 
-   if (!ODM_CheckPowerStatus(adapt))
-   return;
-
ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("Save ADDA 
parameters.\n"));
for (i = 0; i < RegisterNum; i++) {
ADDABackup[i] = PHY_QueryBBReg(adapt, ADDAReg[i], bMaskDWord);
@@ -1294,8 +1282,6 @@ void PHY_IQCalibrate_8188E(struct adapter *adapt, bool 
recovery)
bool is2t;
 
is2t = (dm_odm->RFType == ODM_2T2R) ? true : false;
-   if (!ODM_CheckPowerStatus(adapt))
-   return;
 
if (!(dm_odm->SupportAbility & ODM_RF_CALIBRATION))
return;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 26/28] staging: rtl8188eu: Remove unused function DM_DIG_LowerBound_88E()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |   12 
 1 file changed, 12 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c 
b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
index 323eb93..7c1043c 100644
--- a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
+++ b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
@@ -20,18 +20,6 @@
 
 #include "odm_precomp.h"
 
-void ODM_DIG_LowerBound_88E(struct odm_dm_struct *dm_odm)
-{
-   struct rtw_dig *pDM_DigTable = &dm_odm->DM_DigTable;
-
-   if (dm_odm->AntDivType == CG_TRX_HW_ANTDIV) {
-   pDM_DigTable->rx_gain_range_min = (u8) 
pDM_DigTable->AntDiv_RSSI_max;
-   ODM_RT_TRACE(dm_odm, ODM_COMP_ANT_DIV, ODM_DBG_LOUD,
-("ODM_DIG_LowerBound_88E(): 
pDM_DigTable->AntDiv_RSSI_max=%d\n", pDM_DigTable->AntDiv_RSSI_max));
-   }
-   /* If only one Entry connected */
-}
-
 static void odm_RX_HWAntDivInit(struct odm_dm_struct *dm_odm)
 {
struct adapter *adapter = dm_odm->Adapter;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 27/28] staging: rtl8188eu: Remove unused function ODM_DynamicPrimaryCCA_DupRTS()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |7 ---
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c 
b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
index 7c1043c..a90b2c5 100644
--- a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
+++ b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
@@ -377,13 +377,6 @@ void odm_PrimaryCCA_Init(struct odm_dm_struct *dm_odm)
PrimaryCCA->PriCCA_flag = 0;
 }
 
-bool ODM_DynamicPrimaryCCA_DupRTS(struct odm_dm_struct *dm_odm)
-{
-   struct dyn_primary_cca *PrimaryCCA = &(dm_odm->DM_PriCCA);
-
-   return  PrimaryCCA->DupRTS_flag;
-}
-
 void odm_DynamicPrimaryCCA(struct odm_dm_struct *dm_odm)
 {
return;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 28/28] staging: rtl8188eu:Remove function with empty defination odm_DynamicPrimaryCCA()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm.c  |1 -
 drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |5 -
 drivers/staging/rtl8188eu/include/odm_RTL8188E.h |2 --
 3 files changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm.c 
b/drivers/staging/rtl8188eu/hal/odm.c
index 425c50a4..a39eba9 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -214,7 +214,6 @@ void ODM_DMWatchdog(struct odm_dm_struct *pDM_Odm)
 
odm_RefreshRateAdaptiveMask(pDM_Odm);
 
-   odm_DynamicPrimaryCCA(pDM_Odm);
if ((pDM_Odm->AntDivType ==  CG_TRX_HW_ANTDIV)  ||
(pDM_Odm->AntDivType == CGCS_RX_HW_ANTDIV)  ||
(pDM_Odm->AntDivType == CG_TRX_SMART_ANTDIV))
diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c 
b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
index a90b2c5..a24d954 100644
--- a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
+++ b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
@@ -376,8 +376,3 @@ void odm_PrimaryCCA_Init(struct odm_dm_struct *dm_odm)
PrimaryCCA->Monitor_flag = 0;
PrimaryCCA->PriCCA_flag = 0;
 }
-
-void odm_DynamicPrimaryCCA(struct odm_dm_struct *dm_odm)
-{
-   return;
-}
diff --git a/drivers/staging/rtl8188eu/include/odm_RTL8188E.h 
b/drivers/staging/rtl8188eu/include/odm_RTL8188E.h
index f96ad5a..02ac78d 100644
--- a/drivers/staging/rtl8188eu/include/odm_RTL8188E.h
+++ b/drivers/staging/rtl8188eu/include/odm_RTL8188E.h
@@ -51,6 +51,4 @@ void odm_PrimaryCCA_Init(struct odm_dm_struct *pDM_Odm);
 
 bool ODM_DynamicPrimaryCCA_DupRTS(struct odm_dm_struct *pDM_Odm);
 
-void odm_DynamicPrimaryCCA(struct odm_dm_struct *pDM_Odm);
-
 #endif
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 13/28] staging: rtl8188eu: Remove unused funtion PHY_ScanOperationBackup8188E()

2014-05-18 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |8 
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index a7872c8..941ff74 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
@@ -754,14 +754,6 @@ PHY_SetTxPowerLevel8188E(
rtl8188e_PHY_RF6052SetOFDMTxPower(Adapter, &ofdmPowerLevel[0], 
&BW20PowerLevel[0], &BW40PowerLevel[0], channel);
 }

-void
-PHY_ScanOperationBackup8188E(
-   struct adapter *Adapter,
-   u8 Operation
-   )
-{
-}
-
 /*-
  * Function:PHY_SetBWModeCallback8192C()
  *
--
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 13/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

2014-05-18 Thread navin patidar

Subject line of this patch isn't correct, so please ignore it.
I've submitted new patch with "[PATCH 13/28] staging: rtl8188eu:
Remove unused funtion PHY_ScanOperationBackup8188E()"
subject line.

regards,
navin patidar

On Sun, May 18, 2014 at 8:49 PM, navin patidar  wrote:
> Signed-off-by: navin patidar 
> ---
>  drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |8 
>  1 file changed, 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c 
> b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
> index a7872c8..941ff74 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
> @@ -754,14 +754,6 @@ PHY_SetTxPowerLevel8188E(
> rtl8188e_PHY_RF6052SetOFDMTxPower(Adapter, &ofdmPowerLevel[0], 
> &BW20PowerLevel[0], &BW40PowerLevel[0], channel);
>  }
>
> -void
> -PHY_ScanOperationBackup8188E(
> -   struct adapter *Adapter,
> -   u8 Operation
> -   )
> -{
> -}
> -
>  
> /*-
>   * Function:PHY_SetBWModeCallback8192C()
>   *
> --
> 1.7.10.4
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

2014-05-19 Thread navin patidar

On Mon, May 19, 2014 at 4:22 PM, Dan Carpenter  wrote:
> On Sun, May 18, 2014 at 08:48:58PM +0530, navin patidar wrote:
>> Signed-off-by: navin patidar 
>> ---
>>  drivers/staging/rtl8188eu/hal/usb_halinit.c |8 
>>  1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c 
>> b/drivers/staging/rtl8188eu/hal/usb_halinit.c
>> index 1a83d31..4c3f8c8 100644
>> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
>> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
>> @@ -2231,12 +2231,6 @@ static void rtl8188eu_init_default_value(struct 
>> adapter *adapt)
>>   haldata->odmpriv.RFCalibrateInfo.ThermalValue_HP[i] = 0;
>>  }
>>
>> -static u8 rtl8188eu_ps_func(struct adapter *Adapter, enum hal_intf_ps_func 
>> efunc_id, u8 *val)
>> -{
>> - u8 bResult = true;
>> - return bResult;
>> -}
>> -
>>  void rtl8188eu_set_hal_ops(struct adapter *adapt)
>>  {
>>   struct hal_ops  *halfunc = &adapt->HalFunc;
>> @@ -2277,7 +2271,5 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt)
>>   halfunc->hal_xmit = &rtl8188eu_hal_xmit;
>>   halfunc->mgnt_xmit = &rtl8188eu_mgnt_xmit;
>>
>> - halfunc->interface_ps_func = &rtl8188eu_ps_func;
>
> No, this is used.  See rtw_hal_intf_ps_func().
>
> drivers/staging/rtl8188eu/hal/hal_intf.c
>210  u8 rtw_hal_intf_ps_func(struct adapter *adapt,
>211  enum hal_intf_ps_func efunc_id, u8 *val)
>212  {
>213  if (adapt->HalFunc.interface_ps_func)
>214  return adapt->HalFunc.interface_ps_func(adapt, 
> efunc_id,
>215 val);
>216  return _FAIL;
>217  }
>
> You have changed it to return _FAIL instead of true.  Perhaps that is ok
> but you need to explain it in the changelog.
>
oops, I'll resend this patch with proper changelog.
I have one question, do i need to send v2 of whole patch series or
just this patch.

regards,
navin patidar
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

2014-05-19 Thread navin patidar

On Tue, May 20, 2014 at 12:34 AM, Dan Carpenter
 wrote:
> On Mon, May 19, 2014 at 09:19:07PM +0530, navin patidar wrote:
>> > You have changed it to return _FAIL instead of true.  Perhaps that is ok
>> > but you need to explain it in the changelog.
>> >
>> oops, I'll resend this patch with proper changelog.
>> I have one question, do i need to send v2 of whole patch series or
>> just this patch.
>
> Greg, none of the other patches rely on this one.  Could you apply them
> and drop this one?  This one is also fine except for the changelog but
> Navin can send a new version in a new thread.

Please drop this patch.

> [ General rules on redoing patches threads ]
>
> When you are sending a patch series and someone asks you to update one
> changelog, then you can resend just the patch but you must set the
> In-Reply-To email header.  You didn't do that for [PATCH 13/28] so now
> the v2 of that patch is in its own thread.

Okay, I'll keep that in mind next time.

>
> If you are sending a patch series and updating one in the middle means
> that the other patches won't apply then you should redo the whole thing
> or ask Greg to apply the first 7 patches and redo the last ones.
>
> If you are sending a series and you have to update a lot of patches then
> resend the whole thing because otherwise it becomes confusing.

Thanks for explaining the process in detail. :)

> [ This patch in particular ]
>
> Ok.  So I looked at this and the function which calls
> rtw_hal_intf_ps_func() is never called, so you're right that this
> function isn't used.  Probably this is what you were going to put in
> your changelog and I would check and that's fine.
>
> But when I am reviewing these kinds of "delete unused code" patches then
> I just "Ok.  If there are still users the compile will break."  So I
> don't have to look outside the email client.  So I would prefer if you
> did it in this order:
>
> [patch 1/4] staging: rtl8188eu: Remove unused function rtw_interface_ps_func()
> [patch 2/4] staging: rtl8188eu: Remove unused function rtw_hal_intf_ps_func()
> [patch 3/4] staging: rtl8188eu: Remove unused function pointer 
> ->interface_ps_func
> [patch 4/4] staging: rtl8188eu: staging: rtl8188eu: Remove unused function 
> rtl8188eu_ps_func()

I'll send new patchset in order you mentioned.

regards,
navin patidar
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 00/13]staging: rtl8188eu: Remove unused functions and variables

2014-05-20 Thread navin patidar

Hi Greg,

Please merge this patchset, It has been pending for some time.

regards,
navin patidar

On Wed, May 7, 2014 at 9:27 AM,   wrote:
> From: navin patidar 
>
> Following patches remove unused functions, variables and functions with empty
> definition.
>
> navin patidar (13):
>   staging: rtl8188eu: Remove 'semaphore allrxreturnevt' from struct
> recv_priv
>   staging: rtl8188eu: Remove unused member variables of struct
> recv_priv
>   staging: rtl8188eu: Remove 'spinlock_t lock' from struct recv_priv
>   staging: rtl8188eu: Remove struct zero_bulkout_context
>   staging: rtl8188eu: Remove function rtw_os_recv_resource_init()
>   staging: rtl8188eu: Remove function rtw_os_recv_resource_free()
>   staging: rtl8188eu: Remove function rtw_hostapd_mlme_rx()
>   staging: rtl8188eu: Remove function rtw_os_recvbuf_resource_free()
>   staging: rtl8188eu: Remove unused inline function recvframe_push()
>   staging: rtl8188eu: Remove unused inline function get_rx_status()
>   staging: rtl8188eu: Remove 'void  *precvbuf' from struct recv_frame
>   staging: rtl8188eu: Remove 'int frame_tag' from struct recv_frame
>   staging: rtl8188eu: Remove 'u8 fragcnt' from struct recv_frame
>
>  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c|2 --
>  drivers/staging/rtl8188eu/core/rtw_recv.c|8 -
>  drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c   |2 +-
>  drivers/staging/rtl8188eu/hal/usb_ops_linux.c|1 -
>  drivers/staging/rtl8188eu/include/recv_osdep.h   |4 ---
>  drivers/staging/rtl8188eu/include/rtw_recv.h |   36 
> --
>  drivers/staging/rtl8188eu/os_dep/recv_linux.c|   25 ---
>  drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |7 -
>  8 files changed, 1 insertion(+), 84 deletions(-)
>
> --
> 1.7.10.4
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 02/24] staging: rtl8188eu: Remove unused function rtw_hal_intf_ps_func()

2014-05-26 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/hal_intf.c |9 -
 drivers/staging/rtl8188eu/include/hal_intf.h |3 ---
 2 files changed, 12 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c 
b/drivers/staging/rtl8188eu/hal/hal_intf.c
index d75ca7a..43eee48 100644
--- a/drivers/staging/rtl8188eu/hal/hal_intf.c
+++ b/drivers/staging/rtl8188eu/hal/hal_intf.c
@@ -207,15 +207,6 @@ u32 rtw_hal_inirp_deinit(struct adapter *adapt)
return _FAIL;
 }
 
-u8 rtw_hal_intf_ps_func(struct adapter *adapt,
-   enum hal_intf_ps_func efunc_id, u8 *val)
-{
-   if (adapt->HalFunc.interface_ps_func)
-   return adapt->HalFunc.interface_ps_func(adapt, efunc_id,
-  val);
-   return _FAIL;
-}
-
 s32 rtw_hal_xmit(struct adapter *adapt, struct xmit_frame *pxmitframe)
 {
if (adapt->HalFunc.hal_xmit)
diff --git a/drivers/staging/rtl8188eu/include/hal_intf.h 
b/drivers/staging/rtl8188eu/include/hal_intf.h
index c274b34..9228bc6 100644
--- a/drivers/staging/rtl8188eu/include/hal_intf.h
+++ b/drivers/staging/rtl8188eu/include/hal_intf.h
@@ -332,9 +332,6 @@ void rtw_hal_disable_interrupt(struct adapter *padapter);
 u32rtw_hal_inirp_init(struct adapter *padapter);
 u32rtw_hal_inirp_deinit(struct adapter *padapter);
 
-u8 rtw_hal_intf_ps_func(struct adapter *padapter,
-enum hal_intf_ps_func efunc_id, u8 *val);
-
 s32rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe);
 s32rtw_hal_mgnt_xmit(struct adapter *padapter,
  struct xmit_frame *pmgntframe);
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 03/24] staging: rtl8188eu: Remove unused function pointer ->interface_ps_func

2014-05-26 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c  |2 --
 drivers/staging/rtl8188eu/include/hal_intf.h |3 ---
 2 files changed, 5 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c 
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 0cb84ae..9020129 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -2272,7 +2272,5 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt)
halfunc->hal_xmit = &rtl8188eu_hal_xmit;
halfunc->mgnt_xmit = &rtl8188eu_mgnt_xmit;
 
-   halfunc->interface_ps_func = &rtl8188eu_ps_func;
-
rtl8188e_set_hal_ops(halfunc);
 }
diff --git a/drivers/staging/rtl8188eu/include/hal_intf.h 
b/drivers/staging/rtl8188eu/include/hal_intf.h
index 9228bc6..acdef1d 100644
--- a/drivers/staging/rtl8188eu/include/hal_intf.h
+++ b/drivers/staging/rtl8188eu/include/hal_intf.h
@@ -218,9 +218,6 @@ struct hal_ops {
void(*AntDivCompareHandler)(struct adapter *adapter,
struct wlan_bssid_ex *dst,
struct wlan_bssid_ex *src);
-   u8  (*interface_ps_func)(struct adapter *padapter,
-enum hal_intf_ps_func efunc_id, u8 *val);
-
s32 (*hal_xmit)(struct adapter *padapter,
struct xmit_frame *pxmitframe);
s32 (*mgnt_xmit)(struct adapter *padapter,
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 01/24] staging: rtl8188eu: Remove unused function rtw_interface_ps_func()

2014-05-26 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_pwrctrl.c|9 -
 drivers/staging/rtl8188eu/include/rtw_pwrctrl.h |2 --
 2 files changed, 11 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c 
b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
index f658373..83e34f4 100644
--- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
@@ -497,15 +497,6 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter)
_init_timer(&(pwrctrlpriv->pwr_state_check_timer), padapter->pnetdev, 
pwr_state_check_handler, (u8 *)padapter);
 }
 
-u8 rtw_interface_ps_func(struct adapter *padapter, enum hal_intf_ps_func 
efunc_id, u8 *val)
-{
-   u8 bResult = true;
-   rtw_hal_intf_ps_func(padapter, efunc_id, val);
-
-   return bResult;
-}
-
-
 inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
 {
struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h 
b/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
index 9a42859..751803f 100644
--- a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
+++ b/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
@@ -258,8 +258,6 @@ s32 LPS_RF_ON_check(struct adapter *adapter, u32 delay_ms);
 void LPS_Enter(struct adapter *adapter);
 void LPS_Leave(struct adapter *adapter);
 
-u8 rtw_interface_ps_func(struct adapter *adapter,
-enum hal_intf_ps_func efunc_id, u8 *val);
 void rtw_set_ips_deny(struct adapter *adapter, u32 ms);
 int _rtw_pwr_wakeup(struct adapter *adapter, u32 ips_defer_ms,
const char *caller);
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 04/24] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

2014-05-26 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c |6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c 
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 9020129..141f85a 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -2226,12 +2226,6 @@ static void rtl8188eu_init_default_value(struct adapter 
*adapt)
haldata->odmpriv.RFCalibrateInfo.ThermalValue_HP[i] = 0;
 }
 
-static u8 rtl8188eu_ps_func(struct adapter *Adapter, enum hal_intf_ps_func 
efunc_id, u8 *val)
-{
-   u8 bResult = true;
-   return bResult;
-}
-
 void rtl8188eu_set_hal_ops(struct adapter *adapt)
 {
struct hal_ops  *halfunc = &adapt->HalFunc;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 08/24] staging: rtl8188eu: Remove function rtw_hal_dm_deinit()

2014-05-26 Thread navin patidar

rtw_hal_dm_deinit() calls rtl8188e_deinit_dm_priv() using funtion pointer.
rtl8188e_deinit_dm_priv() has empty defination, so we can remove
rtw_hal_dm_deinit() and later rtl8188e_deinit_dm_priv() also will be
removed.

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/hal_intf.c |7 ---
 drivers/staging/rtl8188eu/include/hal_intf.h |1 -
 drivers/staging/rtl8188eu/os_dep/os_intfs.c  |2 --
 3 files changed, 10 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c 
b/drivers/staging/rtl8188eu/hal/hal_intf.c
index 43eee48..d0ac4a1 100644
--- a/drivers/staging/rtl8188eu/hal/hal_intf.c
+++ b/drivers/staging/rtl8188eu/hal/hal_intf.c
@@ -60,13 +60,6 @@ void rtw_hal_dm_init(struct adapter *adapt)
adapt->HalFunc.dm_init(adapt);
 }
 
-void rtw_hal_dm_deinit(struct adapter *adapt)
-{
-   /*  cancel dm  timer */
-   if (adapt->HalFunc.dm_deinit)
-   adapt->HalFunc.dm_deinit(adapt);
-}
-
 void rtw_hal_sw_led_init(struct adapter *adapt)
 {
if (adapt->HalFunc.InitSwLeds)
diff --git a/drivers/staging/rtl8188eu/include/hal_intf.h 
b/drivers/staging/rtl8188eu/include/hal_intf.h
index acdef1d..a8f25c9 100644
--- a/drivers/staging/rtl8188eu/include/hal_intf.h
+++ b/drivers/staging/rtl8188eu/include/hal_intf.h
@@ -296,7 +296,6 @@ void rtw_hal_def_value_init(struct adapter *padapter);
 void   rtw_hal_free_data(struct adapter *padapter);
 
 void rtw_hal_dm_init(struct adapter *padapter);
-void rtw_hal_dm_deinit(struct adapter *padapter);
 void rtw_hal_sw_led_init(struct adapter *padapter);
 void rtw_hal_sw_led_deinit(struct adapter *padapter);
 
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c 
b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 9edb8e8..c1368b8 100644
--- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
@@ -951,8 +951,6 @@ void rtw_cancel_all_timer(struct adapter *padapter)
_cancel_timer_ex(&padapter->pwrctrlpriv.pwr_state_check_timer);
 
_cancel_timer_ex(&padapter->recvpriv.signal_stat_timer);
-   /* cancel dm timer */
-   rtw_hal_dm_deinit(padapter);
 }
 
 u8 rtw_free_drv_sw(struct adapter *padapter)
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 06/24] staging: rtl8188eu: Remove unused function odm_Init_RSSIForDM()

2014-05-26 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm_HWConfig.c |4 
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm_HWConfig.c 
b/drivers/staging/rtl8188eu/hal/odm_HWConfig.c
index 0145a11..f2e1d02 100644
--- a/drivers/staging/rtl8188eu/hal/odm_HWConfig.c
+++ b/drivers/staging/rtl8188eu/hal/odm_HWConfig.c
@@ -275,10 +275,6 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct 
odm_dm_struct *dm_odm,
dm_odm->DM_FatTable.antsel_rx_keep_2 = pPhyStaRpt->antsel_rx_keep_2;
 }
 
-void odm_Init_RSSIForDM(struct odm_dm_struct *dm_odm)
-{
-}
-
 static void odm_Process_RSSIForDM(struct odm_dm_struct *dm_odm,
  struct odm_phy_status_info *pPhyInfo,
  struct odm_per_pkt_info *pPktinfo)
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 05/24] staging: rtl8188eu: Remove unused function ODM_MacStatusQuery()

2014-05-26 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/odm_HWConfig.c |8 
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/odm_HWConfig.c 
b/drivers/staging/rtl8188eu/hal/odm_HWConfig.c
index a755df3..0145a11 100644
--- a/drivers/staging/rtl8188eu/hal/odm_HWConfig.c
+++ b/drivers/staging/rtl8188eu/hal/odm_HWConfig.c
@@ -436,14 +436,6 @@ void ODM_PhyStatusQuery(struct odm_dm_struct *dm_odm,
ODM_PhyStatusQuery_92CSeries(dm_odm, pPhyInfo, pPhyStatus, pPktinfo);
 }
 
-/*  For future use. */
-void ODM_MacStatusQuery(struct odm_dm_struct *dm_odm, u8 *mac_stat,
-   u8 macid, bool pkt_match_bssid,
-   bool pkttoself, bool pkt_beacon)
-{
-   /*  2011/10/19 Driver team will handle in the future. */
-}
-
 enum HAL_STATUS ODM_ConfigRFWithHeaderFile(struct odm_dm_struct *dm_odm,
   enum rf_radio_path content,
   enum rf_radio_path rfpath)
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 07/24] staging: rtl8188eu: Remove function with empty defination dm_CheckStatistics()

2014-05-26 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c |   10 --
 1 file changed, 10 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index cf88bf2..4e9f797 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -31,10 +31,6 @@
 
 #include 
 
-static void dm_CheckStatistics(struct adapter *Adapter)
-{
-}
-
 /*  Initialize GPIO setting registers */
 static void dm_InitGPIOSetting(struct adapter *Adapter)
 {
@@ -173,12 +169,6 @@ void rtl8188e_HalDmWatchDog(struct adapter *Adapter)
if (Adapter->wdinfo.p2p_ps_mode)
fw_ps_awake = false;
 
-   if (hw_init_completed && ((!fw_cur_in_ps) && fw_ps_awake)) {
-   /*  Calculate Tx/Rx statistics. */
-   dm_CheckStatistics(Adapter);
-
-   }
-
/* ODM */
if (hw_init_completed) {
struct mlme_priv *pmlmepriv = &Adapter->mlmepriv;
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 09/24] staging: rtl8188eu: Remove unused function pointer ->dm_init

2014-05-26 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 -
 drivers/staging/rtl8188eu/include/hal_intf.h  |1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
index f9d5558..5a22c6d 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
@@ -1843,7 +1843,6 @@ void rtl8188e_set_hal_ops(struct hal_ops *pHalFunc)
pHalFunc->free_hal_data = &rtl8188e_free_hal_data;
 
pHalFunc->dm_init = &rtl8188e_init_dm_priv;
-   pHalFunc->dm_deinit = &rtl8188e_deinit_dm_priv;
 
pHalFunc->read_chip_version = &rtl8188e_read_chip_version;
 
diff --git a/drivers/staging/rtl8188eu/include/hal_intf.h 
b/drivers/staging/rtl8188eu/include/hal_intf.h
index a8f25c9..c59fccd 100644
--- a/drivers/staging/rtl8188eu/include/hal_intf.h
+++ b/drivers/staging/rtl8188eu/include/hal_intf.h
@@ -166,7 +166,6 @@ struct hal_ops {
void(*DeInitSwLeds)(struct adapter *padapter);
 
void(*dm_init)(struct adapter *padapter);
-   void(*dm_deinit)(struct adapter *padapter);
void(*read_chip_version)(struct adapter *padapter);
 
void(*init_default_value)(struct adapter *padapter);
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 11/24] staging: rtl8188eu: remove unused header inclusion from rtw_mp.c

2014-05-26 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/core/rtw_mp.c |1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_mp.c 
b/drivers/staging/rtl8188eu/core/rtw_mp.c
index 705f666..17427a6 100644
--- a/drivers/staging/rtl8188eu/core/rtw_mp.c
+++ b/drivers/staging/rtl8188eu/core/rtw_mp.c
@@ -21,7 +21,6 @@
 
 #include 
 
-#include "odm_precomp.h"
 #include "rtl8188e_hal.h"
 #include 
 
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 10/24] staging: rtl8188eu: Remove unused function rtl8188e_deinit_dm_priv()

2014-05-26 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c |4 
 drivers/staging/rtl8188eu/include/rtl8188e_dm.h |1 -
 2 files changed, 5 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index 4e9f797..d5cd30b 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -203,10 +203,6 @@ void rtl8188e_init_dm_priv(struct adapter *Adapter)
ODM_InitDebugSetting(podmpriv);
 }
 
-void rtl8188e_deinit_dm_priv(struct adapter *Adapter)
-{
-}
-
 /*  Add new function to reset the state of antenna diversity before link. */
 /*  Compare RSSI for deciding antenna */
 void AntDivCompare8188E(struct adapter *Adapter, struct wlan_bssid_ex *dst, 
struct wlan_bssid_ex *src)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_dm.h 
b/drivers/staging/rtl8188eu/include/rtl8188e_dm.h
index 97a3175..5e0ac31 100644
--- a/drivers/staging/rtl8188eu/include/rtl8188e_dm.h
+++ b/drivers/staging/rtl8188eu/include/rtl8188e_dm.h
@@ -51,7 +51,6 @@ structdm_priv {
 };
 
 void rtl8188e_init_dm_priv(struct adapter *adapt);
-void rtl8188e_deinit_dm_priv(struct adapter *adapt);
 void rtl8188e_InitHalDm(struct adapter *adapt);
 void rtl8188e_HalDmWatchDog(struct adapter *adapt);
 
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 14/24] staging: rtl8188eu: Remove unused macros in odm_interface.h

2014-05-26 Thread navin patidar

Signed-off-by: navin patidar 
---
 drivers/staging/rtl8188eu/include/odm_interface.h |   11 ---
 1 file changed, 11 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h 
b/drivers/staging/rtl8188eu/include/odm_interface.h
index 548a309..3fc3e3c 100644
--- a/drivers/staging/rtl8188eu/include/odm_interface.h
+++ b/drivers/staging/rtl8188eu/include/odm_interface.h
@@ -21,18 +21,7 @@
 #ifndef__ODM_INTERFACE_H__
 #define __ODM_INTERFACE_H__
 
-/*  */
-/*  === Constant/Structure/Enum/... Define */
-/*  */
-
-/*  */
 /*  === Macro Define */
-/*  */
-
-#define _reg_all(_name)ODM_##_name
-#define _reg_ic(_name, _ic)ODM_##_name##_ic
-#define _bit_all(_name)BIT_##_name
-#define _bit_ic(_name, _ic)BIT_##_name##_ic
 
 /*  _cat: implemented by Token-Pasting Operator. */
 
-- 
1.7.10.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

1 2 3 4 5 6 >

1 - 100 of 599 matches

Mail list logo