[PATCH] x86/Hyper-V: Initialize Syn timer clock even when it's not available

2020-03-30 Thread ltykernel
From: Tianyu Lan 

Current code initializes clock event data structure for syn timer
even when it's available or not. Fix it.

Signed-off-by: Tianyu Lan 
---
 drivers/hv/hv.c | 15 +--
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 632d25674e7f..2e893768fc76 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -212,13 +212,16 @@ int hv_synic_alloc(void)
tasklet_init(&hv_cpu->msg_dpc,
 vmbus_on_msg_dpc, (unsigned long) hv_cpu);
 
-   hv_cpu->clk_evt = kzalloc(sizeof(struct clock_event_device),
- GFP_KERNEL);
-   if (hv_cpu->clk_evt == NULL) {
-   pr_err("Unable to allocate clock event device\n");
-   goto err;
+   if (ms_hyperv.features & HV_MSR_SYNTIMER_AVAILABLE) {
+   hv_cpu->clk_evt =
+   kzalloc(sizeof(struct clock_event_device),
+ GFP_KERNEL);
+   if (hv_cpu->clk_evt == NULL) {
+   pr_err("Unable to allocate clock event 
device\n");
+   goto err;
+   }
+   hv_init_clockevent_device(hv_cpu->clk_evt, cpu);
}
-   hv_init_clockevent_device(hv_cpu->clk_evt, cpu);
 
hv_cpu->synic_message_page =
(void *)get_zeroed_page(GFP_ATOMIC);
-- 
2.14.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[Update PATCH] x86/Hyper-V: Initialize Syn timer clock when it's

2020-03-30 Thread ltykernel
From: Tianyu Lan 

Current code initializes clock event data structure for syn timer
even when it's not available. Fix it.

Signed-off-by: Tianyu Lan 
---
- Fix the wrong title.
 
 drivers/hv/hv.c | 15 +--
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 632d25674e7f..2e893768fc76 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -212,13 +212,16 @@ int hv_synic_alloc(void)
tasklet_init(&hv_cpu->msg_dpc,
 vmbus_on_msg_dpc, (unsigned long) hv_cpu);
 
-   hv_cpu->clk_evt = kzalloc(sizeof(struct clock_event_device),
- GFP_KERNEL);
-   if (hv_cpu->clk_evt == NULL) {
-   pr_err("Unable to allocate clock event device\n");
-   goto err;
+   if (ms_hyperv.features & HV_MSR_SYNTIMER_AVAILABLE) {
+   hv_cpu->clk_evt =
+   kzalloc(sizeof(struct clock_event_device),
+ GFP_KERNEL);
+   if (hv_cpu->clk_evt == NULL) {
+   pr_err("Unable to allocate clock event 
device\n");
+   goto err;
+   }
+   hv_init_clockevent_device(hv_cpu->clk_evt, cpu);
}
-   hv_init_clockevent_device(hv_cpu->clk_evt, cpu);
 
hv_cpu->synic_message_page =
(void *)get_zeroed_page(GFP_ATOMIC);
-- 
2.14.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH V2] x86/Hyper-V: don't allocate clockevent device when synthetic timer is unavailable

2020-03-30 Thread ltykernel
From: Tianyu Lan 

Current code initializes clock event data structure for syn timer
even when it's unavailable. Fix it.

Signed-off-by: Tianyu Lan 
---
Change since v1:
Update title and commit log. 

 drivers/hv/hv.c | 15 +--
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 632d25674e7f..2e893768fc76 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -212,13 +212,16 @@ int hv_synic_alloc(void)
tasklet_init(&hv_cpu->msg_dpc,
 vmbus_on_msg_dpc, (unsigned long) hv_cpu);
 
-   hv_cpu->clk_evt = kzalloc(sizeof(struct clock_event_device),
- GFP_KERNEL);
-   if (hv_cpu->clk_evt == NULL) {
-   pr_err("Unable to allocate clock event device\n");
-   goto err;
+   if (ms_hyperv.features & HV_MSR_SYNTIMER_AVAILABLE) {
+   hv_cpu->clk_evt =
+   kzalloc(sizeof(struct clock_event_device),
+ GFP_KERNEL);
+   if (hv_cpu->clk_evt == NULL) {
+   pr_err("Unable to allocate clock event 
device\n");
+   goto err;
+   }
+   hv_init_clockevent_device(hv_cpu->clk_evt, cpu);
}
-   hv_init_clockevent_device(hv_cpu->clk_evt, cpu);
 
hv_cpu->synic_message_page =
(void *)get_zeroed_page(GFP_ATOMIC);
-- 
2.14.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel