Re: [PATCH 1/2] staging: rtl8188eu: Fix coding style space missing problems

2014-10-12 Thread hejianet
 Thanks for the suggestion, I will update it later

On Thu, 09 Oct 2014 07:35:59 -0700 from j...@perches.com wrote:
> git ls-files "drivers/staging/rtl8188eu/*.[ch]" | \
>   xargs ./scripts/checkpatch.pl -f --fix-inplace --strict --types=SPACING

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


Re: [PATCHv2] staging: rtl8188eu: Fix coding style space related ERROR problems

2014-10-16 Thread hejianet
 Hi Greg
Just ping it, coz this is a practising patch for Eudyptula Challenge task 10.
Any comment is welcome, thank you :)

On Tue, 14 Oct 2014 11:28:32 +0800 from hejia...@gmail.com wrote:
> This fixes space related ERROR reports by checkpatch.pl
> Generated by $ git ls-files "drivers/staging/rtl8188eu/*.[ch]" | \
>   xargs ./scripts/checkpatch.pl -f --fix-inplace --strict --types=SPACING
> Already checked by text comparasion
> $git diff -w 
> and binary comparasion of r8188eu.ko
> $objdiff diff  
>
> Signed-off-by: Jia He 
> Cc: Greg Kroah-Hartman 
> ---
>  drivers/staging/rtl8188eu/core/rtw_cmd.c  |  2 +-
>  drivers/staging/rtl8188eu/core/rtw_ieee80211.c| 16 +-
>  drivers/staging/rtl8188eu/core/rtw_mlme.c |  2 +-
>  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 22 +++---
>  drivers/staging/rtl8188eu/core/rtw_pwrctrl.c  |  2 +-
>  drivers/staging/rtl8188eu/core/rtw_recv.c | 12 
>  drivers/staging/rtl8188eu/core/rtw_security.c | 20 ++---
>  drivers/staging/rtl8188eu/core/rtw_sta_mgt.c  |  2 +-
>  drivers/staging/rtl8188eu/core/rtw_xmit.c | 10 +++
>  drivers/staging/rtl8188eu/hal/bb_cfg.c|  4 +--
>  drivers/staging/rtl8188eu/hal/fw.c|  8 ++---
>  drivers/staging/rtl8188eu/hal/mac_cfg.c   |  2 +-
>  drivers/staging/rtl8188eu/hal/odm.c   |  8 ++---
>  drivers/staging/rtl8188eu/hal/odm_HWConfig.c  |  2 +-
>  drivers/staging/rtl8188eu/hal/odm_RTL8188E.c  |  2 +-
>  drivers/staging/rtl8188eu/hal/phy.c   |  2 +-
>  drivers/staging/rtl8188eu/hal/rf.c|  4 +--
>  drivers/staging/rtl8188eu/hal/rf_cfg.c|  4 +--
>  drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c  |  2 +-
>  drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c|  2 +-
>  drivers/staging/rtl8188eu/hal/usb_halinit.c   |  2 +-
>  drivers/staging/rtl8188eu/include/ieee80211_ext.h | 20 ++---
>  drivers/staging/rtl8188eu/include/odm_debug.h |  2 +-
>  drivers/staging/rtl8188eu/include/osdep_service.h |  4 +--
>  drivers/staging/rtl8188eu/include/rtw_debug.h |  2 +-
>  drivers/staging/rtl8188eu/include/rtw_led.h   |  2 +-
>  drivers/staging/rtl8188eu/include/rtw_mlme_ext.h  | 26 
>  drivers/staging/rtl8188eu/include/wifi.h  | 36 
> +++
>  drivers/staging/rtl8188eu/os_dep/ioctl_linux.c|  2 +-
>  drivers/staging/rtl8188eu/os_dep/os_intfs.c   |  2 +-
>  drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c  |  4 +--
>  drivers/staging/rtl8188eu/os_dep/xmit_linux.c |  2 +-
>  32 files changed, 116 insertions(+), 116 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c 
> b/drivers/staging/rtl8188eu/core/rtw_cmd.c
> index 9935e66..7b59a10 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
> @@ -638,7 +638,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, u8 *psta, 
> u8 unicast_key)
>   ether_addr_copy(psetstakey_para->addr, sta->hwaddr);
>  
>   if (check_fwstate(pmlmepriv, WIFI_STATION_STATE))
> - psetstakey_para->algorithm = (unsigned char) 
> psecuritypriv->dot11PrivacyAlgrthm;
> + psetstakey_para->algorithm = (unsigned 
> char)psecuritypriv->dot11PrivacyAlgrthm;
>   else
>   GET_ENCRY_ALGO(psecuritypriv, sta, psetstakey_para->algorithm, 
> false);
>  
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c 
> b/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
> index 755d3ef..f2c3ca7 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
> @@ -159,7 +159,7 @@ u8 *rtw_set_ie
>   return pbuf + len + 2;
>  }
>  
> -inline u8 *rtw_set_ie_ch_switch (u8 *buf, u32 *buf_len, u8 ch_switch_mode,
> +inline u8 *rtw_set_ie_ch_switch(u8 *buf, u32 *buf_len, u8 ch_switch_mode,
>   u8 new_ch, u8 ch_switch_cnt)
>  {
>   u8 ie_data[3];
> @@ -870,7 +870,7 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, 
> uint elen,
>   if (elen < 4) {
>   if (show_errors) {
>   DBG_88E("short vendor specific information element 
> ignored (len=%lu)\n",
> - (unsigned long) elen);
> + (unsigned long)elen);
>   }
>   return -1;
>   }
> @@ -890,7 +890,7 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, 
> uint elen,
>   case WME_OUI_TYPE: /* this is a Wi-Fi WME info. element */
>   if (elen < 5) {
>   DBG_88E("short WME information element ignored 
> (len=%lu)\n",
> - (unsigned long) elen);
> + (unsigned long)elen);
>   return -1;
>   }
>   switch (pos[4]) {
> @@ -905,7 +905,7 @@ static int rtw_ieee802_11_parse_