[PATCH] Stagingdriver:octeon-hcd.c modified for checkpatch fixes
Signed-off-by: bincy k philip
---
drivers/staging/octeon-usb/octeon-hcd.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 068aece..c1f715e 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -146,13 +146,13 @@ enum cvmx_usb_status {
* status call.
*/
struct cvmx_usb_port_status {
- u32 reserved: 25;
- u32 port_enabled: 1;
- u32 port_over_current : 1;
- u32 port_powered: 1;
- enum cvmx_usb_speed port_speed : 2;
- u32 connected : 1;
- u32 connect_change : 1;
+ u32 reserved:25;
+ u32 port_enabled:1;
+ u32 port_over_current:1;
+ u32 port_powered:1;
+ enum cvmx_usb_speed port_speed:2;
+ u32 connected:1;
+ u32 connect_change:1;
};
/**
--
1.8.3.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: octeon-usb: fix coding style error
I have updated the comments here and resend the new patch On 13/06/17 18:07, Greg KH wrote: On Tue, Jun 13, 2017 at 03:45:32PM +0530, bincy_k_phi...@yahoo.co.in wrote: From: bincy trivial fix for space alignment error Signed-off-by: bincy k philip --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) First off, please slow down. Take a break, and come back to this in a few days when you have had a chance to think exactly about what you are doing here. Hint, your from: and signed-off-by: names do not match at all. There is no rush here at all, please do not resend this for a few more days at the earliest. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: octeon-usb: fix coding style error
Hi, Please consider my new patch send. Regards Bincy On 15/06/17 14:47, bincy wrote: I have updated the comments here and resend the new patch On 13/06/17 18:07, Greg KH wrote: On Tue, Jun 13, 2017 at 03:45:32PM +0530, bincy_k_phi...@yahoo.co.in wrote: From: bincy trivial fix for space alignment error Signed-off-by: bincy k philip --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) First off, please slow down. Take a break, and come back to this in a few days when you have had a chance to think exactly about what you are doing here. Hint, your from: and signed-off-by: names do not match at all. There is no rush here at all, please do not resend this for a few more days at the earliest. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: octeon-usb: coding style fix
Hi,
Please consider my patch file for octeon-usb/octeon-hcd.c coding style
issue.
Regards
Bincy
On 15/06/17 10:28, bincy_k_phi...@yahoo.co.in wrote:
From: bincy k philip
trivial fix for extra space error
Signed-off-by: bincy k philip
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 068aece..c7ec71a 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -146,7 +146,7 @@ enum cvmx_usb_status {
* status call.
*/
struct cvmx_usb_port_status {
- u32 reserved: 25;
+ u32 reserved:25;
u32 port_enabled: 1;
u32 port_over_current : 1;
u32 port_powered: 1;
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning
Hi Gilad, I have added your comments and resent the patch.Thanks On 11/07/17 17:16, Gilad Ben-Yossef wrote: Hello Philip, Thank your patch. Your patch subject line is not descriptive and not formatted well. A better subject would be something like: staging: ccree: move comment to fit coding style Thanks, Gilad On Fri, Jun 30, 2017 at 7:32 AM, wrote: From: Bincy K Philip Trivial fix for Line over 80 characters Moved the comment to top of the definition Signed-off-by: Bincy K Philip --- drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h index aaa56c8..a18e6c9 100644 --- a/drivers/staging/ccree/cc_hw_queue_defs.h +++ b/drivers/staging/ccree/cc_hw_queue_defs.h @@ -27,7 +27,8 @@ **/ #define HW_DESC_SIZE_WORDS 6 -#define HW_QUEUE_SLOTS_MAX 15 /* Max. available slots in HW queue */ +/* Define max. available slots in HW queue */ +#define HW_QUEUE_SLOTS_MAX 15 #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name -- 1.8.3.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: ccree: move comment to fit coding style
Trivial fix for Line over 80 characters Moved the comment to top of the definition Signed-off-by: Bincy K Philip --- drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h --- a/drivers/staging/ccree/cc_hw_queue_defs.h +++ b/drivers/staging/ccree/cc_hw_queue_defs.h @@ -27,7 +27,8 @@ **/ #define HW_DESC_SIZE_WORDS 6 -#define HW_QUEUE_SLOTS_MAX 15 /* Max. available slots in HW queue */ +/* Define max. available slots in HW queue */ +#define HW_QUEUE_SLOTS_MAX 15 #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name -- 1.8.3.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
