Re: [PATCH] drivers: staging: media: davinci_vpfe: dm365_resizer: fixed some spelling mistakes

2016-01-01 Thread Trevor Woerner 
On 01/01/16 11:08, Saatvik Arya wrote:
> fixed spelling mistakes which reffered to OUTPUT as OUPUT

Somewhat ironically, "reffered" is not spelled correctly ;-)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: lustre: lnet: lnet: Added a space

2015-09-14 Thread Trevor Woerner 
On 09/13/15 06:14, Anjali Menon wrote:
> Added a space to fix the following coding style warning detected by
> checkpatch:

Both your commit title and message say (or imply) you've added a space,
but this patch, in fact, removes a space, doesn't it?

> WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Anjali Menon 
> ---
>  drivers/staging/lustre/lnet/lnet/router.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/router.c 
> b/drivers/staging/lustre/lnet/lnet/router.c
> index 8510bae..be23e06 100644
> --- a/drivers/staging/lustre/lnet/lnet/router.c
> +++ b/drivers/staging/lustre/lnet/lnet/router.c
> @@ -1511,7 +1511,7 @@ lnet_notify(lnet_ni_t *ni, lnet_nid_t nid, int alive, 
> unsigned long when)
>   unsigned long   now = cfs_time_current();
>   int cpt = lnet_cpt_of_nid(nid);
>  
> - LASSERT(!in_interrupt ());
> + LASSERT(!in_interrupt());
>  
>   CDEBUG(D_NET, "%s notifying %s: %s\n",
>   (ni == NULL) ? "userspace" : libcfs_nid2str(ni->ni_nid),

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 06/19] staging/lustre/lmv: fix potential null pointer dereference

2015-09-15 Thread Trevor Woerner 
On 09/14/15 18:41, gr...@linuxhacker.ru wrote:
> Reviewed-on: http://review.whamcloud.com/14605

I'm confused why the patch found in this email doesn't match the patch I
find when I click on the above link? Some of the patches in this series
match what I find on your jenkins URLs, and some do not.

For example, the function call in the body of the "if" below is
"sysfs_remove_link()" but the function call in the "if" body of the code
I find at http://review.whamcloud.com/14605 after clicking on the
"lustre/lmv/lmv_obd.c" link is "lprocfs_remove_proc_entry()".

Maybe I'm not using your jenkins correctly?

> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6517
> Reviewed-by: James Simmons 
> Reviewed-by: John L. Hammond 
> Reviewed-by: Dmitry Eremin 
> Signed-off-by: Oleg Drokin 
> ---
>  drivers/staging/lustre/lustre/lmv/lmv_obd.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c 
> b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> index 0fc0b61..cebbacf 100644
> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> @@ -593,11 +593,11 @@ static int lmv_disconnect_mdc(struct obd_device *obd, 
> struct lmv_tgt_desc *tgt)
>   mdc_obd->obd_force = obd->obd_force;
>   mdc_obd->obd_fail = obd->obd_fail;
>   mdc_obd->obd_no_recov = obd->obd_no_recov;
> - }
>  
> - if (lmv->lmv_tgts_kobj)
> - sysfs_remove_link(lmv->lmv_tgts_kobj,
> -   mdc_obd->obd_name);
> + if (lmv->lmv_tgts_kobj)
> + sysfs_remove_link(lmv->lmv_tgts_kobj,
> +   mdc_obd->obd_name);
> + }
>  
>   rc = obd_fid_fini(tgt->ltd_exp->exp_obd);
>   if (rc)

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel