[RESEND(2) PATCH] staging: rtl8188eu: Fix else after return WARNING (checkpatch)

2020-09-13 Thread Sohom
Fixed:
WARNING: else is not generally useful after a break or return
1636: FILE: ./rtw_recv.c:1636:
+   return false;
+   else

Separated the return statement into a separate block since
it doesn't seem to depend on the SN_LESS explicity being false.

Signed-off-by: Sohom 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 5fe7a0458dd2..5e81134ffb6d 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -1629,10 +1629,11 @@ static int enqueue_reorder_recvframe(struct 
recv_reorder_ctrl *preorder_ctrl,
hdr = list_entry(plist, struct recv_frame, list);
pnextattrib = &hdr->attrib;
 
+   if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
+   return false;
+
if (SN_LESS(pnextattrib->seq_num, pattrib->seq_num))
plist = plist->next;
-   else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
-   return false;
else
break;
}
-- 
2.28.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[RESEND PATCH] staging: rtl8188eu: Fix else after return WARNING (checkpatch)

2020-09-13 Thread Sohom Datta
>From 4c8c8f3ff7f4d711daea4ac3bb987fcecc7ef1ed Mon Sep 17 00:00:00 2001
From: Sohom 
Date: Sat, 12 Sep 2020 18:04:56 +0530
Subject: [RESEND PATCH] staging: rtl8188eu: Fix else after return WARNING
 (checkpatch)

Fixed:
WARNING: else is not generally useful after a break or return
1636: FILE: ./rtw_recv.c:1636:
+   return false;
+   else

Separated the return statement into a separate block since
it doesn't seem to depend on the SN_LESS explicity being false.

Signed-off-by: Sohom 
---
 drivers/staging/rtl8188eu/core/rtw_recv.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c 
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 5fe7a0458dd2..5e81134ffb6d 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -1629,10 +1629,11 @@ static int enqueue_reorder_recvframe(struct 
recv_reorder_ctrl *preorder_ctrl,
hdr = list_entry(plist, struct recv_frame, list);
pnextattrib = &hdr->attrib;
 
+   if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
+   return false;
+
if (SN_LESS(pnextattrib->seq_num, pattrib->seq_num))
plist = plist->next;
-   else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
-   return false;
else
break;
}
-- 
2.28.0


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH] staging: rts5208: coding style clean-ups

2016-03-21 Thread Sohom Bhattacharjee
fixed *only* comments that did not follow kernel coding style.
the errors were caught by the checkpatch.pl tool

Signed-off-by: Sohom Bhattacharjee 
---
 drivers/staging/rts5208/rtsx.c   | 55 +-
 drivers/staging/rts5208/rtsx_chip.h  | 53 -
 drivers/staging/rts5208/rtsx_transport.c | 66 +---
 3 files changed, 114 insertions(+), 60 deletions(-)

diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 1fe8e3e..9abde0a 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -1,4 +1,5 @@
-/* Driver for Realtek PCI-Express card reader
+/*
+ * Driver for Realtek PCI-Express card reader
  *
  * Copyright(c) 2009-2013 Realtek Semiconductor Corp. All rights reserved.
  *
@@ -81,17 +82,20 @@ static int slave_alloc(struct scsi_device *sdev)
 
 static int slave_configure(struct scsi_device *sdev)
 {
-   /* Scatter-gather buffers (all but the last) must have a length
+   /*
+* Scatter-gather buffers (all but the last) must have a length
 * divisible by the bulk maxpacket size.  Otherwise a data packet
 * would end up being short, causing a premature end to the data
 * transfer.  Since high-speed bulk pipes have a maxpacket size
 * of 512, we'll use that as the scsi device queue's DMA alignment
 * mask.  Guaranteeing proper alignment of the first buffer will
 * have the desired effect because, except at the beginning and
-* the end, scatter-gather buffers follow page boundaries. */
+* the end, scatter-gather buffers follow page boundaries.
+*/
blk_queue_dma_alignment(sdev->request_queue, (512 - 1));
 
-   /* Set the SCSI level to at least 2.  We'll leave it at 3 if that's
+   /*
+* Set the SCSI level to at least 2.  We'll leave it at 3 if that's
 * what is originally reported.  We need this to avoid confusing
 * the SCSI layer with devices that report 0 or 1, but need 10-byte
 * commands (ala ATAPI devices behind certain bridges, or devices
@@ -186,8 +190,10 @@ static int command_abort(struct scsi_cmnd *srb)
return SUCCESS;
 }
 
-/* This invokes the transport reset mechanism to reset the state of the
- * device */
+/*
+ * This invokes the transport reset mechanism to reset the state of the
+ * device
+ */
 static int device_reset(struct scsi_cmnd *srb)
 {
int result = 0;
@@ -500,8 +506,8 @@ SkipForAbort:
mutex_unlock(&dev->dev_mutex);
} /* for (;;) */
 
-   /* notify the exit routine that we're actually exiting now
-*
+   /*
+* notify the exit routine that we're actually exiting now
 * complete()/wait_for_completion() is similar to up()/down(),
 * except that complete() is safe in the case where the structure
 * is getting deleted in a parallel mode of execution (i.e. just
@@ -633,7 +639,8 @@ static void rtsx_release_resources(struct rtsx_dev *dev)
 {
dev_info(&dev->pci->dev, "-- %s\n", __func__);
 
-   /* Tell the control thread to exit.  The SCSI host must
+   /*
+* Tell the control thread to exit.  The SCSI host must
 * already have been removed so it won't try to queue
 * any more commands.
 */
@@ -665,15 +672,19 @@ static void rtsx_release_resources(struct rtsx_dev *dev)
kfree(dev->chip);
 }
 
-/* First stage of disconnect processing: stop all commands and remove
- * the host */
+/*
+ * First stage of disconnect processing: stop all commands and remove
+ * the host
+ */
 static void quiesce_and_remove_host(struct rtsx_dev *dev)
 {
struct Scsi_Host *host = rtsx_to_host(dev);
struct rtsx_chip *chip = dev->chip;
 
-   /* Prevent new transfers, stop the current command, and
-* interrupt a SCSI-scan or device-reset delay */
+   /*
+* Prevent new transfers, stop the current command, and
+* interrupt a SCSI-scan or device-reset delay
+*/
mutex_lock(&dev->dev_mutex);
scsi_lock(host);
rtsx_set_stat(chip, RTSX_STAT_DISCONNECT);
@@ -685,9 +696,11 @@ static void quiesce_and_remove_host(struct rtsx_dev *dev)
/* Wait some time to let other threads exist */
wait_timeout(100);
 
-   /* queuecommand won't accept any new commands and the control
+   /*
+* queuecommand won't accept any new commands and the control
 * thread won't execute a previously-queued command.  If there
-* is such a command pending, complete it with an error. */
+* is such a command pending, complete it with an error.
+*/
mutex_lock(&dev->dev_mutex);
if (chip->srb) {
chip->srb->result = DID_NO_CONNECT << 16;
@@ -707,8 +720,10 @@ static void release_e

Re: [PATCH] staging: rts5208: coding style clean-ups

2016-03-21 Thread Sohom Bhattacharjee
On Mon, Mar 21, 2016 at 05:29:24PM -0400, Greg KH wrote:
> On Mon, Mar 21, 2016 at 10:53:36PM +0530, Sohom Bhattacharjee wrote:
> > fixed *only* comments that did not follow kernel coding style.
> > the errors were caught by the checkpatch.pl tool
> > 
> > Signed-off-by: Sohom Bhattacharjee 
> 
> Does not apply to the tree at all :(
what do you mean ? 
i used the Linus's latest git tree. :)

thanks,

sohom b
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel