[PATCH] Staging: rtl8723bs/core: fix space coding style issue

[Qiang Ma]

Add one space around (on each side of) '*' binary operators.

Signed-off-by: Qiang Ma 
---
 drivers/staging/rtl8723bs/core/rtw_security.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c 
b/drivers/staging/rtl8723bs/core/rtw_security.c
index a311595deafb..6d53c08b29d1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_security.c
+++ b/drivers/staging/rtl8723bs/core/rtw_security.c
@@ -319,7 +319,7 @@ static u32 secmicgetuint32(u8 *p)
u32 res = 0;
 
for (i = 0; i < 4; i++)
-   res |= ((u32)(*p++)) << (8*i);
+   res |= ((u32)(*p++)) << (8 * i);
 
return res;
 }
-- 
2.20.1



___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8723bs: add spaces between operators

[Qiang Ma]

Add spaces between operators for a better readability
in function 'rtw_secgetmic'.

Signed-off-by: Qiang Ma 
---
 drivers/staging/rtl8723bs/core/rtw_security.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c 
b/drivers/staging/rtl8723bs/core/rtw_security.c
index 6d53c08b29d1..3e576cbe4712 100644
--- a/drivers/staging/rtl8723bs/core/rtw_security.c
+++ b/drivers/staging/rtl8723bs/core/rtw_security.c
@@ -397,7 +397,7 @@ void rtw_secgetmic(struct mic_data *pmicdata, u8 *dst)
rtw_secmicappendbyte(pmicdata, 0);
/*  The appendByte function has already computed the result. */
secmicputuint32(dst, pmicdata->L);
-   secmicputuint32(dst+4, pmicdata->R);
+   secmicputuint32(dst + 4, pmicdata->R);
/*  Reset to the empty message. */
secmicclear(pmicdata);
 }
-- 
2.20.1



___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8723bs/core: add spaces between operators

[Qiang Ma]

Add spaces between operators for a better readability
in function 'rtw_seccalctkipmic'.

Signed-off-by: Qiang Ma 
---
 drivers/staging/rtl8723bs/core/rtw_security.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c 
b/drivers/staging/rtl8723bs/core/rtw_security.c
index 3e576cbe4712..469e4d563da1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_security.c
+++ b/drivers/staging/rtl8723bs/core/rtw_security.c
@@ -413,15 +413,15 @@ void rtw_seccalctkipmic(u8 *key, u8 *header, u8 *data, 
u32 data_len, u8 *mic_cod
priority[0] = pri;
 
/* Michael MIC pseudo header: DA, SA, 3 x 0, Priority */
-   if (header[1]&1) {   /* ToDS == 1 */
+   if (header[1] & 1) {   /* ToDS == 1 */
rtw_secmicappend(&micdata, &header[16], 6);  /* DA */
-   if (header[1]&2)  /* From Ds == 1 */
+   if (header[1] & 2)  /* From Ds == 1 */
rtw_secmicappend(&micdata, &header[24], 6);
else
rtw_secmicappend(&micdata, &header[10], 6);
} else {/* ToDS == 0 */
rtw_secmicappend(&micdata, &header[4], 6);   /* DA */
-   if (header[1]&2)  /* From Ds == 1 */
+   if (header[1] & 2)  /* From Ds == 1 */
rtw_secmicappend(&micdata, &header[16], 6);
else
rtw_secmicappend(&micdata, &header[10], 6);
-- 
2.20.1



___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: r8188eu/core: remove the check for NULL pointer in _rtw_enqueue_cmd()

[Qiang Ma]

Remove the check for _rtw_enqueue_cmd(), because
rtw_enqueue_cmd() already has a check of NULL pointer,
so this condition is not possible.

Signed-off-by: Qiang Ma 
---
 drivers/staging/rtl8188eu/core/rtw_cmd.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c 
b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 1724dfd7edbc..513c0f95b4bf 100644
--- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
+++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
@@ -39,17 +39,12 @@ static int _rtw_enqueue_cmd(struct __queue *queue, struct 
cmd_obj *obj)
 {
unsigned long irqL;
 
-   if (!obj)
-   goto exit;
-
spin_lock_irqsave(&queue->lock, irqL);
 
list_add_tail(&obj->list, &queue->queue);
 
spin_unlock_irqrestore(&queue->lock, irqL);
 
-exit:
-
return _SUCCESS;
 }
 
-- 
2.20.1



___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel