Missing patch for Partial crash when loading driver rtl8192e

2022-10-11 Thread Philipp Hortmann

Hi,

yesterday I did a git pull.

when I tried to load the driver rtl8192e I had the below partial crash.

I was able to fix it with this patch:

https://lore.kernel.org/netdev/20220926233458.5316-1-yin31...@gmail.com/

Thanks for your support.

Bye Philipp


This has worked before. But now I get this in my dmesg
[  224.792852] [ cut here ]
[  224.792856] memcpy: detected field-spanning write (size 8) of single 
field "&compat_event->pointer" at net/wireless/wext-core.c:623 (size 4)
[  224.792869] WARNING: CPU: 3 PID: 1408 at net/wireless/wext-core.c:623 
wireless_send_event+0x41f/0x470
[  224.792876] Modules linked in: r8192e_pci(COE) rtllib(COE) lib80211 
xt_conntrack xt_MASQUERADE nf_conntrack_netlink nfnetlink xfrm_user 
xfrm_algo xt_addrtype iptable_filter iptable_nat nf_nat nf_conntrack 
nf_defrag_ipv6 nf_defrag_ipv4 libcrc32c bpfilter br_netfilter bridge stp 
llc overlay nls_iso8859_1 snd_hda_codec_hdmi snd_hda_codec_conexant 
snd_hda_codec_generic ledtrig_audio intel_rapl_msr intel_rapl_common 
x86_pkg_temp_thermal intel_powerclamp coretemp sch5627 mei_hdcp 
kvm_intel i915 kvm rtl8192se snd_hda_intel rtl_pci snd_intel_dspcfg 
rtlwifi snd_intel_sdw_acpi snd_hda_codec snd_hda_core mac80211 
crct10dif_pclmul ghash_clmulni_intel drm_buddy snd_hwdep aesni_intel ttm 
snd_pcm crypto_simd drm_display_helper cryptd snd_seq_midi cec rapl 
sch56xx_common snd_seq_midi_event intel_cstate input_leds rc_core 
snd_rawmidi cfg80211 joydev drm_kms_helper serio_raw at24 efi_pstore 
snd_seq i2c_algo_bit fb_sys_fops snd_seq_device mei_me libarc4 
syscopyarea snd_timer sysfillrect mei snd sysimgblt
[  224.792925]  soundcore mac_hid tpm_infineon sch_fq_codel ipmi_devintf 
ipmi_msghandler msr parport_pc ppdev drm lp parport ip_tables x_tables 
autofs4 hid_generic usbhid hid e1000e crc32_pclmul i2c_i801 i2c_smbus 
xhci_pci lpc_ich ahci libahci xhci_pci_renesas video wmi
[  224.792943] CPU: 3 PID: 1408 Comm: wpa_supplicant Tainted: G C OE 
6.0.0+ #13
[  224.792945] Hardware name: FUJITSU ESPRIMO P710/D3161-A1, BIOS 
V4.6.5.3 R1.16.0 for D3161-A1x 10/29/2012

[  224.792947] RIP: 0010:wireless_send_event+0x41f/0x470
[  224.792950] Code: 13 fe ff ff b9 04 00 00 00 4c 89 ee 4c 89 4d c0 48 
c7 c2 f0 c1 2d 9f 48 c7 c7 d0 13 1c 9f c6 05 62 99 e9 00 01 e8 c8 4d 04 
00 <0f> 0b 4c 8b 4d c0 e9 e2 fd ff ff 0f 0b be 01 00 00 00 4c 89 e7 e8

[  224.792952] RSP: 0018:b93f40aebd10 EFLAGS: 00010282
[  224.792954] RAX:  RBX: 9ef60d70 RCX: 

[  224.792955] RDX: 0001 RSI: 9f1ec889 RDI: 

[  224.792956] RBP: b93f40aebd90 R08:  R09: 
b93f40aebb78
[  224.792957] R10: 0001 R11: 0001 R12: 
a0a5ed55b900
[  224.792958] R13: 0008 R14: a0a5ed55b400 R15: 
000c
[  224.792959] FS:  7fef3baf5140() GS:a0a61638() 
knlGS:

[  224.792961] CS:  0010 DS:  ES:  CR0: 80050033
[  224.792962] CR2: 56196d1dc400 CR3: 00010891a003 CR4: 
001706e0

[  224.792963] Call Trace:
[  224.792965]  
[  224.792969]  ? _rtl92e_wx_set_freq+0x65/0x7b [r8192e_pci]
[  224.792978]  ioctl_standard_call+0x76/0xe0
[  224.792981]  ? iw_handler_get_private+0x70/0x70
[  224.792982]  ? call_commit_handler+0x50/0x50
[  224.792985]  wireless_process_ioctl+0x13f/0x1a0
[  224.792989]  wext_handle_ioctl+0x9e/0x100
[  224.792991]  ? __switch_to+0x11d/0x440
[  224.792995]  sock_ioctl+0x1da/0x300
[  224.792999]  ? debug_smp_processor_id+0x17/0x20
[  224.793002]  __x64_sys_ioctl+0x95/0xd0
[  224.793007]  do_syscall_64+0x3b/0x90
[  224.793010]  entry_SYSCALL_64_after_hwframe+0x63/0xcd
[  224.793013] RIP: 0033:0x7fef3b7223ab
[  224.793015] Code: 0f 1e fa 48 8b 05 e5 7a 0d 00 64 c7 00 26 00 00 00 
48 c7 c0 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8 10 00 00 00 0f 
05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d b5 7a 0d 00 f7 d8 64 89 01 48
[  224.793016] RSP: 002b:7ffe37cb5818 EFLAGS: 0246 ORIG_RAX: 
0010
[  224.793018] RAX: ffda RBX: 0e774ee0 RCX: 
7fef3b7223ab
[  224.793019] RDX: 7ffe37cb5820 RSI: 8b04 RDI: 
0009
[  224.793020] RBP: 56196f303db0 R08:  R09: 
56196f329210
[  224.793021] R10: 56196f328c98 R11: 0246 R12: 
7ffe37cb5820
[  224.793022] R13:  R14: 0001 R15: 
56196f303dc8

[  224.793025]  
[  224.793026] ---[ end trace  ]---
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


Re: [PATCH v3] staging: rtl8192e: Fix conflicting types error with net_device.

2024-06-25 Thread Philipp Hortmann

On 6/25/24 18:33, Teddy Engel wrote:

Add a pre-declaration of struct net_device so the compiler is able to
use rtl_pci.h / rtl_cam.h.

Signed-off-by: Teddy Engel 
Reported-by: kernel test robot 
Closes: 
https://lore.kernel.org/oe-kbuild-all/202406250858.l8rjmhqm-...@intel.com/
Fixes: 7dff0b27d9c8 ("staging: rtl8192e: Remove unnecessary pre-declaration of 
struct net_device")
---
v3: Replace ad-hoc commit id / subject by expected Fixes tag.
v2: Add commit id / commit subject  under description.

  drivers/staging/rtl8192e/rtl8192e/rtl_cam.h | 2 ++
  drivers/staging/rtl8192e/rtl8192e/rtl_pci.h | 2 ++
  2 files changed, 4 insertions(+)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.h 
b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.h
index 3a5635494385..9deffdf96072 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.h
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.h
@@ -12,6 +12,8 @@
  
  #include 
  
+struct net_device;

+
  void rtl92e_cam_reset(struct net_device *dev);
  void rtl92e_enable_hw_security_config(struct net_device *dev);
  void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex,
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.h 
b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.h
index c645775b2150..3e39c4835ac8 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.h
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.h
@@ -13,6 +13,8 @@
  #include 
  #include 
  
+struct net_device;

+
  bool rtl92e_check_adapter(struct pci_dev *pdev, struct net_device *dev);
  
  #endif


Tested-by: Philipp Hortmann 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel